mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 16:31:02 +03:00
ba87c55127
Summary: The mockall crate's `automock` attribute previously created nondeterministic output, which leads to frequent random "Found possibly newer version of crate" failures in Buck builds that involve cache. The affected trait in Conveyor is: https://www.internalfb.com/code/fbsource/[4753807291f7275a061d67cead04ea12e7b38ae2]/fbcode/conveyor/common/just_knobs/src/lib.rs?lines=13-23 which has a method with two lifetime parameters. Mockall's generated code shuffled them in random order due to emitting the lifetimes in HashSet order. The generated code would randomly contain one of these two types: `Box<dyn for<'b, 'a> FnMut(&str, Option<&'a str>, Option<&'b str>) -> Result<bool> + Send>` `Box<dyn for<'a, 'b> FnMut(&str, Option<&'a str>, Option<&'b str>) -> Result<bool> + Send>` Reviewed By: jsgf Differential Revision: D30656936 fbshipit-source-id: c1a251774333d7a4001a7492c1995efd84ff22e5 |
||
---|---|---|
.. | ||
check_git_wc | ||
git_types | ||
git-pool | ||
gitimport | ||
import_tools |