mirror of
https://github.com/facebook/sapling.git
synced 2024-10-07 15:27:13 +03:00
f46b49a0e3
Before this patch, "missing _() in ui message" rule overlooks
translatable message, which starts with other than alphabet.
To detect "missing _() in ui message" more exactly, this patch
improves the regexp with assumptions below.
- sequence consisting of below might precede "translatable message"
in same string token
- formatting string, which starts with '%'
- escaped character, which starts with 'b' (as replacement of '\\'), or
- characters other than '%', 'b' and 'x' (as replacement of alphabet)
- any string tokens might precede a string token, which contains
"translatable message"
This patch builds an input file, which is used to examine "missing _()
in ui message" detection, before '"$check_code" stringjoin.py' in
test-contrib-check-code.t, because this reduces amount of change churn
in subsequent patch.
This patch also applies "()" instead of "_()" on messages below to
hide false-positives:
- messages for ui.debug() or debug commands/tools
- contrib/debugshell.py
- hgext/win32mbcs.py (ui.write() is used, though)
- mercurial/commands.py
- _debugchangegroup
- debugindex
- debuglocks
- debugrevlog
- debugrevspec
- debugtemplate
- untranslatable messages
- doc/gendoc.py (ReST specific text)
- hgext/hgk.py (permission string)
- hgext/keyword.py (text written into configuration file)
- mercurial/cmdutil.py (formatting strings for JSON)
60 lines
1.4 KiB
Python
60 lines
1.4 KiB
Python
# debugshell extension
|
|
"""a python shell with repo, changelog & manifest objects"""
|
|
|
|
from __future__ import absolute_import
|
|
import code
|
|
import mercurial
|
|
import sys
|
|
from mercurial import (
|
|
cmdutil,
|
|
demandimport,
|
|
)
|
|
|
|
cmdtable = {}
|
|
command = cmdutil.command(cmdtable)
|
|
|
|
def pdb(ui, repo, msg, **opts):
|
|
objects = {
|
|
'mercurial': mercurial,
|
|
'repo': repo,
|
|
'cl': repo.changelog,
|
|
'mf': repo.manifest,
|
|
}
|
|
|
|
code.interact(msg, local=objects)
|
|
|
|
def ipdb(ui, repo, msg, **opts):
|
|
import IPython
|
|
|
|
cl = repo.changelog
|
|
mf = repo.manifest
|
|
cl, mf # use variables to appease pyflakes
|
|
|
|
IPython.embed()
|
|
|
|
@command('debugshell|dbsh', [])
|
|
def debugshell(ui, repo, **opts):
|
|
bannermsg = "loaded repo : %s\n" \
|
|
"using source: %s" % (repo.root,
|
|
mercurial.__path__[0])
|
|
|
|
pdbmap = {
|
|
'pdb' : 'code',
|
|
'ipdb' : 'IPython'
|
|
}
|
|
|
|
debugger = ui.config("ui", "debugger")
|
|
if not debugger:
|
|
debugger = 'pdb'
|
|
|
|
# if IPython doesn't exist, fallback to code.interact
|
|
try:
|
|
with demandimport.deactivated():
|
|
__import__(pdbmap[debugger])
|
|
except ImportError:
|
|
ui.warn(("%s debugger specified but %s module was not found\n")
|
|
% (debugger, pdbmap[debugger]))
|
|
debugger = 'pdb'
|
|
|
|
getattr(sys.modules[__name__], debugger)(ui, repo, bannermsg, **opts)
|