mirror of
https://github.com/facebook/sapling.git
synced 2024-10-09 16:31:02 +03:00
9d450170ba
String literals without explicit prefix in __init__.py and policy.py
are treated as unicode object on Python3, because these modules are
loaded before setup of our specific code transformation (the later
module is imported at the beginning of __init__.py).
BTW, "modulepolicy" in __init__.py is initialized by "policy.policy".
This causes issues below;
- checking "policy" value in other modules causes unintentional result
For example, "b'py' not in (u'c', u'py')" returns True
unintentionally on Python3.
- writing "policy" out fails at conversion from unicode to bytes
db1ebf457295 fixed this issue for default code path, but "policy"
can be overridden by HGMODULEPOLICY environment variable (it should
be rare case for developer using Python3, though).
This patch does:
- add "b" prefix to all string literals, which are related to module
policy, in modules above.
- check existence of HGMODULEPOLICY, and overwrite "policy" only if
it exists
For simplicity, this patch omits checking "supports_bytes_environ",
switching os.environ/os.environb, and so on (Yuya agreed this in
personal talking)
50 lines
1.5 KiB
Python
50 lines
1.5 KiB
Python
# policy.py - module policy logic for Mercurial.
|
|
#
|
|
# Copyright 2015 Gregory Szorc <gregory.szorc@gmail.com>
|
|
#
|
|
# This software may be used and distributed according to the terms of the
|
|
# GNU General Public License version 2 or any later version.
|
|
|
|
from __future__ import absolute_import
|
|
|
|
import os
|
|
import sys
|
|
|
|
# Rules for how modules can be loaded. Values are:
|
|
#
|
|
# c - require C extensions
|
|
# allow - allow pure Python implementation when C loading fails
|
|
# cffi - required cffi versions (implemented within pure module)
|
|
# cffi-allow - allow pure Python implementation if cffi version is missing
|
|
# py - only load pure Python modules
|
|
#
|
|
# By default, require the C extensions for performance reasons.
|
|
policy = b'c'
|
|
policynoc = (b'cffi', b'cffi-allow', b'py')
|
|
policynocffi = (b'c', b'py')
|
|
|
|
try:
|
|
from . import __modulepolicy__
|
|
policy = __modulepolicy__.modulepolicy
|
|
except ImportError:
|
|
pass
|
|
|
|
# PyPy doesn't load C extensions.
|
|
#
|
|
# The canonical way to do this is to test platform.python_implementation().
|
|
# But we don't import platform and don't bloat for it here.
|
|
if '__pypy__' in sys.builtin_module_names:
|
|
policy = 'cffi'
|
|
|
|
# Our C extensions aren't yet compatible with Python 3. So use pure Python
|
|
# on Python 3 for now.
|
|
if sys.version_info[0] >= 3:
|
|
policy = b'py'
|
|
|
|
# Environment variable can always force settings.
|
|
if sys.version_info[0] >= 3:
|
|
if 'HGMODULEPOLICY' in os.environ:
|
|
policy = os.environ['HGMODULEPOLICY'].encode('utf-8')
|
|
else:
|
|
policy = os.environ.get('HGMODULEPOLICY', policy)
|