mirror of
https://github.com/facebook/sapling.git
synced 2024-10-10 16:57:49 +03:00
f6e436f317
After 313b8d61b548 graph canvas width is decided once on the initial rendering.
However, after graph page gets scrolled down to load more, it might need more
horizontal space to draw, so it needs to resize the canvas dynamically.
The exact problem that this patch solves can be seen using:
hg init testfork
cd testfork
echo 0 > foo
hg ci -Am0
echo 1 > foo
hg ci -m1
hg up 0
echo 2 > foo
hg ci -m2
hg gl -T '{rev}\n'
@ 2
|
| o 1
|/
o 0
hg serve
And then by navigating to http://127.0.0.1:8000/graph/tip?revcount=1
"revcount=1" makes sure the initial graph contains only revision 2. And because
the initial canvas width takes only that one revision into count, after the
(immediate) AJAX update revision 1 will be cut off from the graph.
We can safely set canvas width to the new value we get from the AJAX request
because every time graph is updated, it is completely redrawn using all the
requested nodes (in the case above it will use /graph/2?revcount=61), so the
value is guaranteed not to decrease.
P.S.: Sorry for parsing HTML with regexes, but I didn't start it.
|
||
|---|---|---|
| .. | ||
| atom | ||
| coal | ||
| gitweb | ||
| json | ||
| monoblue | ||
| paper | ||
| raw | ||
| rss | ||
| spartan | ||
| static | ||
| map-cmdline.bisect | ||
| map-cmdline.changelog | ||
| map-cmdline.compact | ||
| map-cmdline.default | ||
| map-cmdline.phases | ||
| map-cmdline.status | ||
| map-cmdline.xml | ||