sapling/eden/scm/lib/tracing-collector
Durham Goode 5d66631598 tracing: fix recording on spans via TracingCollector layer
Summary:
EspanId and tracing::span::Id had From/Into implementations that allowed them to be treated as
equivalent when they shouldn't be. This allowed for a subtle but where TracingData::record was
receiving an EspanId where the id was some huge u64 from a tracing::span::Id, when instead that
huge u64 should've been mapped to the real EspanId via the id_map.

Ideally we'd treat EspanId and the tracing Id separately, but the TracingCollector Subscriber
implementation relies on this. Since it controls span creation it can guarantee that all Id's are safely
convertible to EspanId.

Reviewed By: quark-zju

Differential Revision: D29599901

fbshipit-source-id: 79d24d41d86c6098888b1747cc0b9bc2838493fa
2021-07-15 21:19:27 -07:00
..
src tracing: fix recording on spans via TracingCollector layer 2021-07-15 21:19:27 -07:00
Cargo.toml Update several rust crate versions 2021-06-17 16:38:19 -07:00