facebookarchive/prepack
1
1
Fork 0
mirror of https://github.com/facebookarchive/prepack.git synced 2024-09-11 14:46:37 +03:00
Code Issues Projects Releases Wiki Activity

Compile time error for Set constructor argument if using JSC

Browse Source 
Summary:
Release note: fixes issue #1340

When the target platform is JSC, issue a compile time diagnostic if an argument is provided to the set constructor. Then proceed as if there were no argument, which is what JSC does at runtime.
Closes https://github.com/facebook/prepack/pull/1386

Differential Revision: D6863721

Pulled By: hermanventer

fbshipit-source-id: 9ee3af5e8028ea1657e0b39d31393036c66f744a
This commit is contained in:
Herman Venter 2018-01-31 14:22:24 -08:00 committed by Facebook Github Bot
parent 661271cc76
commit 2fdcf9a778
3 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/test-error-handler.js
View File

@ -57,6 +57,7 @@ function runTest(name: string, code: string): boolean {
let additionalFunctions = code.includes("// additional functions");
let delayUnsupportedRequires = code.includes("// delay unsupported requires");
let abstractEffects = code.includes("// abstract effects");
let compatibility = code.includes("// jsc") ? "jsc-600-1-4-17" : undefined;
let expectedErrors = code.match(/\/\/\s*expected errors:\s*(.*)/);
invariant(expectedErrors);
@ -75,6 +76,7 @@ function runTest(name: string, code: string): boolean {
serialize: true,
initializeMoreModules: false,
abstractEffectsInAdditionalFunctions: abstractEffects,
compatibility,
};
if (additionalFunctions) (options: any).additionalFunctions = ["global.additional1", "global['additional2']"];
prepackFileSync([name], options);

11
src/intrinsics/ecma262/Set.js
View File

@ -24,6 +24,7 @@ import {
} from "../../methods/index.js";
import { Create } from "../../singletons.js";
import invariant from "../../invariant.js";
import { CompilerDiagnostic } from "../../errors.js";
export default function(realm: Realm): NativeFunctionValue {
// ECMA262 23.2.1.1
@ -43,7 +44,15 @@ export default function(realm: Realm): NativeFunctionValue {
// 4. If iterable is not present, let iterable be undefined.
if (iterable && realm.isCompatibleWith(realm.MOBILE_JSC_VERSION)) {
throw realm.createErrorThrowCompletion(realm.intrinsics.TypeError, "the set constructor doesn't take arguments");
let loc = realm.currentLocation;
let error = new CompilerDiagnostic(
"This version of JSC ignores the argument to Set, require the polyfill before doing this",
loc,
"PP0001",
"RecoverableError"
);
realm.handleError(error);
iterable = undefined;
}
if (!iterable) iterable = realm.intrinsics.undefined;

7
test/error-handler/Set.js Normal file
View File

@ -0,0 +1,7 @@
// jsc
// recover-from-errors
// expected errors: [{"location":{"start":{"line":5,"column":22},"end":{"line":5,"column":25},"source":"test/error-handler/Set.js"},"severity":"RecoverableError","errorCode":"PP0001"}]
let s = new Set(["a", "a"]);
inspect = function() { return s.size === 1; }