facebookarchive/prepack
1
1
Fork 0
mirror of https://github.com/facebookarchive/prepack.git synced 2024-09-11 14:46:37 +03:00
Code Issues Projects Releases Wiki Activity

Implement Date.parse (#689)

Browse Source 
* Implement most basic Date.parse by using underlying runtime's Date.parse method

* Address comment

* Run date intl402 tests
This commit is contained in:
Matthew Dahl 2017-06-01 15:24:44 -07:00 committed by Herman Venter
parent b6e76f7f53
commit 70712e5641
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/test262-runner.js
View File

@ -906,7 +906,10 @@ function prepareTest(
function createRealm(timeout: number): { realm: Realm, $: ObjectValue } {
// Create a new realm.
let realm = construct_realm({ timeout: timeout * 1000 });
let realm = construct_realm({
strictlyMonotonicDateNow: true,
timeout: timeout * 1000,
});
initializeGlobals(realm);
let executionContext = new ExecutionContext();
executionContext.realm = realm;
@ -1098,7 +1101,9 @@ function testFilterByMetadata(
if (test.location.includes("Simd")) return false;
// temporarily disable intl402 tests (ES5)
if (test.location.includes("intl402")) return false;
if (test.location.includes("intl402") && !test.location.includes('/Date/')) {
return false;
}
// temporarily disable tests which use realm.
if (test.location.includes("realm")) return false;

9
src/intrinsics/ecma262/Date.js
View File

@ -10,7 +10,7 @@
/* @flow */
import type { Realm } from "../../realm.js";
import { NativeFunctionValue, NumberValue, StringValue, ObjectValue } from "../../values/index.js";
import { AbstractValue, NativeFunctionValue, NumberValue, StringValue, ObjectValue } from "../../values/index.js";
import { ToInteger, ToNumber, ToPrimitive } from "../../methods/to.js";
import { OrdinaryCreateFromConstructor } from "../../methods/create.js";
import { MakeTime, MakeDate, MakeDay, TimeClip, UTC, ToDateString, thisTimeValue } from "../../methods/date.js";
@ -189,7 +189,12 @@ export default function (realm: Realm): NativeFunctionValue {
// ECMA262 20.3.3.2
func.defineNativeMethod("parse", 1, (context, [string]) => {
throw new Error("TODO: Implement Date.parse");
if (realm.useAbstractInterpretation) {
throw AbstractValue.createIntrospectionErrorThrowCompletion(string);
} else {
const parsedDate = Date.parse(string.value);
return new NumberValue(realm, parsedDate);
}
});
// ECMA262 20.3.3.4