facebookarchive/prepack
1
1
Fork 0
mirror of https://github.com/facebookarchive/prepack.git synced 2024-09-11 14:46:37 +03:00
Code Issues Projects Releases Wiki Activity

Add invariant that an object with modified properties must be valid. (#2278)

Browse Source 
Summary:
Release notes: None

The uncovered bug is tracked in #2279.
Pull Request resolved: https://github.com/facebook/prepack/pull/2278

Differential Revision: D9472482

Pulled By: NTillmann

fbshipit-source-id: 5d6e24abd76fd83e9078c3908fa0be0e7f0b2c51
This commit is contained in:
Nikolai Tillmann 2018-08-31 02:25:10 -07:00 committed by Facebook Github Bot
parent 12ae403cef
commit b3bcd73102
3 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/serializer/ResidualHeapVisitor.js
View File

@ -847,6 +847,7 @@ export class ResidualHeapVisitor {
}
visitValueObject(val: ObjectValue): void {
invariant(val.isValid());
this._registerAdditionalRoot(val);
if (isReactElement(val)) {
this.residualReactElementVisitor.visitReactElement(val);
@ -1038,17 +1039,20 @@ export class ResidualHeapVisitor {
this.postProcessValue(equivalentValue);
return (equivalentValue: any);
}
if (val instanceof ObjectValue && isReactElement(val)) {
if (val.temporalAlias !== undefined) {
return this.visitEquivalentValue(val.temporalAlias);
if (val instanceof ObjectValue) {
invariant(val.isValid());
if (isReactElement(val)) {
if (val.temporalAlias !== undefined) {
return this.visitEquivalentValue(val.temporalAlias);
}
let equivalentReactElementValue = this.residualReactElementVisitor.reactElementEquivalenceSet.add(val);
if (this._mark(equivalentReactElementValue)) this.visitValueObject(equivalentReactElementValue);
return (equivalentReactElementValue: any);
} else if (isReactPropsObject(val)) {
let equivalentReactPropsValue = this.residualReactElementVisitor.reactPropsEquivalenceSet.add(val);
if (this._mark(equivalentReactPropsValue)) this.visitValueObject(equivalentReactPropsValue);
return (equivalentReactPropsValue: any);
}
let equivalentReactElementValue = this.residualReactElementVisitor.reactElementEquivalenceSet.add(val);
if (this._mark(equivalentReactElementValue)) this.visitValueObject(equivalentReactElementValue);
return (equivalentReactElementValue: any);
} else if (val instanceof ObjectValue && isReactPropsObject(val)) {
let equivalentReactPropsValue = this.residualReactElementVisitor.reactPropsEquivalenceSet.add(val);
if (this._mark(equivalentReactPropsValue)) this.visitValueObject(equivalentReactPropsValue);
return (equivalentReactPropsValue: any);
}
this.visitValue(val);
return val;

1
src/utils/generator.js
View File

@ -614,6 +614,7 @@ export class Generator {
for (let propertyBinding of modifiedProperties.keys()) {
let object = propertyBinding.object;
invariant(object.isValid());
if (createdObjects.has(object)) continue; // Created Object's binding
if (ObjectValue.refuseSerializationOnPropertyBinding(propertyBinding)) continue; // modification to internal state
// modifications to intrinsic objects are tracked in the generator

5
src/values/ObjectValue.js
View File

@ -308,6 +308,11 @@ export default class ObjectValue extends ConcreteValue {
// never be serialized.
refuseSerialization: boolean;
// Checks whether effects are properly applied.
isValid(): boolean {
return this._isPartial !== undefined;
}
equals(x: Value): boolean {
return this === x;
}