mirror of
https://github.com/facebookarchive/prepack.git
synced 2024-09-19 02:58:08 +03:00
cde1af298d
Summary: Release notes: none This fixes an issue that we were experiencing, that turned out to be the correct fix after looking at https://github.com/facebook/prepack/pull/1997. We shouldn't mutate arrays in the reconciliation process, instead we should create new ones when we have new values. Also, we should ensure that we don't mutate ReactElements during reconciliation too, instead we should just create new ones. Mutating existing objects and values breaks down completely when we enter nested effects that need to re-evaluate the same original values, so this fixes a bunch of internal issues we were seeing on our internal FB bundle. Closes https://github.com/facebook/prepack/pull/1999 Differential Revision: D8105499 Pulled By: trueadm fbshipit-source-id: 4e6ceb8b02c886c42156a8903c347765f101c840 |
||
---|---|---|
.. | ||
__snapshots__ | ||
debug-fb-www.js | ||
detect_bad_deps.js | ||
generate-sourcemaps-test.js | ||
instrumentor.js | ||
lint-config.js | ||
multi-runner.js | ||
prettier.js | ||
publish-gh-pages.sh | ||
test262-filters.yml | ||
test262-runner.js | ||
test262.js | ||
test-error-handler.js | ||
test-internal-react.js | ||
test-internal.js | ||
test-node-cli-mode.sh | ||
test-react.js | ||
test-residual.js | ||
test-runner.js | ||
test-sourcemaps.sh | ||
test-std-in.sh |