git.iko.soy/generic-lens
on master help sign in
Changelog, readme
commit4ed90a0d600f1a5e7bf214614da9b3a88fb38438 authorCsongor Kiss <kiss.csongor.kiss@gmail.com> dateThu 5 Apr 2018, 02:56 (9 years ago) parent57a46bd
2 files changed+14−5
compare with master
unifiedsplit
ChangeLog.md+3−1 README.md+11−4
ChangeLog.md+3−1
@@ -1,5 +1,7 @@
11## 1.0.0.0
2−- TODO
2+- Traversals (types, param, constraints)
3+- Prisms are now optimal too
4+- Monomorphic versions of lenses and prisms also included
35
46### Breaking API changes
57- `projectSub` now returns `Maybe sub` instead of `Either sup sub` (#21)
README.md+11−4
@@ -266,7 +266,7 @@ types :: HasTypes s a => Traversal' s a
266266[42,1,88,37,2]
267267```
268268
269−Note that this traversal is `deep': the subtrees are recursively traversed.
269+Note that this traversal is "deep": the subtrees are recursively traversed.
270270
271271### By parameter
272272As the above example shows, the `types` traversal is limited in that it cannot
@@ -398,9 +398,16 @@ Duck 6
398398```
399399
400400# Performance
401−TODO.
402−## Inspection testing
403−## Benchmarks
401+The runtime characteristics of the derived optics is in most cases identical at
402+`-O1`, in some cases only slightly slower than the hand-written version. This
403+is thanks to GHC's optimiser eliminating the generic overhead.
404+
405+The
406+[inspection-testing](https://hackage.haskell.org/package/inspection-testing)
407+library is used to ensure (see [here](test/Spec.hs)) that everything gets
408+inlined away.
409+
410+TODO push benchmarks too
404411# Contributors
405412
406413+ [Matthew Pickering](https://github.com/mpickering)