72d03a2 · generic-lens

git.iko.soy/generic-lens

HLint

commit72d03a291900f0af6df0402bdced6a3d481c11c9 authorCsongor Kiss <kiss.csongor.kiss@gmail.com> dateThu 18 Jan 2018, 22:16 (9 years ago) parent882b766

17 files changed+16−35

compare with master

unifiedsplit

src/Data/Generics/Internal/Families.hs+1−1 src/Data/Generics/Internal/Families/Changing.hs−1 src/Data/Generics/Internal/Profunctor/Iso.hs+4−6 src/Data/Generics/Internal/Profunctor/Lens.hs+2−3 src/Data/Generics/Internal/Profunctor/Prism.hs+1−2 src/Data/Generics/Internal/VL/Iso.hs−2 src/Data/Generics/Internal/VL/Lens.hs+1−3 src/Data/Generics/Internal/VL/Prism.hs−2 src/Data/Generics/Internal/VL/Traversal.hs−2 src/Data/Generics/Product/Internal/Keyed.hs+1−2 src/Data/Generics/Product/Internal/List.hs+2−4 src/Data/Generics/Product/Internal/Positions.hs+1−1 src/Data/Generics/Product/Internal/Types.hs−1 src/Data/Generics/Product/List.hs+1−1 src/Data/Generics/Product/Types.hs−2 src/Data/Generics/Sum/Internal/Constructors.hs+1−1 src/Data/Generics/Sum/Typed.hs+1−1

src/Data/Generics/Internal/Families.hs+1−1

@@ -3,7 +3,6 @@

33{-# LANGUAGE FlexibleInstances #-}

44{-# LANGUAGE KindSignatures #-}

55{-# LANGUAGE MultiParamTypeClasses #-}

6−{-# LANGUAGE TypeApplications #-}

76{-# LANGUAGE TypeFamilies #-}

87{-# LANGUAGE TypeOperators #-}

@@ -28,6 +27,7 @@ import Data.Generics.Internal.Families.Changing as Families

2827

2928import GHC.TypeLits (ErrorMessage (..), Symbol)

3029

30+-- * Stuff

3131type family ShowSymbols (ctors :: [Symbol]) :: ErrorMessage where

3232 ShowSymbols '[]

3333 = 'Text ""

src/Data/Generics/Internal/Families/Changing.hs−1

@@ -1,7 +1,6 @@

11{-# LANGUAGE AllowAmbiguousTypes #-}

22{-# LANGUAGE DataKinds #-}

33{-# LANGUAGE FlexibleInstances #-}

4−{-# LANGUAGE FunctionalDependencies #-}

54{-# LANGUAGE GADTs #-}

65{-# LANGUAGE PolyKinds #-}

76{-# LANGUAGE TypeFamilies #-}

src/Data/Generics/Internal/Profunctor/Iso.hs+4−6

@@ -1,9 +1,7 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

75{-# LANGUAGE TypeFamilies #-}

86{-# LANGUAGE TypeFamilyDependencies #-}

97{-# LANGUAGE TypeOperators #-}

@@ -48,10 +46,10 @@ kIso = iso unK1 K1

4846

4947sumIso :: Iso ((a :+: b) x) ((a' :+: b') x) (Either (a x) (b x)) (Either (a' x) (b' x))

5048sumIso = iso back forth

51− where forth (Left l) = (L1 l)

52− forth (Right r) = (R1 r)

53− back (L1 l) = (Left l)

54− back (R1 r) = (Right r)

49+ where forth (Left l) = L1 l

50+ forth (Right r) = R1 r

51+ back (L1 l) = Left l

52+ back (R1 r) = Right r

5553

5654prodIso :: Iso ((a :*: b) x) ((a' :*: b') x) (a x, b x) (a' x, b' x)

5755prodIso = iso (\(a :*: b) -> (a, b)) (\(a, b) -> (a :*: b))

src/Data/Generics/Internal/Profunctor/Lens.hs+2−3

@@ -1,5 +1,4 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

@@ -74,12 +73,12 @@ build p = unTagged . p . Tagged

7473-- | Lens focusing on the first element of a product

7574first :: Lens ((a :*: b) x) ((a' :*: b) x) (a x) (a' x)

7675first

77− = lens (\(a :*: _) -> a) (\((_ :*: b), a') -> a' :*: b)

76+ = lens (\(a :*: _) -> a) (\(_ :*: b, a') -> a' :*: b)

7877

7978-- | Lens focusing on the second element of a product

8079second :: Lens ((a :*: b) x) ((a :*: b') x) (b x) (b' x)

8180second

82− = lens (\(_ :*: b) -> b) (\((a :*: _), b') -> a :*: b')

81+ = lens (\(_ :*: b) -> b) (\(a :*: _, b') -> a :*: b')

8382

8483fork :: (a -> b) -> (a -> c) -> a -> (b, c)

8584fork f g a = (f a, g a)

src/Data/Generics/Internal/Profunctor/Prism.hs+1−2

@@ -3,7 +3,6 @@

33{-# LANGUAGE NoMonomorphismRestriction #-}

44{-# LANGUAGE Rank2Types #-}

55{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

76{-# LANGUAGE TypeFamilies #-}

87{-# LANGUAGE TypeFamilyDependencies #-}

98{-# LANGUAGE TypeOperators #-}

@@ -106,7 +105,7 @@ instance Profunctor (Market a b) where

106105 {-# INLINE ( .# ) #-}

107106

108107instance Choice (Market a b) where

109− left' (Market bt seta) = Market (Left . bt) $ \sc -> case sc of

108+ left' (Market bt seta) = Market (Left . bt) $ \case

110109 Left s -> case seta s of

111110 Left t -> Left (Left t)

112111 Right a -> Right a

src/Data/Generics/Internal/VL/Iso.hs−2

@@ -1,9 +1,7 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

75{-# LANGUAGE TypeFamilies #-}

86{-# LANGUAGE TypeFamilyDependencies #-}

97{-# LANGUAGE TypeOperators #-}

src/Data/Generics/Internal/VL/Lens.hs+1−3

@@ -1,9 +1,7 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

75{-# LANGUAGE TypeFamilies #-}

86{-# LANGUAGE TypeFamilyDependencies #-}

97{-# LANGUAGE TypeOperators #-}

@@ -37,7 +35,7 @@ view :: ((a -> Const a a) -> s -> Const a s) -> s -> a

3735view l s = (^.) s l

3836

3937set :: Lens s t a b -> b -> s -> t

40−set l x = runIdentity . (l (Identity . const x))

38+set l x = runIdentity . l (Identity . const x)

4139

4240lens2lensvl :: ALens a b s t -> Lens s t a b

4341lens2lensvl (ALens _get _set) = lens _get _set

src/Data/Generics/Internal/VL/Prism.hs−2

@@ -1,9 +1,7 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

75{-# LANGUAGE TypeFamilies #-}

86{-# LANGUAGE TypeFamilyDependencies #-}

97{-# LANGUAGE TypeOperators #-}

src/Data/Generics/Internal/VL/Traversal.hs−2

@@ -1,9 +1,7 @@

11{-# LANGUAGE GADTs #-}

2−{-# LANGUAGE LambdaCase #-}

32{-# LANGUAGE NoMonomorphismRestriction #-}

43{-# LANGUAGE Rank2Types #-}

54{-# LANGUAGE ScopedTypeVariables #-}

6−{-# LANGUAGE TupleSections #-}

75{-# LANGUAGE TypeFamilies #-}

86{-# LANGUAGE TypeFamilyDependencies #-}

97{-# LANGUAGE TypeOperators #-}

src/Data/Generics/Product/Internal/Keyed.hs+1−2

@@ -4,7 +4,6 @@

44{-# LANGUAGE FunctionalDependencies #-}

55{-# LANGUAGE GADTs #-}

66{-# LANGUAGE ScopedTypeVariables #-}

7−{-# LANGUAGE TupleSections #-}

87{-# LANGUAGE TypeApplications #-}

98{-# LANGUAGE TypeFamilies #-}

109{-# LANGUAGE TypeInType #-}

@@ -50,5 +49,5 @@ instance

5049 , IndexList i as bs a b

5150 , GIsList k f g as bs

5251 ) => GHasKey (key :: k) (M1 C meta f) (M1 C meta g) a b where

53− gkey = mIso . (glist @k) . point @i

52+ gkey = mIso . glist @k . point @i

5453

src/Data/Generics/Product/Internal/List.hs+2−4

@@ -38,8 +38,6 @@ module Data.Generics.Product.Internal.List

3838 , Elem

3939 , ListTuple (..)

4040 , TupleToList

41− , Permuting (..)

42− , Appending (..)

4341 ) where

4442

4543import GHC.TypeLits

@@ -160,7 +158,7 @@ instance Permuting List '[] '[] where

160158

161159instance (Permuting List as as', Inserting List '(fa, a) as' bs')

162160 => Permuting List ('(fa, a) ': as) bs' where

163− permuting = fromIso consing . pairing id permuting . consing . (inserting @_ @'(fa, _))

161+ permuting = fromIso consing . pairing id permuting . consing . inserting @_ @'(fa, _)

164162

165163--------------------------------------------------------------------------------

166164class IndexList (i :: Nat) as bs a b | i as -> a, i bs -> b, i as b -> bs, i bs a -> as where

@@ -170,7 +168,7 @@ instance {-# OVERLAPPING #-}

170168 ( as ~ ('(f, a) ': as')

171169 , bs ~ ('(f, b) ': as')

172170 ) => IndexList 0 as bs a b where

173− point = lens (\(x :> _) -> x) (\((_ :> xs), x') -> x' :> xs)

171+ point = lens (\(x :> _) -> x) (\(_ :> xs, x') -> x' :> xs)

174172 {-# INLINE point #-}

175173

176174instance

src/Data/Generics/Product/Internal/Positions.hs+1−1

@@ -58,7 +58,7 @@ instance

5858 ( IndexList (i - 1) as bs a b

5959 , GIsList () f g as bs

6060 ) => GHasPosition i (M1 C meta f) (M1 C meta g) a b where

61− gposition = mIso . (glist @()) . point @(i - 1)

61+ gposition = mIso . glist @() . point @(i - 1)

6262

6363type family Size f :: Nat where

6464 Size (l :*: r)

src/Data/Generics/Product/Internal/Types.hs−1

@@ -5,7 +5,6 @@

55{-# LANGUAGE KindSignatures #-}

66{-# LANGUAGE MultiParamTypeClasses #-}

77{-# LANGUAGE ScopedTypeVariables #-}

8−{-# LANGUAGE TypeApplications #-}

98{-# LANGUAGE TypeFamilies #-}

109{-# LANGUAGE TypeOperators #-}

1110{-# LANGUAGE UndecidableInstances #-}

src/Data/Generics/Product/List.hs+1−1

@@ -46,7 +46,7 @@ instance

4646 , Generic g

4747 , GIsList m (Rep f) (Rep g) as bs

4848 ) => IsList m f g as bs where

49− list = repIso . (glist @m)

49+ list = repIso . glist @m

5050

5151class IsList Symbol f g as bs => IsRecord f g (as :: [(Symbol, Type)]) (bs :: [(Symbol, Type)]) | f -> as, g -> bs

5252instance IsList Symbol f g as bs => IsRecord f g as bs

src/Data/Generics/Product/Types.hs−2

@@ -2,10 +2,8 @@

22{-# LANGUAGE DataKinds #-}

33{-# LANGUAGE FlexibleContexts #-}

44{-# LANGUAGE FlexibleInstances #-}

5−{-# LANGUAGE KindSignatures #-}

65{-# LANGUAGE MultiParamTypeClasses #-}

76{-# LANGUAGE ScopedTypeVariables #-}

8−{-# LANGUAGE TypeApplications #-}

97{-# LANGUAGE TypeFamilies #-}

108{-# LANGUAGE TypeOperators #-}

119{-# LANGUAGE UndecidableInstances #-}

src/Data/Generics/Sum/Internal/Constructors.hs+1−1

@@ -55,7 +55,7 @@ instance

5555

5656-- _GCtor = prismP (M1 . gfromCollection . tupleToList) (Right . listToTuple . gtoCollection . unM1)

5757-- {-# INLINE _GCtor #-}

58− _GCtor = prism (M1 . (view (fromIso (glist @Type))) . tupleToList) (Right . listToTuple . (view (glist @Type)) . unM1)

58+ _GCtor = prism (M1 . view (fromIso (glist @Type)) . tupleToList) (Right . listToTuple . view (glist @Type) . unM1)

5959

6060

6161instance GSumAsConstructor ctor (HasCtorP ctor l) l r l' r' a b => GAsConstructor ctor (l :+: r) (l' :+: r') a b where

src/Data/Generics/Sum/Typed.hs+1−1

@@ -96,7 +96,7 @@ class AsType a s where

9696 -- |Project by type.

9797 projectTyped :: s -> Maybe a

9898 projectTyped

99− = either (const Nothing) Just . (match _Typed)

99+ = either (const Nothing) Just . match _Typed

100100

101101instance

102102 ( Generic s