3354a4f · ghcide · git.iko.soy

Remove unnecessary HLint ignores now HLint 3.0.4 is out (#545)

commit3354a4f38c14b05a866488c748d9e541fa6f1723 authorNeil Mitchell <ndmitchell@gmail.com> dateMon 4 May 2020, 08:12 (6 years ago) parent9adb111

2 files changed−6

unifiedsplit

src/Development/IDE/Core/Shake.hs−2

@@ -392,8 +392,6 @@ withMVar' var unmasked masked = mask $ \restore -> do

392392 pure c

393393

394394-- | Spawn immediately. If you are already inside a call to shakeRun that will be aborted with an exception.

395−{- HLINT ignore shakeRun "Redundant bracket" -}

396−-- HLint seems to get confused by type applications and suggests to remove parentheses.

397395shakeRun :: IdeState -> [Action a] -> IO (IO [a])

398396shakeRun IdeState{shakeExtras=ShakeExtras{..}, ..} acts =

399397 withMVar'

test/exe/Main.hs−4

@@ -1984,8 +1984,6 @@ cradleTests = testGroup "cradle"

19841984 ,testGroup "loading" [loadCradleOnlyonce]

19851985 ]

19861986

1987−{- HLINT ignore loadCradleOnlyonce "Redundant bracket" -}

1988−-- HLint seems to get confused by type applications and suggests to remove parentheses.

19891987loadCradleOnlyonce :: TestTree

19901988loadCradleOnlyonce = testGroup "load cradle only once"

19911989 [ testSession' "implicit" implicit

@@ -2353,8 +2351,6 @@ nthLine i r

23532351 | i >= Rope.rows r = error $ "Row number out of bounds: " <> show i <> "/" <> show (Rope.rows r)

23542352 | otherwise = Rope.takeWhile (/= '\n') $ fst $ Rope.splitAtLine 1 $ snd $ Rope.splitAtLine (i - 1) r

23552353

2356−{- HLINT ignore getWatchedFilesSubscriptionsUntil "Redundant bracket" -}

2357−-- HLint seems to get confused by type applications and suggests to remove parentheses.

23582354getWatchedFilesSubscriptionsUntil :: forall end . (FromJSON end, Typeable end) => Session [Maybe Value]

23592355getWatchedFilesSubscriptionsUntil = do

23602356 msgs <- manyTill (Just <$> message @RegisterCapabilityRequest <|> Nothing <$ anyMessage) (message @end)