@@ -1,6 +1,7 @@
11-- Copyright (c) 2019 The DAML Authors. All rights reserved.
22-- SPDX-License-Identifier: Apache-2.0
33
4+{-# LANGUAGE AllowAmbiguousTypes #-}
45{-# LANGUAGE DuplicateRecordFields #-}
56{-# LANGUAGE PatternSynonyms #-}
67{-# LANGUAGE CPP #-}
@@ -9,51 +10,74 @@
910module Main (main) where
1011
1112import Control.Applicative.Combinators
12−import Control.Exception (catch)
13+import Control.Exception (bracket, catch)
14+import qualified Control.Lens as Lens
1315import Control.Monad
1416import Control.Monad.IO.Class (liftIO)
15−import Data.Char (toLower)
17+import Data.Aeson (FromJSON, Value)
1618import Data.Foldable
17−import Data.List
19+import Data.List.Extra
20+import Data.Rope.UTF16 (Rope)
21+import qualified Data.Rope.UTF16 as Rope
22+import Development.IDE.Core.PositionMapping (fromCurrent, toCurrent)
1823import Development.IDE.GHC.Util
1924import qualified Data.Text as T
25+import Data.Typeable
26+import Development.IDE.Spans.Common
2027import Development.IDE.Test
2128import Development.IDE.Test.Runfiles
2229import Development.IDE.Types.Location
23−import qualified Language.Haskell.LSP.Test as LSPTest
24−import Language.Haskell.LSP.Test hiding (openDoc')
30+import Development.Shake (getDirectoryFilesIO)
31+import Language.Haskell.LSP.Test
32+import Language.Haskell.LSP.Messages
2533import Language.Haskell.LSP.Types
2634import Language.Haskell.LSP.Types.Capabilities
27−import System.Environment.Blank (setEnv)
35+import qualified Language.Haskell.LSP.Types.Lens as Lsp (diagnostics, params, message)
36+import Language.Haskell.LSP.VFS (applyChange)
37+import Network.URI
38+import System.Environment.Blank (getEnv, setEnv, unsetEnv)
2839import System.FilePath
2940import System.IO.Extra
3041import System.Directory
42+import Test.QuickCheck
43+import Test.QuickCheck.Instances ()
3144import Test.Tasty
32−import Test.Tasty.HUnit
3345import Test.Tasty.ExpectedFailure
46+import Test.Tasty.Ingredients.Rerun
47+import Test.Tasty.HUnit
48+import Test.Tasty.QuickCheck
3449import Data.Maybe
3550
3651main :: IO ()
37−main = defaultMain $ testGroup "HIE"
38− [ testSession "open close" $ do
39− doc <- openDoc' "Testing.hs" "haskell" ""
40− void (message :: Session WorkDoneProgressCreateRequest)
41− void (message :: Session WorkDoneProgressBeginNotification)
42− closeDoc doc
43− void (message :: Session WorkDoneProgressEndNotification)
44− , initializeResponseTests
45− , completionTests
46− , cppTests
47− , diagnosticTests
48− , codeActionTests
49− , codeLensesTests
50− , outlineTests
51− , findDefinitionAndHoverTests
52− , pluginTests
53− , preprocessorTests
54− , thTests
55− , unitTests
56− ]
52+main = do
53+ -- We mess with env vars so run single-threaded.
54+ setEnv "TASTY_NUM_THREADS" "1" True
55+ defaultMainWithRerun $ testGroup "HIE"
56+ [ testSession "open close" $ do
57+ doc <- createDoc "Testing.hs" "haskell" ""
58+ void (skipManyTill anyMessage message :: Session WorkDoneProgressCreateRequest)
59+ void (skipManyTill anyMessage message :: Session WorkDoneProgressBeginNotification)
60+ closeDoc doc
61+ void (skipManyTill anyMessage message :: Session WorkDoneProgressEndNotification)
62+ , initializeResponseTests
63+ , completionTests
64+ , cppTests
65+ , diagnosticTests
66+ , codeActionTests
67+ , codeLensesTests
68+ , outlineTests
69+ , findDefinitionAndHoverTests
70+ , pluginTests
71+ , preprocessorTests
72+ , thTests
73+ , safeTests
74+ , unitTests
75+ , haddockTests
76+ , positionMappingTests
77+ , watchedFilesTests
78+ , cradleTests
79+ , dependentFileTest
80+ ]
5781
5882initializeResponseTests :: TestTree
5983initializeResponseTests = withResource acquire release tests where
@@ -88,8 +112,8 @@ initializeResponseTests = withResource acquire release tests where
88112 , chk "NO doc link" _documentLinkProvider Nothing
89113 , chk "NO color" _colorProvider (Just $ ColorOptionsStatic False)
90114 , chk "NO folding range" _foldingRangeProvider (Just $ FoldingRangeOptionsStatic False)
91− , chk " execute command" _executeCommandProvider (Just $ ExecuteCommandOptions $ List ["typesignature.add"])
92− , chk "NO workspace" _workspace nothingWorkspace
115+ , che " execute command" _executeCommandProvider (Just $ ExecuteCommandOptions $ List ["typesignature.add"])
116+ , chk " workspace" _workspace (Just $ WorkspaceOptions (Just WorkspaceFolderOptions{_supported = Just True, _changeNotifications = Just ( WorkspaceFolderChangeNotificationsBool True )}))
93117 , chk "NO experimental" _experimental Nothing
94118 ] where
95119
@@ -100,14 +124,21 @@ initializeResponseTests = withResource acquire release tests where
100124 , _willSaveWaitUntil = Nothing
101125 , _save = Just (SaveOptions {_includeText = Nothing})}))
102126
103− nothingWorkspace = Just (WorkspaceOptions {_workspaceFolders = Nothing})
104−
105127 chk :: (Eq a, Show a) => TestName -> (InitializeResponseCapabilitiesInner -> a) -> a -> TestTree
106128 chk title getActual expected =
107129 testCase title $ getInitializeResponse >>= \ir -> expected @=? (getActual . innerCaps) ir
108130
131+ che :: TestName -> (InitializeResponseCapabilitiesInner -> Maybe ExecuteCommandOptions) -> Maybe ExecuteCommandOptions -> TestTree
132+ che title getActual _expected = testCase title doTest
133+ where
134+ doTest = do
135+ ir <- getInitializeResponse
136+ let Just ExecuteCommandOptions {_commands = List [command]} = getActual $ innerCaps ir
137+ True @=? T.isSuffixOf "typesignature.add" command
138+
139+
109140 innerCaps :: InitializeResponse -> InitializeResponseCapabilitiesInner
110− innerCaps (ResponseMessage _ _ (Just (InitializeResponseCapabilities c)) _) = c
141+ innerCaps (ResponseMessage _ _ (Right (InitializeResponseCapabilities c))) = c
111142 innerCaps _ = error "this test only expects inner capabilities"
112143
113144 acquire :: IO InitializeResponse
@@ -121,7 +152,7 @@ diagnosticTests :: TestTree
121152diagnosticTests = testGroup "diagnostics"
122153 [ testSessionWait "fix syntax error" $ do
123154 let content = T.unlines [ "module Testing wher" ]
124− doc <- openDoc' "Testing.hs" "haskell" content
155+ doc <- createDoc "Testing.hs" "haskell" content
125156 expectDiagnostics [("Testing.hs", [(DsError, (0, 15), "parse error")])]
126157 let change = TextDocumentContentChangeEvent
127158 { _range = Just (Range (Position 0 15) (Position 0 19))
@@ -132,9 +163,9 @@ diagnosticTests = testGroup "diagnostics"
132163 expectDiagnostics [("Testing.hs", [])]
133164 , testSessionWait "introduce syntax error" $ do
134165 let content = T.unlines [ "module Testing where" ]
135− doc <- openDoc' "Testing.hs" "haskell" content
136− void (message :: Session WorkDoneProgressCreateRequest)
137− void (message :: Session WorkDoneProgressBeginNotification)
166+ doc <- createDoc "Testing.hs" "haskell" content
167+ void $ skipManyTill anyMessage (message :: Session WorkDoneProgressCreateRequest)
168+ void $ skipManyTill anyMessage (message :: Session WorkDoneProgressBeginNotification)
138169 let change = TextDocumentContentChangeEvent
139170 { _range = Just (Range (Position 0 15) (Position 0 18))
140171 , _rangeLength = Nothing
@@ -150,7 +181,7 @@ diagnosticTests = testGroup "diagnostics"
150181 , "bar :: Int -> Int -> Int"
151182 , "bar a b = cd + b"
152183 ]
153− _ <- openDoc' "Testing.hs" "haskell" content
184+ _ <- createDoc "Testing.hs" "haskell" content
154185 expectDiagnostics
155186 [ ( "Testing.hs"
156187 , [ (DsError, (2, 14), "Variable not in scope: ab")
@@ -164,7 +195,7 @@ diagnosticTests = testGroup "diagnostics"
164195 , "foo :: Int -> String -> Int"
165196 , "foo a b = a + b"
166197 ]
167− _ <- openDoc' "Testing.hs" "haskell" content
198+ _ <- createDoc "Testing.hs" "haskell" content
168199 expectDiagnostics
169200 [ ( "Testing.hs"
170201 , [(DsError, (2, 14), "Couldn't match type '[Char]' with 'Int'")]
@@ -176,7 +207,7 @@ diagnosticTests = testGroup "diagnostics"
176207 , "foo :: Int -> String"
177208 , "foo a = _ a"
178209 ]
179− _ <- openDoc' "Testing.hs" "haskell" content
210+ _ <- createDoc "Testing.hs" "haskell" content
180211 expectDiagnostics
181212 [ ( "Testing.hs"
182213 , [(DsError, (2, 8), "Found hole: _ :: Int -> String")]
@@ -198,24 +229,23 @@ diagnosticTests = testGroup "diagnostics"
198229 [ ("A.hs", [(DsError, (2,4), aMessage)])
199230 , ("B.hs", [(DsError, (3,4), bMessage)])]
200231 deferralTest title binding msg = testSessionWait title $ do
201− _ <- openDoc' "A.hs" "haskell" $ sourceA binding
202− _ <- openDoc' "B.hs" "haskell" sourceB
232+ _ <- createDoc "A.hs" "haskell" $ sourceA binding
233+ _ <- createDoc "B.hs" "haskell" sourceB
203234 expectDiagnostics $ expectedDs msg
204235 in
205236 [ deferralTest "type error" "True" "Couldn't match expected type"
206237 , deferralTest "typed hole" "_" "Found hole"
207238 , deferralTest "out of scope var" "unbound" "Variable not in scope"
208− , deferralTest "message shows error" "True" "A.hs:3:5: error:"
209239 ]
210240
211241 , testSessionWait "remove required module" $ do
212242 let contentA = T.unlines [ "module ModuleA where" ]
213− docA <- openDoc' "ModuleA.hs" "haskell" contentA
243+ docA <- createDoc "ModuleA.hs" "haskell" contentA
214244 let contentB = T.unlines
215245 [ "module ModuleB where"
216246 , "import ModuleA"
217247 ]
218− _ <- openDoc' "ModuleB.hs" "haskell" contentB
248+ _ <- createDoc "ModuleB.hs" "haskell" contentB
219249 let change = TextDocumentContentChangeEvent
220250 { _range = Just (Range (Position 0 0) (Position 0 20))
221251 , _rangeLength = Nothing
@@ -228,11 +258,21 @@ diagnosticTests = testGroup "diagnostics"
228258 [ "module ModuleB where"
229259 , "import ModuleA"
230260 ]
231− _ <- openDoc' "ModuleB.hs" "haskell" contentB
261+ _ <- createDoc "ModuleB.hs" "haskell" contentB
232262 expectDiagnostics [("ModuleB.hs", [(DsError, (1, 7), "Could not find module")])]
233263 let contentA = T.unlines [ "module ModuleA where" ]
234− _ <- openDoc' "ModuleA.hs" "haskell" contentA
264+ _ <- createDoc "ModuleA.hs" "haskell" contentA
235265 expectDiagnostics [("ModuleB.hs", [])]
266+ , testSessionWait "add missing module (non workspace)" $ do
267+ let contentB = T.unlines
268+ [ "module ModuleB where"
269+ , "import ModuleA"
270+ ]
271+ _ <- createDoc "/tmp/ModuleB.hs" "haskell" contentB
272+ expectDiagnostics [("/tmp/ModuleB.hs", [(DsError, (1, 7), "Could not find module")])]
273+ let contentA = T.unlines [ "module ModuleA where" ]
274+ _ <- createDoc "/tmp/ModuleA.hs" "haskell" contentA
275+ expectDiagnostics [("/tmp/ModuleB.hs", [])]
236276 , testSessionWait "cyclic module dependency" $ do
237277 let contentA = T.unlines
238278 [ "module ModuleA where"
@@ -242,8 +282,8 @@ diagnosticTests = testGroup "diagnostics"
242282 [ "module ModuleB where"
243283 , "import ModuleA"
244284 ]
245− _ <- openDoc' "ModuleA.hs" "haskell" contentA
246− _ <- openDoc' "ModuleB.hs" "haskell" contentB
285+ _ <- createDoc "ModuleA.hs" "haskell" contentA
286+ _ <- createDoc "ModuleB.hs" "haskell" contentB
247287 expectDiagnostics
248288 [ ( "ModuleA.hs"
249289 , [(DsError, (1, 7), "Cyclic module dependency between ModuleA, ModuleB")]
@@ -264,9 +304,9 @@ diagnosticTests = testGroup "diagnostics"
264304 let contentBboot = T.unlines
265305 [ "module ModuleB where"
266306 ]
267− _ <- openDoc' "ModuleA.hs" "haskell" contentA
268− _ <- openDoc' "ModuleB.hs" "haskell" contentB
269− _ <- openDoc' "ModuleB.hs-boot" "haskell" contentBboot
307+ _ <- createDoc "ModuleA.hs" "haskell" contentA
308+ _ <- createDoc "ModuleB.hs" "haskell" contentB
309+ _ <- createDoc "ModuleB.hs-boot" "haskell" contentBboot
270310 expectDiagnostics []
271311 , testSessionWait "correct reference used with hs-boot" $ do
272312 let contentB = T.unlines
@@ -288,10 +328,10 @@ diagnosticTests = testGroup "diagnostics"
288328 -- resolved to the hs-boot file
289329 , "y = x"
290330 ]
291− _ <- openDoc' "ModuleB.hs" "haskell" contentB
292− _ <- openDoc' "ModuleA.hs" "haskell" contentA
293− _ <- openDoc' "ModuleA.hs-boot" "haskell" contentAboot
294− _ <- openDoc' "ModuleC.hs" "haskell" contentC
331+ _ <- createDoc "ModuleB.hs" "haskell" contentB
332+ _ <- createDoc "ModuleA.hs" "haskell" contentA
333+ _ <- createDoc "ModuleA.hs-boot" "haskell" contentAboot
334+ _ <- createDoc "ModuleC.hs" "haskell" contentC
295335 expectDiagnostics []
296336 , testSessionWait "redundant import" $ do
297337 let contentA = T.unlines ["module ModuleA where"]
@@ -300,8 +340,8 @@ diagnosticTests = testGroup "diagnostics"
300340 , "module ModuleB where"
301341 , "import ModuleA"
302342 ]
303− _ <- openDoc' "ModuleA.hs" "haskell" contentA
304− _ <- openDoc' "ModuleB.hs" "haskell" contentB
343+ _ <- createDoc "ModuleA.hs" "haskell" contentA
344+ _ <- createDoc "ModuleB.hs" "haskell" contentB
305345 expectDiagnostics
306346 [ ( "ModuleB.hs"
307347 , [(DsWarning, (2, 0), "The import of 'ModuleA' is redundant")]
@@ -323,8 +363,8 @@ diagnosticTests = testGroup "diagnostics"
323363 , "wrong1 = ThisList.map"
324364 , "wrong2 = BaseList.x"
325365 ]
326− _ <- openDoc' "Data/List.hs" "haskell" thisDataListContent
327− _ <- openDoc' "Main.hs" "haskell" mainContent
366+ _ <- createDoc "Data/List.hs" "haskell" thisDataListContent
367+ _ <- createDoc "Main.hs" "haskell" mainContent
328368 expectDiagnostics
329369 [ ( "Main.hs"
330370 , [(DsError, (6, 9), "Not in scope: \8216ThisList.map\8217")
@@ -339,7 +379,7 @@ diagnosticTests = testGroup "diagnostics"
339379 , "foo :: Ord a => a -> Int"
340380 , "foo a = 1"
341381 ]
342− _ <- openDoc' "Foo.hs" "haskell" fooContent
382+ _ <- createDoc "Foo.hs" "haskell" fooContent
343383 expectDiagnostics
344384 [ ( "Foo.hs"
345385 -- The test is to make sure that warnings contain unqualified names
@@ -364,18 +404,18 @@ diagnosticTests = testGroup "diagnostics"
364404 Just pathB <- pure $ uriToFilePath uriB
365405 uriB <- pure $
366406 let (drive, suffix) = splitDrive pathB
367− in filePathToUri (joinDrive (map toLower drive ) suffix)
407+ in filePathToUri (joinDrive (lower drive) suffix)
368408 liftIO $ createDirectoryIfMissing True (takeDirectory pathB)
369409 liftIO $ writeFileUTF8 pathB $ T.unpack bContent
370410 uriA <- getDocUri "A/A.hs"
371411 Just pathA <- pure $ uriToFilePath uriA
372412 uriA <- pure $
373413 let (drive, suffix) = splitDrive pathA
374− in filePathToUri (joinDrive (map toLower drive ) suffix)
414+ in filePathToUri (joinDrive (lower drive) suffix)
375415 let itemA = TextDocumentItem uriA "haskell" 0 aContent
376416 let a = TextDocumentIdentifier uriA
377417 sendNotification TextDocumentDidOpen (DidOpenTextDocumentParams itemA)
378− diagsNot <- skipManyTill anyMessage message :: Session PublishDiagnosticsNotification
418+ diagsNot <- skipManyTill anyMessage diagnostic
379419 let PublishDiagnosticsParams fileUri diags = _params (diagsNot :: PublishDiagnosticsNotification)
380420 -- Check that if we put a lower-case drive in for A.A
381421 -- the diagnostics for A.B will also be lower-case.
@@ -384,6 +424,38 @@ diagnosticTests = testGroup "diagnostics"
384424 liftIO $ unless ("redundant" `T.isInfixOf` msg) $
385425 assertFailure ("Expected redundant import but got " <> T.unpack msg)
386426 closeDoc a
427+ , testSessionWait "haddock parse error" $ do
428+ let fooContent = T.unlines
429+ [ "module Foo where"
430+ , "foo :: Int"
431+ , "foo = 1 {-|-}"
432+ ]
433+ _ <- createDoc "Foo.hs" "haskell" fooContent
434+ expectDiagnostics
435+ [ ( "Foo.hs"
436+ , [(DsError, (2, 8), "Parse error on input")
437+ ]
438+ )
439+ ]
440+ , testSessionWait "strip file path" $ do
441+ let
442+ name = "Testing"
443+ content = T.unlines
444+ [ "module " <> name <> " where"
445+ , "value :: Maybe ()"
446+ , "value = [()]"
447+ ]
448+ _ <- createDoc (T.unpack name <> ".hs") "haskell" content
449+ notification <- skipManyTill anyMessage diagnostic
450+ let
451+ offenders =
452+ Lsp.params .
453+ Lsp.diagnostics .
454+ Lens.folded .
455+ Lsp.message .
456+ Lens.filtered (T.isInfixOf ("/" <> name <> ".hs:"))
457+ failure msg = liftIO $ assertFailure $ "Expected file path to be stripped but got " <> T.unpack msg
458+ Lens.mapMOf_ offenders failure notification
387459 ]
388460
389461codeActionTests :: TestTree
@@ -392,6 +464,8 @@ codeActionTests = testGroup "code actions"
392464 , typeWildCardActionTests
393465 , removeImportTests
394466 , extendImportTests
467+ , suggestImportTests
468+ , addExtensionTests
395469 , fixConstructorImportTests
396470 , importRenameActionTests
397471 , fillTypedHoleTests
@@ -404,6 +478,33 @@ codeLensesTests = testGroup "code lenses"
404478 [ addSigLensesTests
405479 ]
406480
481+watchedFilesTests :: TestTree
482+watchedFilesTests = testGroup "watched files"
483+ [ testSession' "workspace files" $ \sessionDir -> do
484+ liftIO $ writeFile (sessionDir </> "hie.yaml") "cradle: {direct: {arguments: [\"-isrc\"]}}"
485+ _doc <- createDoc "A.hs" "haskell" "{-#LANGUAGE NoImplicitPrelude #-}\nmodule A where\nimport WatchedFilesMissingModule"
486+ watchedFileRegs <- getWatchedFilesSubscriptionsUntil @PublishDiagnosticsNotification
487+
488+ -- Expect 4 subscriptions (A does not get any because it's VFS):
489+ -- - /path-to-workspace/WatchedFilesMissingModule.hs
490+ -- - /path-to-workspace/WatchedFilesMissingModule.lhs
491+ -- - /path-to-workspace/src/WatchedFilesMissingModule.hs
492+ -- - /path-to-workspace/src/WatchedFilesMissingModule.lhs
493+ liftIO $ length watchedFileRegs @?= 4
494+
495+ , testSession' "non workspace file" $ \sessionDir -> do
496+ liftIO $ writeFile (sessionDir </> "hie.yaml") "cradle: {direct: {arguments: [\"-i/tmp\"]}}"
497+ _doc <- createDoc "A.hs" "haskell" "{-# LANGUAGE NoImplicitPrelude#-}\nmodule A where\nimport WatchedFilesMissingModule"
498+ watchedFileRegs <- getWatchedFilesSubscriptionsUntil @PublishDiagnosticsNotification
499+
500+ -- Expect 2 subscriptions (/tmp does not get any as it is out of the workspace):
501+ -- - /path-to-workspace/WatchedFilesMissingModule.hs
502+ -- - /path-to-workspace/WatchedFilesMissingModule.lhs
503+ liftIO $ length watchedFileRegs @?= 2
504+
505+ -- TODO add a test for didChangeWorkspaceFolder
506+ ]
507+
407508renameActionTests :: TestTree
408509renameActionTests = testGroup "rename actions"
409510 [ testSession "change to local variable name" $ do
@@ -412,7 +513,7 @@ renameActionTests = testGroup "rename actions"
412513 , "foo :: Int -> Int"
413514 , "foo argName = argNme"
414515 ]
415− doc <- openDoc' "Testing.hs" "haskell" content
516+ doc <- createDoc "Testing.hs" "haskell" content
416517 _ <- waitForDiagnostics
417518 action <- findCodeAction doc (Range (Position 2 14) (Position 2 20)) "Replace with ‘argName’"
418519 executeCodeAction action
@@ -430,7 +531,7 @@ renameActionTests = testGroup "rename actions"
430531 , "foo :: Maybe a -> [a]"
431532 , "foo = maybToList"
432533 ]
433− doc <- openDoc' "Testing.hs" "haskell" content
534+ doc <- createDoc "Testing.hs" "haskell" content
434535 _ <- waitForDiagnostics
435536 action <- findCodeAction doc (Range (Position 3 6) (Position 3 16)) "Replace with ‘maybeToList’"
436537 executeCodeAction action
@@ -448,7 +549,7 @@ renameActionTests = testGroup "rename actions"
448549 , "foo :: Char -> Char -> Char -> Char"
449550 , "foo argument1 argument2 argument3 = argumentX"
450551 ]
451− doc <- openDoc' "Testing.hs" "haskell" content
552+ doc <- createDoc "Testing.hs" "haskell" content
452553 _ <- waitForDiagnostics
453554 _ <- findCodeActions doc (Range (Position 2 36) (Position 2 45))
454555 ["Replace with ‘argument1’", "Replace with ‘argument2’", "Replace with ‘argument3’"]
@@ -460,7 +561,7 @@ renameActionTests = testGroup "rename actions"
460561 , "monus x y = max 0 (x - y)"
461562 , "foo x y = x `monnus` y"
462563 ]
463− doc <- openDoc' "Testing.hs" "haskell" content
564+ doc <- createDoc "Testing.hs" "haskell" content
464565 _ <- waitForDiagnostics
465566 actionsOrCommands <- getCodeActions doc (Range (Position 3 12) (Position 3 20))
466567 [fixTypo] <- pure [action | CACodeAction action@CodeAction{ _title = actionTitle } <- actionsOrCommands, "monus" `T.isInfixOf` actionTitle ]
@@ -483,7 +584,7 @@ typeWildCardActionTests = testGroup "type wildcard actions"
483584 , "func :: _"
484585 , "func x = x"
485586 ]
486− doc <- openDoc' "Testing.hs" "haskell" content
587+ doc <- createDoc "Testing.hs" "haskell" content
487588 _ <- waitForDiagnostics
488589 actionsOrCommands <- getCodeActions doc (Range (Position 2 1) (Position 2 10))
489590 let [addSignature] = [action | CACodeAction action@CodeAction { _title = actionTitle } <- actionsOrCommands
@@ -503,7 +604,7 @@ typeWildCardActionTests = testGroup "type wildcard actions"
503604 , "func :: _"
504605 , "func x y = x + y"
505606 ]
506− doc <- openDoc' "Testing.hs" "haskell" content
607+ doc <- createDoc "Testing.hs" "haskell" content
507608 _ <- waitForDiagnostics
508609 actionsOrCommands <- getCodeActions doc (Range (Position 2 1) (Position 2 10))
509610 let [addSignature] = [action | CACodeAction action@CodeAction { _title = actionTitle } <- actionsOrCommands
@@ -526,7 +627,7 @@ typeWildCardActionTests = testGroup "type wildcard actions"
526627 , " y = x * 2"
527628 , " in y"
528629 ]
529− doc <- openDoc' "Testing.hs" "haskell" content
630+ doc <- createDoc "Testing.hs" "haskell" content
530631 _ <- waitForDiagnostics
531632 actionsOrCommands <- getCodeActions doc (Range (Position 4 1) (Position 4 10))
532633 let [addSignature] = [action | CACodeAction action@CodeAction { _title = actionTitle } <- actionsOrCommands
@@ -551,7 +652,7 @@ removeImportTests = testGroup "remove import actions"
551652 let contentA = T.unlines
552653 [ "module ModuleA where"
553654 ]
554− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
655+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
555656 let contentB = T.unlines
556657 [ "{-# OPTIONS_GHC -Wunused-imports #-}"
557658 , "module ModuleB where"
@@ -559,7 +660,7 @@ removeImportTests = testGroup "remove import actions"
559660 , "stuffB :: Integer"
560661 , "stuffB = 123"
561662 ]
562− docB <- openDoc' "ModuleB.hs" "haskell" contentB
663+ docB <- createDoc "ModuleB.hs" "haskell" contentB
563664 _ <- waitForDiagnostics
564665 [CACodeAction action@CodeAction { _title = actionTitle }]
565666 <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
@@ -577,7 +678,7 @@ removeImportTests = testGroup "remove import actions"
577678 let contentA = T.unlines
578679 [ "module ModuleA where"
579680 ]
580− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
681+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
581682 let contentB = T.unlines
582683 [ "{-# OPTIONS_GHC -Wunused-imports #-}"
583684 , "module ModuleB where"
@@ -585,7 +686,7 @@ removeImportTests = testGroup "remove import actions"
585686 , "stuffB :: Integer"
586687 , "stuffB = 123"
587688 ]
588− docB <- openDoc' "ModuleB.hs" "haskell" contentB
689+ docB <- createDoc "ModuleB.hs" "haskell" contentB
589690 _ <- waitForDiagnostics
590691 [CACodeAction action@CodeAction { _title = actionTitle }]
591692 <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
@@ -607,14 +708,14 @@ removeImportTests = testGroup "remove import actions"
607708 , "stuffB = 123"
608709 , "stuffC = ()"
609710 ]
610− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
711+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
611712 let contentB = T.unlines
612713 [ "{-# OPTIONS_GHC -Wunused-imports #-}"
613714 , "module ModuleB where"
614715 , "import ModuleA (stuffA, stuffB, stuffC, stuffA)"
615716 , "main = print stuffB"
616717 ]
617− docB <- openDoc' "ModuleB.hs" "haskell" contentB
718+ docB <- createDoc "ModuleB.hs" "haskell" contentB
618719 _ <- waitForDiagnostics
619720 [CACodeAction action@CodeAction { _title = actionTitle }]
620721 <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
@@ -628,29 +729,26 @@ removeImportTests = testGroup "remove import actions"
628729 , "main = print stuffB"
629730 ]
630731 liftIO $ expectedContentAfterAction @=? contentAfterAction
631− , testSession "redundant symbol binding" $ do
732+ , testSession "redundant operator" $ do
632733 let contentA = T.unlines
633734 [ "module ModuleA where"
634735 , "a !! b = a"
736+ , "a <?> b = a"
635737 , "stuffB :: Integer"
636738 , "stuffB = 123"
637739 ]
638− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
740+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
639741 let contentB = T.unlines
640742 [ "{-# OPTIONS_GHC -Wunused-imports #-}"
641743 , "module ModuleB where"
642− , "import qualified ModuleA as A ((!!), stuffB, (!!))"
744+ , "import qualified ModuleA as A ((<?>), stuffB, (!!))"
643745 , "main = print A.stuffB"
644746 ]
645− docB <- openDoc' "ModuleB.hs" "haskell" contentB
747+ docB <- createDoc "ModuleB.hs" "haskell" contentB
646748 _ <- waitForDiagnostics
647749 [CACodeAction action@CodeAction { _title = actionTitle }]
648750 <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
649−#if MIN_GHC_API_VERSION(8,6,0)
650− liftIO $ "Remove !! from import" @=? actionTitle
651−#else
652− liftIO $ "Remove A.!! from import" @=? actionTitle
653−#endif
751+ liftIO $ "Remove !!, <?> from import" @=? actionTitle
654752 executeCodeAction action
655753 contentAfterAction <- documentContents docB
656754 let expectedContentAfterAction = T.unlines
@@ -660,21 +758,21 @@ removeImportTests = testGroup "remove import actions"
660758 , "main = print A.stuffB"
661759 ]
662760 liftIO $ expectedContentAfterAction @=? contentAfterAction
663− , (`xfail` "known broken (#299)") $ testSession "redundant hierarchical import" $ do
761+ , testSession "redundant all import" $ do
664762 let contentA = T.unlines
665763 [ "module ModuleA where"
666764 , "data A = A"
667765 , "stuffB :: Integer"
668766 , "stuffB = 123"
669767 ]
670− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
768+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
671769 let contentB = T.unlines
672770 [ "{-# OPTIONS_GHC -Wunused-imports #-}"
673771 , "module ModuleB where"
674772 , "import ModuleA (A(..), stuffB)"
675773 , "main = print stuffB"
676774 ]
677− docB <- openDoc' "ModuleB.hs" "haskell" contentB
775+ docB <- createDoc "ModuleB.hs" "haskell" contentB
678776 _ <- waitForDiagnostics
679777 [CACodeAction action@CodeAction { _title = actionTitle }]
680778 <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
@@ -688,6 +786,33 @@ removeImportTests = testGroup "remove import actions"
688786 , "main = print stuffB"
689787 ]
690788 liftIO $ expectedContentAfterAction @=? contentAfterAction
789+ , testSession "redundant constructor import" $ do
790+ let contentA = T.unlines
791+ [ "module ModuleA where"
792+ , "data D = A | B"
793+ , "data E = F"
794+ ]
795+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
796+ let contentB = T.unlines
797+ [ "{-# OPTIONS_GHC -Wunused-imports #-}"
798+ , "module ModuleB where"
799+ , "import ModuleA (D(A,B), E(F))"
800+ , "main = B"
801+ ]
802+ docB <- createDoc "ModuleB.hs" "haskell" contentB
803+ _ <- waitForDiagnostics
804+ [CACodeAction action@CodeAction { _title = actionTitle }]
805+ <- getCodeActions docB (Range (Position 2 0) (Position 2 5))
806+ liftIO $ "Remove A, E, F from import" @=? actionTitle
807+ executeCodeAction action
808+ contentAfterAction <- documentContents docB
809+ let expectedContentAfterAction = T.unlines
810+ [ "{-# OPTIONS_GHC -Wunused-imports #-}"
811+ , "module ModuleB where"
812+ , "import ModuleA (D(B))"
813+ , "main = B"
814+ ]
815+ liftIO $ expectedContentAfterAction @=? contentAfterAction
691816 ]
692817
693818extendImportTests :: TestTree
@@ -712,6 +837,26 @@ extendImportTests = testGroup "extend import actions"
712837 , "import ModuleA as A (stuffA, stuffB)"
713838 , "main = print (stuffA, stuffB)"
714839 ])
840+ , testSession "extend single line import with operator" $ template
841+ (T.unlines
842+ [ "module ModuleA where"
843+ , "(.*) :: Integer -> Integer -> Integer"
844+ , "x .* y = x * y"
845+ , "stuffB :: Integer"
846+ , "stuffB = 123"
847+ ])
848+ (T.unlines
849+ [ "module ModuleB where"
850+ , "import ModuleA as A (stuffB)"
851+ , "main = print (stuffB .* stuffB)"
852+ ])
853+ (Range (Position 3 17) (Position 3 18))
854+ "Add .* to the import list of ModuleA"
855+ (T.unlines
856+ [ "module ModuleB where"
857+ , "import ModuleA as A ((.*), stuffB)"
858+ , "main = print (stuffB .* stuffB)"
859+ ])
715860 , testSession "extend single line import with type" $ template
716861 (T.unlines
717862 [ "module ModuleA where"
@@ -795,8 +940,8 @@ extendImportTests = testGroup "extend import actions"
795940 ]
796941 where
797942 template contentA contentB range expectedAction expectedContentB = do
798− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
799− docB <- openDoc' "ModuleB.hs" "haskell" contentB
943+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
944+ docB <- createDoc "ModuleB.hs" "haskell" contentB
800945 _ <- waitForDiagnostics
801946 CACodeAction action@CodeAction { _title = actionTitle } : _
802947 <- sortOn (\(CACodeAction CodeAction{_title=x}) -> x) <$>
@@ -806,6 +951,117 @@ extendImportTests = testGroup "extend import actions"
806951 contentAfterAction <- documentContents docB
807952 liftIO $ expectedContentB @=? contentAfterAction
808953
954+suggestImportTests :: TestTree
955+suggestImportTests = testGroup "suggest import actions"
956+ [ testGroup "Dont want suggestion"
957+ [ -- extend import
958+ test False ["Data.List.NonEmpty ()"] "f = nonEmpty" [] "import Data.List.NonEmpty (nonEmpty)"
959+ -- data constructor
960+ , test False [] "f = First" [] "import Data.Monoid (First)"
961+ -- internal module
962+ , test False [] "f :: Typeable a => a" ["f = undefined"] "import Data.Typeable.Internal (Typeable)"
963+ -- package not in scope
964+ , test False [] "f = quickCheck" [] "import Test.QuickCheck (quickCheck)"
965+ ]
966+ , testGroup "want suggestion"
967+ [ test True [] "f = nonEmpty" [] "import Data.List.NonEmpty (nonEmpty)"
968+ , test True [] "f = (:|)" [] "import Data.List.NonEmpty (NonEmpty((:|)))"
969+ , test True [] "f :: Natural" ["f = undefined"] "import Numeric.Natural (Natural)"
970+ , test True [] "f :: NonEmpty ()" ["f = () :| []"] "import Data.List.NonEmpty (NonEmpty)"
971+ , test True [] "f = First" [] "import Data.Monoid (First(First))"
972+ , test True [] "f = Endo" [] "import Data.Monoid (Endo(Endo))"
973+ , test True [] "f = Version" [] "import Data.Version (Version(Version))"
974+ , test True [] "f ExitSuccess = ()" [] "import System.Exit (ExitCode(ExitSuccess))"
975+ , test True [] "f = AssertionFailed" [] "import Control.Exception (AssertionFailed(AssertionFailed))"
976+ , test True ["Prelude"] "f = nonEmpty" [] "import Data.List.NonEmpty (nonEmpty)"
977+ , test True [] "f :: Alternative f => f ()" ["f = undefined"] "import Control.Applicative (Alternative)"
978+ , test True [] "f = empty" [] "import Control.Applicative (Alternative(empty))"
979+ , test True [] "f = (&)" [] "import Data.Function ((&))"
980+ , test True [] "f = NE.nonEmpty" [] "import qualified Data.List.NonEmpty as NE"
981+ , test True [] "f :: Typeable a => a" ["f = undefined"] "import Data.Typeable (Typeable)"
982+ , test True [] "f = pack" [] "import Data.Text (pack)"
983+ , test True [] "f :: Text" ["f = undefined"] "import Data.Text (Text)"
984+ , test True [] "f = [] & id" [] "import Data.Function ((&))"
985+ , test True [] "f = (&) [] id" [] "import Data.Function ((&))"
986+ ]
987+ ]
988+ where
989+ test wanted imps def other newImp = testSession' (T.unpack def) $ \dir -> do
990+ let before = T.unlines $ "module A where" : ["import " <> x | x <- imps] ++ def : other
991+ after = T.unlines $ "module A where" : ["import " <> x | x <- imps] ++ [newImp] ++ def : other
992+ cradle = "cradle: {direct: {arguments: [-hide-all-packages, -package, base, -package, text, -package-env, -]}}"
993+ liftIO $ writeFileUTF8 (dir </> "hie.yaml") cradle
994+ doc <- createDoc "Test.hs" "haskell" before
995+ _diags <- waitForDiagnostics
996+ let defLine = length imps + 1
997+ range = Range (Position defLine 0) (Position defLine maxBound)
998+ actions <- getCodeActions doc range
999+ if wanted
1000+ then do
1001+ action <- liftIO $ pickActionWithTitle newImp actions
1002+ executeCodeAction action
1003+ contentAfterAction <- documentContents doc
1004+ liftIO $ after @=? contentAfterAction
1005+ else
1006+ liftIO $ [_title | CACodeAction CodeAction{_title} <- actions, _title == newImp ] @?= []
1007+
1008+
1009+addExtensionTests :: TestTree
1010+addExtensionTests = testGroup "add language extension actions"
1011+ [ testSession "add NamedFieldPuns language extension" $ template
1012+ (T.unlines
1013+ [ "module Module where"
1014+ , ""
1015+ , "data A = A { getA :: Bool }"
1016+ , ""
1017+ , "f :: A -> Bool"
1018+ , "f A { getA } = getA"
1019+ ])
1020+ (Range (Position 0 0) (Position 0 0))
1021+ "Add NamedFieldPuns extension"
1022+ (T.unlines
1023+ [ "{-# LANGUAGE NamedFieldPuns #-}"
1024+ , "module Module where"
1025+ , ""
1026+ , "data A = A { getA :: Bool }"
1027+ , ""
1028+ , "f :: A -> Bool"
1029+ , "f A { getA } = getA"
1030+ ])
1031+ , testSession "add RecordWildCards language extension" $ template
1032+ (T.unlines
1033+ [ "module Module where"
1034+ , ""
1035+ , "data A = A { getA :: Bool }"
1036+ , ""
1037+ , "f :: A -> Bool"
1038+ , "f A { .. } = getA"
1039+ ])
1040+ (Range (Position 0 0) (Position 0 0))
1041+ "Add RecordWildCards extension"
1042+ (T.unlines
1043+ [ "{-# LANGUAGE RecordWildCards #-}"
1044+ , "module Module where"
1045+ , ""
1046+ , "data A = A { getA :: Bool }"
1047+ , ""
1048+ , "f :: A -> Bool"
1049+ , "f A { .. } = getA"
1050+ ])
1051+ ]
1052+ where
1053+ template initialContent range expectedAction expectedContents = do
1054+ doc <- createDoc "Module.hs" "haskell" initialContent
1055+ _ <- waitForDiagnostics
1056+ CACodeAction action@CodeAction { _title = actionTitle } : _
1057+ <- sortOn (\(CACodeAction CodeAction{_title=x}) -> x) <$>
1058+ getCodeActions doc range
1059+ liftIO $ expectedAction @=? actionTitle
1060+ executeCodeAction action
1061+ contentAfterAction <- documentContents doc
1062+ liftIO $ expectedContents @=? contentAfterAction
1063+
1064+
8091065insertNewDefinitionTests :: TestTree
8101066insertNewDefinitionTests = testGroup "insert new definition actions"
8111067 [ testSession "insert new function definition" $ do
@@ -818,7 +1074,7 @@ insertNewDefinitionTests = testGroup "insert new definition actions"
8181074 [""
8191075 ,"someOtherCode = ()"
8201076 ]
821− docB <- openDoc' "ModuleB.hs" "haskell" (T.unlines $ txtB ++ txtB')
1077+ docB <- createDoc "ModuleB.hs" "haskell" (T.unlines $ txtB ++ txtB')
8221078 _ <- waitForDiagnostics
8231079 CACodeAction action@CodeAction { _title = actionTitle } : _
8241080 <- sortOn (\(CACodeAction CodeAction{_title=x}) -> x) <$>
@@ -842,7 +1098,7 @@ insertNewDefinitionTests = testGroup "insert new definition actions"
8421098 [""
8431099 ,"someOtherCode = ()"
8441100 ]
845− docB <- openDoc' "ModuleB.hs" "haskell" (T.unlines $ txtB ++ txtB')
1101+ docB <- createDoc "ModuleB.hs" "haskell" (T.unlines $ txtB ++ txtB')
8461102 _ <- waitForDiagnostics
8471103 CACodeAction action@CodeAction { _title = actionTitle } : _
8481104 <- sortOn (\(CACodeAction CodeAction{_title=x}) -> x) <$>
@@ -881,8 +1137,8 @@ fixConstructorImportTests = testGroup "fix import actions"
8811137 ]
8821138 where
8831139 template contentA contentB range expectedAction expectedContentB = do
884− _docA <- openDoc' "ModuleA.hs" "haskell" contentA
885− docB <- openDoc' "ModuleB.hs" "haskell" contentB
1140+ _docA <- createDoc "ModuleA.hs" "haskell" contentA
1141+ docB <- createDoc "ModuleB.hs" "haskell" contentB
8861142 _diags <- waitForDiagnostics
8871143 CACodeAction action@CodeAction { _title = actionTitle } : _
8881144 <- sortOn (\(CACodeAction CodeAction{_title=x}) -> x) <$>
@@ -901,7 +1157,7 @@ importRenameActionTests = testGroup "import rename actions"
9011157 [ "module Testing where"
9021158 , "import Data.Mape"
9031159 ]
904− doc <- openDoc' "Testing.hs" "haskell" content
1160+ doc <- createDoc "Testing.hs" "haskell" content
9051161 _ <- waitForDiagnostics
9061162 actionsOrCommands <- getCodeActions doc (Range (Position 2 8) (Position 2 16))
9071163 let [changeToMap] = [action | CACodeAction action@CodeAction{ _title = actionTitle } <- actionsOrCommands, ("Data." <> modname) `T.isInfixOf` actionTitle ]
@@ -938,10 +1194,10 @@ fillTypedHoleTests = let
9381194 newA newB newC = testSession (T.unpack actionTitle) $ do
9391195 let originalCode = sourceCode oldA oldB oldC
9401196 let expectedCode = sourceCode newA newB newC
941− doc <- openDoc' "Testing.hs" "haskell" originalCode
1197+ doc <- createDoc "Testing.hs" "haskell" originalCode
9421198 _ <- waitForDiagnostics
9431199 actionsOrCommands <- getCodeActions doc (Range (Position 9 0) (Position 9 maxBound))
944− let chosenAction = pickActionWithTitle actionTitle actionsOrCommands
1200+ chosenAction <- liftIO $ pickActionWithTitle actionTitle actionsOrCommands
9451201 executeCodeAction chosenAction
9461202 modifiedCode <- documentContents doc
9471203 liftIO $ expectedCode @=? modifiedCode
@@ -978,36 +1234,37 @@ fillTypedHoleTests = let
9781234
9791235addSigActionTests :: TestTree
9801236addSigActionTests = let
981− header = "{-# OPTIONS_GHC -Wmissing-signatures #-}"
982− moduleH = "module Sigs where"
1237+ header = "{-# OPTIONS_GHC -Wmissing-signatures -Wmissing-pattern-synonym-signatures #-}"
1238+ moduleH = "{-# LANGUAGE PatternSynonyms #-}\nmodule Sigs where"
9831239 before def = T.unlines [header, moduleH, def]
9841240 after' def sig = T.unlines [header, moduleH, sig, def]
9851241
9861242 def >:: sig = testSession (T.unpack def) $ do
9871243 let originalCode = before def
9881244 let expectedCode = after' def sig
989− doc <- openDoc' "Sigs.hs" "haskell" originalCode
1245+ doc <- createDoc "Sigs.hs" "haskell" originalCode
9901246 _ <- waitForDiagnostics
9911247 actionsOrCommands <- getCodeActions doc (Range (Position 3 1) (Position 3 maxBound))
992− let chosenAction = pickActionWithTitle ("add signature: " <> sig) actionsOrCommands
1248+ chosenAction <- liftIO $ pickActionWithTitle ("add signature: " <> sig) actionsOrCommands
9931249 executeCodeAction chosenAction
9941250 modifiedCode <- documentContents doc
9951251 liftIO $ expectedCode @=? modifiedCode
9961252 in
9971253 testGroup "add signature"
998− [ "abc = True" >:: "abc :: Bool"
999− , "foo a b = a + b" >:: "foo :: Num a => a -> a -> a"
1000− , "bar a b = show $ a + b" >:: "bar :: (Show a, Num a) => a -> a -> String"
1001− , "(!!!) a b = a > b" >:: "(!!!) :: Ord a => a -> a -> Bool"
1002− , "a >>>> b = a + b" >:: "(>>>>) :: Num a => a -> a -> a"
1003− , "a `haha` b = a b" >:: "haha :: (t1 -> t2) -> t1 -> t2"
1254+ [ "abc = True" >:: "abc :: Bool"
1255+ , "foo a b = a + b" >:: "foo :: Num a => a -> a -> a"
1256+ , "bar a b = show $ a + b" >:: "bar :: (Show a, Num a) => a -> a -> String"
1257+ , "(!!!) a b = a > b" >:: "(!!!) :: Ord a => a -> a -> Bool"
1258+ , "a >>>> b = a + b" >:: "(>>>>) :: Num a => a -> a -> a"
1259+ , "a `haha` b = a b" >:: "haha :: (t1 -> t2) -> t1 -> t2"
1260+ , "pattern Some a = Just a" >:: "pattern Some :: a -> Maybe a"
10041261 ]
10051262
10061263addSigLensesTests :: TestTree
10071264addSigLensesTests = let
1008− missing = "{-# OPTIONS_GHC -Wmissing-signatures -Wunused-matches #-}"
1265+ missing = "{-# OPTIONS_GHC -Wmissing-signatures -Wmissing-pattern-synonym-signatures -Wunused-matches #-}"
10091266 notMissing = "{-# OPTIONS_GHC -Wunused-matches #-}"
1010− moduleH = "module Sigs where"
1267+ moduleH = "{-# LANGUAGE PatternSynonyms #-}\nmodule Sigs where"
10111268 other = T.unlines ["f :: Integer -> Integer", "f x = 3"]
10121269 before withMissing def
10131270 = T.unlines $ (if withMissing then (missing :) else (notMissing :)) [moduleH, def, other]
@@ -1017,49 +1274,41 @@ addSigLensesTests = let
10171274 sigSession withMissing def sig = testSession (T.unpack def) $ do
10181275 let originalCode = before withMissing def
10191276 let expectedCode = after' withMissing def sig
1020− doc <- openDoc' "Sigs.hs" "haskell" originalCode
1277+ doc <- createDoc "Sigs.hs" "haskell" originalCode
10211278 [CodeLens {_command = Just c}] <- getCodeLenses doc
10221279 executeCommand c
10231280 modifiedCode <- getDocumentEdit doc
10241281 liftIO $ expectedCode @=? modifiedCode
10251282 in
10261283 testGroup "add signature"
1027− [ testGroup "with warnings enabled"
1028− [ sigSession True "abc = True" "abc :: Bool"
1029− , sigSession True "foo a b = a + b" "foo :: Num a => a -> a -> a"
1030− , sigSession True "bar a b = show $ a + b" "bar :: (Show a, Num a) => a -> a -> String"
1031− , sigSession True "(!!!) a b = a > b" "(!!!) :: Ord a => a -> a -> Bool"
1032− , sigSession True "a >>>> b = a + b" "(>>>>) :: Num a => a -> a -> a"
1033− , sigSession True "a `haha` b = a b" "haha :: (t1 -> t2) -> t1 -> t2"
1034− ]
1035− , testGroup "with warnings disabled"
1036− [ sigSession False "abc = True" "abc :: Bool"
1037− , sigSession False "foo a b = a + b" "foo :: Num a => a -> a -> a"
1038− , sigSession False "bar a b = show $ a + b" "bar :: (Show a, Num a) => a -> a -> String"
1039− , sigSession False "(!!!) a b = a > b" "(!!!) :: Ord a => a -> a -> Bool"
1040− , sigSession False "a >>>> b = a + b" "(>>>>) :: Num a => a -> a -> a"
1041− , sigSession False "a `haha` b = a b" "haha :: (t1 -> t2) -> t1 -> t2"
1284+ [ testGroup title
1285+ [ sigSession enableWarnings "abc = True" "abc :: Bool"
1286+ , sigSession enableWarnings "foo a b = a + b" "foo :: Num a => a -> a -> a"
1287+ , sigSession enableWarnings "bar a b = show $ a + b" "bar :: (Show a, Num a) => a -> a -> String"
1288+ , sigSession enableWarnings "(!!!) a b = a > b" "(!!!) :: Ord a => a -> a -> Bool"
1289+ , sigSession enableWarnings "a >>>> b = a + b" "(>>>>) :: Num a => a -> a -> a"
1290+ , sigSession enableWarnings "a `haha` b = a b" "haha :: (t1 -> t2) -> t1 -> t2"
1291+ , sigSession enableWarnings "pattern Some a = Just a" "pattern Some :: a -> Maybe a"
10421292 ]
1293+ | (title, enableWarnings) <-
1294+ [("with warnings enabled", True)
1295+ ,("with warnings disabled", False)
1296+ ]
10431297 ]
10441298
1045−findDefinitionAndHoverTests :: TestTree
1046−findDefinitionAndHoverTests = let
1047−
1048− tst (get, check) pos targetRange title = testSession title $ do
1049− doc <- openTestDataDoc sourceFilePath
1050− found <- get doc pos
1051− check found targetRange
1052−
1053− checkDefs :: [Location] -> [Expect] -> Session ()
1054− checkDefs defs expectations = traverse_ check expectations where
1299+checkDefs :: [Location] -> Session [Expect] -> Session ()
1300+checkDefs defs mkExpectations = traverse_ check =<< mkExpectations where
10551301
1056− check (ExpectRange expectedRange) = do
1057− assertNDefinitionsFound 1 defs
1058− assertRangeCorrect (head defs) expectedRange
1059− check ExpectNoDefinitions = do
1060− assertNDefinitionsFound 0 defs
1061− check ExpectExternFail = liftIO $ assertFailure "Expecting to fail to find in external file"
1062− check _ = pure () -- all other expectations not relevant to getDefinition
1302+ check (ExpectRange expectedRange) = do
1303+ assertNDefinitionsFound 1 defs
1304+ assertRangeCorrect (head defs) expectedRange
1305+ check (ExpectLocation expectedLocation) = do
1306+ assertNDefinitionsFound 1 defs
1307+ liftIO $ head defs @?= expectedLocation
1308+ check ExpectNoDefinitions = do
1309+ assertNDefinitionsFound 0 defs
1310+ check ExpectExternFail = liftIO $ assertFailure "Expecting to fail to find in external file"
1311+ check _ = pure () -- all other expectations not relevant to getDefinition
10631312
10641313 assertNDefinitionsFound :: Int -> [a] -> Session ()
10651314 assertNDefinitionsFound n defs = liftIO $ assertEqual "number of definitions" n (length defs)
@@ -1067,8 +1316,19 @@ findDefinitionAndHoverTests = let
10671316 assertRangeCorrect Location{_range = foundRange} expectedRange =
10681317 liftIO $ expectedRange @=? foundRange
10691318
1070− checkHover :: Maybe Hover -> [Expect] -> Session ()
1071− checkHover hover expectations = traverse_ check expectations where
1319+
1320+findDefinitionAndHoverTests :: TestTree
1321+findDefinitionAndHoverTests = let
1322+
1323+ tst (get, check) pos targetRange title = testSessionWithExtraFiles "hover" title $ \dir -> do
1324+ doc <- openTestDataDoc (dir </> sourceFilePath)
1325+ found <- get doc pos
1326+ check found targetRange
1327+
1328+
1329+
1330+ checkHover :: Maybe Hover -> Session [Expect] -> Session ()
1331+ checkHover hover expectations = traverse_ check =<< expectations where
10721332
10731333 check expected =
10741334 case hover of
@@ -1111,9 +1371,12 @@ findDefinitionAndHoverTests = let
11111371
11121372 mkFindTests tests = testGroup "get"
11131373 [ testGroup "definition" $ mapMaybe fst tests
1114− , testGroup "hover" $ mapMaybe snd tests ]
1374+ , testGroup "hover" $ mapMaybe snd tests
1375+ , checkFileCompiles sourceFilePath ]
1376+
1377+ test runDef runHover look expect = testM runDef runHover look (return expect)
11151378
1116− test runDef runHover look expect title =
1379+ testM runDef runHover look expect title =
11171380 ( runDef $ tst def look expect title
11181381 , runHover $ tst hover look expect title ) where
11191382 def = (getDefinitions, checkDefs)
@@ -1121,87 +1384,100 @@ findDefinitionAndHoverTests = let
11211384 --type_ = (getTypeDefinitions, checkTDefs) -- getTypeDefinitions always times out
11221385
11231386 -- search locations expectations on results
1124− fffL4 = _start fffR ; fffR = mkRange 4 4 4 7 ; fff = [ExpectRange fffR]
1125− fffL8 = Position 8 4 ;
1126− fffL14 = Position 14 7 ;
1127− aaaL14 = Position 14 20 ; aaa = [mkR 7 0 7 3]
1128− dcL7 = Position 7 11 ; tcDC = [mkR 3 23 5 16]
1129− dcL12 = Position 12 11 ;
1130− xtcL5 = Position 5 11 ; xtc = [ExpectExternFail, ExpectHoverText ["Int", "Defined in ‘GHC.Types’"]]
1131− tcL6 = Position 6 11 ; tcData = [mkR 3 0 5 16, ExpectHoverText ["TypeConstructor", "GotoHover.hs:4:1"]]
1132− vvL16 = Position 16 12 ; vv = [mkR 16 4 16 6]
1133− opL16 = Position 16 15 ; op = [mkR 17 2 17 4]
1134− opL18 = Position 18 22 ; opp = [mkR 18 13 18 17]
1135− aL18 = Position 18 20 ; apmp = [mkR 18 10 18 11]
1136− b'L19 = Position 19 13 ; bp = [mkR 19 6 19 7]
1137− xvL20 = Position 20 8 ; xvMsg = [ExpectExternFail, ExpectHoverText ["Data.Text.pack", ":: String -> Text"]]
1138− clL23 = Position 23 11 ; cls = [mkR 21 0 22 20, ExpectHoverText ["MyClass", "GotoHover.hs:22:1"]]
1139− clL25 = Position 25 9
1140− eclL15 = Position 15 8 ; ecls = [ExpectExternFail, ExpectHoverText ["Num", "Defined in ‘GHC.Num’"]]
1141− dnbL29 = Position 29 18 ; dnb = [ExpectHoverText [":: ()"], mkR 29 12 29 21]
1142− dnbL30 = Position 30 23
1143− lcbL33 = Position 33 26 ; lcb = [ExpectHoverText [":: Char"], mkR 33 26 33 27]
1144− lclL33 = Position 33 22
1145− mclL36 = Position 36 1 ; mcl = [mkR 36 0 36 14]
1146− mclL37 = Position 37 1
1147− spaceL37 = Position 37 24 ; space = [ExpectNoDefinitions, ExpectHoverText [":: Char"]]
1148− docL41 = Position 41 1 ; doc = [ExpectHoverText ["Recognizable docs: kpqz"]]
1387+ fffL4 = _start fffR ; fffR = mkRange 8 4 8 7 ; fff = [ExpectRange fffR]
1388+ fffL8 = Position 12 4 ;
1389+ fffL14 = Position 18 7 ;
1390+ aaaL14 = Position 18 20 ; aaa = [mkR 11 0 11 3]
1391+ dcL7 = Position 11 11 ; tcDC = [mkR 7 23 9 16]
1392+ dcL12 = Position 16 11 ;
1393+ xtcL5 = Position 9 11 ; xtc = [ExpectExternFail, ExpectHoverText ["Int", "Defined in ‘GHC.Types’"]]
1394+ tcL6 = Position 10 11 ; tcData = [mkR 7 0 9 16, ExpectHoverText ["TypeConstructor", "GotoHover.hs:8:1"]]
1395+ vvL16 = Position 20 12 ; vv = [mkR 20 4 20 6]
1396+ opL16 = Position 20 15 ; op = [mkR 21 2 21 4]
1397+ opL18 = Position 22 22 ; opp = [mkR 22 13 22 17]
1398+ aL18 = Position 22 20 ; apmp = [mkR 22 10 22 11]
1399+ b'L19 = Position 23 13 ; bp = [mkR 23 6 23 7]
1400+ xvL20 = Position 24 8 ; xvMsg = [ExpectExternFail, ExpectHoverText ["Data.Text.pack", ":: String -> Text"]]
1401+ clL23 = Position 27 11 ; cls = [mkR 25 0 26 20, ExpectHoverText ["MyClass", "GotoHover.hs:26:1"]]
1402+ clL25 = Position 29 9
1403+ eclL15 = Position 19 8 ; ecls = [ExpectExternFail, ExpectHoverText ["Num", "Defined in ‘GHC.Num’"]]
1404+ dnbL29 = Position 33 18 ; dnb = [ExpectHoverText [":: ()"], mkR 33 12 33 21]
1405+ dnbL30 = Position 34 23
1406+ lcbL33 = Position 37 26 ; lcb = [ExpectHoverText [":: Char"], mkR 37 26 37 27]
1407+ lclL33 = Position 37 22
1408+ mclL36 = Position 40 1 ; mcl = [mkR 40 0 40 14]
1409+ mclL37 = Position 41 1
1410+ spaceL37 = Position 41 24 ; space = [ExpectNoDefinitions, ExpectHoverText [":: Char"]]
1411+ docL41 = Position 45 1 ; doc = [ExpectHoverText ["Recognizable docs: kpqz"]]
11491412 ; constr = [ExpectHoverText ["Monad m"]]
1150− eitL40 = Position 40 28 ; kindE = [ExpectHoverText [":: * -> * -> *\n"]]
1151− intL40 = Position 40 34 ; kindI = [ExpectHoverText [":: *\n"]]
1152− tvrL40 = Position 40 37 ; kindV = [ExpectHoverText [":: * -> *\n"]]
1153− intL41 = Position 41 20 ; litI = [ExpectHoverText ["7518"]]
1154− chrL36 = Position 37 24 ; litC = [ExpectHoverText ["'f'"]]
1155− txtL8 = Position 8 14 ; litT = [ExpectHoverText ["\"dfgv\""]]
1156− lstL43 = Position 43 12 ; litL = [ExpectHoverText ["[ 8391 :: Int, 6268 ]"]]
1157− outL45 = Position 45 3 ; outSig = [ExpectHoverText ["outer", "Bool"], mkR 46 0 46 5]
1158− innL48 = Position 48 5 ; innSig = [ExpectHoverText ["inner", "Char"], mkR 49 2 49 7]
1413+ eitL40 = Position 44 28 ; kindE = [ExpectHoverText [":: * -> * -> *\n"]]
1414+ intL40 = Position 44 34 ; kindI = [ExpectHoverText [":: *\n"]]
1415+ tvrL40 = Position 44 37 ; kindV = [ExpectHoverText [":: * -> *\n"]]
1416+ intL41 = Position 45 20 ; litI = [ExpectHoverText ["7518"]]
1417+ chrL36 = Position 41 24 ; litC = [ExpectHoverText ["'f'"]]
1418+ txtL8 = Position 12 14 ; litT = [ExpectHoverText ["\"dfgy\""]]
1419+ lstL43 = Position 47 12 ; litL = [ExpectHoverText ["[8391 :: Int, 6268]"]]
1420+ outL45 = Position 49 3 ; outSig = [ExpectHoverText ["outer", "Bool"], mkR 46 0 46 5]
1421+ innL48 = Position 52 5 ; innSig = [ExpectHoverText ["inner", "Char"], mkR 49 2 49 7]
1422+ imported = Position 56 13 ; importedSig = getDocUri "Foo.hs" >>= \foo -> return [ExpectHoverText ["foo", "Foo"], mkL foo 4 0 4 3]
1423+ reexported = Position 55 14 ; reexportedSig = getDocUri "Bar.hs" >>= \bar -> return [ExpectHoverText ["Bar", "Bar"], mkL bar 2 0 2 14]
11591424 in
11601425 mkFindTests
1161− -- def hover look expect
1162− [ test yes yes fffL4 fff "field in record definition"
1163− , test broken broken fffL8 fff "field in record construction #71"
1164− , test yes yes fffL14 fff "field name used as accessor" -- 120 in Calculate.hs
1165− , test yes yes aaaL14 aaa "top-level name" -- 120
1166− , test yes yes dcL7 tcDC "data constructor record #247"
1167− , test yes yes dcL12 tcDC "data constructor plain" -- 121
1168− , test yes yes tcL6 tcData "type constructor #248" -- 147
1169− , test broken yes xtcL5 xtc "type constructor external #248,249"
1170− , test broken yes xvL20 xvMsg "value external package #249" -- 120
1171− , test yes yes vvL16 vv "plain parameter" -- 120
1172− , test yes yes aL18 apmp "pattern match name" -- 120
1173− , test yes yes opL16 op "top-level operator" -- 120, 123
1174− , test yes yes opL18 opp "parameter operator" -- 120
1175− , test yes yes b'L19 bp "name in backticks" -- 120
1176− , test yes yes clL23 cls "class in instance declaration #250"
1177− , test yes yes clL25 cls "class in signature #250" -- 147
1178− , test broken yes eclL15 ecls "external class in signature #249,250"
1179− , test yes yes dnbL29 dnb "do-notation bind" -- 137
1180− , test yes yes dnbL30 dnb "do-notation lookup"
1181− , test yes yes lcbL33 lcb "listcomp bind" -- 137
1182− , test yes yes lclL33 lcb "listcomp lookup"
1183− , test yes yes mclL36 mcl "top-level fn 1st clause"
1184− , test yes yes mclL37 mcl "top-level fn 2nd clause #246"
1185− , test yes yes spaceL37 space "top-level fn on space #315"
1186− , test no broken docL41 doc "documentation #7"
1187− , test no yes eitL40 kindE "kind of Either #273"
1188− , test no yes intL40 kindI "kind of Int #273"
1189− , test no broken tvrL40 kindV "kind of (* -> *) type variable #273"
1190− , test no yes intL41 litI "literal Int in hover info #274"
1191− , test no yes chrL36 litC "literal Char in hover info #274"
1192− , test no broken txtL8 litT "literal Text in hover info #274"
1193− , test no broken lstL43 litL "literal List in hover info #274"
1194− , test no yes docL41 constr "type constraint in hover info #283"
1195− , test broken broken outL45 outSig "top-level signature #310"
1196− , test broken broken innL48 innSig "inner signature #310"
1426+ -- def hover look expect
1427+ [ test yes yes fffL4 fff "field in record definition"
1428+ , test broken broken fffL8 fff "field in record construction #71"
1429+ , test yes yes fffL14 fff "field name used as accessor" -- 120 in Calculate.hs
1430+ , test yes yes aaaL14 aaa "top-level name" -- 120
1431+ , test yes yes dcL7 tcDC "data constructor record #247"
1432+ , test yes yes dcL12 tcDC "data constructor plain" -- 121
1433+ , test yes yes tcL6 tcData "type constructor #248" -- 147
1434+ , test broken yes xtcL5 xtc "type constructor external #248,249"
1435+ , test broken yes xvL20 xvMsg "value external package #249" -- 120
1436+ , test yes yes vvL16 vv "plain parameter" -- 120
1437+ , test yes yes aL18 apmp "pattern match name" -- 120
1438+ , test yes yes opL16 op "top-level operator" -- 120, 123
1439+ , test yes yes opL18 opp "parameter operator" -- 120
1440+ , test yes yes b'L19 bp "name in backticks" -- 120
1441+ , test yes yes clL23 cls "class in instance declaration #250"
1442+ , test yes yes clL25 cls "class in signature #250" -- 147
1443+ , test broken yes eclL15 ecls "external class in signature #249,250"
1444+ , test yes yes dnbL29 dnb "do-notation bind" -- 137
1445+ , test yes yes dnbL30 dnb "do-notation lookup"
1446+ , test yes yes lcbL33 lcb "listcomp bind" -- 137
1447+ , test yes yes lclL33 lcb "listcomp lookup"
1448+ , test yes yes mclL36 mcl "top-level fn 1st clause"
1449+ , test yes yes mclL37 mcl "top-level fn 2nd clause #246"
1450+ , test yes yes spaceL37 space "top-level fn on space #315"
1451+ , test no broken docL41 doc "documentation #7"
1452+ , test no yes eitL40 kindE "kind of Either #273"
1453+ , test no yes intL40 kindI "kind of Int #273"
1454+ , test no broken tvrL40 kindV "kind of (* -> *) type variable #273"
1455+ , test no yes intL41 litI "literal Int in hover info #274"
1456+ , test no yes chrL36 litC "literal Char in hover info #274"
1457+ , test no yes txtL8 litT "literal Text in hover info #274"
1458+ , test no yes lstL43 litL "literal List in hover info #274"
1459+ , test no yes docL41 constr "type constraint in hover info #283"
1460+ , test broken broken outL45 outSig "top-level signature #310"
1461+ , test broken broken innL48 innSig "inner signature #310"
1462+ , testM yes yes imported importedSig "Imported symbol"
1463+ , testM yes yes reexported reexportedSig "Imported symbol (reexported)"
11971464 ]
11981465 where yes, broken :: (TestTree -> Maybe TestTree)
11991466 yes = Just -- test should run and pass
12001467 broken = Just . (`xfail` "known broken")
12011468 no = const Nothing -- don't run this test at all
12021469
1470+checkFileCompiles :: FilePath -> TestTree
1471+checkFileCompiles fp =
1472+ testSessionWithExtraFiles "hover" ("Does " ++ fp ++ " compile") $ \dir -> do
1473+ void (openTestDataDoc (dir </> fp))
1474+ expectNoMoreDiagnostics 0.5
1475+
1476+
1477+
12031478pluginTests :: TestTree
1204−pluginTests = testSessionWait "plugins" $ do
1479+pluginTests = (`xfail8101` "known broken (#556)")
1480+ $ testSessionWait "plugins" $ do
12051481 let content =
12061482 T.unlines
12071483 [ "{-# OPTIONS_GHC -fplugin GHC.TypeLits.KnownNat.Solver #-}"
@@ -1215,7 +1491,7 @@ pluginTests = testSessionWait "plugins" $ do
12151491 , "foo :: Int -> Int -> Int"
12161492 , "foo a b = a + c"
12171493 ]
1218− _ <- openDoc' "Testing.hs" "haskell" content
1494+ _ <- createDoc "Testing.hs" "haskell" content
12191495 expectDiagnostics
12201496 [ ( "Testing.hs",
12211497 [(DsError, (8, 14), "Variable not in scope: c")]
@@ -1224,26 +1500,39 @@ pluginTests = testSessionWait "plugins" $ do
12241500
12251501cppTests :: TestTree
12261502cppTests =
1227− testCase "cpp" $ do
1228− let content =
1229− T.unlines
1230− [ "{-# LANGUAGE CPP #-}",
1231− "module Testing where",
1232− "#ifdef FOO",
1233− "foo = 42"
1234− ]
1235− -- The error locations differ depending on which C-preprocessor is used.
1236− -- Some give the column number and others don't (hence -1). Assert either
1237− -- of them.
1238− (run $ expectError content (2, -1))
1239− `catch` ( \e -> do
1240− let _ = e :: HUnitFailure
1241− run $ expectError content (2, 1)
1242− )
1503+ testGroup "cpp"
1504+ [ testCase "cpp-error" $ do
1505+ let content =
1506+ T.unlines
1507+ [ "{-# LANGUAGE CPP #-}",
1508+ "module Testing where",
1509+ "#ifdef FOO",
1510+ "foo = 42"
1511+ ]
1512+ -- The error locations differ depending on which C-preprocessor is used.
1513+ -- Some give the column number and others don't (hence -1). Assert either
1514+ -- of them.
1515+ (run $ expectError content (2, -1))
1516+ `catch` ( \e -> do
1517+ let _ = e :: HUnitFailure
1518+ run $ expectError content (2, 1)
1519+ )
1520+ , testSessionWait "cpp-ghcide" $ do
1521+ _ <- createDoc "A.hs" "haskell" $ T.unlines
1522+ ["{-# LANGUAGE CPP #-}"
1523+ ,"main ="
1524+ ,"#ifdef __GHCIDE__"
1525+ ," worked"
1526+ ,"#else"
1527+ ," failed"
1528+ ,"#endif"
1529+ ]
1530+ expectDiagnostics [("A.hs", [(DsError, (3, 2), "Variable not in scope: worked")])]
1531+ ]
12431532 where
12441533 expectError :: T.Text -> Cursor -> Session ()
12451534 expectError content cursor = do
1246− _ <- openDoc' "Testing.hs" "haskell" content
1535+ _ <- createDoc "Testing.hs" "haskell" content
12471536 expectDiagnostics
12481537 [ ( "Testing.hs",
12491538 [(DsError, cursor, "error: unterminated")]
@@ -1259,13 +1548,43 @@ preprocessorTests = testSessionWait "preprocessor" $ do
12591548 , "module Testing where"
12601549 , "y = x + z" -- plugin replaces x with y, making this have only one diagnostic
12611550 ]
1262− _ <- openDoc' "Testing.hs" "haskell" content
1551+ _ <- createDoc "Testing.hs" "haskell" content
12631552 expectDiagnostics
12641553 [ ( "Testing.hs",
12651554 [(DsError, (2, 8), "Variable not in scope: z")]
12661555 )
12671556 ]
12681557
1558+
1559+safeTests :: TestTree
1560+safeTests =
1561+ testGroup
1562+ "SafeHaskell"
1563+ [ -- Test for https://github.com/digital-asset/ghcide/issues/424
1564+ testSessionWait "load" $ do
1565+ let sourceA =
1566+ T.unlines
1567+ ["{-# LANGUAGE Trustworthy #-}"
1568+ ,"module A where"
1569+ ,"import System.IO.Unsafe"
1570+ ,"import System.IO"
1571+ ,"trustWorthyId :: a -> a"
1572+ ,"trustWorthyId i = unsafePerformIO $ do"
1573+ ," putStrLn \"I'm safe\""
1574+ ," return i"]
1575+ sourceB =
1576+ T.unlines
1577+ ["{-# LANGUAGE Safe #-}"
1578+ ,"module B where"
1579+ ,"import A"
1580+ ,"safeId :: a -> a"
1581+ ,"safeId = trustWorthyId"
1582+ ]
1583+
1584+ _ <- createDoc "A.hs" "haskell" sourceA
1585+ _ <- createDoc "B.hs" "haskell" sourceB
1586+ expectNoMoreDiagnostics 1 ]
1587+
12691588thTests :: TestTree
12701589thTests =
12711590 testGroup
@@ -1291,9 +1610,30 @@ thTests =
12911610 "b :: Integer",
12921611 "b = $(litE $ IntegerL $ a) + n"
12931612 ]
1294− _ <- openDoc' "A.hs" "haskell" sourceA
1295− _ <- openDoc' "B.hs" "haskell" sourceB
1613+ _ <- createDoc "A.hs" "haskell" sourceA
1614+ _ <- createDoc "B.hs" "haskell" sourceB
12961615 expectDiagnostics [ ( "B.hs", [(DsError, (6, 29), "Variable not in scope: n")] ) ]
1616+ , testSessionWait "newtype-closure" $ do
1617+ let sourceA =
1618+ T.unlines
1619+ [ "{-# LANGUAGE DeriveDataTypeable #-}"
1620+ ,"{-# LANGUAGE TemplateHaskell #-}"
1621+ ,"module A (a) where"
1622+ ,"import Data.Data"
1623+ ,"import Language.Haskell.TH"
1624+ ,"newtype A = A () deriving (Data)"
1625+ ,"a :: ExpQ"
1626+ ,"a = [| 0 |]"]
1627+ let sourceB =
1628+ T.unlines
1629+ [ "{-# LANGUAGE TemplateHaskell #-}"
1630+ ,"module B where"
1631+ ,"import A"
1632+ ,"b :: Int"
1633+ ,"b = $( a )" ]
1634+ _ <- createDoc "A.hs" "haskell" sourceA
1635+ _ <- createDoc "B.hs" "haskell" sourceB
1636+ return ()
12971637 ]
12981638
12991639completionTests :: TestTree
@@ -1301,31 +1641,31 @@ completionTests
13011641 = testGroup "completion"
13021642 [ testSessionWait "variable" $ do
13031643 let source = T.unlines ["module A where", "f = hea"]
1304− docId <- openDoc' "A.hs" "haskell" source
1644+ docId <- createDoc "A.hs" "haskell" source
13051645 compls <- getCompletions docId (Position 1 7)
1306− liftIO $ map dropDocs compls @?=
1646+ liftIO $ map dropDocs compls @?=
13071647 [complItem "head" (Just CiFunction) (Just "[a] -> a")]
13081648 let [CompletionItem { _documentation = headDocs}] = compls
13091649 checkDocText "head" headDocs [ "Defined in 'Prelude'"
1310−#if MIN_GHC_API_VERSION(8,6,0)
1650+#if MIN_GHC_API_VERSION(8,6,5)
13111651 , "Extract the first element of a list"
13121652#endif
13131653 ]
13141654 , testSessionWait "constructor" $ do
13151655 let source = T.unlines ["module A where", "f = Tru"]
1316− docId <- openDoc' "A.hs" "haskell" source
1656+ docId <- createDoc "A.hs" "haskell" source
13171657 compls <- getCompletions docId (Position 1 7)
1318− liftIO $ map dropDocs compls @?=
1658+ liftIO $ map dropDocs compls @?=
13191659 [ complItem "True" (Just CiConstructor) (Just "Bool")
13201660#if MIN_GHC_API_VERSION(8,6,0)
13211661 , complItem "truncate" (Just CiFunction) (Just "(RealFrac a, Integral b) => a -> b")
13221662#else
1323− , complItem "truncate" (Just CiFunction) (Just "RealFrac a => forall b. Integral b => a -> b")
1663+ , complItem "truncate" (Just CiFunction) (Just "RealFrac a => forall b. Integral b => a -> b")
13241664#endif
13251665 ]
13261666 , testSessionWait "type" $ do
13271667 let source = T.unlines ["{-# OPTIONS_GHC -Wall #-}", "module A () where", "f :: ()", "f = ()"]
1328− docId <- openDoc' "A.hs" "haskell" source
1668+ docId <- createDoc "A.hs" "haskell" source
13291669 expectDiagnostics [ ("A.hs", [(DsWarning, (3,0), "not used")]) ]
13301670 changeDoc docId [TextDocumentContentChangeEvent Nothing Nothing $ T.unlines ["{-# OPTIONS_GHC -Wall #-}", "module A () where", "f :: Bo", "f = True"]]
13311671 compls <- getCompletions docId (Position 2 7)
@@ -1335,30 +1675,51 @@ completionTests
13351675 let [ CompletionItem { _documentation = boundedDocs},
13361676 CompletionItem { _documentation = boolDocs } ] = compls
13371677 checkDocText "Bounded" boundedDocs [ "Defined in 'Prelude'"
1338−#if MIN_GHC_API_VERSION(8,6,0)
1678+#if MIN_GHC_API_VERSION(8,6,5)
13391679 , "name the upper and lower limits"
13401680#endif
13411681 ]
13421682 checkDocText "Bool" boolDocs [ "Defined in 'Prelude'" ]
13431683 , testSessionWait "qualified" $ do
13441684 let source = T.unlines ["{-# OPTIONS_GHC -Wunused-binds #-}", "module A () where", "f = ()"]
1345− docId <- openDoc' "A.hs" "haskell" source
1685+ docId <- createDoc "A.hs" "haskell" source
13461686 expectDiagnostics [ ("A.hs", [(DsWarning, (2, 0), "not used")]) ]
13471687 changeDoc docId [TextDocumentContentChangeEvent Nothing Nothing $ T.unlines ["{-# OPTIONS_GHC -Wunused-binds #-}", "module A () where", "f = Prelude.hea"]]
13481688 compls <- getCompletions docId (Position 2 15)
1349− liftIO $ map dropDocs compls @?=
1689+ liftIO $ map dropDocs compls @?=
13501690 [complItem "head" (Just CiFunction) (Just "[a] -> a")]
13511691 let [CompletionItem { _documentation = headDocs}] = compls
13521692 checkDocText "head" headDocs [ "Defined in 'Prelude'"
1353−#if MIN_GHC_API_VERSION(8,6,0)
1693+#if MIN_GHC_API_VERSION(8,6,5)
13541694 , "Extract the first element of a list"
13551695#endif
13561696 ]
13571697 , testSessionWait "keyword" $ do
13581698 let source = T.unlines ["module A where", "f = newty"]
1359− docId <- openDoc' "A.hs" "haskell" source
1699+ docId <- createDoc "A.hs" "haskell" source
13601700 compls <- getCompletions docId (Position 1 9)
13611701 liftIO $ compls @?= [keywordItem "newtype"]
1702+ , testSessionWait "type context" $ do
1703+ let source = T.unlines
1704+ [ "{-# OPTIONS_GHC -Wunused-binds #-}"
1705+ , "module A () where"
1706+ , "f = f"
1707+ ]
1708+ docId <- createDoc "A.hs" "haskell" source
1709+ expectDiagnostics [("A.hs", [(DsWarning, (2, 0), "not used")])]
1710+ changeDoc docId
1711+ [ TextDocumentContentChangeEvent Nothing Nothing $ T.unlines
1712+ [ "{-# OPTIONS_GHC -Wunused-binds #-}"
1713+ , "module A () where"
1714+ , "f = f"
1715+ , "g :: Intege"
1716+ ]
1717+ ]
1718+ -- At this point the module parses but does not typecheck.
1719+ -- This should be sufficient to detect that we are in a
1720+ -- type context and only show the completion to the type.
1721+ compls <- getCompletions docId (Position 3 11)
1722+ liftIO $ map dropDocs compls @?= [complItem "Integer"(Just CiStruct) (Just "*")]
13621723 ]
13631724 where
13641725 dropDocs :: CompletionItem -> CompletionItem
@@ -1366,6 +1727,7 @@ completionTests
13661727 complItem label kind ty = CompletionItem
13671728 { _label = label
13681729 , _kind = kind
1730+ , _tags = List []
13691731 , _detail = (":: " <>) <$> ty
13701732 , _documentation = Nothing
13711733 , _deprecated = Nothing
@@ -1383,6 +1745,7 @@ completionTests
13831745 keywordItem label = CompletionItem
13841746 { _label = label
13851747 , _kind = Just CiKeyword
1748+ , _tags = List []
13861749 , _detail = Nothing
13871750 , _documentation = Nothing
13881751 , _deprecated = Nothing
@@ -1410,7 +1773,7 @@ outlineTests = testGroup
14101773 "outline"
14111774 [ testSessionWait "type class" $ do
14121775 let source = T.unlines ["module A where", "class A a where a :: a -> Bool"]
1413− docId <- openDoc' "A.hs" "haskell" source
1776+ docId <- createDoc "A.hs" "haskell" source
14141777 symbols <- getDocumentSymbols docId
14151778 liftIO $ symbols @?= Left
14161779 [ moduleSymbol
@@ -1423,7 +1786,7 @@ outlineTests = testGroup
14231786 ]
14241787 , testSessionWait "type class instance " $ do
14251788 let source = T.unlines ["class A a where", "instance A () where"]
1426− docId <- openDoc' "A.hs" "haskell" source
1789+ docId <- createDoc "A.hs" "haskell" source
14271790 symbols <- getDocumentSymbols docId
14281791 liftIO $ symbols @?= Left
14291792 [ classSymbol "A a" (R 0 0 0 15) []
@@ -1431,7 +1794,7 @@ outlineTests = testGroup
14311794 ]
14321795 , testSessionWait "type family" $ do
14331796 let source = T.unlines ["{-# language TypeFamilies #-}", "type family A"]
1434− docId <- openDoc' "A.hs" "haskell" source
1797+ docId <- createDoc "A.hs" "haskell" source
14351798 symbols <- getDocumentSymbols docId
14361799 liftIO $ symbols @?= Left [docSymbolD "A" "type family" SkClass (R 1 0 1 13)]
14371800 , testSessionWait "type family instance " $ do
@@ -1440,7 +1803,7 @@ outlineTests = testGroup
14401803 , "type family A a"
14411804 , "type instance A () = ()"
14421805 ]
1443− docId <- openDoc' "A.hs" "haskell" source
1806+ docId <- createDoc "A.hs" "haskell" source
14441807 symbols <- getDocumentSymbols docId
14451808 liftIO $ symbols @?= Left
14461809 [ docSymbolD "A a" "type family" SkClass (R 1 0 1 15)
@@ -1448,7 +1811,7 @@ outlineTests = testGroup
14481811 ]
14491812 , testSessionWait "data family" $ do
14501813 let source = T.unlines ["{-# language TypeFamilies #-}", "data family A"]
1451− docId <- openDoc' "A.hs" "haskell" source
1814+ docId <- createDoc "A.hs" "haskell" source
14521815 symbols <- getDocumentSymbols docId
14531816 liftIO $ symbols @?= Left [docSymbolD "A" "data family" SkClass (R 1 0 1 11)]
14541817 , testSessionWait "data family instance " $ do
@@ -1457,7 +1820,7 @@ outlineTests = testGroup
14571820 , "data family A a"
14581821 , "data instance A () = A ()"
14591822 ]
1460− docId <- openDoc' "A.hs" "haskell" source
1823+ docId <- createDoc "A.hs" "haskell" source
14611824 symbols <- getDocumentSymbols docId
14621825 liftIO $ symbols @?= Left
14631826 [ docSymbolD "A a" "data family" SkClass (R 1 0 1 11)
@@ -1465,36 +1828,36 @@ outlineTests = testGroup
14651828 ]
14661829 , testSessionWait "constant" $ do
14671830 let source = T.unlines ["a = ()"]
1468− docId <- openDoc' "A.hs" "haskell" source
1831+ docId <- createDoc "A.hs" "haskell" source
14691832 symbols <- getDocumentSymbols docId
14701833 liftIO $ symbols @?= Left
14711834 [docSymbol "a" SkFunction (R 0 0 0 6)]
14721835 , testSessionWait "pattern" $ do
14731836 let source = T.unlines ["Just foo = Just 21"]
1474− docId <- openDoc' "A.hs" "haskell" source
1837+ docId <- createDoc "A.hs" "haskell" source
14751838 symbols <- getDocumentSymbols docId
14761839 liftIO $ symbols @?= Left
14771840 [docSymbol "Just foo" SkFunction (R 0 0 0 18)]
14781841 , testSessionWait "pattern with type signature" $ do
14791842 let source = T.unlines ["{-# language ScopedTypeVariables #-}", "a :: () = ()"]
1480− docId <- openDoc' "A.hs" "haskell" source
1843+ docId <- createDoc "A.hs" "haskell" source
14811844 symbols <- getDocumentSymbols docId
14821845 liftIO $ symbols @?= Left
14831846 [docSymbol "a :: ()" SkFunction (R 1 0 1 12)]
14841847 , testSessionWait "function" $ do
14851848 let source = T.unlines ["a x = ()"]
1486− docId <- openDoc' "A.hs" "haskell" source
1849+ docId <- createDoc "A.hs" "haskell" source
14871850 symbols <- getDocumentSymbols docId
14881851 liftIO $ symbols @?= Left [docSymbol "a" SkFunction (R 0 0 0 8)]
14891852 , testSessionWait "type synonym" $ do
14901853 let source = T.unlines ["type A = Bool"]
1491− docId <- openDoc' "A.hs" "haskell" source
1854+ docId <- createDoc "A.hs" "haskell" source
14921855 symbols <- getDocumentSymbols docId
14931856 liftIO $ symbols @?= Left
14941857 [docSymbol' "A" SkTypeParameter (R 0 0 0 13) (R 0 5 0 6)]
14951858 , testSessionWait "datatype" $ do
14961859 let source = T.unlines ["data A = C"]
1497− docId <- openDoc' "A.hs" "haskell" source
1860+ docId <- createDoc "A.hs" "haskell" source
14981861 symbols <- getDocumentSymbols docId
14991862 liftIO $ symbols @?= Left
15001863 [ docSymbolWithChildren "A"
@@ -1502,18 +1865,47 @@ outlineTests = testGroup
15021865 (R 0 0 0 10)
15031866 [docSymbol "C" SkConstructor (R 0 9 0 10)]
15041867 ]
1868+ , testSessionWait "record fields" $ do
1869+ let source = T.unlines ["data A = B {", " x :: Int", " , y :: Int}"]
1870+ docId <- createDoc "A.hs" "haskell" source
1871+ symbols <- getDocumentSymbols docId
1872+ liftIO $ symbols @=? Left
1873+ [ docSymbolWithChildren "A" SkStruct (R 0 0 2 13)
1874+ [ docSymbolWithChildren' "B" SkConstructor (R 0 9 2 13) (R 0 9 0 10)
1875+ [ docSymbol "x" SkField (R 1 2 1 3)
1876+ , docSymbol "y" SkField (R 2 4 2 5)
1877+ ]
1878+ ]
1879+ ]
15051880 , testSessionWait "import" $ do
15061881 let source = T.unlines ["import Data.Maybe"]
1507− docId <- openDoc' "A.hs" "haskell" source
1882+ docId <- createDoc "A.hs" "haskell" source
15081883 symbols <- getDocumentSymbols docId
15091884 liftIO $ symbols @?= Left
1510− [docSymbol "import Data.Maybe" SkModule (R 0 0 0 17)]
1885+ [docSymbolWithChildren "imports"
1886+ SkModule
1887+ (R 0 0 0 17)
1888+ [ docSymbol "import Data.Maybe" SkModule (R 0 0 0 17)
1889+ ]
1890+ ]
1891+ , testSessionWait "multiple import" $ do
1892+ let source = T.unlines ["", "import Data.Maybe", "", "import Control.Exception", ""]
1893+ docId <- createDoc "A.hs" "haskell" source
1894+ symbols <- getDocumentSymbols docId
1895+ liftIO $ symbols @?= Left
1896+ [docSymbolWithChildren "imports"
1897+ SkModule
1898+ (R 1 0 3 24)
1899+ [ docSymbol "import Data.Maybe" SkModule (R 1 0 1 17)
1900+ , docSymbol "import Control.Exception" SkModule (R 3 0 3 24)
1901+ ]
1902+ ]
15111903 , testSessionWait "foreign import" $ do
15121904 let source = T.unlines
15131905 [ "{-# language ForeignFunctionInterface #-}"
15141906 , "foreign import ccall \"a\" a :: Int"
15151907 ]
1516− docId <- openDoc' "A.hs" "haskell" source
1908+ docId <- createDoc "A.hs" "haskell" source
15171909 symbols <- getDocumentSymbols docId
15181910 liftIO $ symbols @?= Left [docSymbolD "a" "import" SkObject (R 1 0 1 33)]
15191911 , testSessionWait "foreign export" $ do
@@ -1521,7 +1913,7 @@ outlineTests = testGroup
15211913 [ "{-# language ForeignFunctionInterface #-}"
15221914 , "foreign export ccall odd :: Int -> Bool"
15231915 ]
1524− docId <- openDoc' "A.hs" "haskell" source
1916+ docId <- createDoc "A.hs" "haskell" source
15251917 symbols <- getDocumentSymbols docId
15261918 liftIO $ symbols @?= Left [docSymbolD "odd" "export" SkObject (R 1 0 1 39)]
15271919 ]
@@ -1534,6 +1926,8 @@ outlineTests = testGroup
15341926 DocumentSymbol name (Just detail) kind Nothing loc loc Nothing
15351927 docSymbolWithChildren name kind loc cc =
15361928 DocumentSymbol name Nothing kind Nothing loc loc (Just $ List cc)
1929+ docSymbolWithChildren' name kind loc selectionLoc cc =
1930+ DocumentSymbol name Nothing kind Nothing loc selectionLoc (Just $ List cc)
15371931 moduleSymbol name loc cc = DocumentSymbol name
15381932 Nothing
15391933 SkFile
@@ -1555,8 +1949,16 @@ pattern R x y x' y' = Range (Position x y) (Position x' y')
15551949xfail :: TestTree -> String -> TestTree
15561950xfail = flip expectFailBecause
15571951
1952+xfail8101 :: TestTree -> String -> TestTree
1953+#if MIN_GHC_API_VERSION(8,10,0)
1954+xfail8101 = flip expectFailBecause
1955+#else
1956+xfail8101 t _ = t
1957+#endif
1958+
15581959data Expect
15591960 = ExpectRange Range -- Both gotoDef and hover should report this range
1961+ | ExpectLocation Location
15601962-- | ExpectDefRange Range -- Only gotoDef should report this range
15611963 | ExpectHoverRange Range -- Only hover should report this range
15621964 | ExpectHoverText [T.Text] -- the hover message must contain these snippets
@@ -1568,6 +1970,226 @@ data Expect
15681970
15691971mkR :: Int -> Int -> Int -> Int -> Expect
15701972mkR startLine startColumn endLine endColumn = ExpectRange $ mkRange startLine startColumn endLine endColumn
1973+
1974+mkL :: Uri -> Int -> Int -> Int -> Int -> Expect
1975+mkL uri startLine startColumn endLine endColumn = ExpectLocation $ Location uri $ mkRange startLine startColumn endLine endColumn
1976+
1977+haddockTests :: TestTree
1978+haddockTests
1979+ = testGroup "haddock"
1980+ [ testCase "Num" $ checkHaddock
1981+ (unlines
1982+ [ "However, '(+)' and '(*)' are"
1983+ , "customarily expected to define a ring and have the following properties:"
1984+ , ""
1985+ , "[__Associativity of (+)__]: @(x + y) + z@ = @x + (y + z)@"
1986+ , "[__Commutativity of (+)__]: @x + y@ = @y + x@"
1987+ , "[__@fromInteger 0@ is the additive identity__]: @x + fromInteger 0@ = @x@"
1988+ ]
1989+ )
1990+ (unlines
1991+ [ ""
1992+ , ""
1993+ , "However, `(+)` and `(*)` are"
1994+ , "customarily expected to define a ring and have the following properties: "
1995+ , "+ ****Associativity of (+)****: `(x + y) + z` = `x + (y + z)`"
1996+ , "+ ****Commutativity of (+)****: `x + y` = `y + x`"
1997+ , "+ ****`fromInteger 0` is the additive identity****: `x + fromInteger 0` = `x`"
1998+ ]
1999+ )
2000+ , testCase "unsafePerformIO" $ checkHaddock
2001+ (unlines
2002+ [ "may require"
2003+ , "different precautions:"
2004+ , ""
2005+ , " * Use @{\\-\\# NOINLINE foo \\#-\\}@ as a pragma on any function @foo@"
2006+ , " that calls 'unsafePerformIO'. If the call is inlined,"
2007+ , " the I\\/O may be performed more than once."
2008+ , ""
2009+ , " * Use the compiler flag @-fno-cse@ to prevent common sub-expression"
2010+ , " elimination being performed on the module."
2011+ , ""
2012+ ]
2013+ )
2014+ (unlines
2015+ [ ""
2016+ , ""
2017+ , "may require"
2018+ , "different precautions: "
2019+ , "+ Use `{-# NOINLINE foo #-}` as a pragma on any function `foo` "
2020+ , " that calls `unsafePerformIO` . If the call is inlined,"
2021+ , " the I/O may be performed more than once."
2022+ , ""
2023+ , "+ Use the compiler flag `-fno-cse` to prevent common sub-expression"
2024+ , " elimination being performed on the module."
2025+ , ""
2026+ ]
2027+ )
2028+ ]
2029+ where
2030+ checkHaddock s txt = spanDocToMarkdownForTest s @?= txt
2031+
2032+cradleTests :: TestTree
2033+cradleTests = testGroup "cradle"
2034+ [testGroup "dependencies" [sessionDepsArePickedUp]
2035+ ,testGroup "loading" [loadCradleOnlyonce]
2036+ ,testGroup "multi" [simpleMultiTest, simpleMultiTest2]
2037+ ]
2038+
2039+loadCradleOnlyonce :: TestTree
2040+loadCradleOnlyonce = testGroup "load cradle only once"
2041+ [ testSession' "implicit" implicit
2042+ , testSession' "direct" direct
2043+ ]
2044+ where
2045+ direct dir = do
2046+ liftIO $ writeFileUTF8 (dir </> "hie.yaml")
2047+ "cradle: {direct: {arguments: []}}"
2048+ test dir
2049+ implicit dir = test dir
2050+ test _dir = do
2051+ doc <- createDoc "B.hs" "haskell" "module B where\nimport Data.Foo"
2052+ msgs <- someTill (skipManyTill anyMessage cradleLoadedMessage) (skipManyTill anyMessage (message @PublishDiagnosticsNotification))
2053+ liftIO $ length msgs @?= 1
2054+ changeDoc doc [TextDocumentContentChangeEvent Nothing Nothing "module B where\nimport Data.Maybe"]
2055+ msgs <- manyTill (skipManyTill anyMessage cradleLoadedMessage) (skipManyTill anyMessage (message @PublishDiagnosticsNotification))
2056+ liftIO $ length msgs @?= 0
2057+ _ <- createDoc "A.hs" "haskell" "module A where\nimport LoadCradleBar"
2058+ msgs <- manyTill (skipManyTill anyMessage cradleLoadedMessage) (skipManyTill anyMessage (message @PublishDiagnosticsNotification))
2059+ liftIO $ length msgs @?= 0
2060+
2061+
2062+dependentFileTest :: TestTree
2063+dependentFileTest = testGroup "addDependentFile"
2064+ [testGroup "file-changed" [testSession' "test" test]
2065+ ]
2066+ where
2067+ test dir = do
2068+ -- If the file contains B then no type error
2069+ -- otherwise type error
2070+ liftIO $ writeFile (dir </> "dep-file.txt") "A"
2071+ let fooContent = T.unlines
2072+ [ "{-# LANGUAGE TemplateHaskell #-}"
2073+ , "module Foo where"
2074+ , "import Language.Haskell.TH.Syntax"
2075+ , "foo :: Int"
2076+ , "foo = 1 + $(do"
2077+ , " qAddDependentFile \"dep-file.txt\""
2078+ , " f <- qRunIO (readFile \"dep-file.txt\")"
2079+ , " if f == \"B\" then [| 1 |] else lift f)"
2080+ ]
2081+ let bazContent = T.unlines ["module Baz where", "import Foo"]
2082+ _ <-createDoc "Foo.hs" "haskell" fooContent
2083+ doc <- createDoc "Baz.hs" "haskell" bazContent
2084+ expectDiagnostics
2085+ [("Foo.hs", [(DsError, (4, 6), "Couldn't match expected type")])]
2086+ -- Now modify the dependent file
2087+ liftIO $ writeFile (dir </> "dep-file.txt") "B"
2088+ let change = TextDocumentContentChangeEvent
2089+ { _range = Just (Range (Position 2 0) (Position 2 6))
2090+ , _rangeLength = Nothing
2091+ , _text = "f = ()"
2092+ }
2093+ -- Modifying Baz will now trigger Foo to be rebuilt as well
2094+ changeDoc doc [change]
2095+ expectDiagnostics [("Foo.hs", [])]
2096+
2097+
2098+cradleLoadedMessage :: Session FromServerMessage
2099+cradleLoadedMessage = satisfy $ \case
2100+ NotCustomServer (NotificationMessage _ (CustomServerMethod m) _) -> m == cradleLoadedMethod
2101+ _ -> False
2102+
2103+cradleLoadedMethod :: T.Text
2104+cradleLoadedMethod = "ghcide/cradle/loaded"
2105+
2106+-- Stack sets this which trips up cabal in the multi-component tests.
2107+-- However, our plugin tests rely on those env vars so we unset it locally.
2108+withoutStackEnv :: IO a -> IO a
2109+withoutStackEnv s =
2110+ bracket
2111+ (mapM getEnv vars >>= \prevState -> mapM_ unsetEnv vars >> pure prevState)
2112+ (\prevState -> mapM_ (\(var, value) -> restore var value) (zip vars prevState))
2113+ (const s)
2114+ where vars =
2115+ [ "GHC_PACKAGE_PATH"
2116+ , "GHC_ENVIRONMENT"
2117+ , "HASKELL_DIST_DIR"
2118+ , "HASKELL_PACKAGE_SANDBOX"
2119+ , "HASKELL_PACKAGE_SANDBOXES"
2120+ ]
2121+ restore var Nothing = unsetEnv var
2122+ restore var (Just val) = setEnv var val True
2123+
2124+simpleMultiTest :: TestTree
2125+simpleMultiTest = testCase "simple-multi-test" $ withoutStackEnv $ runWithExtraFiles "multi" $ \dir -> do
2126+ let aPath = dir </> "a/A.hs"
2127+ bPath = dir </> "b/B.hs"
2128+ aSource <- liftIO $ readFileUtf8 aPath
2129+ (TextDocumentIdentifier adoc) <- createDoc aPath "haskell" aSource
2130+ expectNoMoreDiagnostics 0.5
2131+ bSource <- liftIO $ readFileUtf8 bPath
2132+ bdoc <- createDoc bPath "haskell" bSource
2133+ expectNoMoreDiagnostics 0.5
2134+ locs <- getDefinitions bdoc (Position 2 7)
2135+ let fooL = mkL adoc 2 0 2 3
2136+ checkDefs locs (pure [fooL])
2137+ expectNoMoreDiagnostics 0.5
2138+
2139+-- Like simpleMultiTest but open the files in the other order
2140+simpleMultiTest2 :: TestTree
2141+simpleMultiTest2 = testCase "simple-multi-test2" $ withoutStackEnv $ runWithExtraFiles "multi" $ \dir -> do
2142+ let aPath = dir </> "a/A.hs"
2143+ bPath = dir </> "b/B.hs"
2144+ bSource <- liftIO $ readFileUtf8 bPath
2145+ bdoc <- createDoc bPath "haskell" bSource
2146+ expectNoMoreDiagnostics 5
2147+ aSource <- liftIO $ readFileUtf8 aPath
2148+ (TextDocumentIdentifier adoc) <- createDoc aPath "haskell" aSource
2149+ -- Need to have some delay here or the test fails
2150+ expectNoMoreDiagnostics 5
2151+ locs <- getDefinitions bdoc (Position 2 7)
2152+ let fooL = mkL adoc 2 0 2 3
2153+ checkDefs locs (pure [fooL])
2154+ expectNoMoreDiagnostics 0.5
2155+
2156+sessionDepsArePickedUp :: TestTree
2157+sessionDepsArePickedUp = testSession'
2158+ "session-deps-are-picked-up"
2159+ $ \dir -> do
2160+ liftIO $
2161+ writeFileUTF8
2162+ (dir </> "hie.yaml")
2163+ "cradle: {direct: {arguments: []}}"
2164+ -- Open without OverloadedStrings and expect an error.
2165+ doc <- createDoc "Foo.hs" "haskell" fooContent
2166+ expectDiagnostics
2167+ [("Foo.hs", [(DsError, (3, 6), "Couldn't match expected type")])]
2168+ -- Update hie.yaml to enable OverloadedStrings.
2169+ liftIO $
2170+ writeFileUTF8
2171+ (dir </> "hie.yaml")
2172+ "cradle: {direct: {arguments: [-XOverloadedStrings]}}"
2173+ -- Send change event.
2174+ let change =
2175+ TextDocumentContentChangeEvent
2176+ { _range = Just (Range (Position 4 0) (Position 4 0)),
2177+ _rangeLength = Nothing,
2178+ _text = "\n"
2179+ }
2180+ changeDoc doc [change]
2181+ -- Now no errors.
2182+ expectDiagnostics [("Foo.hs", [])]
2183+ where
2184+ fooContent =
2185+ T.unlines
2186+ [ "module Foo where",
2187+ "import Data.Text",
2188+ "foo :: Text",
2189+ "foo = \"hello\""
2190+ ]
2191+
2192+
15712193----------------------------------------------------------------------
15722194-- Utils
15732195
@@ -1575,6 +2197,12 @@ mkR startLine startColumn endLine endColumn = ExpectRange $ mkRange startLine st
15752197testSession :: String -> Session () -> TestTree
15762198testSession name = testCase name . run
15772199
2200+testSessionWithExtraFiles :: FilePath -> String -> (FilePath -> Session ()) -> TestTree
2201+testSessionWithExtraFiles prefix name = testCase name . runWithExtraFiles prefix
2202+
2203+testSession' :: String -> (FilePath -> Session ()) -> TestTree
2204+testSession' name = testCase name . run'
2205+
15782206testSessionWait :: String -> Session () -> TestTree
15792207testSessionWait name = testSession name .
15802208 -- Check that any diagnostics produced were already consumed by the test case.
@@ -1585,24 +2213,53 @@ testSessionWait name = testSession name .
15852213 -- Experimentally, 0.5s seems to be long enough to wait for any final diagnostics to appear.
15862214 ( >> expectNoMoreDiagnostics 0.5)
15872215
1588−pickActionWithTitle :: T.Text -> [CAResult] -> CodeAction
1589−pickActionWithTitle title actions = head
1590− [ action
1591− | CACodeAction action@CodeAction{ _title = actionTitle } <- actions
1592− , title == actionTitle ]
2216+pickActionWithTitle :: T.Text -> [CAResult] -> IO CodeAction
2217+pickActionWithTitle title actions = do
2218+ assertBool ("Found no matching actions: " <> show titles) (not $ null matches)
2219+ return $ head matches
2220+ where
2221+ titles =
2222+ [ actionTitle
2223+ | CACodeAction CodeAction { _title = actionTitle } <- actions
2224+ ]
2225+ matches =
2226+ [ action
2227+ | CACodeAction action@CodeAction { _title = actionTitle } <- actions
2228+ , title == actionTitle
2229+ ]
15932230
15942231mkRange :: Int -> Int -> Int -> Int -> Range
15952232mkRange a b c d = Range (Position a b) (Position c d)
15962233
15972234run :: Session a -> IO a
1598−run s = withTempDir $ \dir -> do
2235+run s = withTempDir $ \dir -> runInDir dir s
2236+
2237+runWithExtraFiles :: FilePath -> (FilePath -> Session a) -> IO a
2238+runWithExtraFiles prefix s = withTempDir $ \dir -> do
2239+ copyTestDataFiles dir prefix
2240+ runInDir dir (s dir)
2241+
2242+copyTestDataFiles :: FilePath -> FilePath -> IO ()
2243+copyTestDataFiles dir prefix = do
2244+ -- Copy all the test data files to the temporary workspace
2245+ testDataFiles <- getDirectoryFilesIO ("test/data" </> prefix) ["//*"]
2246+ for_ testDataFiles $ \f -> do
2247+ createDirectoryIfMissing True $ dir </> takeDirectory f
2248+ copyFile ("test/data" </> prefix </> f) (dir </> f)
2249+
2250+run' :: (FilePath -> Session a) -> IO a
2251+run' s = withTempDir $ \dir -> runInDir dir (s dir)
2252+
2253+runInDir :: FilePath -> Session a -> IO a
2254+runInDir dir s = do
15992255 ghcideExe <- locateGhcideExecutable
16002256
16012257 -- Temporarily hack around https://github.com/mpickering/hie-bios/pull/56
16022258 -- since the package import test creates "Data/List.hs", which otherwise has no physical home
16032259 createDirectoryIfMissing True $ dir ++ "/Data"
16042260
1605− let cmd = unwords [ghcideExe, "--lsp", "--cwd", dir]
2261+
2262+ let cmd = unwords [ghcideExe, "--lsp", "--test", "--cwd", dir]
16062263 -- HIE calls getXgdDirectory which assumes that HOME is set.
16072264 -- Only sets HOME if it wasn't already set.
16082265 setEnv "HOME" "/homeless-shelter" False
@@ -1619,7 +2276,7 @@ run s = withTempDir $ \dir -> do
16192276openTestDataDoc :: FilePath -> Session TextDocumentIdentifier
16202277openTestDataDoc path = do
16212278 source <- liftIO $ readFileUtf8 $ "test/data" </> path
1622− openDoc' path "haskell" source
2279+ createDoc path "haskell" source
16232280
16242281findCodeActions :: TextDocumentIdentifier -> Range -> [T.Text] -> Session [CodeAction]
16252282findCodeActions doc range expectedTitles = do
@@ -1634,7 +2291,7 @@ findCodeActions doc range expectedTitles = do
16342291 [ actionTitle
16352292 | CACodeAction CodeAction { _title = actionTitle } <- actions
16362293 ]
1637− ++ "is not a superset of "
2294+ ++ " is not a superset of "
16382295 ++ show expectedTitles
16392296 liftIO $ case matches of
16402297 Nothing -> assertFailure msg
@@ -1647,13 +2304,193 @@ findCodeAction doc range t = head <$> findCodeActions doc range [t]
16472304unitTests :: TestTree
16482305unitTests = do
16492306 testGroup "Unit"
1650− [ testCase "empty file path" $
1651− uriToFilePath' (fromNormalizedUri $ filePathToUri' "") @?= Just ""
2307+ [ testCase "empty file path does NOT work with the empty String literal" $
2308+ uriToFilePath' (fromNormalizedUri $ filePathToUri' "") @?= Just "."
2309+ , testCase "empty file path works using toNormalizedFilePath'" $
2310+ uriToFilePath' (fromNormalizedUri $ filePathToUri' (toNormalizedFilePath' "")) @?= Just ""
2311+ , testCase "empty path URI" $ do
2312+ Just URI{..} <- pure $ parseURI (T.unpack $ getUri $ fromNormalizedUri emptyPathUri)
2313+ uriScheme @?= "file:"
2314+ uriPath @?= ""
2315+ , testCase "from empty path URI" $ do
2316+ let uri = Uri "file://"
2317+ uriToFilePath' uri @?= Just ""
16522318 ]
16532319
1654−-- | Wrapper around 'LSPTest.openDoc'' that sends file creation events
1655−openDoc' :: FilePath -> String -> T.Text -> Session TextDocumentIdentifier
1656−openDoc' fp name contents = do
1657− res@(TextDocumentIdentifier uri) <- LSPTest.openDoc' fp name contents
1658− sendNotification WorkspaceDidChangeWatchedFiles (DidChangeWatchedFilesParams $ List [FileEvent uri FcCreated])
1659− return res
2320+positionMappingTests :: TestTree
2321+positionMappingTests =
2322+ testGroup "position mapping"
2323+ [ testGroup "toCurrent"
2324+ [ testCase "before" $
2325+ toCurrent
2326+ (Range (Position 0 1) (Position 0 3))
2327+ "ab"
2328+ (Position 0 0) @?= Just (Position 0 0)
2329+ , testCase "after, same line, same length" $
2330+ toCurrent
2331+ (Range (Position 0 1) (Position 0 3))
2332+ "ab"
2333+ (Position 0 3) @?= Just (Position 0 3)
2334+ , testCase "after, same line, increased length" $
2335+ toCurrent
2336+ (Range (Position 0 1) (Position 0 3))
2337+ "abc"
2338+ (Position 0 3) @?= Just (Position 0 4)
2339+ , testCase "after, same line, decreased length" $
2340+ toCurrent
2341+ (Range (Position 0 1) (Position 0 3))
2342+ "a"
2343+ (Position 0 3) @?= Just (Position 0 2)
2344+ , testCase "after, next line, no newline" $
2345+ toCurrent
2346+ (Range (Position 0 1) (Position 0 3))
2347+ "abc"
2348+ (Position 1 3) @?= Just (Position 1 3)
2349+ , testCase "after, next line, newline" $
2350+ toCurrent
2351+ (Range (Position 0 1) (Position 0 3))
2352+ "abc\ndef"
2353+ (Position 1 0) @?= Just (Position 2 0)
2354+ , testCase "after, same line, newline" $
2355+ toCurrent
2356+ (Range (Position 0 1) (Position 0 3))
2357+ "abc\nd"
2358+ (Position 0 4) @?= Just (Position 1 2)
2359+ , testCase "after, same line, newline + newline at end" $
2360+ toCurrent
2361+ (Range (Position 0 1) (Position 0 3))
2362+ "abc\nd\n"
2363+ (Position 0 4) @?= Just (Position 2 1)
2364+ , testCase "after, same line, newline + newline at end" $
2365+ toCurrent
2366+ (Range (Position 0 1) (Position 0 1))
2367+ "abc"
2368+ (Position 0 1) @?= Just (Position 0 4)
2369+ ]
2370+ , testGroup "fromCurrent"
2371+ [ testCase "before" $
2372+ fromCurrent
2373+ (Range (Position 0 1) (Position 0 3))
2374+ "ab"
2375+ (Position 0 0) @?= Just (Position 0 0)
2376+ , testCase "after, same line, same length" $
2377+ fromCurrent
2378+ (Range (Position 0 1) (Position 0 3))
2379+ "ab"
2380+ (Position 0 3) @?= Just (Position 0 3)
2381+ , testCase "after, same line, increased length" $
2382+ fromCurrent
2383+ (Range (Position 0 1) (Position 0 3))
2384+ "abc"
2385+ (Position 0 4) @?= Just (Position 0 3)
2386+ , testCase "after, same line, decreased length" $
2387+ fromCurrent
2388+ (Range (Position 0 1) (Position 0 3))
2389+ "a"
2390+ (Position 0 2) @?= Just (Position 0 3)
2391+ , testCase "after, next line, no newline" $
2392+ fromCurrent
2393+ (Range (Position 0 1) (Position 0 3))
2394+ "abc"
2395+ (Position 1 3) @?= Just (Position 1 3)
2396+ , testCase "after, next line, newline" $
2397+ fromCurrent
2398+ (Range (Position 0 1) (Position 0 3))
2399+ "abc\ndef"
2400+ (Position 2 0) @?= Just (Position 1 0)
2401+ , testCase "after, same line, newline" $
2402+ fromCurrent
2403+ (Range (Position 0 1) (Position 0 3))
2404+ "abc\nd"
2405+ (Position 1 2) @?= Just (Position 0 4)
2406+ , testCase "after, same line, newline + newline at end" $
2407+ fromCurrent
2408+ (Range (Position 0 1) (Position 0 3))
2409+ "abc\nd\n"
2410+ (Position 2 1) @?= Just (Position 0 4)
2411+ , testCase "after, same line, newline + newline at end" $
2412+ fromCurrent
2413+ (Range (Position 0 1) (Position 0 1))
2414+ "abc"
2415+ (Position 0 4) @?= Just (Position 0 1)
2416+ ]
2417+ , adjustOption (\(QuickCheckTests i) -> QuickCheckTests (max 1000 i)) $ testGroup "properties"
2418+ [ testProperty "fromCurrent r t <=< toCurrent r t" $ do
2419+ -- Note that it is important to use suchThatMap on all values at once
2420+ -- instead of only using it on the position. Otherwise you can get
2421+ -- into situations where there is no position that can be mapped back
2422+ -- for the edit which will result in QuickCheck looping forever.
2423+ let gen = do
2424+ rope <- genRope
2425+ range <- genRange rope
2426+ PrintableText replacement <- arbitrary
2427+ oldPos <- genPosition rope
2428+ pure (range, replacement, oldPos)
2429+ forAll
2430+ (suchThatMap gen
2431+ (\(range, replacement, oldPos) -> (range, replacement, oldPos,) <$> toCurrent range replacement oldPos)) $
2432+ \(range, replacement, oldPos, newPos) ->
2433+ fromCurrent range replacement newPos === Just oldPos
2434+ , testProperty "toCurrent r t <=< fromCurrent r t" $ do
2435+ let gen = do
2436+ rope <- genRope
2437+ range <- genRange rope
2438+ PrintableText replacement <- arbitrary
2439+ let newRope = applyChange rope (TextDocumentContentChangeEvent (Just range) Nothing replacement)
2440+ newPos <- genPosition newRope
2441+ pure (range, replacement, newPos)
2442+ forAll
2443+ (suchThatMap gen
2444+ (\(range, replacement, newPos) -> (range, replacement, newPos,) <$> fromCurrent range replacement newPos)) $
2445+ \(range, replacement, newPos, oldPos) ->
2446+ toCurrent range replacement oldPos === Just newPos
2447+ ]
2448+ ]
2449+
2450+newtype PrintableText = PrintableText { getPrintableText :: T.Text }
2451+ deriving Show
2452+
2453+instance Arbitrary PrintableText where
2454+ arbitrary = PrintableText . T.pack . getPrintableString <$> arbitrary
2455+
2456+
2457+genRope :: Gen Rope
2458+genRope = Rope.fromText . getPrintableText <$> arbitrary
2459+
2460+genPosition :: Rope -> Gen Position
2461+genPosition r = do
2462+ row <- choose (0, max 0 $ rows - 1)
2463+ let columns = Rope.columns (nthLine row r)
2464+ column <- choose (0, max 0 $ columns - 1)
2465+ pure $ Position row column
2466+ where rows = Rope.rows r
2467+
2468+genRange :: Rope -> Gen Range
2469+genRange r = do
2470+ startPos@(Position startLine startColumn) <- genPosition r
2471+ let maxLineDiff = max 0 $ rows - 1 - startLine
2472+ endLine <- choose (startLine, startLine + maxLineDiff)
2473+ let columns = Rope.columns (nthLine endLine r)
2474+ endColumn <-
2475+ if startLine == endLine
2476+ then choose (startColumn, columns)
2477+ else choose (0, max 0 $ columns - 1)
2478+ pure $ Range startPos (Position endLine endColumn)
2479+ where rows = Rope.rows r
2480+
2481+-- | Get the ith line of a rope, starting from 0. Trailing newline not included.
2482+nthLine :: Int -> Rope -> Rope
2483+nthLine i r
2484+ | i < 0 = error $ "Negative line number: " <> show i
2485+ | i == 0 && Rope.rows r == 0 = r
2486+ | i >= Rope.rows r = error $ "Row number out of bounds: " <> show i <> "/" <> show (Rope.rows r)
2487+ | otherwise = Rope.takeWhile (/= '\n') $ fst $ Rope.splitAtLine 1 $ snd $ Rope.splitAtLine (i - 1) r
2488+
2489+getWatchedFilesSubscriptionsUntil :: forall end . (FromJSON end, Typeable end) => Session [Maybe Value]
2490+getWatchedFilesSubscriptionsUntil = do
2491+ msgs <- manyTill (Just <$> message @RegisterCapabilityRequest <|> Nothing <$ anyMessage) (message @end)
2492+ return
2493+ [ args
2494+ | Just RequestMessage{_params = RegistrationParams (List regs)} <- msgs
2495+ , Registration _id WorkspaceDidChangeWatchedFiles args <- regs
2496+ ]