diff --git a/apps/desktop/src/lib/pr/PrDetailsModal.svelte b/apps/desktop/src/lib/pr/PrDetailsModal.svelte index e302e1e95..0c2adf32a 100644 --- a/apps/desktop/src/lib/pr/PrDetailsModal.svelte +++ b/apps/desktop/src/lib/pr/PrDetailsModal.svelte @@ -20,7 +20,6 @@ import { getGitHostPrService } from '$lib/gitHost/interface/gitHostPrService'; import { showError, showToast } from '$lib/notifications/toasts'; import { isFailure } from '$lib/result'; - import ScrollableContainer from '$lib/scroll/ScrollableContainer.svelte'; import BorderlessTextarea from '$lib/shared/BorderlessTextarea.svelte'; import Toggle from '$lib/shared/Toggle.svelte'; import { User } from '$lib/stores/user'; @@ -290,6 +289,18 @@ } } + function showBorderOnScroll(e: Event) { + const target = e.target as HTMLElement; + const scrollPosition = target.scrollTop; + const top = scrollPosition < 5; + + if (top) { + target.style.borderTop = 'none'; + } else { + target.style.borderTop = '1px solid var(--clr-border-3)'; + } + } + function onClose() { isEditing = true; inputTitle = undefined; @@ -342,77 +353,77 @@ {/if} - {#if isPreviewOnly || !isEditing} -
- -
- {:else} - { - inputBody = e.currentTarget.value; - }} - /> - {/if} +
+ {#if isPreviewOnly || !isEditing} +
+ +
+ {:else} + { + inputBody = e.currentTarget.value; + }} + /> + {/if} - - {#if !isPreviewOnly && canUseAI && isEditing} -
- {#if showAiBox} - { - aiDescriptionDirective = e.currentTarget.value; - }} - /> -
- - -
- {:else} -
- -
- {/if} -
- {/if} + /> +
+ + +
+ {:else} +
+ +
+ {/if} +
+ {/if} + @@ -435,9 +446,6 @@ onclick={async () => await handleCreatePR(close)} >{isDraft ? 'Create draft pull request' : 'Create pull request'} - {/snippet} @@ -447,12 +455,18 @@ .pr-content { display: flex; flex-direction: column; + /* max-height: 66vh; */ + } + + .pr-fields { + overflow-y: auto; + max-height: 66vh; } .pr-header { display: flex; gap: 16px; - padding: 16px 16px 0 20px; + padding: 16px 16px 12px 20px; } .pr-title { @@ -464,7 +478,6 @@ overflow-y: auto; display: flex; padding: 16px 16px 16px 20px; - max-height: 66vh; } /* AI BOX */ @@ -481,7 +494,7 @@ .pr-ai__actions { display: flex; gap: 6px; - padding: 0 20px 16px; + padding: 12px 20px 16px; } /* FOOTER */ diff --git a/apps/desktop/src/lib/shared/BorderlessTextarea.svelte b/apps/desktop/src/lib/shared/BorderlessTextarea.svelte index 55e9d5b5d..2c8d33e54 100644 --- a/apps/desktop/src/lib/shared/BorderlessTextarea.svelte +++ b/apps/desktop/src/lib/shared/BorderlessTextarea.svelte @@ -80,6 +80,7 @@ color: var(--clr-text-1); overflow-y: auto; /* Enable scrolling when max height is reached */ background-color: transparent; + /* background-color: rgba(0, 0, 0, 0.1); */ } /* placeholder */ diff --git a/packages/ui/src/styles/sharable/markdown.css b/packages/ui/src/styles/sharable/markdown.css index dedcbaa44..1b1f3e638 100644 --- a/packages/ui/src/styles/sharable/markdown.css +++ b/packages/ui/src/styles/sharable/markdown.css @@ -1,4 +1,8 @@ @layer sharable { + .markdown { + user-select: text; + } + .markdown p:last-child, .markdown ul:last-child, .markdown ol:last-child,