From 0754c441280aeca49a03571760d7196847a23206 Mon Sep 17 00:00:00 2001
From: Mattias Granlund <mtsgrd@gmail.com>
Date: Mon, 31 Jul 2023 14:05:39 +0200
Subject: [PATCH] Fix frontend lint errors

---
 .eslintignore                                         |  3 ++-
 .prettierignore                                       |  1 +
 src/lib/components/CommandPalette/commands.ts         |  1 -
 src/lib/components/Differ/Differ.svelte               |  2 +-
 src/lib/components/Overlay/Overlay.svelte             |  1 -
 src/lib/components/PopupMenu/PopupMenu.svelte         |  2 +-
 src/lib/components/Scrollbar.svelte                   |  8 ++++----
 src/routes/+layout.svelte                             |  8 +-------
 src/routes/+page.svelte                               |  2 +-
 src/routes/Breadcrumbs.svelte                         |  1 -
 src/routes/projects/[projectId]/+layout.svelte        | 10 ++--------
 src/routes/repo/[projectId]/BottomPanel.svelte        |  2 +-
 src/routes/repo/[projectId]/BranchLane.svelte         |  4 +++-
 src/routes/repo/[projectId]/FileCardNext.svelte       |  1 -
 src/routes/repo/[projectId]/Tray.svelte               |  2 +-
 src/routes/repo/[projectId]/UpstreamBranchLane.svelte | 10 ++++------
 16 files changed, 22 insertions(+), 36 deletions(-)

diff --git a/.eslintignore b/.eslintignore
index 130161871..58696a4ce 100644
--- a/.eslintignore
+++ b/.eslintignore
@@ -1,5 +1,6 @@
 .DS_Store
 node_modules
+butler/target
 /build
 /.svelte-kit
 /package
@@ -23,4 +24,4 @@ yarn.lock
 /histoire.setup.ts
 /histoire.config.ts
 /postcss.config.cjs
-/tailwind.config.cjs
\ No newline at end of file
+/tailwind.config.cjs
diff --git a/.prettierignore b/.prettierignore
index 19f26d03a..b2f52da98 100644
--- a/.prettierignore
+++ b/.prettierignore
@@ -1,5 +1,6 @@
 .DS_Store
 node_modules
+butler/target
 /build
 /.svelte-kit
 /package
diff --git a/src/lib/components/CommandPalette/commands.ts b/src/lib/components/CommandPalette/commands.ts
index 42616ad21..e14464cb0 100644
--- a/src/lib/components/CommandPalette/commands.ts
+++ b/src/lib/components/CommandPalette/commands.ts
@@ -6,7 +6,6 @@ import {
 	IconFeedback,
 	IconTerminal,
 	IconSettings,
-	IconAdjustmentsHorizontal,
 	IconDiscord,
 	IconSearch,
 	IconRewind,
diff --git a/src/lib/components/Differ/Differ.svelte b/src/lib/components/Differ/Differ.svelte
index 0143e05fb..6e4a91df0 100644
--- a/src/lib/components/Differ/Differ.svelte
+++ b/src/lib/components/Differ/Differ.svelte
@@ -120,7 +120,7 @@
 
 	$: renderedRows = diffRows.rows.map((row) => ({ ...row, render: renderRowContent(row) }));
 
-	type RenderedRow = (typeof renderedRows)[0];
+	type RenderedRow = typeof renderedRows[0];
 
 	const padHighlighted = (rows: RenderedRow[]): RenderedRow[] => {
 		const chunks: (RenderedRow[] | RenderedRow)[] = [];
diff --git a/src/lib/components/Overlay/Overlay.svelte b/src/lib/components/Overlay/Overlay.svelte
index e22f84dbf..3adfa354f 100644
--- a/src/lib/components/Overlay/Overlay.svelte
+++ b/src/lib/components/Overlay/Overlay.svelte
@@ -1,5 +1,4 @@
 <script lang="ts">
-	import { scale } from 'svelte/transition';
 	import OutClick from 'svelte-outclick';
 
 	let dialog: HTMLDialogElement;
diff --git a/src/lib/components/PopupMenu/PopupMenu.svelte b/src/lib/components/PopupMenu/PopupMenu.svelte
index 7429e46ad..3d9910556 100644
--- a/src/lib/components/PopupMenu/PopupMenu.svelte
+++ b/src/lib/components/PopupMenu/PopupMenu.svelte
@@ -5,7 +5,7 @@
 	let showMenu = false;
 	let item: any;
 
-	function onDismiss(e: MouseEvent | KeyboardEvent | FocusEvent) {
+	function onDismiss() {
 		showMenu = false;
 	}
 
diff --git a/src/lib/components/Scrollbar.svelte b/src/lib/components/Scrollbar.svelte
index 89ca81aec..5438ab0ad 100644
--- a/src/lib/components/Scrollbar.svelte
+++ b/src/lib/components/Scrollbar.svelte
@@ -1,5 +1,5 @@
 <script lang="ts">
-	import { onDestroy, onMount } from 'svelte';
+	import { onDestroy } from 'svelte';
 
 	export let viewport: Element;
 	export let contents: Element;
@@ -7,8 +7,8 @@
 	export let alwaysVisible = false;
 	export let initiallyVisible = false;
 	export let margin: { top?: number; right?: number; bottom?: number; left?: number } = {};
-	export let opacity: string = '0.2';
-	export let width: string = '0.625rem';
+	export let opacity = '0.2';
+	export let width = '0.625rem';
 
 	let thumb: Element;
 	let track: Element;
@@ -68,7 +68,7 @@
 		track.addEventListener('mouseenter', onTrackEnter);
 		track.addEventListener('mouseleave', onTrackLeave);
 		return () => {
-			track.removeEventListener('mousedown', onThumbClick);
+			track.removeEventListener('mousedown', onTrackClick);
 			track.removeEventListener('mouseenter', onTrackEnter);
 			track.removeEventListener('mouseleave', onTrackLeave);
 		};
diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte
index 47c4d2826..6bbe68c5c 100644
--- a/src/routes/+layout.svelte
+++ b/src/routes/+layout.svelte
@@ -4,10 +4,8 @@
 	import { open } from '@tauri-apps/api/dialog';
 	import { toasts, Toaster, events, hotkeys, stores } from '$lib';
 	import type { LayoutData } from './$types';
-	import { Button, Link, Tooltip } from '$lib/components';
+	import { Link, Tooltip } from '$lib/components';
 	import { IconEmail } from '$lib/icons';
-	import type { Project } from '$lib/api';
-	import { PUBLIC_API_BASE_URL } from '$env/static/public';
 	import { page } from '$app/stores';
 	import { derived } from '@square/svelte-store';
 	import { onMount, setContext } from 'svelte';
@@ -16,7 +14,6 @@
 	import LinkProjectModal from './LinkProjectModal.svelte';
 	import Breadcrumbs from './Breadcrumbs.svelte';
 	import ShareIssueModal from './ShareIssueModal.svelte';
-	import ThemeSelector from './ThemeSelector.svelte';
 	import { SETTINGS_CONTEXT, loadUserSettings } from '$lib/userSettings';
 	import { initTheme } from '$lib/theme';
 
@@ -40,9 +37,6 @@
 	$: document.documentElement.style.fontSize = zoom + 'rem';
 	$: userSettings.update((s) => ({ ...s, zoom: zoom }));
 
-	const projectUrl = (project: Project) =>
-		new URL(`/projects/${project.id}`, new URL(PUBLIC_API_BASE_URL)).toString();
-
 	onMount(() =>
 		unsubscribe(
 			events.on('openNewProjectModal', () =>
diff --git a/src/routes/+page.svelte b/src/routes/+page.svelte
index 1bf5387b3..78098d3e5 100644
--- a/src/routes/+page.svelte
+++ b/src/routes/+page.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import type { LayoutData } from './$types';
-	import { Button, Tooltip } from '$lib/components';
+	import { Button } from '$lib/components';
 	import { events } from '$lib';
 
 	export let data: LayoutData;
diff --git a/src/routes/Breadcrumbs.svelte b/src/routes/Breadcrumbs.svelte
index 4a34ca949..da931eb9f 100644
--- a/src/routes/Breadcrumbs.svelte
+++ b/src/routes/Breadcrumbs.svelte
@@ -1,7 +1,6 @@
 <script lang="ts">
 	import type { Project } from '$lib/api';
 	import { IconHome } from '$lib/icons';
-	import { Button } from '$lib/components';
 	import { goto } from '$app/navigation';
 
 	export let project: Project | undefined;
diff --git a/src/routes/projects/[projectId]/+layout.svelte b/src/routes/projects/[projectId]/+layout.svelte
index 9f607919b..bc8c23be2 100644
--- a/src/routes/projects/[projectId]/+layout.svelte
+++ b/src/routes/projects/[projectId]/+layout.svelte
@@ -1,12 +1,9 @@
 <script lang="ts">
 	import type { LayoutData } from './$types';
-	import type { Project } from '$lib/api';
-	import { Button, Link, Tooltip } from '$lib/components';
+	import { Button, Tooltip } from '$lib/components';
 	import { page } from '$app/stores';
 	import { goto } from '$app/navigation';
-	import { IconEmail, IconRewind, IconSearch, IconSettings, IconTerminal } from '$lib/icons';
-	import { PUBLIC_API_BASE_URL } from '$env/static/public';
-	import { events } from '$lib';
+	import { IconRewind, IconSearch, IconSettings, IconTerminal } from '$lib/icons';
 
 	export let data: LayoutData;
 	const { project } = data;
@@ -16,9 +13,6 @@
 	const onSearchSubmit = () =>
 		goto(`/projects/${$project?.id}/search?q=${encodeURIComponent(query)}`);
 
-	const projectUrl = (project: Project) =>
-		new URL(`/projects/${project.id}`, new URL(PUBLIC_API_BASE_URL)).toString();
-
 	$: selection = $page?.route?.id?.split('/')?.[3];
 </script>
 
diff --git a/src/routes/repo/[projectId]/BottomPanel.svelte b/src/routes/repo/[projectId]/BottomPanel.svelte
index e53c75045..717f1fb0f 100644
--- a/src/routes/repo/[projectId]/BottomPanel.svelte
+++ b/src/routes/repo/[projectId]/BottomPanel.svelte
@@ -1,7 +1,7 @@
 <script lang="ts">
 	import { slide } from 'svelte/transition';
 	import { IconTriangleUp, IconTriangleDown } from '$lib/icons';
-	import type { BaseBranch, Commit } from '$lib/vbranches';
+	import type { BaseBranch } from '$lib/vbranches';
 	import { formatDistanceToNow } from 'date-fns';
 	import type { SettingsStore } from '$lib/userSettings';
 
diff --git a/src/routes/repo/[projectId]/BranchLane.svelte b/src/routes/repo/[projectId]/BranchLane.svelte
index cea81d536..6ee0c2e1f 100644
--- a/src/routes/repo/[projectId]/BranchLane.svelte
+++ b/src/routes/repo/[projectId]/BranchLane.svelte
@@ -332,7 +332,9 @@
 				</div>
 			{/if}
 		</div>
-		<div class="w-3 shrink-0 border-l border-r border-light-400 bg-light-300 dark:bg-dark-500 dark:border-dark-600" />
+		<div
+			class="w-3 shrink-0 border-l border-r border-light-400 bg-light-300 dark:border-dark-600 dark:bg-dark-500"
+		/>
 	</div>
 
 	<div class="relative flex flex-grow overflow-y-hidden">
diff --git a/src/routes/repo/[projectId]/FileCardNext.svelte b/src/routes/repo/[projectId]/FileCardNext.svelte
index ee90205ae..7bc28bd71 100644
--- a/src/routes/repo/[projectId]/FileCardNext.svelte
+++ b/src/routes/repo/[projectId]/FileCardNext.svelte
@@ -22,7 +22,6 @@
 	import { slide } from 'svelte/transition';
 	import { SETTINGS_CONTEXT, type SettingsStore } from '$lib/userSettings';
 	import { summarizeHunk } from '$lib/summaries';
-	import { Button } from '$lib/components';
 
 	export let file: File;
 	export let conflicted: boolean;
diff --git a/src/routes/repo/[projectId]/Tray.svelte b/src/routes/repo/[projectId]/Tray.svelte
index 970b8d52b..69bb9c5a3 100644
--- a/src/routes/repo/[projectId]/Tray.svelte
+++ b/src/routes/repo/[projectId]/Tray.svelte
@@ -1,6 +1,6 @@
 <script lang="ts">
 	import { Button, Checkbox, Modal } from '$lib/components';
-	import type { Branch, BranchData, Hunk } from '$lib/vbranches';
+	import type { Branch, BranchData } from '$lib/vbranches';
 	import { formatDistanceToNow } from 'date-fns';
 	import { IconGitBranch, IconRemote } from '$lib/icons';
 	import { IconTriangleDown, IconTriangleUp } from '$lib/icons';
diff --git a/src/routes/repo/[projectId]/UpstreamBranchLane.svelte b/src/routes/repo/[projectId]/UpstreamBranchLane.svelte
index 08253ee25..e3538d40d 100644
--- a/src/routes/repo/[projectId]/UpstreamBranchLane.svelte
+++ b/src/routes/repo/[projectId]/UpstreamBranchLane.svelte
@@ -14,14 +14,12 @@
 	let viewport: Element;
 	let contents: Element;
 
+	let fetching = false;
+	let buttonHovered = false;
+
 	const branchController = getContext<BranchController>(BRANCH_CONTROLLER_KEY);
 
-	// $: behind = baseBranch.behind > 0;
-	$: behindMessage = base.behind > 0 ? `behind ${base.behind}` : 'up-to-date';
-
-	let fetching = false;
 	$: expanded = base.behind > 0;
-	let buttonHovered = false;
 </script>
 
 <div
@@ -71,7 +69,7 @@
 		</div>
 		{#if expanded}
 			<div
-				class="h-full w-3 shrink-0 border-l border-r border-light-400 bg-light-300 dark:bg-dark-500 dark:border-dark-600"
+				class="h-full w-3 shrink-0 border-l border-r border-light-400 bg-light-300 dark:border-dark-600 dark:bg-dark-500"
 			/>
 		{/if}
 	</div>