Fix app updater error analytics

Error payload must be an object, otherwise it gets converted to an array of characters.
This commit is contained in:
Mattias Granlund 2024-02-29 10:47:05 +01:00
parent 0cbea7fa7c
commit 8ba697482e

View File

@ -46,7 +46,10 @@ export class UpdaterService {
constructor() { constructor() {
onUpdaterEvent((status) => { onUpdaterEvent((status) => {
const err = status.error; const err = status.error;
if (err) showErrorToast(err); if (err) {
showErrorToast(err);
posthog.capture('App Update Status Error', { error: err });
}
this.status$.next(status.status); this.status$.next(status.status);
}).then((unlistenFn) => (this.unlistenFn = unlistenFn)); }).then((unlistenFn) => (this.unlistenFn = unlistenFn));
@ -65,7 +68,7 @@ export class UpdaterService {
// Hide offline/timeout errors since no app ever notifies you about this // Hide offline/timeout errors since no app ever notifies you about this
catchError((err) => { catchError((err) => {
if (!isOffline(err) && !isTimeoutError(err)) { if (!isOffline(err) && !isTimeoutError(err)) {
posthog.capture('Updater Check Error', err); posthog.capture('App Update Check Error', { error: err });
showErrorToast(err); showErrorToast(err);
console.log(err); console.log(err);
} }
@ -91,9 +94,9 @@ export class UpdaterService {
try { try {
await installUpdate(); await installUpdate();
posthog.capture('App Update Successful'); posthog.capture('App Update Successful');
} catch (e: any) { } catch (err: any) {
// We expect toast to be shown by error handling in `onUpdaterEvent` // We expect toast to be shown by error handling in `onUpdaterEvent`
posthog.capture('App Update Failed', e); posthog.capture('App Update Install Error', { error: err });
} }
} }
@ -126,5 +129,4 @@ function showErrorToast(err: any) {
`, `,
style: 'error' style: 'error'
}); });
posthog.capture('Updater Status Error', err);
} }