gitbutlerapp/gitbutler
1
1
Fork 0
mirror of https://github.com/gitbutlerapp/gitbutler.git synced 2024-12-19 15:41:31 +03:00
Code Issues Packages Projects Releases Wiki Activity

Ensure set isn't called after initial load

Browse Source
This commit is contained in:
Caleb Owens 2024-03-11 19:39:54 +00:00 committed by Mattias Granlund
parent 5ece49ad41
commit 8fee75762d
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
gitbutler-ui/src/lib/backend/gitConfig.ts
View File

@ -13,15 +13,18 @@ export class GitConfig {
buildWritable<T extends string>(key: string): Writable<T | undefined> {
const subject = writable<T | undefined>();
let initialized = false;
this.gitGetConfig<T>(key).then((value) => {
subject.set(value || undefined);
// Ensure we don't set the value we just read from the config by registering after
subject.subscribe((recievedValue) => {
if (recievedValue) {
this.gitSetConfig<T>(key, recievedValue);
}
});
initialized = true;
});
subject.subscribe((recievedValue) => {
if (initialized && recievedValue) {
this.gitSetConfig<T>(key, recievedValue);
}
});
return subject;
@ -30,11 +33,18 @@ export class GitConfig {
buildWritableWithDefault<T extends string>(key: string, defaultValue: T): Writable<T> {
const subject = writable<T>(defaultValue);
let initialized = false;
this.gitGetConfig<T>(key).then((value) => {
subject.set(value || defaultValue);
// Ensure we don't set the value we just read from the config by registering after
subject.subscribe((recievedValue) => this.gitSetConfig<T>(key, recievedValue));
initialized = true;
});
subject.subscribe((recievedValue) => {
if (initialized) {
this.gitSetConfig<T>(key, recievedValue);
}
});
return subject;