gitbutlerapp/gitbutler
1
1
Fork 0
mirror of https://github.com/gitbutlerapp/gitbutler.git synced 2024-12-19 07:32:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Code review fixes

Browse Source 
- Removed unused import
- Removed commited `console.log)
- Updated logic to correctly handle splitting summary and description
- Updated text styling for commit message textarea
This commit is contained in:
Pavel Laptev 2024-03-13 15:13:21 +01:00 committed by GitButler
parent 4ce119758e
commit 9148df8ac7
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gitbutler-ui/src/lib/components/CommitDialog.svelte
View File

@ -22,7 +22,6 @@
import { invoke } from '@tauri-apps/api/tauri';
import { createEventDispatcher } from 'svelte';
import { quintOut } from 'svelte/easing';
import { get } from 'svelte/store';
import { fly, slide } from 'svelte/transition';
import type { User, getCloudApiClient } from '$lib/backend/cloud';
import type { BranchController } from '$lib/vbranches/branchController';
@ -49,11 +48,11 @@
function getCommitMessageTitleAndDescription(commitMessage: string) {
// Split the commit message into title and description
// get the first line as title and the rest as description
const [summary, ...description] = commitMessage.split('\n');
const [summary, ...description] = commitMessage.trim().split(/\n+(.*)/s);
console.log('summary and description', summary, description);
return {
summary: summary || '',
// remove top new line
description: description.join('\n').replace(/^\n/, '') || ''
description: description[0] || ''
};
}
@ -61,7 +60,7 @@
return `${message.summary}\n${message.description}`;
}
let commitMessageSet = getCommitMessageTitleAndDescription(get(currentCommitMessage));
let commitMessageSet = getCommitMessageTitleAndDescription($currentCommitMessage);
let isCommitting = false;
let summaryTextareaElement: HTMLTextAreaElement;
@ -75,8 +74,7 @@
if (el) el.focus();
}
function commit() {
// console.log('commitMessage', commitMessage);
async function commit() {
if (!commitMessageSet.summary) return;
isCommitting = true;
branchController
@ -199,7 +197,7 @@
}
}}
spellcheck={false}
class="text-base-body-14 commit-box__textarea commit-box__textarea__title"
class="text-base-body-13 text-semibold commit-box__textarea commit-box__textarea__title"
class:commit-box__textarea_bottom-padding={commitMessageSet.description.length == 0 &&
commitMessageSet.summary.length == 0}
rows="1"