From 8e4ed63a0756afd9e968f1816e1e8d5764834d6d Mon Sep 17 00:00:00 2001 From: Josh Junon Date: Tue, 9 Apr 2024 14:50:31 +0200 Subject: [PATCH] Revert "Remove unused (?) allow clippy statements" This reverts commit 7ee778a0ebae6123f638008cc77391a8026ab8f2. --- crates/gitbutler-changeset/src/signature.rs | 1 + crates/gitbutler-core/src/lib.rs | 8 ++++++++ crates/gitbutler-core/src/zip/controller.rs | 1 + crates/gitbutler-tauri/src/lib.rs | 8 ++++++++ crates/gitbutler-tauri/src/main.rs | 8 ++++++++ crates/gitbutler-tauri/src/zip.rs | 1 + 6 files changed, 27 insertions(+) diff --git a/crates/gitbutler-changeset/src/signature.rs b/crates/gitbutler-changeset/src/signature.rs index b3ef41d74..77744d92b 100644 --- a/crates/gitbutler-changeset/src/signature.rs +++ b/crates/gitbutler-changeset/src/signature.rs @@ -109,6 +109,7 @@ impl Signature { } } + #[allow(clippy::cast_precision_loss)] { (2 * matching_bigrams) as f64 / (original_length as usize + other.len() - 2) as f64 } diff --git a/crates/gitbutler-core/src/lib.rs b/crates/gitbutler-core/src/lib.rs index 216917ba2..675c84f92 100644 --- a/crates/gitbutler-core/src/lib.rs +++ b/crates/gitbutler-core/src/lib.rs @@ -4,6 +4,14 @@ all(windows, not(test), not(debug_assertions)), windows_subsystem = "windows" )] +// FIXME(qix-): Stuff we want to fix but don't have a lot of time for. +// FIXME(qix-): PRs welcome! +#![allow( + clippy::used_underscore_binding, + clippy::module_name_repetitions, + clippy::struct_field_names, + clippy::too_many_lines +)] pub mod askpass; pub mod assets; diff --git a/crates/gitbutler-core/src/zip/controller.rs b/crates/gitbutler-core/src/zip/controller.rs index 83ab3ecc8..790c27565 100644 --- a/crates/gitbutler-core/src/zip/controller.rs +++ b/crates/gitbutler-core/src/zip/controller.rs @@ -9,6 +9,7 @@ pub struct Controller { local_data_dir: path::PathBuf, logs_dir: path::PathBuf, zipper: Zipper, + #[allow(clippy::struct_field_names)] projects_controller: projects::Controller, } diff --git a/crates/gitbutler-tauri/src/lib.rs b/crates/gitbutler-tauri/src/lib.rs index 719cb38f7..77c35a4ca 100644 --- a/crates/gitbutler-tauri/src/lib.rs +++ b/crates/gitbutler-tauri/src/lib.rs @@ -4,6 +4,14 @@ all(windows, not(test), not(debug_assertions)), windows_subsystem = "windows" )] +// FIXME(qix-): Stuff we want to fix but don't have a lot of time for. +// FIXME(qix-): PRs welcome! +#![allow( + clippy::used_underscore_binding, + clippy::module_name_repetitions, + clippy::struct_field_names, + clippy::too_many_lines +)] pub mod analytics; pub mod app; diff --git a/crates/gitbutler-tauri/src/main.rs b/crates/gitbutler-tauri/src/main.rs index 683f19443..ae7bd83d7 100644 --- a/crates/gitbutler-tauri/src/main.rs +++ b/crates/gitbutler-tauri/src/main.rs @@ -4,6 +4,14 @@ all(windows, not(test), not(debug_assertions)), windows_subsystem = "windows" )] +// FIXME(qix-): Stuff we want to fix but don't have a lot of time for. +// FIXME(qix-): PRs welcome! +#![allow( + clippy::used_underscore_binding, + clippy::module_name_repetitions, + clippy::struct_field_names, + clippy::too_many_lines +)] use std::path::PathBuf; diff --git a/crates/gitbutler-tauri/src/zip.rs b/crates/gitbutler-tauri/src/zip.rs index 3c5f02eb3..81dd0f20f 100644 --- a/crates/gitbutler-tauri/src/zip.rs +++ b/crates/gitbutler-tauri/src/zip.rs @@ -1,4 +1,5 @@ pub mod commands { + #![allow(clippy::used_underscore_binding)] use anyhow::Context; use std::path;