gitbutlerapp/gitbutler
1
1
Fork 0
mirror of https://github.com/gitbutlerapp/gitbutler.git synced 2024-11-23 20:54:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix: State update for the PR modal

Browse Source 
The PR modals title would only be correctly updated on blur, because it was using the 'onchange' listener.
Using the 'oninput' listener fixed that.
Also: 
Only fetch the pull-request body if the modal is open
This commit is contained in:
estib 2024-10-14 10:52:52 +02:00
parent 49a88430a2
commit e65fd1c947
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/desktop/src/lib/pr/PrDetailsModal.svelte
View File

@ -129,7 +129,12 @@
// Fetch PR template content
$effect(() => {
if ($prService && pullRequestTemplateBody === undefined && prTemplatePath) {
if (
modal?.imports.open &&
$prService &&
pullRequestTemplateBody === undefined &&
prTemplatePath
) {
$prService.pullRequestTemplateContent(prTemplatePath, project.id).then((template) => {
pullRequestTemplateBody = template;
});
@ -358,7 +363,7 @@
placeholder="PR title"
value={actualTitle}
readonly={!isEditing || isPreviewOnly}
on:change={(e) => {
on:input={(e) => {
inputTitle = e.detail;
}}
/>