Commit Graph

9039 Commits

Author SHA1 Message Date
ndom91
8efe6c7a71 fix: cleanup createPr arguments and types 2024-09-09 14:02:59 +02:00
estib
8c22b6c0d1 Update Ownership class
Rename the `Ownership` class to `SelectedOwnership`, as it is only used to determine the selected state of the files to add to a commit.

Renamed the methods as well to convey their actual purpose.

The `SelectedOwnership` class will be updated in a way that the selected is persisted across file/hunk ownership updates
2024-09-09 13:53:57 +02:00
ndom91
8986dc3e12 fix: refactor template inputs to being passed to 'createPr' fn 2024-09-09 13:49:46 +02:00
Kiril Videlov
33c4447fd8
Merge pull request #4856 from gitbutlerapp/update-clone-form-validation
remove incorrect placeholder
2024-09-09 13:39:49 +02:00
Kiril Videlov
db2f33a2ef
remove incorrect placeholder 2024-09-09 13:12:18 +02:00
estib
7bb3c7c9cf BranchFilesList: Clean-up and prefer Svelte 5 APIs
Refactor and clean-up the component, so that the newer, more readable Svelte 5 state APIs are used
2024-09-09 12:00:34 +02:00
estib
660c555cd9 Move chunk to array utilities
Deduplicate and move the chunk utility into the array utilities module
2024-09-09 11:56:03 +02:00
Sebastian Thiel
ee083deada
Merge pull request #4849 from Byron/nicer-clone
refactor clone for clarity
2024-09-09 06:56:31 +02:00
ndom91
c5ede5ce79 fix: use correct relative path when sending to GH 2024-09-08 18:49:35 +02:00
ndom91
d7badd82a5 fix: enable saving git_host settings to projects.json 2024-09-08 18:34:45 +02:00
ndom91
32f13df06d fix: handle old projects which dont have git_host project settings key 2024-09-08 18:23:05 +02:00
ndom91
b43e9312cb fix: sync selected values with GitHost preferences form 2024-09-08 18:19:23 +02:00
ndom91
460e19299a fix: refactor out use of Persisted store values for pr template boolean and path 2024-09-08 18:11:39 +02:00
ndom91
6b55fa56ba fix: simplify getAvailablePullRequestTemplate args 2024-09-08 18:11:03 +02:00
ndom91
216f5b40f3 fix: update Select to use correct label and value in dropdown 2024-09-08 17:42:36 +02:00
ndom91
3c812cb963 fix: move getAvailableTemplates functionality from project service to github service 2024-09-08 17:42:08 +02:00
ndom91
ac420780e0 fix: walk .github recursively 2024-09-08 17:11:54 +02:00
ndom91
a02d80807d fix: rm textinput in GitHostForm 2024-09-08 16:48:30 +02:00
Nico Domino
888181326a Discard changes to package.json 2024-09-08 16:39:40 +02:00
ndom91
6396bfea45 fix: cleanup 2024-09-08 16:39:19 +02:00
ndom91
bbe9249a01 fix: git paths 2024-09-08 16:34:58 +02:00
ndom91
e2bb456f7d feat: initial template dropdown support 2024-09-08 16:16:09 +02:00
estib
0a6493087b FileListItem: Track whether all or some hunks have been selected
If only some of the hunks have been selected, display the file checkbox as indeterminate
2024-09-08 12:21:49 +02:00
estib
d7c8c78100 Utils: Check for array items compliance
Create a module for array utilities.
Add a function that determines what amount of items in an array satisfy a condition
2024-09-08 12:18:56 +02:00
estib
d3c1ed8ed4 Style: Checkbox indeterminate state
Make it so that the indeterminate state of the checkbox matches the selected style
2024-09-08 12:16:56 +02:00
Esteban Vega
d1462f1ea5
UI: Info Button component (#4829)
* UI: Info Button component

Info button that displays a custom component on hover.

* Extend tooltip

Optionally, toggle the tooltip on click.
If enabled, clicking outside will close the tooltip

* Click outside: Broaden the elements that can be ignored

Broaden the types of elements that can be ignored

* Info Button: Ignore the SVG when checking for clicking outside

* Info Button: Add Storybook

* Info Button: Use a separate component for the tooltip arrow

That way we can set the border-radius easliy, plus it's probably a bit more CSS-compatible with picky browser engines

* TooltipWrapper shared component

Factor out the common logic of the Tooltip and Info Button so that there is no duplicated functionality and so that the Info Button doesn't have to depend on the Tooltip

* Tooltip and the InfoButton use the TooltipWrapper

Use the shared component.
Also:
- Info button is opened (and stays open) on hover

* separate tooltip components

* icon transition effect added

* button tooltip to the body level + utils function

* Remove log

---------

Co-authored-by: Pavel Laptev <pawellaptew@gmail.com>
2024-09-07 22:12:52 +02:00
Sebastian Thiel
a4df70c422
refactor clone for clarity 2024-09-07 21:08:31 +02:00
Nico Domino
68f0a3c288
fix: use our own open-rs implementation instead of relying on tauri's "shell-open" (#4748)
Co-authored-by: Yerke Tulibergenov <yerke@squareup.com>
Co-authored-by: Caleb Owens <caleb@gitbutler.com>
Co-authored-by: Pavel Laptev <pawellaptew@gmail.com>
Co-authored-by: Mattias Granlund <mtsgrd@gmail.com>
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Co-authored-by: GitButler <gitbutler@gitbutler.com>
2024-09-07 19:28:50 +02:00
estib
a904bcc567 Commit List: Allow force push when removing commits
Display the force-push action button even when only removing "localAndRemote" commits.
2024-09-06 17:30:28 +02:00
Esteban Vega
6fdcf9fcc8
Merge pull request #4844 from gitbutlerapp/clean-up-branch-lane
Clean-up: BranchLaneContextMenu: Remove console.log
2024-09-06 15:58:07 +02:00
Esteban Vega
ff6dff1729
Merge branch 'master' into clean-up-branch-lane 2024-09-06 15:56:36 +02:00
Kiril Videlov
245c8dfd1c
Merge pull request #4841 from gitbutlerapp/workspace-migration-fix-branch
fixes a test that should be using writable fixture
2024-09-06 15:55:51 +02:00
Kiril Videlov
d4fd20bb57
Merge pull request #4840 from gitbutlerapp/rm-legacy-branch-applied-bool
removes the legacy bool indicatin a vbranch is applied
2024-09-06 15:55:42 +02:00
estib
33eb64392f Clean-up: BranchLaneContextMenu: Remove console.log 2024-09-06 15:55:28 +02:00
Kiril Videlov
df4d6ac099
fixes a test that should be using writable fixture 2024-09-06 15:18:09 +02:00
Kiril Videlov
7693b7b9ac
removes the legacy bool indicatin a vbranch is applied 2024-09-06 15:16:20 +02:00
Kiril Videlov
49dd5431b0
Merge pull request #4839 from gitbutlerapp/rm-vb-actions-struct
Remove unnecessary VirtualBranchActions struct
2024-09-06 14:39:35 +02:00
Kiril Videlov
95e946b8a1
Remove unnecessary VirtualBranchActions struct 2024-09-06 14:12:14 +02:00
Nico Domino
32d766c2d6
fix: bump all svelte related dependencies (#4828) 2024-09-06 12:25:41 +02:00
Kiril Videlov
2cad53efa4
Merge pull request #4838 from gitbutlerapp/update-set-branch-target-logic-impl
remove unused set branch target function
2024-09-06 11:25:55 +02:00
Kiril Videlov
8dfd421b60
Merge pull request #4837 from gitbutlerapp/remote-credentials-helper-struct
remove useless credentials helper struct
2024-09-06 11:25:43 +02:00
Esteban Vega
710308b4ea
Merge pull request #4832 from gitbutlerapp/fix-create-pr-button
fix: Disable the PR button if there is no GitHub integration
2024-09-06 11:14:05 +02:00
Esteban Vega
cb6cdf794f
Merge pull request #4834 from gitbutlerapp/clean-up-select-component
Clean-up: Remove anti-pattern from the Select component
2024-09-06 11:11:44 +02:00
Esteban Vega
2b508c66cf
Merge pull request #4836 from gitbutlerapp/style-fix-delete-page
fix: Project Not Found page
2024-09-06 11:10:57 +02:00
Kiril Videlov
b9e39a4503
remove unused set branch target function 2024-09-06 11:08:36 +02:00
Kiril Videlov
3899975d6c
remove useless credentials helper struct 2024-09-06 11:03:57 +02:00
estib
bde8c52477 fix: Project Not Found page
After successfully untracking the missing project, display the correct messages (whether the success or failure to untrack).
Also, update the projects list accordingly
2024-09-06 09:43:10 +02:00
estib
057df19c9d Clean-up: Remove anti-pattern from the Select component
Instead of updating the state through an effect, factor out the `searchValue` state variable into the parent component, and only derive the filtered options from it
2024-09-05 15:25:29 +02:00
Esteban Vega
3c0f67300d
Merge branch 'master' into fix-create-pr-button 2024-09-05 13:54:26 +02:00
Kiril Videlov
a3800459c3
Merge pull request #4833 from gitbutlerapp/Fix-broken-error-page
Fix broken error page
2024-09-05 13:46:33 +02:00