The revised code now allows the function parseFileSections to return hunkSections even if there is no file content. This appears to have resolved an issue where the function would return an empty array if the content was missing, hence potentially ignoring changes that have been stored in hunkSections.
Changes include:
- An early return statement has been moved further down in the code in the parseFileSections function.
- Now, even if file content does not exist, hunkSections are returned to the caller, ensuring that the changes are not missed.
This code change refactors the functions `git_remote_branches_data` and `get_base_branch_data` for improved concurrency and error handling. It primarily uses the `join_all` method from the Futures crate to effectively manage concurrent tasks.
Summary of changes:
- User avatars are now fetched concurrently rather than sequentially. This will improve performance when dealing with large numbers of authors.
- Introduced error handling when a proxy request for the gravatar image fails. A failure to retrieve the image will now default to the use of the original image url, instead of breaking the function.
- Removed redundant construction and use of a HashMap for managing proxies.
- Streamlined the `get_base_branch_data` function for better readability by eliminating the mutable `proxy_map` and directly calling the proxy in the async block.
- Optimized the creation of `virtual_branches::BaseBranch` and `virtual_branches::RemoteBranch` instances by directly embedding the changes within the `join_all` function calls, reducing the complexity of the code.
Redesigned the user profile page to receive Full Name instead of First and Last name. The user update method was adjusted to handle this change. Inputs in the UI that took the first and last name as separate inputs have also been modified to only accept a single name input.
Here's a summary of what was changed:
- The First Name and Last Name fields were replaced with a Full Name field in the form.
- The functions that submitted or processed first and last name data have been simplified to process full name data.
- The client-side and server-side code handling the user update has also been updated to handle only full name.
- Any relevant variable names were also updated to reflect this change.
- The user object now only checks and assigns the `name` property, instead of `given_name` and `family_name`.
As a note, this simplifies the form and the process but some user's may find the change limiting if they typically prefer to provide their names separately for their first and last names.
Refactored user name field into two separate fields: "given_name" and "family_name". Added functionality to retrieve, update, and validate these new fields. Also streamlined the code related to updating the user's picture.
Changes include:
- Splitting the single "name" field into "given_name" and "family_name" in the User structure and updating the associated functions.
- Modified the user updating function to handle these two new fields separately.
- Added new variables "newGivenName" and "newFamilyName" that store the user's input for these fields and are used to update the user's profile.
- Removed "userNameInput" variable and "pictureChanged" flag that were used to track changes in the previous implementation.
- Ensured that the new input fields are bound to the correct variables in the form markup.
- Included code to load the user's full name (both "given_name" and "family_name") when the page is loaded.
- Removed name-related code from the "user subscribe" block since this is now handled by the new fields.
The changes refactor and enhance the logic for rendering URLs of a Git branch within the system. Prior to this, the logic created a url function based on the branch name, and used a nameToBranch function to call it, transforming the name string by replacing non-letter/numeric characters. This led to potential issues.
- Added an 'upstream' object to 'branches' which is then passed on to further components using it.
- The URL function now directly uses this 'upstream' object instead of deriving it from the branch name, leading to more consistency with remote branches.
- The nameToBranch function became obsolete and was removed.
- The URL now splits the upstream branch name and uses the last part for the branchName, maintaining the old structure while improving the accuracy.
- A condition was added to make sure the URL is only created if the 'upstream' exists.
This commit includes several changes that revolve around the SVG icons used as loading indicators. The loading indicators have been reduced in size and the animation and color have been adjusted. New SVG graphics have also been introduced, including a complex icon and a simple icon for different sections of the interface.
Here are some key points:
- The size of the `IconLoading` class has been changed from `h-5` and `w-5` to `h-4` and `w-4`.
- New styling with `fill-purple-600`, `text-light-500`, and `dark:text-dark-500` have been applied to `IconLoading` to better match the project's color scheme.
- A new SVG graphic, using `fill="currentFill"`, has been introduced and replaces the old SVG graphic.
- Some SVG tags have been commented out, presumably for future use or for debugging purposes.
Updated several class attribute values within the commit component to better control element aspect ratios. This was achieved by changing the flex classes. The reference to commit.description has also been modified to display only the first 100 characters, earlier it used to display 200 characters.
Key changes include:
- The use of "shrink-0" versus the previous "w-24" and "w-32" values to prevent those elements from shrinking.
- The reduction of commit description substring length.
- Addition of "rel=noreferrer" to the commit url link for improved security and performance.
In this commit, the layout structure of the code has been refactored. The aim is to create better organization and improve overflow handling. The `UpstreamBranchLane` no longer directly shows under the `target` but is now a child of a new div in `Board`. The removal of a comma at the end of `cloud` indicates a minor syntactic adjustment.
Details:
- Introduced a new div with `flex flex-grow overflow-hidden` classes for better layout management.
- Shifted the `UpstreamBranchLane` component inside the newly introduced div.
- Added `overflow-x-hidden` class in two places to handle the x-axis overflow.
It redirects to the account page if user is logged in.
This meant that if a user is logged in they cant go to the project settings, since it instantly redirected them to the account settings
I was trying to figure out how we can leverage the rust code for
boostrapping new repos during development. It would be great if
I only needed one command to spawn a repo with an active merge
conflict.
While figuring things out I spotted this opportunity to make the
code a bit more dry.
