Commit Graph

817 Commits

Author SHA1 Message Date
Kiril Videlov
615f0092a6 add Storybook dev dependency 2023-03-27 17:09:32 +02:00
Nikita Galaiko
d8af16f0cf better file filter 2023-03-27 16:38:32 +02:00
Nikita Galaiko
2057c9216e fix url encoding 2023-03-27 16:38:32 +02:00
Nikita Galaiko
3cec588eef fix layout 2023-03-27 16:38:32 +02:00
Nikita Galaiko
a35d875aa1 dynamic file filter 2023-03-27 16:38:32 +02:00
Nikita Galaiko
e955f4a786 format 2023-03-27 16:38:32 +02:00
Nikita Galaiko
8cadaed8a0 link file 2023-03-27 16:38:32 +02:00
Nikita Galaiko
b9363aed1f add file filter back 2023-03-27 16:38:32 +02:00
Nikita Galaiko
b19e1ebb76 link player from search 2023-03-27 16:38:32 +02:00
Nikita Galaiko
c45819cc6b flip sessions 2023-03-27 16:38:32 +02:00
Nikita Galaiko
5aabfac420 scroll sessions list 2023-03-27 16:38:32 +02:00
Nikita Galaiko
b1d881247c scroll code viewer 2023-03-27 16:38:32 +02:00
Nikita Galaiko
fa58493f49 make player linkable 2023-03-27 16:38:32 +02:00
Ian Donahue
9410eafd92
Merge pull request #48 from gitbutlerapp/ian/gb-112-spacing-in-search-results
Ian/gb 112 spacing in search results
2023-03-24 16:05:17 +01:00
Nikita Galaiko
34cfd571d6 player: use session to calculate duration 2023-03-24 16:00:09 +01:00
Nikita Galaiko
f146e9d33d player: drop editsCount 2023-03-24 16:00:09 +01:00
Nikita Galaiko
06301d2853 player store date in the same way 2023-03-24 16:00:09 +01:00
Nikita Galaiko
1e9a187e4b player: auto-update file filter 2023-03-24 16:00:09 +01:00
Nikita Galaiko
638028b119 player: store delta index in url 2023-03-24 16:00:09 +01:00
Nikita Galaiko
74eb6ae450 fix some linter issues 2023-03-24 14:47:20 +01:00
Nikita Galaiko
73d1a44671 pnpm format 2023-03-24 14:47:20 +01:00
Nikita Galaiko
7d846fccbc player: simplify activities layout 2023-03-24 14:47:20 +01:00
Nikita Galaiko
6ff78b8cf7 player: fix linter 2023-03-24 14:47:20 +01:00
Nikita Galaiko
fa8f95f705 player: refactor day selector css/js 2023-03-24 14:47:20 +01:00
Nikita Galaiko
5b55f10d8f player: make url search params reactive 2023-03-24 14:47:20 +01:00
Nikita Galaiko
2da6febd2c 🚀 hardware accelerate webkit 2023-03-24 12:25:06 +01:00
Nikita Galaiko
e77cc0c616 Refactor CodeViewer to use table layout
Refactored the CodeViewer component to switch from using grid layout to a table layout for improved rendering performance. This change simplifies CSS styles by removing unnecessary definitions and ensures consistency in line number display. Additional styling has been applied to the table layout to maintain the existing look and functionality.

- Replaced the `div` structure with `table`, `tbody`, and `tr` elements
- Renamed `rows` to `renderedRows` for better naming consistency
- Added `originalLineNumberDigits` and `currentLineNumberDigits` for proper alignment in table cells
- Removed unnecessary CSS rules and added table-specific styles
2023-03-24 12:12:48 +01:00
Kiril Videlov
1ba0ae0fe7 refactor reusable modal component 2023-03-24 12:06:59 +01:00
Ian Donahue
5a218c8ce5 Refactor search results UI and navigation
This commit refactors the search results page UI and updates the navigation buttons for better user experience. Previously, the search result list layout and the navigation buttons showed inconsistent styling and padding issues.

Changes include:
- Adjusting padding and margin for search result list and search result items.
- Moving the navigation buttons inside the search result list.
- Updating the styling and hover effect for navigation buttons.
- Removing unnecessary padding and margin for figure elements.
2023-03-24 11:19:46 +01:00
Ian Donahue
b875f3bc58 Added 1 Title to the current branch
This will allow people to see full names o fa branch.
2023-03-24 10:44:26 +01:00
Ian Donahue
132b2b1ee5 Merge branch 'master' into ian/gb-112-spacing-in-search-results 2023-03-24 10:38:49 +01:00
Nikita Galaiko
6d692f43be apply custom hyighlight only for if needed 2023-03-24 09:01:50 +01:00
Nikita Galaiko
1ac0e9a0d4 Improve search result layout and spacing
Adjusted the search result layout and added more consistent spacing in the search results page. This makes the display cleaner and easier to read for users. 

Changes:
- Changed list styling for flex display and added a `-mr-14` class to control the layout.
- Updated spacing between elements using both `flex-col gap-6` and `mr-14` to provide more consistent separation between items.
2023-03-24 08:53:49 +01:00
Nikita Galaiko
4cc61cd8d4 Add pagination and improve search UI
This commit adds pagination support to the search results page by updating the limit of results per page, implementing openNextPage and openPrevPage functions, and including navigation buttons for the pagination. It also improves the UI by adding a spinning icon while searching for results and adjusts the overall styling for better readability.

- Added IconChevronLeft and IconChevronRight to icons exports
- Updated the limit of results per page from 50 to 10
- Implemented openNextPage and openPrevPage functions for pagination
- Added navigation buttons for previous and next pages
- Used IconRotateClockwise with animation for a spinning icon while searching
- Updated the styling for better UI readability
2023-03-24 08:53:49 +01:00
Ian Donahue
3a372284e8 Scroll for search results are now on the right of screen
This commit includes refactoring the code format to use consistent indentation, and updates the CSS classes to improve UI element styling. The changes were made in the src/lib/search.ts file and the src/routes/projects/[projectId]/search/+page.svelte file.

- Adjusted the indentation in src/lib/search.ts to use tabs consistently
- Changed the figure class from "mx-14 flex h-full flex-col gap-2" to "search-results flex h-full flex-col gap-2" in +page.svelte
- Updated the figcaption and ul elements to have consistent margins and padding in +page.svelte
2023-03-24 07:42:44 +01:00
Ian Donahue
b10518b14f Scroll for search results are now on the right of screen
This commit includes refactoring the code format to use consistent indentation, and updates the CSS classes to improve UI element styling. The changes were made in the src/lib/search.ts file and the src/routes/projects/[projectId]/search/+page.svelte file.

- Adjusted the indentation in src/lib/search.ts to use tabs consistently
- Changed the figure class from "mx-14 flex h-full flex-col gap-2" to "search-results flex h-full flex-col gap-2" in +page.svelte
- Updated the figcaption and ul elements to have consistent margins and padding in +page.svelte
2023-03-23 16:22:43 +01:00
Kiril Videlov
39e0c1a8ff
Merge pull request #44 from gitbutlerapp/asdf2
asdf2
2023-03-23 16:13:00 +01:00
Nikita Galaiko
a686f64c7a Add pagination support to project search
This commit adds support for pagination within the project search feature. The changes include adding a limit of 50 results per page and an offset to handle page offsets in the search. Additionally, the search results are now updated to include a 'haveMore' flag to indicate if there are more results to display.

Changes in detail:
- Added limit and offset variables
- Updated search result to include 'haveMore' flag
- Modified fetchResultData function to handle updated search results
2023-03-23 16:11:39 +01:00
Nikita Galaiko
b7e5e2a0c8 Refactor search results with asyncDerived store
This commit refactors the search results code to use the asyncDerived store for fetching and displaying results. This simplifies and improves the overall code structure by streamlining the state management and lifecycle of search-related data. Additionally, it switches to using derived stores for displaying results and states related to searching, showing loading, error, and result states as needed.

Changes:
- Remove the manual search fetching and state management code.
- Utilize asyncDerived and derived stores to handle fetching and displaying search results.
- Update use of loading, error, and result states to check the $searchState store instead of manually managing those states.
2023-03-23 16:11:39 +01:00
Nikita Galaiko
a0eeeae645 Refactor search functionality in project layout
This commit refactors the search functionality present in the project layout. Instead of using a debounced input event handler to update the search query, a form is now used to handle search submission. The search functionality in the search page has also been updated to use the query param instead of a writable store, and the fetchResultData function has been extracted for better readability.

Changes:
- Replace debounced input event handler with form submission in project layout
- Update search functionality in search page to use query param
- Extract fetchResultData function for better readability
- Remove unnecessary context and store usage
2023-03-23 16:11:39 +01:00
Nikita Galaiko
aaba14e819 use cache for get session by id 2023-03-23 16:11:39 +01:00
Nikita Galaiko
e4f1edfc83 Refactor search result to include total count
This commit refactors the search result to include the total count of matches found, alongside the limited search results (page) for better pagination support. Changes made include:

- Modified the return type from `Vec<SearchResult>` to `SearchResults` structure, to include a total count.
- Updated the search function implementation to handle the new data structure.
- Adapted the test cases to account for the updated search result format.

In addition to the previous changes, this commit addresses the issue of not knowing the total number of search results when using pagination, which can now be easily obtained from the `SearchResults` structure.
2023-03-23 16:11:39 +01:00
Kiril Videlov
d7a11d1cd0 format 2023-03-23 16:11:30 +01:00
Kiril Videlov
95c690be91 command palett replay dialog now contains things 2023-03-23 16:11:15 +01:00
Scott Chacon
d2fdecc752
Merge pull request #42 from gitbutlerapp/sc-render-removals
Better rendering of removed files
2023-03-23 15:07:17 +01:00
Scott Chacon
3aa1f7d0b6 lint 2023-03-23 14:59:30 +01:00
Scott Chacon
5c0c4a8196 Better rendering of removed files 2023-03-23 14:57:12 +01:00
Kiril Videlov
5fa0b9e68e command palette refactor 2023-03-23 14:23:36 +01:00
Nikita Galaiko
f842829583 Update padding logic in CodeViewer component
This commit updates the padding logic in the CodeViewer component to handle highlighted lines more effectively. The renderRowContent function now returns an object with an html property and a highlighted property, allowing for more precise controls when rendering rows. Additionally, new functions have been introduced to manage chunks of lines and apply padding, helping to optimize the display of code diffs.

Changes include:
- Modify `renderRowContent` to return an object containing html and highlighted properties
- Add a `rows` computed variable that maps the original rows to the newly rendered rows
- Introduce new `RenderedRow` type and `applyPadding` function to manage chunks and padding logic
- Update Row interface to include a size property
2023-03-23 14:07:58 +01:00
Nikita Galaiko
cbc82a93cc simplify highlight condition 2023-03-23 14:07:58 +01:00