Commit Graph

259 Commits

Author SHA1 Message Date
Mattias Granlund
ad3e2ffdf5 Make branch title change reflect branch name optimistically 2024-04-12 17:02:08 +02:00
Pavel Laptev
c6c221b6a2
added status messages + code refactor (#3465)
* added status messages + code refactor

* Exclude `skipped` checks from running checks count

* Added types `ColorStyle` and `KindStyle`

- in order to share same color types across components and avoid duplication added  `ColorStyle` and `KindStyle` types
- Renamed color style `warn` in some components to `warning` for consistency

* typo and naming fixes

* Updated component style types
2024-04-12 13:13:24 +02:00
Mattias Granlund
eb80df0450 Simplify project service and settings
- removes unnecessary object creation
- fixes staleness bug
2024-04-11 23:34:33 +02:00
Mattias Granlund
701e75f241 Fix unintended effect on project settings
- removes unnecessary event dispatching
2024-04-11 23:34:33 +02:00
Mattias Granlund
f0097846e4 Fix "open in vscode" on Windows
- fixes #3489
2024-04-11 23:34:33 +02:00
Mattias Granlund
150acb0abf Show most errors using toast
- does not automatically dismiss
- shows the error to the user
2024-04-11 20:17:48 +02:00
Mattias Granlund
92b12ebad7 Refactor parameters in httpClient.ts
- it's convention for first param to be url
2024-04-11 16:06:36 +02:00
Mattias Granlund
7aa30724e7 Move syncToCloud out of httpClient.ts 2024-04-11 16:06:36 +02:00
Mattias Granlund
b7ca1ad2c4 Move feedback functions from httpClient.ts into ShareIssueModal.ts 2024-04-11 15:25:20 +02:00
Mattias Granlund
dada5f7dd0 Move user related functions from httpClient.ts to user.ts 2024-04-11 15:25:20 +02:00
Mattias Granlund
84a61e9644 Move Project from HttpClient to projects.ts
- renames duplicate type CloudProject
2024-04-11 15:25:20 +02:00
Mattias Granlund
f079f0df77 Rename Project -> CloudProject
- we should probably not have multiple types
- one is used on disk, the other in the cloud
2024-04-11 15:25:20 +02:00
Mattias Granlund
6270cbe403 Move User from httpClient.ts to user.ts 2024-04-11 15:25:20 +02:00
Mattias Granlund
ef270ceaa4 Fixup previous commit 2024-04-11 15:25:20 +02:00
Mattias Granlund
ffbd6e7a0c Rename constants and move functions in order of priority
Readers always start at the top, we should put the most important functions / definitions there.
2024-04-11 15:25:20 +02:00
Mattias Granlund
5abcdcca1f Replace RequestMethod enum with simpler type 2024-04-11 15:25:20 +02:00
Mattias Granlund
a85ecb9dbb Rename CloudClient -> HttpClient
This class will become a thin wrapper around fetch, the functions it currently declares should live in the code that calls them.
2024-04-11 15:25:20 +02:00
Mattias Granlund
9ca84a6144 Rename cloud.ts -> httpClient.ts 2024-04-11 15:25:20 +02:00
Caleb Owens
0ceff12989 Remove empty body object 2024-04-11 15:25:20 +02:00
Caleb Owens
41644432b9 Introduce method specific methods 2024-04-11 15:25:20 +02:00
Caleb Owens
7100a06b59 Allow passing undefined content type to fix form multipart types 2024-04-11 15:25:20 +02:00
Caleb Owens
59039d3dda Make use of makeRequest in butlerClient 2024-04-11 15:25:20 +02:00
Caleb Owens
61e68778a9 Move AI types back into the AI folder 2024-04-11 15:25:20 +02:00
Caleb Owens
f8daeeb8c2 Use makeRequest in all existing API wrappers 2024-04-11 15:25:20 +02:00
Caleb Owens
1debab3a92 Introduce an initial makeRequest method 2024-04-11 15:25:20 +02:00
Caleb Owens
b7ac4cc41e Tidy up seting CloudClient#fetch 2024-04-11 15:25:20 +02:00
Caleb Owens
c094d7e1ee Remove any cyclic packages 2024-04-11 15:25:20 +02:00
Caleb Owens
251aaa3e59 Moved types.ts which was previously missed 2024-04-11 15:25:20 +02:00
Caleb Owens
3cb86afae7 Move AI Client related stuff into its own folder 2024-04-11 15:25:20 +02:00
Pavel Laptev
266fd534d9
Backspace was navigation to the previous page
On each page, which wasn't expected when you accidentally hit it.
2024-04-11 03:00:08 +02:00
Mattias Granlund
7d01a537d4 Only allow use of system executable git on Windows
- libgit2 does not work on windows
2024-04-10 16:48:33 +02:00
Mattias Granlund
f84b853aae Make NoBaseBranch a component
- solves navigation race condition that can land you on the wrong page
- some users have reported seeing "up-to-date" without navigation sidebar
2024-04-10 11:23:49 +02:00
Pavel Laptev
87cfadffaf
replaced wrong button prop iconAlign (#3481) 2024-04-10 02:20:09 +02:00
Pavel Laptev
11c28cf1ef
CSS glitches fix + AI page typo fixed (#3480) 2024-04-10 01:03:26 +02:00
Pavel Laptev
59e441a2eb
added z-index variables (#3466)
* added z-index variables
in order to ease levels for `absolute` and `fixed` elements
2024-04-09 17:53:47 +02:00
Pavel Laptev
cee9b96142
Components props and style fixes (#3464)
* Components props and style fixes
2024-04-09 16:18:31 +02:00
Pavel Laptev
dcf43e94c3
Code fixes, update on:close Function for Files, Button styles update (#3444)
* Renamed `FileSelection` to `FileIdSelection`

In order to make it more specific,since we already have `selectedFiles`

* fix Project name input type

* button styles updated
2024-04-09 00:18:01 +02:00
Mattias Granlund
57349821b5 Make PR success criteria stricter
- prompted by feedback on discord
2024-04-08 23:11:19 +02:00
Mattias Granlund
d3742bf1ec Simplify layout.ts by removing fetch parameter
- it's not needed since the client is a single page application
2024-04-08 17:59:51 +02:00
Pavel Laptev
d2dde6cec5
scc: button fixes (#3453) 2024-04-08 11:26:30 +02:00
Pavel Laptev
e7377132bf
Design tokens updates (#3452)
* refactored design tokens

* color-mix CSS function replaced with oklch

OKLCH has more accurate and shorter way of making colors darker for hover effects
2024-04-08 09:06:17 +02:00
Mattias Granlund
603710329f Rename branchStoresCache.ts -> virtualBranch.ts
- split out `baseBranch.ts`, these should never have been in the same file
2024-04-07 15:03:18 +02:00
Caleb Owens
fa75c8f817
Merge pull request #3424 from gitbutlerapp/refactor-settings-into-multiple-files
Refactor settings into multiple real pages
2024-04-07 12:36:30 +01:00
Mattias Granlund
f4ba84753b Check for locked status correctly
- always check on boolean property instead of array length
2024-04-05 15:30:26 +02:00
Pavel Laptev
04fb7848ce
Smol CSS fixes (#3441)
* zindex remove: it crops the sidebar resizer thumb

* delete project button changed to the contrast one
2024-04-05 13:09:44 +02:00
Caleb Owens
2b780fdbde Removed overly specific type casts 2024-04-05 00:16:22 +01:00
Caleb Owens
d5f5f90e7a Fix import ordering in sidebar 2024-04-05 00:00:21 +01:00
Caleb Owens
d7ae34d612 Rename ProfileSIdebar to Sidebar 2024-04-04 23:56:36 +01:00
Caleb Owens
1b94b2fcdd Fix formatting 2024-04-04 23:06:02 +01:00
Caleb Owens
00910c8027 De-duplicate AnalyticsSettings 2024-04-04 23:06:02 +01:00
Caleb Owens
5ef5fa0143 Refactor settings into multiple real pages 2024-04-04 23:06:00 +01:00
Mattias Granlund
1c2db6f24f Allow amend while hunk/file locked
We have gone a bit back and forth here, but this should be the right way of handling locks wrt to dragging.

- uses dropzone accept call to dynamically block locked hunks/files
2024-04-04 21:06:30 +02:00
Mattias Granlund
96a3237ac1 Allow merging/rebasing from branch preview
- feels like you shouldn't need to apply a branch just to merge a pr
2024-04-04 19:14:05 +02:00
Mattias Granlund
e95fb62410 Flatten the AI service directory
- resolves cyclic dependency between the two packages
2024-04-04 19:06:28 +02:00
Mattias Granlund
54cba257dd Fix cyclical dependency in AI service 2024-04-04 18:19:26 +02:00
Mattias Granlund
295e14ee50 Improve wait conditions for PR checks
- continue waiting if there are check suites that haven't completed
2024-04-04 15:49:51 +02:00
Pavel Laptev
b36bc1ff4b
wiggle lock files if dragging (#3432)
* wiggle lock files if dragging

* lint fixes

* Expand lane only when clicking expand button

- previous behavior was click anywhere to expand

* wiggle lock files if dragging

* lint fixes

* minor comments change

---------

Co-authored-by: Mattias Granlund <mtsgrd@gmail.com>
2024-04-04 15:31:56 +02:00
Mattias Granlund
6b888c3e89 Expand lane only when clicking expand button
- previous behavior was click anywhere to expand
2024-04-04 15:19:57 +02:00
Josh Junon
5a9962bc5a
initial move of crates (no config changes) 2024-04-04 11:49:12 +02:00