Commit Graph

945 Commits

Author SHA1 Message Date
Nico Domino
b4bdbdcfb6 fix: StackingSeriesHeader merge conflicts
Discard changes to apps/desktop/src/lib/branch/BranchLabel.svelte
2024-10-31 10:30:24 +01:00
ndom91
3884c96ddf feat: double input handling and blur clear 2024-10-31 10:30:24 +01:00
Pavel Laptev
fb0fa7eb9a fix styles and words wrap 2024-10-31 10:30:24 +01:00
Pavel Laptev
de50077ebb styles update 2024-10-31 10:30:24 +01:00
Pavel Laptev
ecbed20789 replace components 2024-10-31 10:30:24 +01:00
ndom91
5b355935a0 fix: allow periods in git refs through slugify() 2024-10-30 15:20:04 +01:00
Esteban Vega
3b8a96ca47
Merge pull request #5330 from gitbutlerapp/e-branch-2
fix: Modal closes on mouse down outside
2024-10-28 14:52:03 +01:00
estib
42270f1c9f fix: Modal closes on mouse down outside
Avoid closing the modals when releasing the mouse outside the modal.
Only close them on clicking down outside the modal
2024-10-28 14:44:50 +01:00
Kiril Videlov
97c344404f
Merge pull request #5316 from gitbutlerapp/fix-dashed-lines
Fix dashed lines
2024-10-28 13:25:52 +01:00
estib
7b0e447a98 Modal: Close is a promise + onClickOutside
Make the modal closing function a promise as it's done asynchronously.
Add another optional callback that's called only in the case when clicking outside the modal.
2024-10-28 10:21:32 +01:00
ndom91
04d2fdd26c fix: playwright on nix 2024-10-27 10:54:10 +01:00
ndom91
34cb68e52c fix: add timeAgo tests 2024-10-26 16:54:01 +02:00
ndom91
fe10b21602 fix: replace momet with dayjs 2024-10-26 16:54:01 +02:00
Pavel Laptev
6d10a5944f fix commit lines dotted lines 2024-10-25 16:07:59 +02:00
Pavel Laptev
428fc5aee6 fix Spacer repeating gradient 2024-10-25 15:22:06 +02:00
Pavel Laptev
2ed3957ab3 move Spacer to UI 2024-10-25 15:21:33 +02:00
ndom91
fdc5f8b94d
fix: overlapping context menus 2024-10-24 19:49:54 +02:00
Pavel Laptev
d3a0f3108b
Update text areas (#5297)
* reedit "borderlessTextArea" to "Textarea"

* replace old textareas

* Delete TextArea.svelte

* move `TextBox` to UI

* mock the keyboard event

* migrate `Textbox` to svelte 5

* Update PrDetailsModal.svelte

* fix event

* fix text formatting

* Update DialogBubble.svelte

* codereview fixes
2024-10-24 15:37:27 +00:00
estib
549f5341d7 lint: ALL BUTTONS HAVE TYPE, FOREVER
Ensure that all buttons have an explicit type so that no button mistakenly submits a form they may be inside of
2024-10-24 16:32:50 +02:00
estib
9d588efbd4 fix: SimpleCommitRow butttons of type button
Apparently buttons without a type inside a form default to `submit`.
In order to open the links in the commit list and not trigger the upstream to be integrated, we need to set the type of the button to `button`
2024-10-24 16:08:42 +02:00
Pavel Laptev
5f7941d17a
Context menu fixes (#5291)
* added "disabled" prop to Tooltip

* don't show tooltips when the context menu is activated

* correct context menu positioning

* fixes: menu toggling, hold the active card state when the ctx menu is opened
2024-10-24 11:13:49 +02:00
Kiril Videlov
2f62bad734 Allow underscore on slugify 2024-10-24 11:03:16 +02:00
Pavel Laptev
dcd6391c88
New branch menus (#5279)
* added new overflowMenu

* refactor(StackingSeriesHeader): Remove redundant code for opening link and context menu options

* commit context menu added

* refactor: Improve click outside handler in ContextMenu.svelte

* feat(commit): Add ability to insert blank commit above or below existing commit

* refactor(contextmenu): Refactor align logic, remove el and add clientHeight/Width binding

* added: "Activated" state for overflow menu and buttons

* added: conditions for "kebab" buttons when context menu is opened

* fixing context menu positioning

* feat: Add preventDefault to context menu in OverflowMenuItem

* fix: Toggle button label

* added "copy PR" item

* Update OverflowMenuItem.svelte

* Update InsertEmptyCommitAction.svelte

* adde more itrm to the commit context menu

* Update StackingCommitList.svelte

* Update Button.svelte

* fix checks

* change context menu trigger area

* components rename

* restrict context menu actions to the commit type

* Update CommitContextMenu.svelte

* add missing prop

* rearrange buttons

* Update apps/desktop/src/lib/branch/StackingSeriesHeader.svelte

* some buttons had missing kind prop

* move new components to UI

---------

Co-authored-by: Nico Domino <yo@ndo.dev>
2024-10-24 02:46:06 +02:00
ndom91
cca10524bf fix: dont force runes on packages/ui - storybook still doesnt support 2024-10-23 11:09:39 +02:00
ndom91
e5f63c557c chore: eslint ignore storybook stories for now 2024-10-23 11:09:39 +02:00
ndom91
d8a22b5196 fix: cleanup @typescript-eslint rules 2024-10-23 11:09:39 +02:00
ndom91
26713898b8 fix: packages/ui eslint issues 2024-10-23 11:09:39 +02:00
ndom91
f928b25fff fix: update tsconfig related options 2024-10-23 11:09:39 +02:00
ndom91
1838fab7c3 fix: enable svelte.config runes mode explicitly 2024-10-23 11:09:39 +02:00
ndom91
e1401d11af fix: move all stirng utils to shared ui utils 2024-10-22 11:56:40 +02:00
ndom91
02d5a88612 feat: add a few string tests 2024-10-22 11:56:40 +02:00
ndom91
3eed596cc8 fix: replace lookbehind regex with for loop 2024-10-22 11:56:40 +02:00
Pavel Laptev
029b8e5b2c move Toggle and ToggleButton to UI 2024-10-21 12:07:19 +02:00
estib
41b9ed4ad7 BorderlessTextarea: Auto height on value changes
Update the height on value changes instead of only on input events.
That way, if the value is externally updated then the height will update as well
2024-10-21 11:34:55 +02:00
Pavel Laptev
f27f65a6fb update design 2024-10-20 22:18:20 +02:00
Pavel Laptev
ff29f37457
UI: Stacking branch header (#5217)
* styles update

* fix focusTrap
2024-10-18 15:35:09 +00:00
Pavel Laptev
d9c027dba9
update styles and props (#5204) 2024-10-18 16:26:23 +02:00
Pavel Laptev
45467f33e5
UI stacking lanes style fixes (#5210)
* fix margins and positioning

* fix dots on zoom
2024-10-18 15:19:15 +02:00
Esteban Vega
a9ecf285f6
add-branch-to-stack-update (#5188)
* Button: Add more styling props

- Choose the border radius style
- Set a max-width
- Ignore children (helps with the animation in between having no children and having a large child)

* StackingAddSeriesButton

Replace the 'new series' card with a button that appears on hover.
Also:
The modal displays more information, like what the resulting branch name will be called

* style updates

* button center align

* fix tooltip positioning

* some UI fixes

* added focus trap to the context menu

* styles updated

* update: transition time

---------

Co-authored-by: Pavel Laptev <pawellaptew@gmail.com>
2024-10-18 12:55:08 +02:00
ndom91
b26b30d8d0 fix: ensure commit-lines.css works for both stacking/original lanes 2024-10-17 12:03:09 +02:00
estib
fb152bcc96 PR card updates 2024-10-16 16:20:02 +02:00
Pavel Laptev
a7eef8ff38 center dots 2024-10-16 15:22:27 +02:00
ndom91
6b89ffdecf fix: bottom commitLine dashed 2024-10-16 15:22:27 +02:00
Pavel Laptev
c6482a94de
Improve modal UI and discard changes (#5148)
* style(modal): Update header padding and add color to body

* style: Update font color in modal body paragraphs

* feat(ui): improve DemoModal structure and props usage

* style: Remove unnecessary global styles from Modal component

* feat(ui): Update DemoModal component onclick event and add onSubmit handler

* StoryBook: Update text in DemoModal

* add missing "submit"

* modal lint/checks fixes

* Update "Discard changes" modal
2024-10-15 16:25:02 +02:00
Pavel Laptev
436cd41f44
fix(ui): Change onmousedown to onclick in Segment.svelte (#5147) 2024-10-15 15:10:10 +02:00
Pavel Laptev
4d84a87f5c
Fix button type for modals (#5145) 2024-10-15 14:19:00 +02:00
Pavel Laptev
62ffe0986d
Revert dialog modal implementation (#5143)
* rename `default` size to `medium`

* animation on close and focus trap

* focus trap fix

* fix clickoutside bug with open select

* Update focusTrap.ts

* fix check

* remove unnesessery code
2024-10-15 10:45:09 +02:00
Pavel Laptev
31020d9dec
style(ui): Simplify label badge conditional rendering in IntegrationSeriesRow (#5130) 2024-10-14 14:27:37 +02:00
ndom91
5724136e88 fix: change stacking header line alignment 2024-10-14 12:29:37 +02:00
ndom91
26784d1ae7 fix: divergent commit shorten to 7 char sha 2024-10-14 12:22:18 +02:00