1
1
mirror of https://github.com/github/semantic.git synced 2024-12-23 23:11:50 +03:00

Move the ignore eta reduce thing into the hlint config.

This commit is contained in:
Rob Rix 2018-11-05 09:36:40 -05:00
parent fe9f0b0aeb
commit 1e5920e318
7 changed files with 11 additions and 12 deletions

View File

@ -34,6 +34,17 @@
# Change the severity of hints we dont want to fail CI for
- suggest: {name: Eta reduce}
# Ignore eta reduce in the assignment modules
- ignore:
name: Eta reduce
within:
- Language.Go.Assignment
- Language.MiniPython.Assignment
- Language.MiniRuby.Assignment
- Language.PHP.Assignment
- Language.Python.Assignment
- Language.Ruby.Assignment
# Our customized warnings
# AMP fallout

View File

@ -663,5 +663,3 @@ manyTerm = many . term
-- | Match a term and contextualize any comments preceeding or proceeding the term.
term :: Assignment Term -> Assignment Term
term term' = contextualize comment term' <|> makeTerm1 <$> (Syntax.Context <$> some1 comment <*> emptyTerm)
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}

View File

@ -158,5 +158,3 @@ infixTerm :: Assignment Term
-> [Assignment (Term -> Term -> Sum Syntax Term)]
-> Assignment (Sum Syntax Term)
infixTerm = infixContext comment
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}

View File

@ -216,5 +216,3 @@ identWithLocals = do
locals <- getLocals
ident <- source
pure (loc, ident, locals)
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}

View File

@ -823,5 +823,3 @@ infixTerm :: Assignment Term
-> [Assignment (Term -> Term -> Sum Syntax Term)]
-> Assignment (Sum Syntax Term)
infixTerm = infixContext (comment <|> textInterpolation)
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}

View File

@ -553,5 +553,3 @@ infixTerm :: Assignment Term
-> [Assignment (Term -> Term -> Sum Syntax Term)]
-> Assignment (Sum Syntax Term)
infixTerm = infixContext comment
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}

View File

@ -572,5 +572,3 @@ infixTerm :: Assignment Term
-> [Assignment (Term -> Term -> Sum Syntax Term)]
-> Assignment (Sum Syntax Term)
infixTerm = infixContext comment
{-# ANN module ("HLint: ignore Eta reduce" :: String) #-}