Merge branch 'heap-frames' of https://github.com/github/semantic into heap-frames

src/Data/Syntax/Literal.hs

@@ -215,7 +215,7 @@ instance Ord1 Array where liftCompare = genericLiftCompare
 instance Show1 Array where liftShowsPrec = genericLiftShowsPrec
 
 instance Evaluatable Array where
-  eval _ (Array _) = undefined -- rvalBox =<< array =<< traverse (eval >=> address) a
+  eval eval Array{..} = rvalBox =<< array =<< traverse (eval >=> Eval.value) arrayElements
 
 instance Tokenize Array where
   tokenize = list . arrayElements
@@ -255,7 +255,7 @@ instance Ord1 Tuple where liftCompare = genericLiftCompare
 instance Show1 Tuple where liftShowsPrec = genericLiftShowsPrec
 
 instance Evaluatable Tuple where
-  eval _ (Tuple _) = undefined -- rvalBox =<< tuple =<< traverse (eval >=> address) cs
+  eval eval (Tuple cs) = rvalBox =<< tuple =<< traverse (eval >=> Eval.value) cs
 
 newtype Set a = Set { setElements :: [a] }
   deriving (Declarations1, Diffable, Eq, Foldable, FreeVariables1, Functor, Generic1, Hashable1, Ord, Show, ToJSONFields1, Traversable, Named1, Message1, NFData1)

src/Data/Syntax/Statement.hs

@@ -133,11 +133,19 @@ instance Ord1 Let where liftCompare = genericLiftCompare
 instance Show1 Let where liftShowsPrec = genericLiftShowsPrec
 
 instance Evaluatable Let where
-  eval _ Let{..} = do
-    undefined
-    -- name <- maybeM (throwEvalError NoNameError) (declaredName letVariable)
-    -- addr <- snd <$> letrec name (eval letValue >>= Abstract.value)
-    -- Rval <$> locally (bind name addr *> (eval letBody >>= address))
+  eval eval Let{..} = do
+    name <- maybeM (throwEvalError NoNameError) (declaredName letVariable)
+    letSpan <- ask @Span
+    valueName <- maybeM (throwEvalError NoNameError) (declaredName letValue)
+    assocScope <- associatedScope (Declaration valueName)
+
+    withLexicalScopeAndFrame $ do
+      declare (Declaration name) letSpan assocScope
+      letVal <- (eval letValue >>= Abstract.value)
+      slot <- lookupDeclaration (Declaration name)
+      assign slot letVal
+      eval letBody
+    rvalBox unit
 
 
 -- Assignment