github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-30 10:27:45 +03:00
Code Issues Projects Releases Wiki Activity

clarify TODO

Browse Source
This commit is contained in:
Patrick Thomson 2018-11-26 11:21:34 -05:00
parent 0f71cd2404
commit 330a78b230
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Language/Ruby/Syntax.hs
View File

@ -222,7 +222,9 @@ instance Eq1 LowPrecedenceAnd where liftEq = genericLiftEq
instance Ord1 LowPrecedenceAnd where liftCompare = genericLiftCompare instance Ord1 LowPrecedenceAnd where liftCompare = genericLiftCompare
instance Show1 LowPrecedenceAnd where liftShowsPrec = genericLiftShowsPrec instance Show1 LowPrecedenceAnd where liftShowsPrec = genericLiftShowsPrec
-- PT TODO: This isn't right -- TODO: These should probably be expressed with a new context/token,
-- rather than a literal run, and need to take surrounding precedence
-- into account.
instance Tokenize LowPrecedenceAnd where instance Tokenize LowPrecedenceAnd where
tokenize LowPrecedenceAnd{..} = lhs *> yield (Token.Run "and") <* rhs tokenize LowPrecedenceAnd{..} = lhs *> yield (Token.Run "and") <* rhs
@ -241,6 +243,5 @@ instance Eq1 LowPrecedenceOr where liftEq = genericLiftEq
instance Ord1 LowPrecedenceOr where liftCompare = genericLiftCompare instance Ord1 LowPrecedenceOr where liftCompare = genericLiftCompare
instance Show1 LowPrecedenceOr where liftShowsPrec = genericLiftShowsPrec instance Show1 LowPrecedenceOr where liftShowsPrec = genericLiftShowsPrec
-- PT TODO: This isn't right
instance Tokenize LowPrecedenceOr where instance Tokenize LowPrecedenceOr where
tokenize LowPrecedenceOr{..} = lhs *> yield (Token.Run "or") <* rhs tokenize LowPrecedenceOr{..} = lhs *> yield (Token.Run "or") <* rhs