github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-19 12:51:52 +03:00
Code Issues Projects Releases Wiki Activity

Change methodParams to be a list of args

Browse Source
This commit is contained in:
joshvera 2016-08-17 10:42:05 -04:00
parent 1d79153f01
commit 5615da1bc0
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Parser.hs
View File

@ -69,8 +69,10 @@ termConstructor source sourceSpan info = fmap cofree . construct
_ -> errorWith children
construct children | FunctionCall == category info = case runCofree <$> children of
[ (_ :< S.MemberAccess{..}), params@(_ :< S.Args{}) ] ->
pure $! setCategory info MethodCall :< S.MethodCall memberId property (cofree params)
[ (_ :< S.MemberAccess{..}), params@(_ :< S.Args args) ] ->
pure $! setCategory info MethodCall :< S.MethodCall memberId property args
[ (_ :< S.MemberAccess{..}) ] ->
pure $! setCategory info MethodCall :< S.MethodCall memberId property []
(x:xs) ->
withDefaultInfo $ S.FunctionCall (cofree x) (cofree <$> xs)
_ -> errorWith children

2
src/Syntax.hs
View File

@ -33,7 +33,7 @@ data Syntax a f
| MemberAccess { memberId :: f, property :: f }
-- | A method call consisting of its target, the method name, and the parameters passed to the method.
-- | e.g. in Javascript console.log('hello') represents a method call.
| MethodCall { targetId :: f, methodId :: f, methodParams :: f }
| MethodCall { targetId :: f, methodId :: f, methodParams :: [f] }
-- | The list of arguments to a method call.
-- | TODO: It might be worth removing this and using Fixed instead.
| Args [f]