github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-19 12:51:52 +03:00
Code Issues Projects Releases Wiki Activity

Document why sourceSpan isn’t evaluated eagerly any more.

Browse Source
This commit is contained in:
Rob Rix 2016-08-15 17:41:13 -04:00
parent fddb9dd90a
commit 5a979aaf5b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/TreeSitter.hs
View File

@ -116,6 +116,7 @@ documentToTerm language document blob = alloca $ \ root -> do
, spanEnd = SourcePos (fromIntegral $ ts_node_p_end_point_row node) (fromIntegral $ ts_node_p_end_point_column node) }
-- Note: The strict application here is semantically important. Without it, we may not evaluate the range until after we’ve exited the scope that `node` was allocated within, meaning `alloca` will free it & other stack data may overwrite it.
-- We don’t evaluate `sourceSpan` eagerly so that terms which don’t use it don’t pay the toll for it. This places the onus for evaluating it on the termConstructor function.
let info = range `seq` range .: (categoriesForLanguage language (toS name)) .: RNil
pure $! termConstructor (source blob) sourceSpan info children
getChild node n out = ts_node_p_named_child node n out >> toTerm out