1
1
mirror of https://github.com/github/semantic.git synced 2024-12-21 13:51:44 +03:00

Merge pull request #1726 from github/charliesome/ruby-method-calls

Add special Ruby.Syntax.Send node type
This commit is contained in:
Josh Vera 2018-04-09 13:19:18 -04:00 committed by GitHub
commit e6854fd5ef
48 changed files with 211 additions and 269 deletions

View File

@ -74,6 +74,7 @@ type Syntax = '[
, Syntax.Identifier
, Syntax.Paren
, Syntax.Program
, Ruby.Syntax.Send
, Ruby.Syntax.Class
, Ruby.Syntax.Load
, Ruby.Syntax.LowPrecedenceBoolean
@ -83,7 +84,8 @@ type Syntax = '[
]
type Term = Term.Term (Union Syntax) (Record Location)
type Assignment = HasCallStack => Assignment.Assignment [] Grammar Term
type Assignment' a = HasCallStack => Assignment.Assignment [] Grammar a
type Assignment = Assignment' Term
-- | Assignment from AST in Rubys grammar onto a program in Rubys syntax.
assignment :: Assignment
@ -291,9 +293,12 @@ pair :: Assignment
pair = makeTerm <$> symbol Pair <*> children (Literal.KeyValue <$> expression <*> (expression <|> emptyTerm))
methodCall :: Assignment
methodCall = makeTerm' <$> symbol MethodCall <*> children (require <|> load <|> regularCall)
methodCall = makeTerm' <$> symbol MethodCall <*> children (require <|> load <|> funcCall <|> regularCall)
where
regularCall = inj <$> (Expression.Call <$> pure [] <*> expression <*> args <*> (block <|> emptyTerm))
funcCall = inj <$> (Ruby.Syntax.Send Nothing <$> methodSelector <*> args <*> optional block)
regularCall = inj <$> (symbol Call *> children (Ruby.Syntax.Send <$> (Just <$> expression) <*> methodSelector) <*> args <*> optional block)
require = inj <$> (symbol Identifier *> do
s <- source
guard (s `elem` ["require", "require_relative"])
@ -302,14 +307,17 @@ methodCall = makeTerm' <$> symbol MethodCall <*> children (require <|> load <|>
s <- source
guard (s == "load")
Ruby.Syntax.Load <$> loadArgs)
args = (symbol ArgumentList <|> symbol ArgumentListWithParens) *> children (many expression) <|> pure []
args = (symbol ArgumentList <|> symbol ArgumentListWithParens) *> children (many expression) <|> many expression
loadArgs = (symbol ArgumentList <|> symbol ArgumentListWithParens) *> children (some expression)
nameExpression = (symbol ArgumentList <|> symbol ArgumentListWithParens) *> children expression
call :: Assignment
call = makeTerm <$> symbol Call <*> children (Expression.MemberAccess <$> expression <*> (expressions <|> args))
methodSelector :: Assignment
methodSelector = mk Identifier <|> mk Identifier'
where
args = (symbol ArgumentList <|> symbol ArgumentListWithParens) *> children expressions
mk s = makeTerm <$> symbol s <*> (Syntax.Identifier <$> (name <$> source))
call :: Assignment
call = makeTerm <$> symbol Call <*> children (Ruby.Syntax.Send <$> (Just <$> expression) <*> methodSelector <*> pure [] <*> optional block)
rescue :: Assignment
rescue = rescue'

View File

@ -36,6 +36,22 @@ maybeFailNotFound name = maybeFail notFound
cleanNameOrPath :: ByteString -> String
cleanNameOrPath = BC.unpack . dropRelativePrefix . stripQuotes
data Send a = Send { sendReceiver :: Maybe a, sendSelector :: a, sendArgs :: [a], sendBlock :: Maybe a }
deriving (Diffable, Eq, Foldable, Functor, GAlign, Generic1, Mergeable, Ord, Show, Traversable, FreeVariables1)
instance Eq1 Send where liftEq = genericLiftEq
instance Ord1 Send where liftCompare = genericLiftCompare
instance Show1 Send where liftShowsPrec = genericLiftShowsPrec
instance Evaluatable Send where
eval Send{..} = do
func <- case sendReceiver of
Just recv -> do
recvEnv <- subtermValue recv >>= scopedEnvironment
localEnv (mappend recvEnv) (subtermValue sendSelector)
Nothing -> subtermValue sendSelector -- TODO Does this require `localize` so we don't leak terms when resolving `sendSelector`?
call func (map subtermValue sendArgs) -- TODO pass through sendBlock
data Require a = Require { requireRelative :: Bool, requirePath :: !a }
deriving (Diffable, Eq, Foldable, Functor, GAlign, Generic1, Mergeable, Ord, Show, Traversable, FreeVariables1)

View File

@ -5,7 +5,6 @@
(
(Try
{ ([])
->(Call
->(Send
{+(Identifier)+}
{+(TextElement)+}
{+(Empty)+}) }))))
{+(TextElement)+}) }))))

View File

@ -4,8 +4,7 @@
(Identifier)
(
(Try
{ (Call
{ (Send
{-(Identifier)-}
{-(TextElement)-}
{-(Empty)-})
{-(TextElement)-})
->([]) }))))

View File

@ -4,7 +4,6 @@
(Identifier)
(
(Try
(Call
(Send
(Identifier)
(TextElement)
(Empty))))))
(TextElement))))))

View File

@ -1,12 +1,10 @@
(Program
(Try
(
(Call
(Identifier)
(Empty))
(Send
(Identifier))
(Else
(Empty)
{ ([])
->(Call
{+(Identifier)+}
{+(Empty)+}) }))))
->(Send
{+(Identifier)+}) }))))

View File

@ -1,12 +1,10 @@
(Program
(Try
(
(Call
(Identifier)
(Empty))
(Send
(Identifier))
(Else
(Empty)
{ (Call
{-(Identifier)-}
{-(Empty)-})
{ (Send
{-(Identifier)-})
->([]) }))))

View File

@ -1,9 +1,8 @@
(Program
(Try
(
(Call
(Identifier)
(Empty))
(Send
(Identifier))
(Else
(Empty)
([])))))

View File

@ -1,11 +1,9 @@
(Program
(Try
(
(Call
(Identifier)
(Empty))
(Send
(Identifier))
(Else
(Empty)
(Call
(Identifier)
(Empty))))))
(Send
(Identifier))))))

View File

@ -2,13 +2,11 @@
(If
(Identifier)
(
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))
(If
(Identifier)
(
{+(Call
{+(Identifier)+}
{+(Empty)+})+})
{+(Send
{+(Identifier)+})+})
(Empty))))

View File

@ -2,13 +2,11 @@
(If
(Identifier)
(
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))
(If
(Identifier)
([]
{-(Call
{-(Identifier)-}
{-(Empty)-})-})
{-(Send
{-(Identifier)-})-})
(Empty))))

View File

@ -2,9 +2,8 @@
(If
(Identifier)
(
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))
(If
(Identifier)
([])

View File

@ -2,13 +2,11 @@
(If
(Identifier)
(
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))
(If
(Identifier)
(
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))
(Empty))))

View File

@ -6,10 +6,9 @@
{+(Integer)+}
{+(Integer)+}
{+(Integer)+})+}
{+(Call
{+(Send
{+(Identifier)+}
{+(Identifier)+}
{+(Empty)+})+})+}
{+(Identifier)+})+})+}
{-(ForEach
{-(
{-(Identifier)-})-}

View File

@ -22,10 +22,9 @@
{+(Integer)+}
{+(Integer)+}
{+(Empty)+}) }
{ (Call
{ (Send
{-(Identifier)-}
{-(Identifier)-}
{-(Empty)-})
{-(Identifier)-})
->(Boolean) })
{+(ForEach
{+(

View File

@ -6,7 +6,6 @@
(Integer)
(Integer)
(Integer))
(Call
(Send
(Identifier)
(Identifier)
(Empty))))
(Identifier))))

View File

@ -1,12 +1,9 @@
(Program
{+(Call
{+(MemberAccess
{+(Call
{+(Identifier)+}
{+(TextElement)+}
{+(TextElement)+}
{+(Empty)+})+}
{+(Identifier)+})+}
{+(Empty)+})+}
{+(Send
{+(Send
{+(Identifier)+}
{+(TextElement)+}
{+(TextElement)+})+}
{+(Identifier)+})+}
{-(TextElement)-}
{-(TextElement)-})

View File

@ -1,12 +1,9 @@
(Program
{+(TextElement)+}
{+(TextElement)+}
{-(Call
{-(MemberAccess
{-(Call
{-(Identifier)-}
{-(TextElement)-}
{-(TextElement)-}
{-(Empty)-})-}
{-(Identifier)-})-}
{-(Empty)-})-})
{-(Send
{-(Send
{-(Identifier)-}
{-(TextElement)-}
{-(TextElement)-})-}
{-(Identifier)-})-})

View File

@ -1,10 +1,7 @@
(Program
(Call
(MemberAccess
(Call
(Identifier)
(TextElement)
(TextElement)
(Empty))
(Identifier))
(Empty)))
(Send
(Send
(Identifier)
(TextElement)
(TextElement))
(Identifier)))

View File

@ -1,9 +1,8 @@
(Program
{-(Call
{-(Send
{-(Identifier)-}
{-(Hash)-}
{-(Empty)-})-}
(Call
{-(Hash)-})-}
(Send
(Identifier)
(Function
(Empty)
@ -12,7 +11,7 @@
->(Plus
{+(Identifier)+}
{+(Integer)+}) }))
{-(Call
{-(Send
{-(Identifier)-}
{-(Function
{-(Empty)-}

View File

@ -1,9 +1,8 @@
(Program
{+(Call
{+(Send
{+(Identifier)+}
{+(Hash)+}
{+(Empty)+})+}
(Call
{+(Hash)+})+}
(Send
(Identifier)
(Function
(Empty)
@ -12,7 +11,7 @@
{-(Identifier)-}
{-(Integer)-})
->(Identifier) }))
{+(Call
{+(Send
{+(Identifier)+}
{+(Function
{+(Empty)+}

View File

@ -1,14 +1,13 @@
(Program
(Call
(Send
(Identifier)
(Hash)
(Empty))
(Call
(Hash))
(Send
(Identifier)
(Function
(Empty)
(Identifier)))
(Call
(Send
(Identifier)
(Function
(Empty)

View File

@ -1,5 +1,5 @@
(Program
(Call
(Send
(Identifier)
(Function
(Empty)

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Symbol)
(Boolean))
{+(KeyValue
{+(Symbol)+}
{+(Integer)+})+}
(Empty)))
{+(Integer)+})+}))

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Symbol)
(Boolean))
{-(KeyValue
{-(Symbol)-}
{-(Integer)-})-}
(Empty)))
{-(Integer)-})-}))

View File

@ -1,7 +1,6 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Symbol)
(Boolean))
(Empty)))
(Boolean))))

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Symbol)
(Boolean))
(KeyValue
(Symbol)
(Integer))
(Empty)))
(Integer))))

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Identifier)
(Boolean))
{+(KeyValue
{+(Identifier)+}
{+(Integer)+})+}
(Empty)))
{+(Integer)+})+}))

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Identifier)
(Boolean))
{-(KeyValue
{-(Identifier)-}
{-(Integer)-})-}
(Empty)))
{-(Integer)-})-}))

View File

@ -1,7 +1,6 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Identifier)
(Boolean))
(Empty)))
(Boolean))))

View File

@ -1,10 +1,9 @@
(Program
(Call
(Send
(Identifier)
(KeyValue
(Identifier)
(Boolean))
(KeyValue
(Identifier)
(Integer))
(Empty)))
(Integer))))

View File

@ -1,11 +1,9 @@
(Program
(Call
{ (MemberAccess
{-(Identifier)-}
{-(Identifier)-})
->(Identifier) }
(Empty))
{-(Call
(Send
{-(Identifier)-}
{ (Identifier)
->(Identifier) })
{-(Send
{-(Identifier)-}
{-(Identifier)-}
{-(Identifier)-}
@ -14,16 +12,13 @@
{-(Integer)-})-}
{-(KeyValue
{-(Identifier)-}
{-(Integer)-})-}
{-(Empty)-})-}
{-(Call
{-(Integer)-})-})-}
{-(Send
{-(Identifier)-}
{-(Call
{-(Send
{-(Identifier)-}
{-(Identifier)-}
{-(Empty)-})-}
{-(Empty)-})-}
{-(Call
{-(Identifier)-})-})-}
{-(Send
{-(Identifier)-}
{-(KeyValue
{-(Array)-}
@ -35,5 +30,4 @@
{-(Identifier)-}
{-(Function
{-(Empty)-}
{-(Integer)-})-})-}
{-(Empty)-})-})
{-(Integer)-})-})-})-})

View File

@ -1,11 +1,9 @@
(Program
(Call
(Send
{+(Identifier)+}
{ (Identifier)
->(MemberAccess
{+(Identifier)+}
{+(Identifier)+}) }
(Empty))
{+(Call
->(Identifier) })
{+(Send
{+(Identifier)+}
{+(Identifier)+}
{+(Identifier)+}
@ -14,16 +12,13 @@
{+(Integer)+})+}
{+(KeyValue
{+(Identifier)+}
{+(Integer)+})+}
{+(Empty)+})+}
{+(Call
{+(Integer)+})+})+}
{+(Send
{+(Identifier)+}
{+(Call
{+(Send
{+(Identifier)+}
{+(Identifier)+}
{+(Empty)+})+}
{+(Empty)+})+}
{+(Call
{+(Identifier)+})+})+}
{+(Send
{+(Identifier)+}
{+(KeyValue
{+(Array)+}
@ -35,5 +30,4 @@
{+(Identifier)+}
{+(Function
{+(Empty)+}
{+(Integer)+})+})+}
{+(Empty)+})+})
{+(Integer)+})+})+})+})

View File

@ -1,10 +1,8 @@
(Program
(Call
(MemberAccess
(Identifier)
(Identifier))
(Empty))
(Call
(Send
(Identifier)
(Identifier))
(Send
(Identifier)
(Identifier)
(Identifier)
@ -13,16 +11,13 @@
(Integer))
(KeyValue
(Identifier)
(Integer))
(Empty))
(Call
(Integer)))
(Send
(Identifier)
(Call
(Send
(Identifier)
(Identifier)
(Empty))
(Empty))
(Call
(Identifier)))
(Send
(Identifier)
(KeyValue
(Array)
@ -34,5 +29,4 @@
(Identifier)
(Function
(Empty)
(Integer)))
(Empty)))
(Integer)))))

View File

@ -1,4 +1,3 @@
(Program
(Call
(Identifier)
(Empty)))
(Send
(Identifier)))

View File

@ -1,25 +1,17 @@
(Program
{+(Call
{+(Send
{+(Identifier)+}
{+(TextElement)+}
{+(Empty)+})+}
{+(Call
{+(MemberAccess
{+(Identifier)+}
{+(Identifier)+})+}
{+(Empty)+})+}
{+(Call
{+(Identifier)+}
{+(Integer)+}
{+(Integer)+}
{+(Empty)+})+}
{+(Call
{+(Identifier)+}
{+(Integer)+}
{+(Integer)+}
{+(Empty)+})+}
{+(TextElement)+})+}
{-(Identifier)-}
{-(MemberAccess
{-(Identifier)-}
{-(Identifier)-})-}
(Send
(Identifier)
(Identifier))
{+(Send
{+(Identifier)+}
{+(Integer)+}
{+(Integer)+})+}
{+(Send
{+(Identifier)+}
{+(Integer)+}
{+(Integer)+})+}
{-(Identifier)-})

View File

@ -1,25 +1,17 @@
(Program
{+(Identifier)+}
{+(MemberAccess
{+(Identifier)+}
{+(Identifier)+})+}
{-(Send
{-(Identifier)-}
{-(TextElement)-})-}
(Send
(Identifier)
(Identifier))
{+(Identifier)+}
{-(Call
{-(Identifier)-}
{-(TextElement)-}
{-(Empty)-})-}
{-(Call
{-(MemberAccess
{-(Identifier)-}
{-(Identifier)-})-}
{-(Empty)-})-}
{-(Call
{-(Send
{-(Identifier)-}
{-(Integer)-}
{-(Integer)-}
{-(Empty)-})-}
{-(Call
{-(Integer)-})-}
{-(Send
{-(Identifier)-}
{-(Integer)-}
{-(Integer)-}
{-(Empty)-})-})
{-(Integer)-})-})

View File

@ -1,6 +1,6 @@
(Program
(Identifier)
(MemberAccess
(Send
(Identifier)
(Identifier))
(Identifier))

View File

@ -1,20 +1,15 @@
(Program
(Call
(Send
(Identifier)
(TextElement)
(Empty))
(Call
(MemberAccess
(Identifier)
(Identifier))
(Empty))
(Call
(TextElement))
(Send
(Identifier)
(Identifier))
(Send
(Identifier)
(Integer)
(Integer)
(Empty))
(Call
(Integer))
(Send
(Identifier)
(Integer)
(Integer)
(Empty)))
(Integer)))

View File

@ -37,17 +37,17 @@
{-(Identifier)-})-}
{-(Assignment
{-(
{-(MemberAccess
{-(Send
{-(Identifier)-}
{-(Identifier)-})-}
{-(MemberAccess
{-(Send
{-(Identifier)-}
{-(Identifier)-})-})-}
{-(
{-(MemberAccess
{-(Send
{-(Identifier)-}
{-(Identifier)-})-}
{-(MemberAccess
{-(Send
{-(Identifier)-}
{-(Identifier)-})-})-})-}
{-(Assignment

View File

@ -37,17 +37,17 @@
{+(Identifier)+})+}
{+(Assignment
{+(
{+(MemberAccess
{+(Send
{+(Identifier)+}
{+(Identifier)+})+}
{+(MemberAccess
{+(Send
{+(Identifier)+}
{+(Identifier)+})+})+}
{+(
{+(MemberAccess
{+(Send
{+(Identifier)+}
{+(Identifier)+})+}
{+(MemberAccess
{+(Send
{+(Identifier)+}
{+(Identifier)+})+})+})+}
{+(Assignment

View File

@ -36,17 +36,17 @@
(Identifier))
(Assignment
(
(MemberAccess
(Send
(Identifier)
(Identifier))
(MemberAccess
(Send
(Identifier)
(Identifier)))
(
(MemberAccess
(Send
(Identifier)
(Identifier))
(MemberAccess
(Send
(Identifier)
(Identifier))))
(Assignment

View File

@ -1,5 +1,5 @@
(Program
{(Equal
{ (Equal
{-(Identifier)-}
{-(Identifier)-})
->(Comparison
@ -10,11 +10,12 @@
{+(Identifier)+})+}
{+(Assignment
{+(Identifier)+}
{+(Not{+(Identifier)+})+})+}
{+(Not
{+(Identifier)+})+})+}
{-(Not
{-(Equal
{-(Identifier)-}
{-(Identifier)-})-})-}
{-(Equal
{-(Identifier)-}
{-(Identifier)-})- })
{-(Identifier)-})-})

View File

@ -1,5 +1,5 @@
(Program
{(Comparison
{ (Comparison
{-(Identifier)-}
{-(Identifier)-})
->(Equal
@ -17,4 +17,5 @@
{-(Identifier)-})-}
{-(Assignment
{-(Identifier)-}
{-(Not{-(Identifier)-})-})- })
{-(Not
{-(Identifier)-})-})-})

View File

@ -2,10 +2,9 @@
(Require
{ (TextElement)
->(TextElement) })
(Call
(Send
{ (Identifier)
->(Identifier) }
{+(Symbol)+}
{+(TextElement)+}
{-(Identifier)-}
(Empty)))
{-(Identifier)-}))

View File

@ -2,10 +2,9 @@
(Require
{ (TextElement)
->(TextElement) })
(Call
(Send
{ (Identifier)
->(Identifier) }
{+(Identifier)+}
{-(Symbol)-}
{-(TextElement)-}
(Empty)))
{-(TextElement)-}))

View File

@ -1,7 +1,6 @@
(Program
(Require
(TextElement))
(Call
(Send
(Identifier)
(Identifier)
(Empty)))
(Identifier)))

View File

@ -1,8 +1,7 @@
(Program
(Require
(TextElement))
(Call
(Send
(Identifier)
(Symbol)
(TextElement)
(Empty)))
(TextElement)))