github/semantic
1
1
Fork 0
mirror of https://github.com/github/semantic.git synced 2024-12-24 23:42:31 +03:00
Code Issues Projects Releases Wiki Activity

Generalize Constraint over the name type.

Browse Source
This commit is contained in:
Rob Rix 2019-10-11 11:39:32 -04:00
parent 7e51f43451
commit f87f7c0d0d
No known key found for this signature in database
GPG Key ID: F188A01508EA1CF7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
semantic-core/src/Analysis/Typecheck.hs
View File

@ -140,7 +140,7 @@ runFile eval file = traverse run file
. (\ m -> do
(cs, t) <- m
t <$ solve cs)
. runState (Set.empty :: Set.Set Constraint)
. runState (Set.empty :: Set.Set (Constraint name))
. (\ m -> do
v <- meta
bs <- m
@ -151,7 +151,7 @@ typecheckingAnalysis
:: ( Alternative m
, Carrier sig m
, Member Fresh sig
, Member (State (Set.Set Constraint)) sig
, Member (State (Set.Set (Constraint Name))) sig
, Member (State (Heap Name (Type Name))) sig
)
=> Analysis term Name Name (Type Name) m
@ -188,7 +188,7 @@ typecheckingAnalysis = Analysis{..}
_ ... m = pure (Just m)
data Constraint = Type Name :===: Type Name
data Constraint name = Type name :===: Type name
deriving (Eq, Ord, Show)
infix 4 :===:
@ -202,14 +202,14 @@ infix 5 :=
meta :: (Carrier sig m, Member Fresh sig) => m (Type Name)
meta = pure <$> Fresh.fresh
unify :: (Carrier sig m, Member (State (Set.Set Constraint)) sig) => Type Name -> Type Name -> m ()
unify :: (Carrier sig m, Member (State (Set.Set (Constraint Name))) sig) => Type Name -> Type Name -> m ()
unify t1 t2
| t1 == t2 = pure ()
| otherwise = modify (<> Set.singleton (t1 :===: t2))
type Substitution name = IntMap.IntMap (Type name)
solve :: (Carrier sig m, Member (State (Substitution Name)) sig, MonadFail m) => Set.Set Constraint -> m ()
solve :: (Carrier sig m, Member (State (Substitution Name)) sig, MonadFail m) => Set.Set (Constraint Name) -> m ()
solve cs = for_ cs solve
where solve = \case
-- FIXME: how do we enforce proper subtyping? row polymorphism or something?