Josh Vera
ffe99f84d9
Merge pull request #733 from github/account-for-false-positives
...
Account for false positives
2016-08-18 15:04:57 -04:00
Rob Rix
6765a9e764
Use the default parameters when diffing.
2016-08-18 14:04:25 -04:00
Rob Rix
00689650dd
Use the defaultFeatureVectorDecorator in the tests.
2016-08-18 14:03:36 -04:00
Rob Rix
1473c10659
Add a defaultFeatureVectorDecorator function.
2016-08-18 14:02:48 -04:00
Rob Rix
900a0b7a1f
Use the global l/m defaults.
2016-08-18 14:00:40 -04:00
Rob Rix
3e01b1cd13
Add bindings for the default values of the variables.
2016-08-18 13:59:34 -04:00
Rob Rix
2706ed262e
Rename constantTimeEditDistance to editDistanceUpTo.
2016-08-18 13:44:27 -04:00
Rob Rix
627ae0552c
Revert "Extract a Comparator type synonym."
...
This reverts commit 1aa2b093f0f45815b73c8ad172cf507d2d7ed6ec.
2016-08-18 12:54:52 -04:00
Rob Rix
3fb0ba5ddf
constantTimeEditDistance takes a diff.
2016-08-18 12:54:41 -04:00
Rob Rix
d169e6fa66
Spacing.
2016-08-18 12:51:07 -04:00
Rob Rix
12f6ce9fa4
Merge remote-tracking branch 'origin/account-for-false-positives' into account-for-false-positives
2016-08-18 12:50:26 -04:00
Rob Rix
f49527a268
Export constantTimeEditDistance.
2016-08-18 12:50:15 -04:00
Rob Rix
ddbcb0cd18
Roll diffCostOfMaybes into constantTimeEditDistance.
2016-08-18 12:50:03 -04:00
Rick Winfrey
52ace63c81
Merge branch 'account-for-false-positives' of github.com:github/semantic-diff into account-for-false-positives
2016-08-18 11:49:33 -05:00
Rob Rix
e063d7e0cd
constantTimeEditDistance is computed over terms.
2016-08-18 12:49:17 -04:00
Rob Rix
a184d5ad4b
Extract constantTimeEditDistance to the top level.
2016-08-18 12:48:13 -04:00
Rob Rix
f2c5e88801
Extract a Comparator type synonym.
2016-08-18 12:48:01 -04:00
Rob Rix
29a0db2675
📝 l & m.
2016-08-18 12:42:57 -04:00
Rob Rix
ab2dfacab6
Bind a variable for m.
2016-08-18 12:38:39 -04:00
Rob Rix
0c4921b58c
Bind a variable for l.
2016-08-18 12:38:28 -04:00
Rob Rix
3832a7b90f
📝 constantTimeEditDistance.
2016-08-18 12:35:24 -04:00
Rob Rix
ffad7170f0
Spacing.
2016-08-18 12:31:46 -04:00
Rob Rix
768703dc7e
📝 nearestUnmapped.
2016-08-18 12:27:26 -04:00
Rob Rix
b14a7765e6
Copy in b.
2016-08-18 11:40:39 -04:00
Rob Rix
ecaff655c1
Extract a function to copy terms in.
2016-08-18 11:40:33 -04:00
Rob Rix
cabf1a887e
Compute recursive as copies instead of replacements.
...
This should make us more accurate to the tests of Interpreter.
2016-08-18 11:37:55 -04:00
Rob Rix
02bb72ee0b
Move compare to the where clause.
2016-08-18 11:25:21 -04:00
Rob Rix
8aa0f082a6
Bump _q_ in all of the specs.
...
Figure it’s best if they use the same value for the parameter.
2016-08-18 11:23:21 -04:00
joshvera
6d29088336
Update test cases
2016-08-18 11:20:18 -04:00
Rob Rix
d17f76bc60
Take surrounding context into account when computing bases.
...
```
1 `div` 2 = 0
2 `div` 2 = 1
3 `div` 2 = 1
```
etc.
This means that given _q_ = 3, the base for b in [a, b, c, d] will be
[a, b, c] instead of [b, c, d]. This means that grams encode limited
sibling ordering information both forwards and backwards, making them
slightly more stable.
2016-08-18 11:14:37 -04:00
joshvera
fbb108d7a1
Don't use toLower
2016-08-18 11:05:28 -04:00
Rob Rix
c3e0e9e7d4
Bump _q_ to 3.
2016-08-18 11:01:27 -04:00
Rob Rix
4cc090e92b
Use Int instead of Integer.
2016-08-18 10:52:49 -04:00
Rob Rix
ceab42bab3
Merge branch 'master' into account-for-false-positives
2016-08-18 10:37:02 -04:00
joshvera
b6cf282d2b
Move Error doc calculation to summaries
2016-08-18 10:27:07 -04:00
joshvera
5d8cfe826d
Prefix errors with Error:
2016-08-18 09:58:23 -04:00
Rob Rix
81853cf41b
Merge pull request #731 from github/binary-relations-are-relational
...
Add RelationalOperator to replace generic BinaryOperator category
2016-08-18 09:26:36 -04:00
Rick Winfrey
d9d743f292
Merge branch 'master' into binary-relations-are-relational
2016-08-17 16:31:04 -05:00
Rick Winfrey
a36583014a
Merge pull request #729 from github/method-call-improvements
...
Method call improvements
2016-08-17 16:27:15 -05:00
Rick Winfrey
b86b3218dc
Merge branch 'master' into method-call-improvements
2016-08-17 16:20:01 -05:00
Rick Winfrey
11d6362997
Preserve original hashed value for Category
2016-08-17 16:12:40 -05:00
joshvera
2c04be022d
Remove unused comment
2016-08-17 16:35:48 -04:00
joshvera
2df90eada7
Account for false positive close terms
...
Improve nearestUnmapped by looking up the nearest unmapped term which is not a false positive. We look up the nearest unmapped terms closest to the query term, then sort by the constant time edit distance between the query term and the intersecting terms. Finally, we select the first term that has the lowest edit distance.
2016-08-17 16:34:58 -04:00
Rick Winfrey
1b542a89ba
Promote "rel_op" to general language production
2016-08-17 11:55:20 -05:00
Rick Winfrey
95582bb798
Account for RelationalOperator in diff summaries
2016-08-17 11:54:53 -05:00
Rick Winfrey
ed3fab42c3
Render RelationalOperator
2016-08-17 11:54:40 -05:00
Rick Winfrey
e0f28282e8
Add RelationalOperator constructor to list of operators
2016-08-17 11:54:30 -05:00
Rick Winfrey
349b268884
Add RelationalOperator constructor for Category
2016-08-17 11:54:16 -05:00
Josh Vera
9ecdd27a13
Merge pull request #730 from github/make-binary-wise-to-bitwise
...
Enhance diff summary output to identify bitwise operators
2016-08-17 12:39:25 -04:00
Rick Winfrey
2fa8f1487e
Submodule update
2016-08-17 11:17:09 -05:00
