Timothy Clem
b28fb749e8
Start to build the diff interface back up
2019-01-21 15:52:00 -07:00
Timothy Clem
3527f676e0
Whitespace
2019-01-21 15:51:38 -07:00
Rick Winfrey
736ead4ade
Update fixtures
2019-01-18 18:21:36 -08:00
Rick Winfrey
e7c984182c
Update specs
2019-01-18 18:21:24 -08:00
Rick Winfrey
2eccafcecb
Rename fields from visibility -> accessControl
2019-01-18 18:21:07 -08:00
Rick Winfrey
27feb45a4b
Regen protos
2019-01-18 18:20:36 -08:00
Rick Winfrey
ffc9437891
Fix order of Ruby's Declaration.Method
parameters
2019-01-18 17:34:58 -08:00
Timothy Clem
fd88f143b2
Format
2019-01-18 16:13:47 -08:00
Timothy Clem
154e0388af
Goodbye Semantic.Parse
2019-01-18 16:04:23 -08:00
Timothy Clem
dad86f11e7
No more TermRenderer and all tests passing
2019-01-18 15:54:55 -08:00
Rick Winfrey
056fd8eddf
Regenerate protos
2019-01-18 15:43:04 -08:00
Rick Winfrey
c99dfc6d0f
Clean up old fixture
2019-01-18 14:09:00 -08:00
Rick Winfrey
b79638ab7d
Add string based private method spec for now
2019-01-18 14:08:48 -08:00
Rick Winfrey
30ef3ab52b
Imports
2019-01-18 14:08:36 -08:00
Timothy Clem
9f222adcd3
Show and Quiet outputs
2019-01-18 12:37:49 -08:00
Timothy Clem
faa8c0f20c
Nope
2019-01-18 12:37:31 -08:00
Timothy Clem
e45e1669e7
Format
2019-01-18 09:38:48 -08:00
Timothy Clem
f23110a73a
Transition sexpression term rendering
2019-01-18 09:29:51 -08:00
Rick Winfrey
0639353cd1
Add private method fixture
2019-01-17 17:51:27 -08:00
Rick Winfrey
9c887e7eee
Ensure private static field definitions are not accessible by external member access
2019-01-17 17:21:16 -08:00
Rick Winfrey
a5fcc3f1df
Ensure private field definitions throw when accessed via external syntax
2019-01-17 17:17:53 -08:00
Timothy Clem
45df906304
Not using these
2019-01-17 16:40:16 -08:00
Timothy Clem
c5fb6a5697
Support the legacy diff summary format
2019-01-17 16:38:12 -08:00
Timothy Clem
d39b019c3b
Get the structure right for new toc summaries response
2019-01-17 16:30:48 -08:00
Timothy Clem
15643e1d4f
Switch over ToCDiffRenderer (will fix the tests next)
2019-01-17 15:58:49 -08:00
Timothy Clem
d8ef1c1f40
Fix up tests
2019-01-17 15:36:56 -08:00
Timothy Clem
43b6656f22
Serialize to proto as well for fun
2019-01-17 15:36:51 -08:00
Timothy Clem
30f937ecf0
Cleanup
2019-01-17 15:36:43 -08:00
Timothy Clem
5dc2ac2d04
Rename
2019-01-17 15:36:37 -08:00
Timothy Clem
e3afd9d684
Symbol rendering is entirely on the new path
2019-01-17 15:13:39 -08:00
Rick Winfrey
4998421038
Compare directly against SomeError ...
rather than String
values
...
Co-Authored-By: Rob Rix <robrix@github.com>
2019-01-17 14:02:54 -08:00
Rick Winfrey
548cfb9dd3
Add AccessControlError
to Eq1 instance of EvalError
...
This was preventing the specs from allowing an equality check of `AccessControlError`s, resulting in a strange null diff that appeared to be wrong (but was defaulting to `False` because `AccessControlError` was in the fall through case)
Co-Authored-By: Rob Rix <robrix@github.com>
2019-01-17 14:01:58 -08:00
Timothy Clem
8d5d3e45da
Factor back in the toc summary endpoint, now supported in twirp too
2019-01-17 14:00:13 -08:00
Rick Winfrey
c7b1d13ab0
Compare against strings
2019-01-17 12:50:33 -08:00
Rick Winfrey
ad57ac0967
Add missing case
2019-01-17 10:45:58 -08:00
Rick Winfrey
d4abe75456
Merge branch 'master' into visibility-resolution
2019-01-16 18:31:44 -08:00
Rick Winfrey
bf3ff6154a
Update tests for new AccessControl / Relation split
2019-01-16 18:20:33 -08:00
Rick Winfrey
12e63cac6d
Comment this for now
2019-01-16 18:19:51 -08:00
Rick Winfrey
2ba74ef97d
Fix lints
2019-01-16 18:19:38 -08:00
Rick Winfrey
b407882093
Provide convenience function for loookup of declaration info within a scope by name
2019-01-16 18:05:18 -08:00
Rick Winfrey
17e43eb226
Add AccessControlError
2019-01-16 18:04:24 -08:00
Rick Winfrey
39b056df47
Update name to be more accurate
2019-01-16 17:26:39 -08:00
Rick Winfrey
5076caa2d5
Reflow
2019-01-16 17:25:49 -08:00
Rick Winfrey
5f5df139ed
Update lookupDeclaration
to lookupSlot
...
The old name can be confusing, but we are actually returning `Slot` values from this function, not a `Declaration` or `Info`.
2019-01-16 17:25:18 -08:00
Timothy Clem
f38e10a9e6
Just remove this
2019-01-16 16:13:39 -08:00
Timothy Clem
8346f6aaa2
Start to fill out toc summaries endpoint
2019-01-16 15:49:36 -08:00
Timothy Clem
01af025638
Move parse back into semantic
2019-01-16 15:39:07 -08:00
Timothy Clem
8d989cdead
Remove crazy term and diff language specific protos
2019-01-16 12:41:32 -08:00
Ayman Nadeem
da6dd46bfe
Merge pull request #2299 from github/factor-abstract-value-as-value-effects
...
Factor AbstractValue as value effects
2019-01-16 14:18:12 -05:00
Ayman Nadeem
cef0b1cdb6
make sure haskell-tree-sitter reflects master
2019-01-16 13:53:07 -05:00