Rob Rix
6de5e73219
Inline the definition of termVector.
2017-02-08 15:47:50 -05:00
Rob Rix
ce59dfba8b
Merge remote-tracking branch 'origin/master' into cache-and-discard-feature-vectors
2017-02-08 15:44:52 -05:00
Timothy Clem
a3a895d107
Another iterator for go method toc summaries
2017-02-08 10:57:13 -08:00
Rob Rix
7aed25cccd
Remove the fallback to termVector, as it’s redundant.
2017-02-08 12:18:17 -05:00
Rob Rix
d9e44ede6c
📝 modifyAnnotations.
2017-02-08 12:04:05 -05:00
Rob Rix
051916082a
Correct a misleading comment.
2017-02-08 12:03:50 -05:00
Rob Rix
f19a1fdfbf
Add a function to modify the annotation of a top-level diff node.
2017-02-08 12:03:10 -05:00
Rob Rix
d102c6a13a
Don’t re-erase vectors.
2017-02-08 11:54:14 -05:00
Rob Rix
223b836612
Erase feature vectors for the empty/nonempty cases.
2017-02-08 11:53:19 -05:00
Josh Vera
6cf8def01f
Merge pull request #986 from github/fix-go-method-receiver
...
Fix ordering of go Method shape in termAssignment
2017-02-08 11:51:25 -05:00
Timothy Clem
1bde86531e
Fix ordering of go Method shape in termAssignment
2017-02-08 08:43:04 -08:00
Rob Rix
398bb62d16
Merge remote-tracking branch 'origin/master' into cache-and-discard-feature-vectors
2017-02-08 11:36:52 -05:00
Rob Rix
93937a1bf9
Fix the tests.
2017-02-08 11:15:37 -05:00
Josh Vera
ad23047c91
Merge pull request #984 from github/one-more-tree-sitter-ruby-bump
...
++tree-sitter-ruby
2017-02-08 11:01:49 -05:00
Timothy Clem
660104e874
++tree-sitter-ruby
2017-02-08 07:53:44 -08:00
Rob Rix
33e533cf29
Merge pull request #982 from github/update-ruby
...
Bump tree-sitter-ruby
2017-02-08 07:27:47 -05:00
Timothy Clem
047bcfcbcb
++tree-sitter-ruby
2017-02-07 15:59:12 -08:00
Timothy Clem
340975336f
Merge pull request #981 from github/method-declaration-receiver
...
Add receiver to shape of Method
2017-02-07 15:48:56 -08:00
Timothy Clem
ded960356a
Remove S.MemberAccess case entirely since it's now handled above
2017-02-07 15:20:27 -08:00
Timothy Clem
d2d2e2113f
Remove left over new_ruby.json
2017-02-07 14:53:49 -08:00
Timothy Clem
1675e0b4ee
Update go diff summaries tests
2017-02-07 14:53:36 -08:00
Timothy Clem
2f230a485e
Add receiver to Syntax.Method
2017-02-07 14:53:15 -08:00
Rob Rix
04cc05c20f
Erase the feature vector from equal terms.
2017-02-07 16:11:51 -05:00
Timothy Clem
bea1a841f8
Merge pull request #979 from github/fix-singleton-method-toc-summaries
...
Handle termAssignment for Ruby singleton method defs
2017-02-07 13:00:49 -08:00
Rob Rix
3a0c0c29a6
🔥 a redundant import.
2017-02-07 15:57:44 -05:00
Timothy Clem
f6dd81df71
Merge branch 'master' into fix-singleton-method-toc-summaries
2017-02-07 12:56:51 -08:00
Rob Rix
cee0bef699
🔥 eitherCutoff.
...
We don’t gain any value from `eitherCutoff`, because:
1. We compute diffs in O(1), only ever matching up equal terms (up to category).
2. We compute costs in O(1), mapping Pure (i.e. unmatched diffs) to 1 & Free to 0.
3. If SES were going to compute the cost of recursive diffs (which is what makes it O(n³) instead of just O(n²)), it would have done so before returning, i.e. mapping the results thus is null.
Thus, `eitherCutoff 1` is essentially the identity transformation for our purposes, and can safely be omitted.
/cc @joshvera.
2017-02-07 15:56:25 -05:00
Rob Rix
7d25fb7103
Revert "Erase the feature vectors from the copied portions of the diff."
...
This reverts commit 0e4d3fd887004941f92747f17538ec73a6e3095e.
2017-02-07 15:38:37 -05:00
Rob Rix
1598b2b417
I do not know how to git.
...
Merge branch 'cache-and-discard-feature-vectors' of https://github.com/github/semantic-diff into cache-and-discard-feature-vectors
2017-02-07 15:27:51 -05:00
Rob Rix
ddfadeaf6b
Erase the feature vectors from the copied portions of the diff.
2017-02-07 15:27:13 -05:00
Rob Rix
86a5f2f077
Define stripDiff in terms of mapAnnotations.
2017-02-07 15:27:13 -05:00
Rob Rix
9a39762d91
📝 the generalization.
2017-02-07 15:27:13 -05:00
Rob Rix
7263b683e5
Generalize the type of mapAnnotations slightly.
2017-02-07 15:27:13 -05:00
Rob Rix
bb46960dd8
📝 mapAnnotations.
2017-02-07 15:27:13 -05:00
Rob Rix
4a3dd9afd8
Define a function for mapping over the annotations in a diff.
2017-02-07 15:27:13 -05:00
Rob Rix
ef2bc957c1
Erase the feature vectors from patches.
2017-02-07 15:27:13 -05:00
Rob Rix
3814fb6968
Pull the feature vector setter out.
2017-02-07 15:27:13 -05:00
Rob Rix
b72e5fa730
Don’t erase feature vectors recursively.
2017-02-07 15:27:13 -05:00
Rob Rix
d5ba968315
Erase feature vectors during mapping.
2017-02-07 15:27:13 -05:00
Rob Rix
79dc68a497
Cache feature vectors in record annotations.
2017-02-07 15:27:13 -05:00
Timothy Clem
85afbd6df4
Handle termAssignment for Ruby singleton method defs
2017-02-07 11:59:18 -08:00
Rob Rix
de58d6c952
Erase the feature vectors from patches.
2017-02-07 14:33:15 -05:00
Rob Rix
492aafba89
Pull the feature vector setter out.
2017-02-07 14:29:44 -05:00
Rob Rix
a5065ec64f
Don’t erase feature vectors recursively.
2017-02-07 14:13:43 -05:00
Rob Rix
ba0df63a53
Erase feature vectors during mapping.
2017-02-07 14:06:28 -05:00
Rob Rix
0c8fb2e9a8
Cache feature vectors in record annotations.
2017-02-07 13:40:30 -05:00
Rob Rix
bd1e43b867
Merge pull request #953 from github/go-parser-fixes
...
Go parser fixes
2017-02-07 12:38:45 -05:00
joshvera
0535e54a42
update tests
2017-02-07 11:37:47 -05:00
joshvera
7553619356
Merge remote-tracking branch 'origin/master' into go-parser-fixes
2017-02-07 10:51:15 -05:00
Josh Vera
c59e1e1dd7
Merge pull request #976 from github/bump-tree-sitter-go
...
++tree-sitter-go for empty statements
2017-02-06 19:58:41 -05:00
