haskell-nix/hnix-store
1
1
Fork 0
mirror of https://github.com/haskell-nix/hnix-store.git synced 2024-08-17 13:51:21 +03:00
Code Issues Projects Releases Wiki Activity

remote: fix pretty TODO failing to parse on old GHC

Browse Source
This commit is contained in:
sorki 2023-12-10 18:53:47 +01:00
parent 3eb346699b
commit 29f58f46e7
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
hnix-store-remote/src/System/Nix/Store/Remote.hs
View File

@ -161,11 +161,10 @@ runDaemonSocket workerHelper postGreet sockFamily sockAddr k =
Network.Socket.Stream
Network.Socket.defaultProtocol
)
(\lsock -> liftIO $ Network.Socket.close lsock) -- *> System.Directory.removeFile f)
(\lsock -> liftIO $ Network.Socket.close lsock)
$ \lsock -> do
-- ^^^^^^^^^^^^
-- TODO: this: -------------------------------------------------------////////////
-- should really be
-- TODO: the: (\lsock -> liftIO $ Network.Socket.close lsock *> System.Directory.removeFile f)
-- branch should really be (and even removeFile is currently omitted)
-- a file lock followed by unlink *before* bind rather than after close. If
-- the program crashes (or loses power or something) then a stale unix
-- socket will stick around and prevent the daemon from starting. using a