on iko/ghcjs-patch-master help sign in
LicenseRef-OtherLicense is not `free = false` (#1006)

The [dependent-map](https://hackage.haskell.org/package/dependent-map) package for instance is not clear on which free license applies to which parts of the code, but that does not mean it is not free. `cabal2nix` maps LicenseRef-OtherLicense to `meta.license = "unknown"` `cabal-to-nix` and `haskell.nix` map it to a more detailed attribute set but it includes `free = false` and that causes packages like `dependent-map` to fail to install when `allowUnfree` has not been set. This change removes the `free` attribute altogether, which seems more principled than asserting that the `OtherLicense` cannot be `free`.

commit6e34587fc84413b0473e1673c782f1cf7daba665 authorHamish Mackenzie <Hamish.Mackenzie@iohk.io> dateWed 20 Jan 2021, 00:27 (6 years ago) parent505130b
1 file changed+2−1
lib/cabal-licenses.nix+2−1
lib/cabal-licenses.nix+2−1
@@ -14,7 +14,8 @@ in licenses // {
1414 shortName = "Other License";
1515 fullName = "Unidentified Other License";
1616 url = "https://spdx.github.io/spdx-spec/appendix-IV-SPDX-license-expressions/";
17− free = false;
17+ # Not setting `free` here. The license may or may not be `free`.
18+ # See https://github.com/input-output-hk/haskell.nix/pull/1006
1819 };
1920 NONE = null;
2021}