ghcide/test
Jacek Generowicz bbb75c2f95 Fix #248 and #250 (#267)
* Fix #248 and #250

This fixes hover for types, classes and type variables.

Information about spans includes a `Maybe Type` which is `Just` for data-level
expressions and `Nothing` for type-level expressions.

`AtPoint.atPoint` which is the oddly-named function responsible for constructing
hover information, runs in the `Maybe` monad, and aborted at the first sight of
a `Nothing`, thus producing no hover information for type-level spans.

In the process of fixing this, I have refactored the function to

+ separate the construction of data-level and type-level hover info

+ make the components that make up the hover info (and their construction) more
  clear

I can see plenty little improvements that could be made to the functionality of
the code (and lots that could be made to its organization), but the most
important fixes of the basic missing functionality are here.

Fix #248
Fix #250

* Revert behaviour of locationsAtPoint to match its name

The name suggests that it returns all locations, while the last commit changed
this to return at most one.

* Fix issue numbers in test titles

There was some confusion about which tests addressed issue 248 vs 249
2019-12-18 11:47:51 +01:00
..
cabal/Development/IDE/Test Enable more warnings for the ghcide codebase (#75) 2019-09-17 08:50:20 +02:00
data Fix #248 and #250 (#267) 2019-12-18 11:47:51 +01:00
exe Fix #248 and #250 (#267) 2019-12-18 11:47:51 +01:00
manual/lhs added unlit stage for literate Haskell source files 2019-09-11 11:56:26 +02:00
src/Development/IDE ghcide: make tests fail on unexpected diagnostic messages (#2813) (#2823) 2019-09-10 15:01:33 +02:00