Pepe Iborra d4fd99edb3 Interface file fixes (#645) ... * Add test for inconsistent diagnostics * Refactoring ModIfaceFromDisk This started as a pure refactoring to clarify the responsibilities between ModIface and ModIfaceFromDisk, but ended up having some behaviour changes: 1. Regenerate interface when checkOldIface returns something other than UpToDate. This was a bug. 2. Do not generate a diagnostic when regenerating an interface. 2. Previously we conflated stale interface with other errors, and would regenerate in both cases. Now we only regenerate in the first case. Tentative fix for #597 * Split interface tests * Always recompile modules with TH splices Tentative fix for #614 TODO support stability * Fix expectDiagnostics in MacOs * Avoid File does not exist diagnostics for interface files Fixes #642 * Clarify interface tests * hlints * Performance fixes The previous changes were 10X slower, this is 20X faster than those, so 2X faster than upstream, for some benchmarks * formatting * Fix GetModificationTime identity The answer for a GetModification query is independent of the missingFileDiagnostics field (as the diagnostics are not part of the answer) * remove stale comment * Avoid calling ghcSessionDepsDefinition twice * Apply suggestions from code review Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org> * Code review feedback * Address review feedback 49b0d9ac65 (r443383239) * Change recomp to direct cradle Co-authored-by: Zubin Duggal <zubin@cmi.ac.in> Co-authored-by: Moritz Kiefer <moritz.kiefer@purelyfunctional.org>		2020-06-23 11:01:52 +02:00
..
Main.hs	Interface file fixes (#645)	2020-06-23 11:01:52 +02:00