Commit Graph

25 Commits

Author SHA1 Message Date
Michael Peyton Jones
88c26eb796
Remove Pepe from CODEOWNERS (#4239) 2024-05-17 13:22:46 +00:00
fendor
16912ccebd
Add cabal-gild as a cabal file formatter plugin (#4101)
* Add cabal-gild as a cabal file formatter plugin

* Add support for multiple cabal formatters

In addition, allow different cabal file formatter provider to specify an
explicit file path, instead of searching only on $PATH.

* Fix cabal formatter test flags
2024-03-11 17:23:29 +00:00
Jan van Brügge
03d418c92c
hls-notes-plugin: Initial implementation (#4126)
* hls-notes-plugin: Initial implementation

* hls-notes-plugin: add to feature list and plugin table

* hls-notes-plugin: Add more documentation comments

* hls-notes-plugin: Fix tests after #3846, add CI job

* hls-notes-plugin: Address review comments

* hls-notes-plugin: Allow Note definition within single line comments

* hls-notes-plugin: Improve "Note not found" error message

* hls-notes-plugin: Allow single line notes to be indented

* treewide: Add missing underscores to note definitions

* hls-notes-plugin: Wait until HLS is done in tests

* hls-notes-plugin: Fix tests on windows

The regex did not allow windows line endings in note definitions

---------

Co-authored-by: Jan Hrcek <2716069+jhrcek@users.noreply.github.com>
Co-authored-by: fendor <fendor@users.noreply.github.com>
2024-03-11 15:19:51 +00:00
Michael Peyton Jones
2156ac2836
Remove some people from CODEOWNERS (#3930)
Also:
- Sort plugin list
- Add some missing components
- Add @soulomoon for semantic-tokens
2024-01-09 11:13:19 +00:00
Peter Becich
92d3ba9816
update Floskell to 0.11.* (#3933)
* update Floskell to 0.11.*

Floskell 0.11.* supports Aeson 2.2.*

* package version 2.5.0.0, Stack Floskell dependency, codeowner

* update GHC 9.4 Stack resolver

https://www.stackage.org/lts-21.25

remove duplicate `extra-deps`
2024-01-06 22:02:27 +00:00
0rphee
2bcdb04556 Add myself (@0rphee) to CODEOWNERS 2023-10-31 10:45:14 -06:00
fendor
168976d6f5
Cleanup func-test suite (#3828)
* Cleanup func-test suite

This test-suite is vastly legacy from Haskell IDE Engine.
It was originally written before we had a plugin-based architecture
where each plugin tests its feature in isolation.
Over time, this test-suite bitrotted, where a lot of testcases were
either redundant or out-of-date and consequentially disabled.

We clean up the test-suite, delete old tests and remove unused testdata.

* Remove unused config change

* Move qualified import tests to hls-refactor-plugin

* Add README for `func-test`

Provides guidance when to add a test to `func-test` and some historical
context.

* Add fendor as CODEOWNER for `func-test` and `hls-test-utils`

---------

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2023-10-09 13:04:34 +00:00
Michael Peyton Jones
bfaecfd03c
Delete hls-haddock-comments-plugin, hls-stan-plugin, and hls-tactics-plugin (#3782)
* Delete hls-haddock-comments-plugin

* Delete hls-stan-plugin

* Delete hls-tactics-plugin

* Fix a warning

* Delete some wingman stuff

* Workflows
2023-08-30 12:17:22 +01:00
Nathan Maxson
6111a100ab
Add resolve support in refine imports by merging it with explicit imports (#3729) 2023-08-01 01:03:08 +00:00
Haskell Man Sandy Savage
3d49025300
Remove isovector as an owner (#3700)
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-07-12 12:38:48 +00:00
Nathan Maxson
1edb4892a6
overloaded record dot plugin intial version (closes #3350) (#3560)
* overloaded record dot plugin initial version (closes #3350)

* Added support to GHC 9.2, and updated documentation

Also, update the CI to test overloaded-record-dot-plugin
and added overloaded-record-dot-plugin to stack.yml

* Apply suggestions from Lei Zhu (July541)

Co-authored-by: Lei Zhu <julytreee@gmail.com>

* Use GHC2021 and updated gif

* Fix test.yml formatting problem

* use coerce instead of unExt (from michaelpj)

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>

* Implements michaelpj code review suggestions

* Collect records on lists instead of maybe
This way we don't need to switch back and forward between the two,
and we can also return more than one match from inside a HsExpanded

* Added documentation

* Reworded comments for spelling and clarity

* use useWithStale for the TypeCheck rule

* Update version to conform with changes on master

* No longer depend on specific hls package versions

* Fixed comments and line length issues

* Added test for HsExpanded expressions

---------

Co-authored-by: Lei Zhu <julytreee@gmail.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2023-05-26 10:58:17 +00:00
Michael Peyton Jones
05051866b2
Delete the Brittany plugin (#3441)
It's unmaintained and not popular.

Fixes #3346.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2023-01-06 13:36:42 +00:00
Rune K. Svendsen
5dbbd852ab
Parse .cabal files; show error and warning diagnostics (#2954)
* Extract cabal plugin in its own package

* hls-cabal-plugin: Add plugin

Add golden parse test for test/testdata/simple.cabal
Add module Ide.Plugin.Cabal.Diag
Also: add -Wall

Add parseCabalFileContents
Use VFS for cabal file contents

Diagnostics
 * Parse and display Errors
 * Parse and display Warnings

Code Actions
 * Code Action for License Field

* Add CI workflow

* Add test-suite for hls-cabal-plugin

* Fix various cabal issues

* Update Codeowners file for hls-cabal-plugin

* Document Bytestring is UTF-8 encoded

Co-authored-by: Julian Ospald <hasufell@posteo.de>

* Remove code duplication

* Add cabal files of interest and kick function

Configure a "kick" function for cabal files that is run when the shake
queue needs to be restarted.
Copy pastes from ghcide and 'files of interest'. Maybe more abstraction
needed.

* Add more documentation

* Mark flaky test-case as flaky with issue ref

* Make fendor the only CODEOWNER for hls-cabal-plugin

* Add missing extra-source-files for hls-cabal-plugin

* Add proper CHANGELOG entry for the first version of hls-cabal-plugin

* Add support for Cabal 3.8

* Set diagnostics source to cabal

* Remove unused function

* Add unit tests for code action utilities

* Remove overly specific logging of diagnostics from hls-cabal-plugin

* Improve logging for Cabal FOIs

* Add Range manipulation functions

* Use Range manipulation functions from hls-plugin-api

* Add more documentation for crucial shake restart function

* Add hls-cabal-plugin features to features.md

* Re-use existing GetFileContents rule

Co-authored-by: Fendor <power.walross@gmail.com>
Co-authored-by: fendor <fendor@users.noreply.github.com>
Co-authored-by: Julian Ospald <hasufell@posteo.de>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-11-21 16:45:26 +00:00
Berk Özkütük
385dd1b57a
Add @ozkutuk to CODEOWNERS (#3329)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-11-11 18:53:07 +00:00
VeryMilkyJoe
7020532537
Add formatting plugin for cabal files which uses cabal-fmt (#2047)
* Add plugin for formatting cabal files using cabal-fmt

* Add 'isolateTests' cabal flag to make plugin install cabal-fmt

For CI, we want to run the tests with a specific cabal-fmt version,
installed automatically by cabal.
However, locally, we might want to test with a locally installed
cabal-fmt version.
This flag allows developers to either let cabal install the
build-tool-depends or install a fitting version locally.

* Ignore failing cabal-fmt test on windows

* Add log message for missing cabal-fmt executable

Co-authored-by: Jana Chadt <jana.chadt@tuwien.ac.at>
Co-authored-by: Fendor <power.walross@gmail.com>
2022-11-11 10:25:29 +00:00
santiweight
9d70df07e6
support "add argument" action (#3149)
* support add-argument action

* respond to review comments

* review: add ability to report errors in CodeAction api

* review: use already-defined function

* attempts at cpp

* fix format error

* fix broken test

* doc: add self to codeowners; add doc to features.md

* formatting

* formatting

* fix an import

* review

* formatting

* add testcase with comments

* fix build error

Co-authored-by: Santiago Weight <santiago.weight@lmns.com>
Co-authored-by: Pepe Iborra <pepeiborra@gmail.com>
Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-11-06 14:08:28 -08:00
Javier Neira
c1d8f78160
Remove myself from codeowners (#3230)
Cause i am getting lot of notifications i dont have time to attend

Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
2022-09-29 15:59:20 +00:00
Kobayashi
217573f4a1
Improve haddock comments (#3207)
* remove 'buildable: False' in cabal

* remove constraint on ghc-exactprint

* wip

* revert HaddockComments.hs

* generate haddock comments for constructors

* fix tests

* restore constraints

* make it compatible with ghc 9.0

* add more tests

* add comments & fix dp calculation for inline case

* add kokobd to codeowners of haddock-comments plugin

* fix a comment

* rephrase some comments to make them clearer

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-09-26 00:05:19 +00:00
Gregory Gerasev
078fc14dda
Stan integration #258 (#2908) 2022-07-28 02:11:31 +03:00
Kobayashi
445192e21d
refactor selection range plugin (#3003)
* update Gitpod config

* update nix shellHook & docs

* install pre-commit hook

* add kokobd as code owner to .gitpod.*

* add gen-hie to Gitpod

* add tools for doc

* remove .pre-commit-config.yaml from .gitignore

* set vscode formatter to stylish-haskell in Gitpod

* refactor selection range plugin

* refine selection range

* add CodeKind to CodeRange

* rename hls-selection-range-plugin to hls-code-range-plugin

* update docs about selection range

* cleanup RuleTypes.hs

* add the missing bang pattern

* fix subRange

* add some unit tests to CodeRange.Rules

* add tests for removeInterleaving

* add even more tests

* fix extra sources

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-07-11 04:24:35 +00:00
Kobayashi
771d8f44e6
unify pre-commit hook & update Gitpod config (#2991)
* update Gitpod config

* update nix shellHook & docs

* install pre-commit hook

* add kokobd as code owner to .gitpod.*

* add gen-hie to Gitpod

* add tools for doc

* remove .pre-commit-config.yaml from .gitignore

* set vscode formatter to stylish-haskell in Gitpod
2022-06-28 08:54:32 +00:00
Lei Zhu
faa88f685e
A plugin for GADT syntax converter (#2899)
* initial hls-gadt-plugin

* Correct condition

* Render context correctly

* Fix typo

* Support from ghc-8.6 to ghc-9.0

* ghc8.6 compat

* Try to fix test for ghc-8.6

* Pretty name

* Add GADTs pragma automatically

* Enrich Readme

* Clean up

* Update hls docs

* Update CODEOWNERS

* Fix typo

* Rename withTempDir with withCanonicalTempDir

* Add @michaelpj's suggestions

* Pass PluginId through descriptor

* Explicit forall
2022-05-26 17:13:09 +08:00
Lei Zhu
f22ed56a59
Add @July541 for call-hierarchy-plugin (#2708) 2022-02-13 07:15:00 +00:00
Javier Neira
df21896546
Assing ourmolu to @georgefst (#2661)
Due to this comment: https://github.com/haskell/haskell-language-server/pull/2619#issuecomment-1025237395
2022-01-31 13:46:47 +00:00
Michael Peyton Jones
49abc74a06
Add initial CODEOWNERS file (#2619)
* Add initial CODEOWNERS file

As discussed in
https://github.com/haskell/haskell-language-server/discussions/2588.

* Add a few more

* Update CODEOWNERS

Co-authored-by: Pepe Iborra <pepeiborra@me.com>

* Apply suggestions from code review

Co-authored-by: J. S. <document_done@hotmail.com>
Co-authored-by: Junyoung "Clare" Jang <jjc9310@gmail.com>

* Update CODEOWNERS

Co-authored-by: Javier Neira  <atreyu.bbb@gmail.com>

* Add guibou for Nix

* Remove people who haven't responded

Co-authored-by: Pepe Iborra <pepeiborra@me.com>
Co-authored-by: J. S. <document_done@hotmail.com>
Co-authored-by: Junyoung "Clare" Jang <jjc9310@gmail.com>
Co-authored-by: Javier Neira <atreyu.bbb@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-01-30 00:52:29 +00:00