2021-09-22 18:34:53 +03:00
|
|
|
{-# LANGUAGE ApplicativeDo #-}
|
2021-07-15 15:44:26 +03:00
|
|
|
{-# OPTIONS_GHC -fno-warn-orphans #-}
|
|
|
|
|
2021-11-04 19:08:33 +03:00
|
|
|
module Hasura.Backends.MySQL.Instances.Schema () where
|
2021-07-15 15:44:26 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.Aeson qualified as J
|
|
|
|
import Data.ByteString (ByteString)
|
2021-10-29 17:42:07 +03:00
|
|
|
import Data.Has
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.HashMap.Strict qualified as HM
|
|
|
|
import Data.List.NonEmpty qualified as NE
|
|
|
|
import Data.Text.Encoding (encodeUtf8)
|
|
|
|
import Data.Text.Extended
|
|
|
|
import Database.MySQL.Base.Types qualified as MySQL
|
|
|
|
import Hasura.Backends.MySQL.Types qualified as MySQL
|
|
|
|
import Hasura.Base.Error
|
|
|
|
import Hasura.GraphQL.Parser hiding (EnumValueInfo, field)
|
|
|
|
import Hasura.GraphQL.Parser qualified as P
|
|
|
|
import Hasura.GraphQL.Parser.Internal.Parser hiding (field)
|
|
|
|
import Hasura.GraphQL.Schema.Backend
|
|
|
|
import Hasura.GraphQL.Schema.Build qualified as GSB
|
|
|
|
import Hasura.GraphQL.Schema.Select
|
|
|
|
import Hasura.Prelude
|
|
|
|
import Hasura.RQL.IR
|
|
|
|
import Hasura.RQL.IR.Select qualified as IR
|
|
|
|
import Hasura.RQL.Types as RQL
|
|
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
instance BackendSchema 'MySQL where
|
2021-09-24 01:56:37 +03:00
|
|
|
buildTableQueryFields = GSB.buildTableQueryFields
|
|
|
|
buildTableRelayQueryFields = buildTableRelayQueryFields'
|
2021-07-15 15:44:26 +03:00
|
|
|
buildTableInsertMutationFields = buildTableInsertMutationFields'
|
|
|
|
buildTableUpdateMutationFields = buildTableUpdateMutationFields'
|
|
|
|
buildTableDeleteMutationFields = buildTableDeleteMutationFields'
|
2021-09-24 01:56:37 +03:00
|
|
|
buildFunctionQueryFields = buildFunctionQueryFields'
|
|
|
|
buildFunctionRelayQueryFields = buildFunctionRelayQueryFields'
|
|
|
|
buildFunctionMutationFields = buildFunctionMutationFields'
|
|
|
|
relayExtension = Nothing
|
|
|
|
tableArguments = mysqlTableArgs
|
|
|
|
nodesAggExtension = Just ()
|
|
|
|
columnParser = columnParser'
|
|
|
|
jsonPathArg = jsonPathArg'
|
|
|
|
orderByOperators = orderByOperators'
|
|
|
|
comparisonExps = comparisonExps'
|
|
|
|
mkCountType = error "mkCountType: MySQL backend does not support this operation yet."
|
|
|
|
aggregateOrderByCountType = error "aggregateOrderByCountType: MySQL backend does not support this operation yet."
|
|
|
|
computedField = error "computedField: MySQL backend does not support this operation yet."
|
|
|
|
node = error "node: MySQL backend does not support this operation yet."
|
|
|
|
columnDefaultValue = error "columnDefaultValue: MySQL backend does not support this operation yet."
|
2021-10-01 15:52:19 +03:00
|
|
|
getExtraInsertData = const ()
|
2021-07-15 15:44:26 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
mysqlTableArgs ::
|
|
|
|
forall r m n.
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
TableInfo 'MySQL ->
|
|
|
|
SelPermInfo 'MySQL ->
|
|
|
|
m (InputFieldsParser n (IR.SelectArgsG 'MySQL (UnpreparedValue 'MySQL)))
|
2021-07-15 15:44:26 +03:00
|
|
|
mysqlTableArgs sourceName tableInfo selectPermissions = do
|
2021-09-24 01:56:37 +03:00
|
|
|
whereParser <- tableWhereArg sourceName tableInfo selectPermissions
|
2021-07-15 15:44:26 +03:00
|
|
|
orderByParser <- tableOrderByArg sourceName tableInfo selectPermissions
|
|
|
|
pure do
|
2021-09-24 01:56:37 +03:00
|
|
|
whereArg <- whereParser
|
2021-07-15 15:44:26 +03:00
|
|
|
orderByArg <- orderByParser
|
2021-09-24 01:56:37 +03:00
|
|
|
limitArg <- tableLimitArg
|
|
|
|
offsetArg <- tableOffsetArg
|
|
|
|
pure $
|
|
|
|
IR.SelectArgs
|
|
|
|
{ IR._saWhere = whereArg,
|
|
|
|
IR._saOrderBy = orderByArg,
|
|
|
|
IR._saLimit = limitArg,
|
|
|
|
IR._saOffset = offsetArg,
|
|
|
|
IR._saDistinct = Nothing
|
|
|
|
}
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
buildTableRelayQueryFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
TableInfo 'MySQL ->
|
|
|
|
G.Name ->
|
|
|
|
NESeq (ColumnInfo 'MySQL) ->
|
|
|
|
SelPermInfo 'MySQL ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildTableRelayQueryFields' _sourceName _tableName _tableInfo _gqlName _pkeyColumns _selPerms =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildTableInsertMutationFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
TableInfo 'MySQL ->
|
|
|
|
G.Name ->
|
|
|
|
InsPermInfo 'MySQL ->
|
|
|
|
Maybe (SelPermInfo 'MySQL) ->
|
|
|
|
Maybe (UpdPermInfo 'MySQL) ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildTableInsertMutationFields' _sourceName _tableName _tableInfo _gqlName _insPerms _selPerms _updPerms =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildTableUpdateMutationFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
TableInfo 'MySQL ->
|
|
|
|
G.Name ->
|
|
|
|
UpdPermInfo 'MySQL ->
|
|
|
|
Maybe (SelPermInfo 'MySQL) ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildTableUpdateMutationFields' _sourceName _tableName _tableInfo _gqlName _updPerns _selPerms =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildTableDeleteMutationFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
TableInfo 'MySQL ->
|
|
|
|
G.Name ->
|
|
|
|
DelPermInfo 'MySQL ->
|
|
|
|
Maybe (SelPermInfo 'MySQL) ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildTableDeleteMutationFields' _sourceName _tableName _tableInfo _gqlName _delPerns _selPerms =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildFunctionQueryFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
FunctionName 'MySQL ->
|
|
|
|
FunctionInfo 'MySQL ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
SelPermInfo 'MySQL ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildFunctionQueryFields' _ _ _ _ _ =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildFunctionRelayQueryFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
FunctionName 'MySQL ->
|
|
|
|
FunctionInfo 'MySQL ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
NESeq (ColumnInfo 'MySQL) ->
|
|
|
|
SelPermInfo 'MySQL ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildFunctionRelayQueryFields' _sourceName _functionName _functionInfo _tableName _pkeyColumns _selPerms =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
|
|
|
buildFunctionMutationFields' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
SourceName ->
|
|
|
|
FunctionName 'MySQL ->
|
|
|
|
FunctionInfo 'MySQL ->
|
|
|
|
RQL.TableName 'MySQL ->
|
|
|
|
SelPermInfo 'MySQL ->
|
2021-11-26 00:07:53 +03:00
|
|
|
m [a]
|
|
|
|
buildFunctionMutationFields' _ _ _ _ _ =
|
2021-07-15 15:44:26 +03:00
|
|
|
pure []
|
|
|
|
|
2021-08-04 14:42:24 +03:00
|
|
|
bsParser :: MonadParse m => Parser 'Both m ByteString
|
|
|
|
bsParser = encodeUtf8 <$> P.string
|
2021-07-15 15:44:26 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
columnParser' ::
|
2021-10-29 17:42:07 +03:00
|
|
|
(MonadSchema n m, MonadError QErr m, MonadReader r m, Has MkTypename r) =>
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnType 'MySQL ->
|
|
|
|
G.Nullability ->
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
m (Parser 'Both n (ValueWithOrigin (ColumnValue 'MySQL)))
|
2021-07-15 15:44:26 +03:00
|
|
|
columnParser' columnType (G.Nullability isNullable) =
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
peelWithOrigin . fmap (ColumnValue columnType) <$> case columnType of
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnScalar scalarType -> case scalarType of
|
2021-09-24 01:56:37 +03:00
|
|
|
MySQL.Decimal -> pure $ possiblyNullable scalarType $ MySQL.DecimalValue <$> P.float
|
|
|
|
MySQL.Tiny -> pure $ possiblyNullable scalarType $ MySQL.TinyValue <$> P.int
|
|
|
|
MySQL.Short -> pure $ possiblyNullable scalarType $ MySQL.SmallValue <$> P.int
|
|
|
|
MySQL.Long -> pure $ possiblyNullable scalarType $ MySQL.IntValue <$> P.int
|
|
|
|
MySQL.Float -> pure $ possiblyNullable scalarType $ MySQL.FloatValue <$> P.float
|
|
|
|
MySQL.Double -> pure $ possiblyNullable scalarType $ MySQL.DoubleValue <$> P.float
|
|
|
|
MySQL.Null -> pure $ possiblyNullable scalarType $ MySQL.NullValue <$ P.string
|
2021-07-15 15:44:26 +03:00
|
|
|
MySQL.LongLong -> pure $ possiblyNullable scalarType $ MySQL.BigValue <$> P.int
|
2021-09-24 01:56:37 +03:00
|
|
|
MySQL.Int24 -> pure $ possiblyNullable scalarType $ MySQL.MediumValue <$> P.int
|
2021-08-04 14:42:24 +03:00
|
|
|
MySQL.Date -> pure $ possiblyNullable scalarType $ MySQL.DateValue <$> P.string
|
|
|
|
MySQL.Year -> pure $ possiblyNullable scalarType $ MySQL.YearValue <$> P.string
|
2021-09-24 01:56:37 +03:00
|
|
|
MySQL.Bit -> pure $ possiblyNullable scalarType $ MySQL.BitValue <$> P.boolean
|
|
|
|
MySQL.String -> pure $ possiblyNullable scalarType $ MySQL.VarcharValue <$> P.string
|
|
|
|
MySQL.VarChar -> pure $ possiblyNullable scalarType $ MySQL.VarcharValue <$> P.string
|
2021-08-04 14:42:24 +03:00
|
|
|
MySQL.DateTime -> pure $ possiblyNullable scalarType $ MySQL.DatetimeValue <$> P.string
|
|
|
|
MySQL.Blob -> pure $ possiblyNullable scalarType $ MySQL.BlobValue <$> bsParser
|
|
|
|
MySQL.Timestamp -> pure $ possiblyNullable scalarType $ MySQL.TimestampValue <$> P.string
|
2021-09-24 01:56:37 +03:00
|
|
|
_ -> do
|
2021-08-04 14:42:24 +03:00
|
|
|
name <- MySQL.mkMySQLScalarTypeName scalarType
|
Refactor type name customization
Source typename customization (hasura/graphql-engine@aac64f2c81faa6a3aef4d0cf5fae97289ac4383e) introduced a mechanism to change certain names in the GraphQL schema that is exposed. In particular it allows last-minute modification of:
1. the names of some types, and
2. the names of some root fields.
The above two items are assigned distinct customization algorithms, and at times both algorithms are in scope. So a need to distinguish them is needed.
In the original design, this was addressed by introducing a newtype wrapper `Typename` around GraphQL `Name`s, dedicated to the names of types. However, in the majority of the codebase, type names are also represented by `Name`. For this reason, it was unavoidable to allow for easy conversion. This was supported by a `HasName Typename` instance, as well as by publishing the constructors of `Typename`.
This means that the type safety that newtypes can add is lost. In particular, it is now very easy to confuse type name customization with root field name customization.
This refactors the above design by instead introducing newtypes around the customization operations:
```haskell
newtype MkTypename = MkTypename {runMkTypename :: Name -> Name}
deriving (Semigroup, Monoid) via (Endo Name)
newtype MkRootFieldName = MkRootFieldName {runMkRootFieldName :: Name -> Name}
deriving (Semigroup, Monoid) via (Endo Name)
```
The `Monoid` instance allows easy composition of customization operations, piggybacking off of the type of `Endo`maps.
This design allows safe co-existence of the two customization algorithms, while avoiding the syntactic overhead of packing and unpacking newtypes.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2989
GitOrigin-RevId: da3a353a9b003ee40c8d0a1e02872e99d2edd3ca
2021-11-30 12:51:46 +03:00
|
|
|
let schemaType = P.NonNullable $ P.TNamed $ P.mkDefinition name Nothing P.TIScalar
|
2021-09-24 01:56:37 +03:00
|
|
|
pure $
|
|
|
|
Parser
|
|
|
|
{ pType = schemaType,
|
|
|
|
pParser =
|
|
|
|
valueToJSON (P.toGraphQLType schemaType)
|
|
|
|
>=> either (parseErrorWith ParseFailed . qeError) pure . (MySQL.parseScalarValue scalarType)
|
|
|
|
}
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnEnumReference (EnumReference tableName enumValues) ->
|
|
|
|
case nonEmpty (HM.toList enumValues) of
|
|
|
|
Just enumValuesList -> do
|
|
|
|
tableGQLName <- tableGraphQLName @'MySQL tableName `onLeft` throwError
|
2021-10-29 17:42:07 +03:00
|
|
|
enumName <- P.mkTypename $ tableGQLName <> $$(G.litName "_enum")
|
2021-07-15 15:44:26 +03:00
|
|
|
pure $ possiblyNullable MySQL.VarChar $ P.enum enumName Nothing (mkEnumValue <$> enumValuesList)
|
|
|
|
Nothing -> throw400 ValidationFailed "empty enum values"
|
|
|
|
where
|
|
|
|
possiblyNullable :: (MonadParse m) => MySQL.Type -> Parser 'Both m MySQL.ScalarValue -> Parser 'Both m MySQL.ScalarValue
|
|
|
|
possiblyNullable _scalarType
|
|
|
|
| isNullable = fmap (fromMaybe MySQL.NullValue) . P.nullable
|
2021-09-24 01:56:37 +03:00
|
|
|
| otherwise = id
|
2021-07-15 15:44:26 +03:00
|
|
|
mkEnumValue :: (EnumValue, EnumValueInfo) -> (P.Definition P.EnumValueInfo, RQL.ScalarValue 'MySQL)
|
|
|
|
mkEnumValue (RQL.EnumValue value, EnumValueInfo description) =
|
2021-09-24 01:56:37 +03:00
|
|
|
( P.mkDefinition value (G.Description <$> description) P.EnumValueInfo,
|
|
|
|
MySQL.VarcharValue $ G.unName value
|
2021-07-15 15:44:26 +03:00
|
|
|
)
|
|
|
|
throughJSON scalarName =
|
|
|
|
let schemaType = P.NonNullable $ P.TNamed $ P.mkDefinition scalarName Nothing P.TIScalar
|
2021-09-24 01:56:37 +03:00
|
|
|
in Parser
|
|
|
|
{ pType = schemaType,
|
|
|
|
pParser =
|
|
|
|
valueToJSON (P.toGraphQLType schemaType)
|
|
|
|
>=> either (parseErrorWith ParseFailed . qeError) pure . runAesonParser J.parseJSON
|
|
|
|
}
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
jsonPathArg' ::
|
|
|
|
MonadParse n =>
|
|
|
|
ColumnType 'MySQL ->
|
|
|
|
InputFieldsParser n (Maybe (IR.ColumnOp 'MySQL))
|
|
|
|
jsonPathArg' _columnType = pure Nothing
|
|
|
|
|
|
|
|
orderByOperators' :: NonEmpty (Definition P.EnumValueInfo, (BasicOrderType 'MySQL, NullsOrderType 'MySQL))
|
|
|
|
orderByOperators' =
|
|
|
|
NE.fromList
|
2021-09-24 01:56:37 +03:00
|
|
|
[ ( define $$(G.litName "asc") "in ascending order, nulls first",
|
|
|
|
(MySQL.Asc, MySQL.NullsFirst)
|
|
|
|
),
|
|
|
|
( define $$(G.litName "asc_nulls_first") "in ascending order, nulls first",
|
|
|
|
(MySQL.Asc, MySQL.NullsFirst)
|
|
|
|
),
|
|
|
|
( define $$(G.litName "asc_nulls_last") "in ascending order, nulls last",
|
|
|
|
(MySQL.Asc, MySQL.NullsLast)
|
|
|
|
),
|
|
|
|
( define $$(G.litName "desc") "in descending order, nulls last",
|
|
|
|
(MySQL.Desc, MySQL.NullsLast)
|
|
|
|
),
|
|
|
|
( define $$(G.litName "desc_nulls_first") "in descending order, nulls first",
|
|
|
|
(MySQL.Desc, MySQL.NullsFirst)
|
|
|
|
),
|
|
|
|
( define $$(G.litName "desc_nulls_last") "in descending order, nulls last",
|
|
|
|
(MySQL.Desc, MySQL.NullsLast)
|
2021-07-15 15:44:26 +03:00
|
|
|
)
|
|
|
|
]
|
|
|
|
where
|
|
|
|
define name desc = P.mkDefinition name (Just desc) P.EnumValueInfo
|
|
|
|
|
|
|
|
-- | TODO: Make this as thorough as the one for MSSQL/PostgreSQL
|
|
|
|
comparisonExps' ::
|
2021-10-29 17:42:07 +03:00
|
|
|
forall m n r.
|
|
|
|
(BackendSchema 'MySQL, MonadSchema n m, MonadError QErr m, MonadReader r m, Has MkTypename r) =>
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnType 'MySQL ->
|
|
|
|
m (Parser 'Input n [ComparisonExp 'MySQL])
|
|
|
|
comparisonExps' = P.memoize 'comparisonExps $ \columnType -> do
|
|
|
|
-- see Note [Columns in comparison expression are never nullable]
|
2021-09-24 01:56:37 +03:00
|
|
|
typedParser <- columnParser columnType (G.Nullability False)
|
2021-07-15 15:44:26 +03:00
|
|
|
nullableTextParser <- columnParser (ColumnScalar @'MySQL MySQL.VarChar) (G.Nullability True)
|
2021-09-24 01:56:37 +03:00
|
|
|
textParser <- columnParser (ColumnScalar @'MySQL MySQL.VarChar) (G.Nullability False)
|
Refactor type name customization
Source typename customization (hasura/graphql-engine@aac64f2c81faa6a3aef4d0cf5fae97289ac4383e) introduced a mechanism to change certain names in the GraphQL schema that is exposed. In particular it allows last-minute modification of:
1. the names of some types, and
2. the names of some root fields.
The above two items are assigned distinct customization algorithms, and at times both algorithms are in scope. So a need to distinguish them is needed.
In the original design, this was addressed by introducing a newtype wrapper `Typename` around GraphQL `Name`s, dedicated to the names of types. However, in the majority of the codebase, type names are also represented by `Name`. For this reason, it was unavoidable to allow for easy conversion. This was supported by a `HasName Typename` instance, as well as by publishing the constructors of `Typename`.
This means that the type safety that newtypes can add is lost. In particular, it is now very easy to confuse type name customization with root field name customization.
This refactors the above design by instead introducing newtypes around the customization operations:
```haskell
newtype MkTypename = MkTypename {runMkTypename :: Name -> Name}
deriving (Semigroup, Monoid) via (Endo Name)
newtype MkRootFieldName = MkRootFieldName {runMkRootFieldName :: Name -> Name}
deriving (Semigroup, Monoid) via (Endo Name)
```
The `Monoid` instance allows easy composition of customization operations, piggybacking off of the type of `Endo`maps.
This design allows safe co-existence of the two customization algorithms, while avoiding the syntactic overhead of packing and unpacking newtypes.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2989
GitOrigin-RevId: da3a353a9b003ee40c8d0a1e02872e99d2edd3ca
2021-11-30 12:51:46 +03:00
|
|
|
let name = P.getName typedParser <> $$(G.litName "_MySQL_comparison_exp")
|
2021-09-24 01:56:37 +03:00
|
|
|
desc =
|
|
|
|
G.Description $
|
|
|
|
"Boolean expression to compare columns of type "
|
|
|
|
<> P.getName typedParser
|
|
|
|
<<> ". All fields are combined with logical 'AND'."
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
textListParser = fmap openValueOrigin <$> P.list textParser
|
|
|
|
columnListParser = fmap openValueOrigin <$> P.list typedParser
|
2021-09-24 01:56:37 +03:00
|
|
|
pure $
|
|
|
|
P.object name (Just desc) $
|
|
|
|
catMaybes
|
|
|
|
<$> sequenceA
|
|
|
|
[ P.fieldOptional $$(G.litName "_is_null") Nothing (bool ANISNOTNULL ANISNULL <$> P.boolean),
|
|
|
|
P.fieldOptional $$(G.litName "_eq") Nothing (AEQ True . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional $$(G.litName "_neq") Nothing (ANE True . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional $$(G.litName "_gt") Nothing (AGT . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional $$(G.litName "_lt") Nothing (ALT . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional $$(G.litName "_gte") Nothing (AGTE . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional $$(G.litName "_lte") Nothing (ALTE . mkParameter <$> typedParser)
|
|
|
|
]
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
offsetParser' :: MonadParse n => Parser 'Both n (SQLExpression 'MySQL)
|
|
|
|
offsetParser' =
|
|
|
|
MySQL.ValueExpression . MySQL.BigValue . fromIntegral <$> P.int
|