graphql-engine/server/tests-hspec/Harness/Test/Context.hs

263 lines
8.9 KiB
Haskell
Raw Normal View History

{-# LANGUAGE DeriveAnyClass #-}
-- | Helper functions for easily testing features.
module Harness.Test.Context
( run,
runWithLocalState,
Context (..),
ContextName (..),
noLocalState,
Options (..),
combineOptions,
defaultOptions,
)
where
import Control.Applicative ((<|>))
import Control.Exception.Safe (Exception, SomeException, catch, mask, throwIO)
import Data.Foldable (for_)
import Data.Maybe (fromMaybe)
Auto-launch graphql-engine (close hasura/graphql-engine#7801, hasura/graphql-engine#7827 ) Dupe of https://github.com/hasura/graphql-engine-mono/pull/2853 with branch renamed so it doesn't break a tool. prev pr: https://github.com/hasura/graphql-engine-mono/pull/2911 next pr: https://github.com/hasura/graphql-engine-mono/pull/2922 This implements https://github.com/hasura/graphql-engine/issues/7801 Some points to keep in mind for review: * How state is passed to the tests. Do we like how this works? * I quite like it, with the opaque type [`State`](https://github.com/hasura/graphql-engine-mono/blob/68f33051ca6373c42988e78d069eea2a135dc190/server/tests-hspec/Harness/State.hs#L17), we can avoid churn when adding things. * The [setup/teardown](https://github.com/hasura/graphql-engine-mono/blob/68f33051ca6373c42988e78d069eea2a135dc190/server/tests-hspec/Spec.hs#L19-L31) seems clean. * By using hspec's own means to pass and denote context, we avoid "getting new ideas" for how to structure the tests -- we use a standard. Hopefully, that means the tests' structure rarely change. * The various flags passed in the [ServeOptions](https://github.com/hasura/graphql-engine-mono/blob/68f33051ca6373c42988e78d069eea2a135dc190/server/tests-hspec/Harness/Constants.hs#L123) - if there are any causes for concern, raise them here. My thinking is that, there are lots. I've picked some "sane" defaults (mostly empty). The tests pass. I think as we add more complex tests, these flags will be scrutinised and updated as needed. I think it's valuable that all flags are explicitly listed here, though. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/2921 GitOrigin-RevId: 2c2e70bf784ef571a48509a7e5006fd0f48773b5
2021-11-23 21:15:17 +03:00
import Harness.State (State)
import Test.Hspec (ActionWith, HasCallStack, SpecWith, aroundAllWith, describe)
import Test.Hspec.Core.Spec (Item (..), mapSpecItem)
import Prelude
--------------------------------------------------------------------------------
-- Context
-- | Runs the given tests, for each provided 'Context'@ ()@.
--
-- Each 'Context' provides distinct setup and teardown functions; 'run'
-- guarantees that the associated 'teardown' function is always called after a
-- setup, even if the tests fail.
--
-- See 'Context' for details.
--
-- This function restricts the local state parameter for 'Context' to be '()',
-- indicating that there should be _no_ local state.
--
-- For a more general version that can run tests for any 'Context'@ a@, see
-- 'runWithLocalState'.
run :: [Context ()] -> (Options -> SpecWith State) -> SpecWith State
run contexts tests = do
let mappedTests opts =
mapSpecItem
actionWithStateMapping
(mapItemAction actionWithStateMapping)
(tests opts)
runWithLocalState contexts mappedTests
-- | Observe that there is a direct correspondance (i.e. an isomorphism) from
-- @State@ to @(State, ())@ within 'ActionWith'.
--
-- NOTE: 'ActionWith'@ a@ is a type alias for @a -> IO ()@; thus, the fully
-- expanded type signature here is @(State -> IO ()) -> (State, ()) -> IO ()@.
--
-- NOTE: This can possibly be generalized to a @Control.Lens.Iso@.
--
-- NOTE: This should probably be extracted to some common helper module (e.g.
-- @Harness.State@).
actionWithStateMapping :: ActionWith State -> ActionWith (State, ())
actionWithStateMapping actionWith (state, _) = actionWith state
-- | Modify an 'Item'@ a@ by way of mapping its 'ActionWith'@ a@ function to
-- some 'ActionWith'@ b@, producing an 'Item'@ b@.
--
-- This can be useful when one wants to modify the state parameter in a
-- 'SpecWith' test tree, without having to resolve the type mismatch using some
-- combination of type families and helper type classes.
--
-- NOTE: This should go in some sort of @Test.Hspec.Core.Spec.Extended@ module.
mapItemAction :: (ActionWith a -> ActionWith b) -> Item a -> Item b
mapItemAction mapActionWith item@Item {itemExample} =
let mappedExample params next callback =
itemExample
params
(next . mapActionWith)
callback
in item {itemExample = mappedExample}
-- | Runs the given tests, for each provided 'Context'@ a@.
--
-- Each 'Context' provides distinct setup and teardown functions; 'feature'
-- guarantees that the associated 'teardown' function is always called after a
-- setup, even if the tests fail.
--
-- 'Context's are parameterized by the type of local state that needs to be
-- carried throughout the tests.
--
-- See 'Context' for details.
runWithLocalState ::
forall a.
[Context a] ->
(Options -> SpecWith (State, a)) ->
SpecWith State
runWithLocalState contexts tests =
for_ contexts \context@Context {name, customOptions} -> do
let options = fromMaybe defaultOptions customOptions
describe (show name) $ aroundAllWith (contextBracket context) (tests options)
where
-- We want to be able to report exceptions happening both during the tests
-- and at teardown, which is why we use a custom re-implementation of
-- @bracket@.
contextBracket ::
forall b.
Context a ->
((State, a) -> IO b) ->
State ->
IO ()
contextBracket Context {mkLocalState, setup, teardown} actionWith globalState =
mask \restore -> do
localState <- mkLocalState globalState
let state = (globalState, localState)
catch
-- Setup for a test
(setup state)
( \setupEx ->
catch
-- On setup error, attempt to run `teardown` and then throw the setup error
(teardown state *> throwIO setupEx)
-- On teardown error as well, throw both exceptions
(throwIO . Exceptions setupEx)
)
-- Run tests.
_ <-
catch
(restore $ actionWith state)
( \restoreEx -> do
-- On test error, attempt to run `teardown`...
teardown state
`catch`
-- ...if it fails as well, bundle both exceptions together and
-- rethrow them...
(throwIO . Exceptions restoreEx)
-- ...otherwise rethrow the original exception.
throwIO restoreEx
)
-- If no exception occurred, run the normal teardown function.
teardown state
--------------------------------------------------------------------------------
-- | A context in which a set of tests should be executed; this could be an
-- individual backend, or a setup of several of them to test relationships.
--
-- The @a@ parameter defines the local state, in addition to the global state.
--
-- A test that doesn't require additional local state can indicate this with
-- '()'.
--
-- For example a value of type @Context ()@ will have the following record
-- fields:
--
-- @
-- setup :: State -> IO ()
-- teardown :: (State, ()) -> IO ()
-- tests :: SpecWith (State, ())
-- @
--
-- However, if a test needs some custom state it must be passed in as a tuple.
--
-- For example a value of type @Context Server@ will have the following record
-- fields:
--
-- @
-- setup :: State -> IO ()
-- teardown :: (State, Server) -> IO ()
-- tests :: SpecWith (State, Server)
-- @
data Context a = Context
{ -- | A name describing the given context.
--
-- e.g. @Postgre@ or @MySQL@
name :: ContextName,
-- | Setup actions associated with creating a local state for this 'Context'; for example:
-- * starting remote servers
--
-- If any of those resources need to be threaded throughout the tests
-- themselves they should be returned here. Otherwise, a ()
mkLocalState :: State -> IO a,
-- | Setup actions associated with this 'Context'; for example:
-- * running SQL commands
-- * sending metadata commands
--
-- Takes the global 'State' and any local state (i.e. @a@) as arguments.
setup :: (State, a) -> IO (),
-- | Cleanup actions associated with this 'Context'.
--
-- This function /must/ return any resources created or modified as part of
-- 'setup' to their /original state/ (whatever that may be).
--
-- Takes the global 'State' and any local state (i.e. @a@) as arguments.
teardown :: (State, a) -> IO (),
-- | Options which modify the behavior of a given testing 'Context'; when
-- this field is 'Nothing', tests are given the 'defaultOptions'.
customOptions :: Maybe Options
}
-- | A name describing the given context.
data ContextName
= Postgres
| MySQL
| SQLServer
| BigQuery
| Citus
| Combine ContextName ContextName
deriving (Show, Eq)
-- | Default function for 'mkLocalState' when there's no local state.
noLocalState :: State -> IO ()
noLocalState _ = pure ()
data Options = Options
{ -- | Whether a given testing 'Context' should treat numeric values as
-- strings.
--
-- This is primarily a workaround for tests which run BigQuery.
stringifyNumbers :: Bool
}
-- | This function can be used to combine two sets of 'Option's when creating
-- custom composite 'Context's.
--
-- NOTE: This function throws an impure exception if the options are
-- irreconcilable.
combineOptions :: HasCallStack => Maybe Options -> Maybe Options -> Maybe Options
combineOptions (Just lhs) (Just rhs) =
let -- 'stringifyNumbers' can only be unified if both sides have the same value.
stringifyNumbers =
if lhsStringify == rhsStringify
then lhsStringify
else reportInconsistency "stringifyNumbers" lhsStringify rhsStringify
in Just Options {..}
where
reportInconsistency fieldName lhsValue rhsValue =
error $ "Could not reconcile '" <> fieldName <> "'\n lhs value: " <> show lhsValue <> "\n rhs value: " <> show rhsValue
Options {stringifyNumbers = lhsStringify} = lhs
Options {stringifyNumbers = rhsStringify} = rhs
combineOptions mLhs mRhs = mLhs <|> mRhs
defaultOptions :: Options
defaultOptions =
Options
{ stringifyNumbers = False
}
--------------------------------------------------------------------------------
-- Local helpers
-- | Two exceptions, bundled as one.
data Exceptions
= Exceptions SomeException SomeException
deriving anyclass (Exception)
instance Show Exceptions where
show (Exceptions e1 e2) =
unlines
[ "1. " <> show e1,
"",
"2. " <> show e2
]