graphql-engine/server/tests-py/queries/endpoints/endpoint_duplicate_param.yaml

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

33 lines
820 B
YAML
Raw Normal View History

description: Try to add an endpoint with duplicate params
url: /v1/query
status: 400
response:
Inconsistent metadata support for REST endpoints Previously invalid REST endpoints would throw errors during schema cache build. This PR changes the validation to instead add to the inconsistent metadata objects in order to allow use of `allow_inconsistent_metadata` with inconsistent REST endpoints. All non-fatal endpoint definition errors are returned as inconsistent metadata warnings/errors depending on the use of `allow_inconsistent_metadata`. The endpoints with issues are then created and return informational runtime errors when they are called. Console impact when creating endpoints is that error messages now refer to metadata inconsistencies rather than REST feature at the top level: ![image](https://user-images.githubusercontent.com/92299/109911843-ede9ec00-7cfe-11eb-9c55-7cf924d662a6.png) <img width="969" alt="image" src="https://user-images.githubusercontent.com/92299/110258597-8336fa00-7ff7-11eb-872c-bfca945aa0e8.png"> Note: Conflicting endpoints generate one error per conflicting set of endpoints due to the implementation of `groupInconsistentMetadataById` and `imObjectIds`. This is done to ensure that error messages are terse, but may pose errors if there are some assumptions made surrounding `imObjectIds`. Related to https://github.com/hasura/graphql-engine-mono/pull/473 (Allow Inconsistent Metadata (v2) #473 (Merged)) --- ### Kodiak commit message Changes the validation to use inconsistent metadata objects for REST endpoint issues. #### Commit title Inconsistent metadata for REST endpoints GitOrigin-RevId: b9de971208e9bb0a319c57df8dace44cb115ff66
2021-03-10 08:25:12 +03:00
internal:
- definition:
definition:
query:
collection_name: test_collection
query_name: simple_query
url: foo/:id/bar/:id
methods:
- GET
name: duplicate
comment:
reason: "Duplicate variables found in endpoint path: foo/:id/bar/:id"
name: rest_endpoint duplicate
type: rest_endpoint
path: $.args
error: 'Duplicate variables found in endpoint path: foo/:id/bar/:id'
code: invalid-configuration
query:
type: create_rest_endpoint
args:
url: "foo/:id/bar/:id"
name: duplicate
methods:
- GET
definition:
query:
collection_name: test_collection
query_name: simple_query