2021-09-22 18:34:53 +03:00
|
|
|
{-# LANGUAGE ApplicativeDo #-}
|
2022-04-22 22:53:12 +03:00
|
|
|
{-# LANGUAGE TemplateHaskellQuotes #-}
|
2021-02-23 20:37:27 +03:00
|
|
|
{-# OPTIONS_GHC -fno-warn-orphans #-}
|
|
|
|
|
2022-01-11 01:54:51 +03:00
|
|
|
-- | MSSQL Instances Schema
|
|
|
|
--
|
|
|
|
-- Defines a 'Hasura.GraphQL.Schema.Backend.BackendSchema' type class instance for MSSQL.
|
2021-02-23 20:37:27 +03:00
|
|
|
module Hasura.Backends.MSSQL.Instances.Schema () where
|
|
|
|
|
2022-08-22 11:33:31 +03:00
|
|
|
import Data.Char qualified as Char
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Data.HashMap.Strict qualified as Map
|
|
|
|
import Data.List.NonEmpty qualified as NE
|
2022-08-22 11:33:31 +03:00
|
|
|
import Data.Text qualified as T
|
|
|
|
import Data.Text.Encoding as TE
|
2021-02-23 20:37:27 +03:00
|
|
|
import Data.Text.Extended
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Database.ODBC.SQLServer qualified as ODBC
|
2021-12-31 13:56:06 +03:00
|
|
|
import Hasura.Backends.MSSQL.Schema.IfMatched
|
2021-12-22 14:04:33 +03:00
|
|
|
import Hasura.Backends.MSSQL.Types.Insert (BackendInsert (..))
|
2021-11-26 16:47:12 +03:00
|
|
|
import Hasura.Backends.MSSQL.Types.Internal qualified as MSSQL
|
2023-01-10 04:54:40 +03:00
|
|
|
import Hasura.Backends.MSSQL.Types.Update (UpdateOperator (..))
|
2021-05-11 18:18:31 +03:00
|
|
|
import Hasura.Base.Error
|
An `ErrorMessage` type, to encapsulate.
This introduces an `ErrorMessage` newtype which wraps `Text` in a manner which is designed to be easy to construct, and difficult to deconstruct.
It provides functionality similar to `Data.Text.Extended`, but designed _only_ for error messages. Error messages are constructed through `fromString`, concatenation, or the `toErrorValue` function, which is designed to be overridden for all meaningful domain types that might show up in an error message. Notably, there are not and should never be instances of `ToErrorValue` for `String`, `Text`, `Int`, etc. This is so that we correctly represent the value in a way that is specific to its type. For example, all `Name` values (from the _graphql-parser-hs_ library) are single-quoted now; no exceptions.
I have mostly had to add `instance ToErrorValue` for various backend types (and also add newtypes where necessary). Some of these are not strictly necessary for this changeset, as I had bigger aspirations when I started. These aspirations have been tempered by trying and failing twice.
As such, in this changeset, I have started by introducing this type to the `parseError` and `parseErrorWith` functions. In the future, I would like to extend this to the `QErr` record and the various `throwError` functions, but this is a much larger task and should probably be done in stages.
For now, `toErrorMessage` and `fromErrorMessage` are provided for conversion to and from `Text`, but the intent is to stop exporting these once all error messages are converted to the new type.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5018
GitOrigin-RevId: 84b37e238992e4312255a87ca44f41af65e2d89a
2022-07-18 23:26:01 +03:00
|
|
|
import Hasura.Base.ErrorMessage (toErrorMessage)
|
2021-02-23 20:37:27 +03:00
|
|
|
import Hasura.GraphQL.Schema.Backend
|
2021-04-08 11:25:11 +03:00
|
|
|
import Hasura.GraphQL.Schema.BoolExp
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Hasura.GraphQL.Schema.Build qualified as GSB
|
2021-02-23 20:37:27 +03:00
|
|
|
import Hasura.GraphQL.Schema.Common
|
2022-07-12 17:00:15 +03:00
|
|
|
import Hasura.GraphQL.Schema.NamingCase
|
2022-07-14 20:57:28 +03:00
|
|
|
import Hasura.GraphQL.Schema.Options qualified as Options
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Parser
|
2023-01-10 04:54:40 +03:00
|
|
|
( InputFieldsParser,
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
Kind (..),
|
|
|
|
MonadParse,
|
|
|
|
Parser,
|
|
|
|
)
|
|
|
|
import Hasura.GraphQL.Schema.Parser qualified as P
|
2021-06-15 18:53:20 +03:00
|
|
|
import Hasura.GraphQL.Schema.Select
|
2021-11-26 16:47:12 +03:00
|
|
|
import Hasura.GraphQL.Schema.Update qualified as SU
|
2022-06-23 12:14:24 +03:00
|
|
|
import Hasura.Name qualified as Name
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Hasura.Prelude
|
|
|
|
import Hasura.RQL.IR
|
|
|
|
import Hasura.RQL.IR.Select qualified as IR
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.RQL.Types.Backend hiding (BackendInsert)
|
|
|
|
import Hasura.RQL.Types.Column
|
|
|
|
import Hasura.RQL.Types.SchemaCache
|
Remove circular dependency in schema building code
### Description
The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop.
As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context.
This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4557
GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
2022-05-27 20:21:22 +03:00
|
|
|
import Hasura.RQL.Types.Source
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
import Hasura.RQL.Types.SourceCustomization
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.SQL.Backend
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
2021-02-23 20:37:27 +03:00
|
|
|
|
|
|
|
----------------------------------------------------------------
|
2022-01-03 20:16:24 +03:00
|
|
|
|
|
|
|
-- * BackendSchema instance
|
2021-02-23 20:37:27 +03:00
|
|
|
|
|
|
|
instance BackendSchema 'MSSQL where
|
|
|
|
-- top level parsers
|
2022-06-07 08:32:08 +03:00
|
|
|
buildTableQueryAndSubscriptionFields = GSB.buildTableQueryAndSubscriptionFields
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
buildTableRelayQueryFields _ _ _ _ _ = pure []
|
2022-04-22 22:53:12 +03:00
|
|
|
buildTableStreamingSubscriptionFields = GSB.buildTableStreamingSubscriptionFields
|
|
|
|
buildTableInsertMutationFields = GSB.buildTableInsertMutationFields backendInsertParser
|
2021-11-19 20:05:01 +03:00
|
|
|
buildTableDeleteMutationFields = GSB.buildTableDeleteMutationFields
|
2023-01-10 04:54:40 +03:00
|
|
|
buildTableUpdateMutationFields = GSB.buildSingleBatchTableUpdateMutationFields id
|
2021-11-26 16:47:12 +03:00
|
|
|
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
buildFunctionQueryFields _ _ _ _ = pure []
|
|
|
|
buildFunctionRelayQueryFields _ _ _ _ _ = pure []
|
|
|
|
buildFunctionMutationFields _ _ _ _ = pure []
|
2021-06-15 18:53:20 +03:00
|
|
|
|
2021-02-23 20:37:27 +03:00
|
|
|
-- backend extensions
|
2021-08-31 16:34:43 +03:00
|
|
|
relayExtension = Nothing
|
|
|
|
nodesAggExtension = Just ()
|
2022-04-22 22:53:12 +03:00
|
|
|
streamSubscriptionExtension = Nothing
|
2021-06-15 18:53:20 +03:00
|
|
|
|
2022-08-11 14:57:06 +03:00
|
|
|
-- When we support nested inserts, we also need to ensure we limit ourselves
|
|
|
|
-- to inserting into tables whch supports inserts:
|
|
|
|
{-
|
|
|
|
import Hasura.GraphQL.Schema.Mutation qualified as GSB
|
|
|
|
|
|
|
|
runMaybeT $ do
|
|
|
|
let otherTableName = riRTable relationshipInfo
|
|
|
|
otherTableInfo <- lift $ askTableInfo sourceName otherTableName
|
|
|
|
guard (supportsInserts otherTableInfo)
|
|
|
|
-}
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
mkRelationshipParser _ = pure Nothing
|
2021-06-15 18:53:20 +03:00
|
|
|
|
|
|
|
-- individual components
|
2021-02-23 20:37:27 +03:00
|
|
|
columnParser = msColumnParser
|
2022-09-14 00:21:07 +03:00
|
|
|
enumParser = msEnumParser
|
|
|
|
possiblyNullable = msPossiblyNullable
|
2022-08-11 14:57:06 +03:00
|
|
|
scalarSelectionArgumentsParser _ = pure Nothing
|
2022-06-10 06:59:00 +03:00
|
|
|
orderByOperators _sourceInfo = msOrderByOperators
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
comparisonExps = msComparisonExps
|
2022-01-18 17:53:44 +03:00
|
|
|
countTypeInput = msCountTypeInput
|
2021-02-23 20:37:27 +03:00
|
|
|
aggregateOrderByCountType = MSSQL.IntegerType
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
computedField _ _ _ = pure Nothing
|
2021-06-15 18:53:20 +03:00
|
|
|
|
2022-06-30 18:22:19 +03:00
|
|
|
instance BackendTableSelectSchema 'MSSQL where
|
|
|
|
tableArguments = msTableArgs
|
|
|
|
selectTable = defaultSelectTable
|
|
|
|
selectTableAggregate = defaultSelectTableAggregate
|
|
|
|
tableSelectionSet = defaultTableSelectionSet
|
|
|
|
|
2023-01-10 04:54:40 +03:00
|
|
|
instance BackendUpdateOperatorsSchema 'MSSQL where
|
|
|
|
type UpdateOperators 'MSSQL = UpdateOperator
|
|
|
|
|
|
|
|
parseUpdateOperators = msParseUpdateOperators
|
|
|
|
|
2021-02-23 20:37:27 +03:00
|
|
|
----------------------------------------------------------------
|
2022-01-03 20:16:24 +03:00
|
|
|
|
|
|
|
-- * Top level parsers
|
2021-02-23 20:37:27 +03:00
|
|
|
|
2021-12-15 20:07:21 +03:00
|
|
|
backendInsertParser ::
|
|
|
|
forall m r n.
|
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
|
|
|
TableInfo 'MSSQL ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (InputFieldsParser n (BackendInsert (UnpreparedValue 'MSSQL)))
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
backendInsertParser tableInfo = do
|
|
|
|
ifMatched <- ifMatchedFieldParser tableInfo
|
2021-12-31 13:56:06 +03:00
|
|
|
let _biIdentityColumns = _tciExtraTableMetadata $ _tiCoreInfo tableInfo
|
2021-12-15 20:07:21 +03:00
|
|
|
pure $ do
|
2021-12-31 13:56:06 +03:00
|
|
|
_biIfMatched <- ifMatched
|
2021-12-15 20:07:21 +03:00
|
|
|
pure $ BackendInsert {..}
|
2021-12-09 12:05:42 +03:00
|
|
|
|
2021-06-15 18:53:20 +03:00
|
|
|
----------------------------------------------------------------
|
2022-01-03 20:16:24 +03:00
|
|
|
|
|
|
|
-- * Table arguments
|
2021-06-15 18:53:20 +03:00
|
|
|
|
|
|
|
msTableArgs ::
|
|
|
|
forall r m n.
|
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
|
|
|
TableInfo 'MSSQL ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (InputFieldsParser n (IR.SelectArgsG 'MSSQL (UnpreparedValue 'MSSQL)))
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
msTableArgs tableInfo = do
|
|
|
|
whereParser <- tableWhereArg tableInfo
|
|
|
|
orderByParser <- tableOrderByArg tableInfo
|
2021-06-15 18:53:20 +03:00
|
|
|
pure do
|
|
|
|
whereArg <- whereParser
|
|
|
|
orderByArg <- orderByParser
|
|
|
|
limitArg <- tableLimitArg
|
|
|
|
offsetArg <- tableOffsetArg
|
|
|
|
pure $
|
|
|
|
IR.SelectArgs
|
|
|
|
{ IR._saWhere = whereArg,
|
|
|
|
IR._saOrderBy = orderByArg,
|
|
|
|
IR._saLimit = limitArg,
|
|
|
|
IR._saOffset = offsetArg,
|
|
|
|
-- not supported on MSSQL for now
|
|
|
|
IR._saDistinct = Nothing
|
|
|
|
}
|
|
|
|
|
2021-02-23 20:37:27 +03:00
|
|
|
----------------------------------------------------------------
|
2022-01-03 20:16:24 +03:00
|
|
|
|
|
|
|
-- * Individual components
|
2021-02-23 20:37:27 +03:00
|
|
|
|
|
|
|
msColumnParser ::
|
2022-09-06 19:48:04 +03:00
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
2021-02-23 20:37:27 +03:00
|
|
|
ColumnType 'MSSQL ->
|
|
|
|
G.Nullability ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (Parser 'Both n (ValueWithOrigin (ColumnValue 'MSSQL)))
|
2022-10-03 23:09:42 +03:00
|
|
|
msColumnParser columnType nullability = case columnType of
|
|
|
|
-- TODO: the mapping here is not consistent with mkMSSQLScalarTypeName. For
|
|
|
|
-- example, exposing all the float types as a GraphQL Float type is
|
|
|
|
-- incorrect, similarly exposing all the integer types as a GraphQL Int
|
|
|
|
ColumnScalar scalarType ->
|
|
|
|
P.memoizeOn 'msColumnParser (scalarType, nullability) $
|
|
|
|
peelWithOrigin . fmap (ColumnValue columnType) . msPossiblyNullable scalarType nullability
|
|
|
|
<$> case scalarType of
|
|
|
|
-- text
|
|
|
|
MSSQL.CharType -> pure $ mkCharValue <$> P.string
|
|
|
|
MSSQL.VarcharType -> pure $ mkCharValue <$> P.string
|
|
|
|
MSSQL.WcharType -> pure $ ODBC.TextValue <$> P.string
|
|
|
|
MSSQL.WvarcharType -> pure $ ODBC.TextValue <$> P.string
|
|
|
|
MSSQL.WtextType -> pure $ ODBC.TextValue <$> P.string
|
|
|
|
MSSQL.TextType -> pure $ ODBC.TextValue <$> P.string
|
|
|
|
-- integer
|
|
|
|
MSSQL.IntegerType -> pure $ ODBC.IntValue . fromIntegral <$> P.int
|
|
|
|
MSSQL.SmallintType -> pure $ ODBC.IntValue . fromIntegral <$> P.int
|
|
|
|
MSSQL.BigintType -> pure $ ODBC.IntValue . fromIntegral <$> P.int
|
|
|
|
MSSQL.TinyintType -> pure $ ODBC.IntValue . fromIntegral <$> P.int
|
|
|
|
-- float
|
|
|
|
MSSQL.NumericType -> pure $ ODBC.DoubleValue <$> P.float
|
|
|
|
MSSQL.DecimalType -> pure $ ODBC.DoubleValue <$> P.float
|
|
|
|
MSSQL.FloatType -> pure $ ODBC.DoubleValue <$> P.float
|
|
|
|
MSSQL.RealType -> pure $ ODBC.DoubleValue <$> P.float
|
|
|
|
-- boolean
|
|
|
|
MSSQL.BitType -> pure $ ODBC.BoolValue <$> P.boolean
|
|
|
|
_ -> do
|
|
|
|
name <- MSSQL.mkMSSQLScalarTypeName scalarType
|
|
|
|
let schemaType = P.TNamed P.NonNullable $ P.Definition name Nothing Nothing [] P.TIScalar
|
|
|
|
pure $
|
|
|
|
P.Parser
|
|
|
|
{ pType = schemaType,
|
|
|
|
pParser =
|
|
|
|
P.valueToJSON (P.toGraphQLType schemaType)
|
|
|
|
>=> either (P.parseErrorWith P.ParseFailed . toErrorMessage . qeError) pure . (MSSQL.parseScalarValue scalarType)
|
|
|
|
}
|
|
|
|
ColumnEnumReference (EnumReference tableName enumValues customTableName) ->
|
|
|
|
case nonEmpty (Map.toList enumValues) of
|
|
|
|
Just enumValuesList ->
|
|
|
|
peelWithOrigin . fmap (ColumnValue columnType)
|
|
|
|
<$> msEnumParser tableName enumValuesList customTableName nullability
|
|
|
|
Nothing -> throw400 ValidationFailed "empty enum values"
|
2021-02-23 20:37:27 +03:00
|
|
|
where
|
2022-08-22 11:33:31 +03:00
|
|
|
-- CHAR/VARCHAR in MSSQL _can_ represent the full UCS (Universal Coded Character Set),
|
|
|
|
-- but might not always if the collation used is not UTF-8 enabled
|
|
|
|
-- https://docs.microsoft.com/en-us/sql/t-sql/data-types/char-and-varchar-transact-sql?view=sql-server-ver16
|
|
|
|
--
|
|
|
|
-- NCHAR/NVARCHAR in MSSQL are always able to represent the full UCS
|
|
|
|
-- https://docs.microsoft.com/en-us/sql/t-sql/data-types/nchar-and-nvarchar-transact-sql?view=sql-server-ver16
|
|
|
|
--
|
|
|
|
-- We'd prefer to encode as CHAR/VARCHAR literals to CHAR/VARCHAR columns, as this
|
|
|
|
-- means better index performance, BUT as we don't know what the collation
|
|
|
|
-- the column is set to (an example is 'SQL_Latin1_General_CP437_BIN') and thus
|
|
|
|
-- what characters are available in order to do this safely.
|
|
|
|
--
|
|
|
|
-- Therefore, we are conservative and only convert on the HGE side when the
|
|
|
|
-- characters are all ASCII and guaranteed to be in the target character
|
|
|
|
-- set, if not we pass an NCHAR/NVARCHAR and let MSSQL implicitly convert it.
|
|
|
|
|
|
|
|
-- resolves https://github.com/hasura/graphql-engine/issues/8735
|
|
|
|
mkCharValue :: Text -> ODBC.Value
|
|
|
|
mkCharValue txt =
|
|
|
|
if T.all Char.isAscii txt
|
|
|
|
then ODBC.ByteStringValue (TE.encodeUtf8 txt) -- an ODBC.ByteStringValue becomes a VARCHAR
|
|
|
|
else ODBC.TextValue txt -- an ODBC.TextValue becomes an NVARCHAR
|
2021-02-23 20:37:27 +03:00
|
|
|
|
2022-09-14 00:21:07 +03:00
|
|
|
msEnumParser ::
|
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
|
|
|
TableName 'MSSQL ->
|
|
|
|
NonEmpty (EnumValue, EnumValueInfo) ->
|
|
|
|
Maybe G.Name ->
|
|
|
|
G.Nullability ->
|
|
|
|
SchemaT r m (Parser 'Both n (ScalarValue 'MSSQL))
|
|
|
|
msEnumParser tableName enumValues customTableName nullability = do
|
|
|
|
enumName <- mkEnumTypeName @'MSSQL tableName customTableName
|
|
|
|
pure $ msPossiblyNullable MSSQL.VarcharType nullability $ P.enum enumName Nothing (mkEnumValue <$> enumValues)
|
|
|
|
where
|
|
|
|
mkEnumValue :: (EnumValue, EnumValueInfo) -> (P.Definition P.EnumValueInfo, ScalarValue 'MSSQL)
|
|
|
|
mkEnumValue (EnumValue value, EnumValueInfo description) =
|
|
|
|
( P.Definition value (G.Description <$> description) Nothing [] P.EnumValueInfo,
|
|
|
|
ODBC.TextValue $ G.unName value
|
|
|
|
)
|
|
|
|
|
|
|
|
msPossiblyNullable ::
|
|
|
|
(MonadParse m) =>
|
|
|
|
ScalarType 'MSSQL ->
|
|
|
|
G.Nullability ->
|
|
|
|
Parser 'Both m (ScalarValue 'MSSQL) ->
|
|
|
|
Parser 'Both m (ScalarValue 'MSSQL)
|
|
|
|
msPossiblyNullable _scalarType (G.Nullability isNullable)
|
|
|
|
| isNullable = fmap (fromMaybe ODBC.NullValue) . P.nullable
|
|
|
|
| otherwise = id
|
|
|
|
|
2021-02-23 20:37:27 +03:00
|
|
|
msOrderByOperators ::
|
2022-05-26 14:54:30 +03:00
|
|
|
NamingCase ->
|
2022-06-10 06:59:00 +03:00
|
|
|
( G.Name,
|
|
|
|
NonEmpty
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
( P.Definition P.EnumValueInfo,
|
2022-06-10 06:59:00 +03:00
|
|
|
(BasicOrderType 'MSSQL, NullsOrderType 'MSSQL)
|
2021-02-23 20:37:27 +03:00
|
|
|
)
|
2022-06-10 06:59:00 +03:00
|
|
|
)
|
|
|
|
msOrderByOperators _tCase =
|
2022-06-23 12:14:24 +03:00
|
|
|
(Name._order_by,) $
|
2022-06-10 06:59:00 +03:00
|
|
|
-- NOTE: NamingCase is not being used here as we don't support naming conventions for this DB
|
|
|
|
NE.fromList
|
2022-06-23 12:14:24 +03:00
|
|
|
[ ( define Name._asc "in ascending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.AscOrder, MSSQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._asc_nulls_first "in ascending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.AscOrder, MSSQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._asc_nulls_last "in ascending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.AscOrder, MSSQL.NullsLast)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc "in descending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.DescOrder, MSSQL.NullsLast)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc_nulls_first "in descending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.DescOrder, MSSQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc_nulls_last "in descending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MSSQL.DescOrder, MSSQL.NullsLast)
|
|
|
|
)
|
|
|
|
]
|
2021-02-23 20:37:27 +03:00
|
|
|
where
|
2022-07-25 18:53:25 +03:00
|
|
|
define name desc = P.Definition name (Just desc) Nothing [] P.EnumValueInfo
|
2021-02-23 20:37:27 +03:00
|
|
|
|
|
|
|
msComparisonExps ::
|
2021-04-08 11:25:11 +03:00
|
|
|
forall m n r.
|
2022-09-06 19:48:04 +03:00
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
2021-02-23 20:37:27 +03:00
|
|
|
ColumnType 'MSSQL ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (Parser 'Input n [ComparisonExp 'MSSQL])
|
2021-02-23 20:37:27 +03:00
|
|
|
msComparisonExps = P.memoize 'comparisonExps \columnType -> do
|
|
|
|
-- see Note [Columns in comparison expression are never nullable]
|
2022-07-14 20:57:28 +03:00
|
|
|
collapseIfNull <- retrieve Options.soDangerousBooleanCollapse
|
2021-04-08 11:25:11 +03:00
|
|
|
|
|
|
|
-- parsers used for individual values
|
2021-02-23 20:37:27 +03:00
|
|
|
typedParser <- columnParser columnType (G.Nullability False)
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
let columnListParser = fmap openValueOrigin <$> P.list typedParser
|
2021-04-08 11:25:11 +03:00
|
|
|
|
|
|
|
-- field info
|
2022-06-23 12:14:24 +03:00
|
|
|
let name = P.getName typedParser <> Name.__MSSQL_comparison_exp
|
2021-04-08 11:25:11 +03:00
|
|
|
desc =
|
|
|
|
G.Description $
|
|
|
|
"Boolean expression to compare columns of type "
|
|
|
|
<> P.getName typedParser
|
|
|
|
<<> ". All fields are combined with logical 'AND'."
|
2021-09-24 01:56:37 +03:00
|
|
|
|
2022-05-26 14:54:30 +03:00
|
|
|
-- Naming convention
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
tCase <- retrieve $ _rscNamingConvention . _siCustomization @'MSSQL
|
2022-05-26 14:54:30 +03:00
|
|
|
|
2021-03-19 15:42:09 +03:00
|
|
|
pure $
|
|
|
|
P.object name (Just desc) $
|
|
|
|
fmap catMaybes $
|
|
|
|
sequenceA $
|
|
|
|
concat
|
|
|
|
[ -- Common ops for all types
|
2021-04-08 11:25:11 +03:00
|
|
|
equalityOperators
|
2022-05-26 14:54:30 +03:00
|
|
|
tCase
|
2021-04-08 11:25:11 +03:00
|
|
|
collapseIfNull
|
|
|
|
(mkParameter <$> typedParser)
|
|
|
|
(mkListLiteral <$> columnListParser),
|
|
|
|
comparisonOperators
|
2022-05-26 14:54:30 +03:00
|
|
|
tCase
|
2021-04-08 11:25:11 +03:00
|
|
|
collapseIfNull
|
|
|
|
(mkParameter <$> typedParser),
|
2021-03-19 15:42:09 +03:00
|
|
|
-- Ops for String like types
|
|
|
|
guard (isScalarColumnWhere (`elem` MSSQL.stringTypes) columnType)
|
|
|
|
*> [ P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__like
|
2021-03-19 15:42:09 +03:00
|
|
|
(Just "does the column match the given pattern")
|
|
|
|
(ALIKE . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__nlike
|
2021-03-19 15:42:09 +03:00
|
|
|
(Just "does the column NOT match the given pattern")
|
|
|
|
(ANLIKE . mkParameter <$> typedParser)
|
|
|
|
],
|
2021-03-24 16:43:40 +03:00
|
|
|
-- Ops for Geometry/Geography types
|
|
|
|
guard (isScalarColumnWhere (`elem` MSSQL.geoTypes) columnType)
|
|
|
|
*> [ P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_contains
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "does the column contain the given value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTContains . mkParameter <$> typedParser),
|
2021-03-24 16:43:40 +03:00
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_equals
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "is the column equal to given value (directionality is ignored)")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTEquals . mkParameter <$> typedParser),
|
2021-03-24 16:43:40 +03:00
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_intersects
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "does the column spatially intersect the given value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTIntersects . mkParameter <$> typedParser),
|
2021-03-24 16:43:40 +03:00
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_overlaps
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "does the column 'spatially overlap' (intersect but not completely contain) the given value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTOverlaps . mkParameter <$> typedParser),
|
2021-03-24 16:43:40 +03:00
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_within
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "is the column contained in the given value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTWithin . mkParameter <$> typedParser)
|
2021-03-24 16:43:40 +03:00
|
|
|
],
|
|
|
|
-- Ops for Geometry types
|
|
|
|
guard (isScalarColumnWhere (MSSQL.GeometryType ==) columnType)
|
|
|
|
*> [ P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_crosses
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "does the column cross the given geometry value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTCrosses . mkParameter <$> typedParser),
|
2021-03-24 16:43:40 +03:00
|
|
|
P.fieldOptional
|
2022-06-23 12:14:24 +03:00
|
|
|
Name.__st_touches
|
2021-03-24 16:43:40 +03:00
|
|
|
(Just "does the column have at least one point in common with the given geometry value")
|
2021-03-25 20:50:08 +03:00
|
|
|
(ABackendSpecific . MSSQL.ASTTouches . mkParameter <$> typedParser)
|
2021-03-24 16:43:40 +03:00
|
|
|
]
|
2021-02-23 20:37:27 +03:00
|
|
|
]
|
2021-03-19 15:42:09 +03:00
|
|
|
where
|
|
|
|
mkListLiteral :: [ColumnValue 'MSSQL] -> UnpreparedValue 'MSSQL
|
|
|
|
mkListLiteral =
|
2022-05-31 01:07:02 +03:00
|
|
|
UVLiteral . MSSQL.ListExpression . fmap (MSSQL.ValueExpression . cvValue)
|
2021-02-23 20:37:27 +03:00
|
|
|
|
2022-01-18 17:53:44 +03:00
|
|
|
msCountTypeInput ::
|
|
|
|
MonadParse n =>
|
|
|
|
Maybe (Parser 'Both n (Column 'MSSQL)) ->
|
|
|
|
InputFieldsParser n (IR.CountDistinct -> CountType 'MSSQL)
|
|
|
|
msCountTypeInput = \case
|
|
|
|
Just columnEnum -> do
|
2022-06-23 12:14:24 +03:00
|
|
|
column <- P.fieldOptional Name._column Nothing columnEnum
|
2022-01-18 17:53:44 +03:00
|
|
|
pure $ flip mkCountType column
|
|
|
|
Nothing -> pure $ flip mkCountType Nothing
|
|
|
|
where
|
|
|
|
mkCountType :: IR.CountDistinct -> Maybe (Column 'MSSQL) -> CountType 'MSSQL
|
|
|
|
mkCountType _ Nothing = MSSQL.StarCountable
|
|
|
|
mkCountType IR.SelectCountDistinct (Just col) = MSSQL.DistinctCountable col
|
|
|
|
mkCountType IR.SelectCountNonDistinct (Just col) = MSSQL.NonNullFieldCountable col
|
2023-01-10 04:54:40 +03:00
|
|
|
|
|
|
|
msParseUpdateOperators ::
|
|
|
|
forall m n r.
|
|
|
|
MonadBuildSchema 'MSSQL r m n =>
|
|
|
|
TableInfo 'MSSQL ->
|
|
|
|
UpdPermInfo 'MSSQL ->
|
|
|
|
SchemaT r m (InputFieldsParser n (HashMap (Column 'MSSQL) (UpdateOperators 'MSSQL (UnpreparedValue 'MSSQL))))
|
|
|
|
msParseUpdateOperators tableInfo updatePermissions = do
|
|
|
|
SU.buildUpdateOperators
|
|
|
|
(UpdateSet <$> SU.presetColumns updatePermissions)
|
|
|
|
[ UpdateSet <$> SU.setOp,
|
|
|
|
UpdateInc <$> SU.incOp
|
|
|
|
]
|
|
|
|
tableInfo
|