2021-06-11 06:26:50 +03:00
|
|
|
module Hasura.GraphQL.Execute.RemoteJoin.Collect
|
2021-09-24 01:56:37 +03:00
|
|
|
( getRemoteJoins,
|
|
|
|
getRemoteJoinsSelect,
|
|
|
|
getRemoteJoinsMutationDB,
|
|
|
|
getRemoteJoinsActionQuery,
|
|
|
|
getRemoteJoinsActionMutation,
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
getRemoteJoinsGraphQLField,
|
2021-09-24 01:56:37 +03:00
|
|
|
)
|
|
|
|
where
|
|
|
|
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
import Control.Lens (Traversal', preview, (^?), _2)
|
2021-09-24 01:56:37 +03:00
|
|
|
import Control.Monad.Writer
|
|
|
|
import Data.HashMap.Strict qualified as Map
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
import Data.HashMap.Strict.InsOrd qualified as OMap
|
2022-03-01 19:03:23 +03:00
|
|
|
import Data.HashMap.Strict.NonEmpty (NEHashMap)
|
|
|
|
import Data.HashMap.Strict.NonEmpty qualified as NEMap
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.Text qualified as T
|
|
|
|
import Hasura.GraphQL.Execute.RemoteJoin.Types
|
|
|
|
import Hasura.GraphQL.Parser.Column (UnpreparedValue (..))
|
|
|
|
import Hasura.Prelude
|
|
|
|
import Hasura.RQL.IR
|
|
|
|
import Hasura.RQL.Types
|
|
|
|
import Hasura.SQL.AnyBackend qualified as AB
|
2022-03-03 06:43:27 +03:00
|
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
2021-06-11 06:26:50 +03:00
|
|
|
|
2022-03-01 19:03:23 +03:00
|
|
|
{- Note [Remote Joins Architecture]
|
2021-06-11 06:26:50 +03:00
|
|
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
2022-03-01 19:03:23 +03:00
|
|
|
Unparsed Incoming GraphQL +------------------------------+
|
|
|
|
--------------------------> | Parsing of the GraphQL query |-----+
|
|
|
|
+------------------------------+ |
|
|
|
|
| DB Query and remote joins (if any)
|
|
|
|
|
|
|
|
|
V
|
|
|
|
+----------------------------------+ SQL query response +----------------------------+
|
|
|
|
| Traverse the DB response to | <------------------- | Execution of the DB query |
|
|
|
|
| get the values of the arguments | +----------------------------+
|
|
|
|
| of the remote field |
|
|
|
|
+----------------------------------+
|
|
|
|
|
|
|
|
|
| Remote field arguments
|
|
|
|
V
|
|
|
|
+--------------------------+ Remote schema response +----------------------------------------+
|
|
|
|
| Query the remote schema | ------------------------> | Replace the remote join fields in |
|
|
|
|
| with the remote field | | the SQL query response (JSON) with |
|
|
|
|
| arguments to the remote | | the response obtained from the remote |
|
|
|
|
| field configured in the | | schema at appropriate places. |
|
|
|
|
| remote join. | +----------------------------------------+
|
|
|
|
+--------------------------+
|
2021-06-11 06:26:50 +03:00
|
|
|
-}
|
|
|
|
|
2021-08-06 16:39:00 +03:00
|
|
|
-- | A writer monad used to collect together all remote joins
|
|
|
|
-- appearing in some data structure.
|
|
|
|
--
|
|
|
|
-- In the functions below, the 'withField' function is used to track the
|
|
|
|
-- context of the path from the root of the current selection set.
|
|
|
|
--
|
|
|
|
-- It is important that we work bottom-up, and do not 'collect' duplicate
|
|
|
|
-- field names at any level, because the 'Semigroup' instance for 'RemoteJoins'
|
|
|
|
-- does not allow for these duplicates.
|
2021-09-24 01:56:37 +03:00
|
|
|
newtype Collector a = Collector {runCollector :: (a, Maybe RemoteJoins)}
|
|
|
|
deriving
|
|
|
|
(Functor, Applicative, Monad, MonadWriter (Maybe RemoteJoins))
|
2021-08-06 16:39:00 +03:00
|
|
|
via Writer (Maybe RemoteJoins)
|
|
|
|
|
|
|
|
-- | Collect some remote joins appearing at the given field names in the current
|
|
|
|
-- context.
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
collect :: NEHashMap QualifiedFieldName RemoteJoin -> Collector ()
|
2022-03-01 19:03:23 +03:00
|
|
|
collect = tell . Just . JoinTree . fmap Leaf
|
2021-08-06 16:39:00 +03:00
|
|
|
|
|
|
|
-- | Keep track of the given field name in the current path from the root of the
|
|
|
|
-- selection set.
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
withField :: Maybe Text -> Text -> Collector a -> Collector a
|
|
|
|
withField typeName fieldName = censor (fmap wrap)
|
2021-09-24 01:56:37 +03:00
|
|
|
where
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
wrap rjs = JoinTree $ NEMap.singleton (QualifiedFieldName typeName fieldName) (Tree rjs)
|
2021-08-06 16:39:00 +03:00
|
|
|
|
2021-06-11 06:26:50 +03:00
|
|
|
-- | Collects remote joins from the AST and also adds the necessary join fields
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoins ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
QueryDB b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(QueryDB b Void (UnpreparedValue b), Maybe RemoteJoins)
|
2021-06-11 06:26:50 +03:00
|
|
|
getRemoteJoins = \case
|
|
|
|
QDBMultipleRows s -> first QDBMultipleRows $ getRemoteJoinsSelect s
|
2021-09-24 01:56:37 +03:00
|
|
|
QDBSingleRow s -> first QDBSingleRow $ getRemoteJoinsSelect s
|
|
|
|
QDBAggregation s -> first QDBAggregation $ getRemoteJoinsAggregateSelect s
|
|
|
|
QDBConnection s -> first QDBConnection $ getRemoteJoinsConnectionSelect s
|
2021-06-11 06:26:50 +03:00
|
|
|
|
|
|
|
-- | Traverse through 'AnnSimpleSel' and collect remote join fields (if any).
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnSimpleSelectG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(AnnSimpleSelectG b Void (UnpreparedValue b), Maybe RemoteJoins)
|
2021-06-11 06:26:50 +03:00
|
|
|
getRemoteJoinsSelect =
|
2021-08-06 16:39:00 +03:00
|
|
|
runCollector . transformSelect
|
2021-06-11 06:26:50 +03:00
|
|
|
|
|
|
|
-- | Traverse through @'AnnAggregateSelect' and collect remote join fields (if any).
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsAggregateSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnAggregateSelectG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(AnnAggregateSelectG b Void (UnpreparedValue b), Maybe RemoteJoins)
|
2021-06-11 06:26:50 +03:00
|
|
|
getRemoteJoinsAggregateSelect =
|
2021-08-06 16:39:00 +03:00
|
|
|
runCollector . transformAggregateSelect
|
2021-06-11 06:26:50 +03:00
|
|
|
|
|
|
|
-- | Traverse through @'ConnectionSelect' and collect remote join fields (if any).
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsConnectionSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
ConnectionSelect b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(ConnectionSelect b Void (UnpreparedValue b), Maybe RemoteJoins)
|
2021-06-11 06:26:50 +03:00
|
|
|
getRemoteJoinsConnectionSelect =
|
2021-08-06 16:39:00 +03:00
|
|
|
runCollector . transformConnectionSelect
|
2021-06-11 06:26:50 +03:00
|
|
|
|
|
|
|
-- | Traverse through 'MutationOutput' and collect remote join fields (if any)
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsMutationOutput ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
MutationOutputG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(MutationOutputG b Void (UnpreparedValue b), Maybe RemoteJoins)
|
2021-06-11 06:26:50 +03:00
|
|
|
getRemoteJoinsMutationOutput =
|
2021-08-06 16:39:00 +03:00
|
|
|
runCollector . transformMutationOutput
|
2021-06-11 06:26:50 +03:00
|
|
|
where
|
2021-08-06 16:39:00 +03:00
|
|
|
transformMutationOutput = \case
|
2021-06-11 06:26:50 +03:00
|
|
|
MOutMultirowFields mutationFields ->
|
|
|
|
MOutMultirowFields <$> transfromMutationFields mutationFields
|
|
|
|
MOutSinglerowObject annFields ->
|
2021-08-06 16:39:00 +03:00
|
|
|
MOutSinglerowObject <$> transformAnnFields annFields
|
2021-06-11 06:26:50 +03:00
|
|
|
where
|
|
|
|
transfromMutationFields fields =
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
for fields $ \(fieldName, field') -> withField Nothing (getFieldNameTxt fieldName) do
|
2021-08-06 16:39:00 +03:00
|
|
|
(fieldName,) <$> case field' of
|
2021-09-24 01:56:37 +03:00
|
|
|
MCount -> pure MCount
|
|
|
|
MExp t -> pure $ MExp t
|
2021-08-06 16:39:00 +03:00
|
|
|
MRet annFields -> MRet <$> transformAnnFields annFields
|
2021-06-11 06:26:50 +03:00
|
|
|
|
|
|
|
-- local helpers
|
|
|
|
|
2021-12-16 02:51:52 +03:00
|
|
|
getRemoteJoinsActionFields ::
|
2022-03-03 06:43:27 +03:00
|
|
|
ActionFieldsG (RemoteRelationshipField UnpreparedValue) ->
|
|
|
|
(ActionFieldsG Void, Maybe RemoteJoins)
|
2021-12-16 02:51:52 +03:00
|
|
|
getRemoteJoinsActionFields =
|
|
|
|
runCollector . transformActionFields
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsMutationDB ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
MutationDB b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
(MutationDB b Void (UnpreparedValue b), Maybe RemoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
getRemoteJoinsMutationDB = \case
|
|
|
|
MDBInsert insert ->
|
|
|
|
first MDBInsert $ getRemoteJoinsInsert insert
|
|
|
|
MDBUpdate update ->
|
|
|
|
first MDBUpdate $ getRemoteJoinsUpdate update
|
|
|
|
MDBDelete delete ->
|
|
|
|
first MDBDelete $ getRemoteJoinsDelete delete
|
|
|
|
MDBFunction aggSelect select ->
|
|
|
|
first (MDBFunction aggSelect) $ getRemoteJoinsSelect select
|
|
|
|
where
|
|
|
|
getRemoteJoinsInsert insert =
|
|
|
|
let (output', remoteJoins) = getRemoteJoinsMutationOutput $ _aiOutput insert
|
2021-09-24 01:56:37 +03:00
|
|
|
in (insert {_aiOutput = output'}, remoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
|
|
|
getRemoteJoinsUpdate update =
|
2021-11-25 00:39:42 +03:00
|
|
|
let (output', remoteJoins) = getRemoteJoinsMutationOutput $ _auOutput update
|
|
|
|
in (update {_auOutput = output'}, remoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
|
|
|
getRemoteJoinsDelete delete =
|
|
|
|
let (output', remoteJoins) = getRemoteJoinsMutationOutput $ dqp1Output delete
|
2021-09-24 01:56:37 +03:00
|
|
|
in (delete {dqp1Output = output'}, remoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsSyncAction ::
|
2022-03-03 06:43:27 +03:00
|
|
|
AnnActionExecution (RemoteRelationshipField UnpreparedValue) ->
|
|
|
|
(AnnActionExecution Void, Maybe RemoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
getRemoteJoinsSyncAction actionExecution =
|
2021-12-16 02:51:52 +03:00
|
|
|
let (fields', remoteJoins) = getRemoteJoinsActionFields $ _aaeFields actionExecution
|
2021-09-24 01:56:37 +03:00
|
|
|
in (actionExecution {_aaeFields = fields'}, remoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsActionQuery ::
|
2022-03-03 06:43:27 +03:00
|
|
|
ActionQuery (RemoteRelationshipField UnpreparedValue) ->
|
|
|
|
(ActionQuery Void, Maybe RemoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
getRemoteJoinsActionQuery = \case
|
|
|
|
AQQuery sync ->
|
|
|
|
first AQQuery $ getRemoteJoinsSyncAction sync
|
|
|
|
AQAsync async ->
|
|
|
|
first AQAsync $ getRemoteJoinsAsyncQuery async
|
|
|
|
where
|
|
|
|
getRemoteJoinsAsyncQuery async =
|
|
|
|
let (fields', remoteJoins) =
|
2021-08-06 16:39:00 +03:00
|
|
|
runCollector . transformAsyncFields $
|
2021-09-24 01:56:37 +03:00
|
|
|
_aaaqFields async
|
|
|
|
in (async {_aaaqFields = fields'}, remoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
2021-08-06 16:39:00 +03:00
|
|
|
transformAsyncFields fields =
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
for fields $ \(fieldName, field) -> withField Nothing (getFieldNameTxt fieldName) do
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
(fieldName,) <$> case field of
|
|
|
|
AsyncTypename t -> pure $ AsyncTypename t
|
|
|
|
AsyncOutput outputFields ->
|
2021-12-16 02:51:52 +03:00
|
|
|
AsyncOutput <$> transformActionFields outputFields
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
AsyncId -> pure AsyncId
|
|
|
|
AsyncCreatedAt -> pure AsyncCreatedAt
|
|
|
|
AsyncErrors -> pure AsyncErrors
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsActionMutation ::
|
2022-03-03 06:43:27 +03:00
|
|
|
ActionMutation (RemoteRelationshipField UnpreparedValue) ->
|
|
|
|
(ActionMutation Void, Maybe RemoteJoins)
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
getRemoteJoinsActionMutation = \case
|
|
|
|
AMAsync async -> (AMAsync async, Nothing)
|
2021-09-24 01:56:37 +03:00
|
|
|
AMSync sync -> first AMSync $ getRemoteJoinsSyncAction sync
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
transformSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnSimpleSelectG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
Collector (AnnSimpleSelectG b Void (UnpreparedValue b))
|
2021-09-24 01:56:37 +03:00
|
|
|
transformSelect select@AnnSelectG {_asnFields = fields} = do
|
2021-06-11 06:26:50 +03:00
|
|
|
-- Transform selects in array, object and computed fields
|
2021-08-06 16:39:00 +03:00
|
|
|
transformedFields <- transformAnnFields fields
|
2021-09-24 01:56:37 +03:00
|
|
|
pure select {_asnFields = transformedFields}
|
2021-06-11 06:26:50 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
transformAggregateSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnAggregateSelectG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
Collector (AnnAggregateSelectG b Void (UnpreparedValue b))
|
2021-09-24 01:56:37 +03:00
|
|
|
transformAggregateSelect select@AnnSelectG {_asnFields = aggFields} = do
|
2021-08-06 16:39:00 +03:00
|
|
|
transformedFields <- for aggFields \(fieldName, aggField) ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
withField Nothing (getFieldNameTxt fieldName) $ case aggField of
|
2021-09-24 01:56:37 +03:00
|
|
|
TAFAgg agg -> pure (fieldName, TAFAgg agg)
|
|
|
|
TAFExp t -> pure (fieldName, TAFExp t)
|
|
|
|
TAFNodes nodesAgg annFields -> do
|
|
|
|
transformed <- transformAnnFields annFields
|
|
|
|
pure (fieldName, TAFNodes nodesAgg transformed)
|
|
|
|
pure select {_asnFields = transformedFields}
|
|
|
|
|
|
|
|
transformConnectionSelect ::
|
|
|
|
forall b.
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
ConnectionSelect b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
Collector (ConnectionSelect b Void (UnpreparedValue b))
|
2021-09-24 01:56:37 +03:00
|
|
|
transformConnectionSelect connSelect@ConnectionSelect {..} = do
|
2021-08-06 16:39:00 +03:00
|
|
|
transformedFields <- for (_asnFields _csSelect) \(fieldName, connField) ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
withField Nothing (getFieldNameTxt fieldName) $ case connField of
|
2021-09-24 01:56:37 +03:00
|
|
|
ConnectionTypename t -> pure (fieldName, ConnectionTypename t)
|
|
|
|
ConnectionPageInfo p -> pure (fieldName, ConnectionPageInfo p)
|
2021-08-06 16:39:00 +03:00
|
|
|
ConnectionEdges edges -> do
|
|
|
|
transformed <- transformEdges edges
|
|
|
|
pure (fieldName, ConnectionEdges transformed)
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
let select = _csSelect {_asnFields = transformedFields}
|
|
|
|
pure connSelect {_csSelect = select}
|
2021-06-11 06:26:50 +03:00
|
|
|
where
|
2021-09-24 01:56:37 +03:00
|
|
|
transformEdges ::
|
2021-12-07 16:12:02 +03:00
|
|
|
[(FieldName, EdgeField b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b))] ->
|
|
|
|
Collector [(FieldName, EdgeField b Void (UnpreparedValue b))]
|
2021-08-06 16:39:00 +03:00
|
|
|
transformEdges edgeFields = for edgeFields \(fieldName, edgeField) ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
withField Nothing (getFieldNameTxt fieldName) $ case edgeField of
|
2021-09-24 01:56:37 +03:00
|
|
|
EdgeTypename t -> pure (fieldName, EdgeTypename t)
|
|
|
|
EdgeCursor -> pure (fieldName, EdgeCursor)
|
2021-08-06 16:39:00 +03:00
|
|
|
EdgeNode annFields -> do
|
|
|
|
transformed <- transformAnnFields annFields
|
|
|
|
pure (fieldName, EdgeNode transformed)
|
2021-06-11 06:26:50 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
transformObjectSelect ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnObjectSelectG b (RemoteRelationshipField UnpreparedValue) (UnpreparedValue b) ->
|
|
|
|
Collector (AnnObjectSelectG b Void (UnpreparedValue b))
|
2021-09-24 01:56:37 +03:00
|
|
|
transformObjectSelect select@AnnObjectSelectG {_aosFields = fields} = do
|
2021-08-06 16:39:00 +03:00
|
|
|
transformedFields <- transformAnnFields fields
|
2021-09-24 01:56:37 +03:00
|
|
|
pure select {_aosFields = transformedFields}
|
2021-06-11 06:26:50 +03:00
|
|
|
|
2021-12-07 16:12:02 +03:00
|
|
|
-- | Converts a remote relationship field into a 'RemoteJoin' that
|
|
|
|
-- the execution engine understands
|
|
|
|
createRemoteJoin ::
|
|
|
|
-- We need information about 'how' the lhs join fields appear in the lhs
|
|
|
|
-- response to construct a 'RemoteJoin' node
|
|
|
|
Map.HashMap FieldName JoinColumnAlias ->
|
|
|
|
-- The remote relationship field as captured in the IR
|
|
|
|
RemoteRelationshipField UnpreparedValue ->
|
|
|
|
RemoteJoin
|
|
|
|
createRemoteJoin joinColumnAliases remoteRelationship =
|
|
|
|
case remoteRelationship of
|
|
|
|
RemoteSchemaField RemoteSchemaSelect {..} ->
|
|
|
|
let inputArgsToMap = Map.fromList . map (_rfaArgument &&& _rfaValue)
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
(transformedSchemaRelationship, schemaRelationshipJoins) =
|
|
|
|
getRemoteJoinsGraphQLSelectionSet _rselSelection
|
2021-12-07 16:12:02 +03:00
|
|
|
remoteJoin =
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
RemoteSchemaJoin
|
|
|
|
(inputArgsToMap _rselArgs)
|
|
|
|
_rselResultCustomizer
|
|
|
|
transformedSchemaRelationship
|
|
|
|
joinColumnAliases
|
|
|
|
_rselFieldCall
|
|
|
|
_rselRemoteSchema
|
|
|
|
in RemoteJoinRemoteSchema remoteJoin schemaRelationshipJoins
|
2021-12-07 16:12:02 +03:00
|
|
|
RemoteSourceField anySourceSelect ->
|
|
|
|
AB.dispatchAnyBackend @Backend anySourceSelect \RemoteSourceSelect {..} ->
|
|
|
|
let (transformedSourceRelationship, sourceRelationshipJoins) =
|
|
|
|
getRemoteJoinsSourceRelation _rssSelection
|
|
|
|
|
|
|
|
-- the invariant here is that the the keys in joinColumnAliases and
|
|
|
|
-- _rssJoinMapping are the same. We could've opted for a more type
|
|
|
|
-- safe representation Map k (a, b) instead of (Map k a, Map k b)
|
|
|
|
-- but that would make the type of lhs join columns creep into
|
|
|
|
-- RemoteRelationshipField which would make the type a little
|
|
|
|
-- unweildy
|
|
|
|
joinColumns =
|
|
|
|
_rssJoinMapping & Map.mapMaybeWithKey
|
|
|
|
\joinFieldName (rhsColumn, rhsColumnType) ->
|
|
|
|
(,rhsColumn,rhsColumnType)
|
|
|
|
<$> Map.lookup joinFieldName joinColumnAliases
|
|
|
|
anySourceJoin =
|
|
|
|
AB.mkAnyBackend $
|
|
|
|
RemoteSourceJoin
|
|
|
|
_rssName
|
|
|
|
_rssConfig
|
|
|
|
transformedSourceRelationship
|
|
|
|
joinColumns
|
|
|
|
in RemoteJoinSource anySourceJoin sourceRelationshipJoins
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
transformAnnFields ::
|
|
|
|
forall src.
|
|
|
|
Backend src =>
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnFieldsG src (RemoteRelationshipField UnpreparedValue) (UnpreparedValue src) ->
|
|
|
|
Collector (AnnFieldsG src Void (UnpreparedValue src))
|
2021-08-06 16:39:00 +03:00
|
|
|
transformAnnFields fields = do
|
|
|
|
-- Produces a list of transformed fields that may or may not have an
|
|
|
|
-- associated remote join.
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
annotatedFields <- for fields \(fieldName, field') -> withField Nothing (getFieldNameTxt fieldName) do
|
2021-06-11 06:26:50 +03:00
|
|
|
(fieldName,) <$> case field' of
|
2021-08-06 16:39:00 +03:00
|
|
|
-- AnnFields which do not need to be transformed.
|
|
|
|
AFNodeId x qt pkeys -> pure (AFNodeId x qt pkeys, Nothing)
|
2021-09-24 01:56:37 +03:00
|
|
|
AFColumn c -> pure (AFColumn c, Nothing)
|
|
|
|
AFExpression t -> pure (AFExpression t, Nothing)
|
2021-08-06 16:39:00 +03:00
|
|
|
-- AnnFields with no associated remote joins and whose transformations are
|
|
|
|
-- relatively straightforward.
|
|
|
|
AFObjectRelation annRel -> do
|
|
|
|
transformed <- transformAnnRelation transformObjectSelect annRel
|
|
|
|
pure (AFObjectRelation transformed, Nothing)
|
|
|
|
AFArrayRelation (ASSimple annRel) -> do
|
|
|
|
transformed <- transformAnnRelation transformSelect annRel
|
|
|
|
pure (AFArrayRelation . ASSimple $ transformed, Nothing)
|
|
|
|
AFArrayRelation (ASAggregate aggRel) -> do
|
|
|
|
transformed <- transformAnnRelation transformAggregateSelect aggRel
|
|
|
|
pure (AFArrayRelation . ASAggregate $ transformed, Nothing)
|
|
|
|
AFArrayRelation (ASConnection annRel) -> do
|
|
|
|
transformed <- transformAnnRelation transformConnectionSelect annRel
|
|
|
|
pure (AFArrayRelation . ASConnection $ transformed, Nothing)
|
|
|
|
AFComputedField computedField computedFieldName computedFieldSelect -> do
|
|
|
|
transformed <- case computedFieldSelect of
|
2021-09-24 01:56:37 +03:00
|
|
|
CFSScalar cfss cbe -> pure $ CFSScalar cfss cbe
|
2021-08-06 16:39:00 +03:00
|
|
|
CFSTable jsonAggSel annSel -> do
|
|
|
|
transformed <- transformSelect annSel
|
|
|
|
pure $ CFSTable jsonAggSel transformed
|
|
|
|
pure (AFComputedField computedField computedFieldName transformed, Nothing)
|
|
|
|
-- Remote AnnFields, whose elements require annotation so that they can be
|
|
|
|
-- used to construct a remote join.
|
2021-12-07 16:12:02 +03:00
|
|
|
AFRemote RemoteRelationshipSelect {..} ->
|
|
|
|
pure
|
|
|
|
( -- We generate this so that the response has a key with the relationship,
|
|
|
|
-- without which preserving the order of fields in the final response
|
|
|
|
-- would require a lot of bookkeeping.
|
|
|
|
remoteAnnPlaceholder,
|
|
|
|
Just $ createRemoteJoin joinColumnAliases _rrsRelationship
|
|
|
|
)
|
2021-09-24 01:56:37 +03:00
|
|
|
|
|
|
|
let transformedFields = (fmap . fmap) fst annotatedFields
|
|
|
|
remoteJoins =
|
|
|
|
annotatedFields & mapMaybe \(fieldName, (_, mRemoteJoin)) ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
(QualifiedFieldName Nothing (getFieldNameTxt fieldName),) <$> mRemoteJoin
|
2021-12-07 16:12:02 +03:00
|
|
|
|
2022-03-01 19:03:23 +03:00
|
|
|
case NEMap.fromList remoteJoins of
|
2021-06-11 06:26:50 +03:00
|
|
|
Nothing -> pure transformedFields
|
2021-08-06 16:39:00 +03:00
|
|
|
Just neRemoteJoins -> do
|
2021-12-07 16:12:02 +03:00
|
|
|
collect neRemoteJoins
|
2021-08-06 16:39:00 +03:00
|
|
|
pure $ transformedFields <> phantomFields
|
server: IR for DB-DB joins
### Description
This PR adds the required IR for DB to DB joins, based on @paf31 and @0x777 's `feature/db-to-db` branch.
To do so, it also refactors the IR to introduce a new type parameter, `r`, which is used to recursively constructs the `v` parameter of remote QueryDBs. When collecting remote joins, we replace `r` with `Const Void`, indicating at the type level that there cannot be any leftover remote join.
Furthermore, this PR refactors IR.Select for readability, moves some code from IR.Root to IR.Select to avoid having to deal with circular dependencies, and makes it compile by adding `error` in all new cases in the execution pipeline.
The diff doesn't make it clear, but most of Select.hs is actually unchanged. Declarations have just been reordered by topic, in the following order:
- type declarations
- instance declarations
- type aliases
- constructor functions
- traverse functions
https://github.com/hasura/graphql-engine-mono/pull/1580
Co-authored-by: Phil Freeman <630306+paf31@users.noreply.github.com>
GitOrigin-RevId: bbdcb4119cec8bb3fc32f1294f91b8dea0728721
2021-06-18 02:12:11 +03:00
|
|
|
where
|
2021-08-06 16:39:00 +03:00
|
|
|
-- Placeholder text to annotate a remote relationship field.
|
2021-12-07 16:12:02 +03:00
|
|
|
remoteAnnPlaceholder :: AnnFieldG src Void (UnpreparedValue src)
|
2021-08-06 16:39:00 +03:00
|
|
|
remoteAnnPlaceholder = AFExpression "remote relationship placeholder"
|
|
|
|
|
|
|
|
-- This is a map of column name to its alias of all columns in the
|
|
|
|
-- selection set.
|
2021-09-22 13:43:05 +03:00
|
|
|
columnFields :: HashMap (Column src) FieldName
|
2021-09-24 01:56:37 +03:00
|
|
|
columnFields =
|
|
|
|
Map.fromList $
|
|
|
|
[ (_acfColumn annColumn, alias)
|
|
|
|
| (alias, annColumn) <- getFields _AFColumn fields
|
|
|
|
]
|
2021-08-06 16:39:00 +03:00
|
|
|
|
|
|
|
-- This is a map of computed field name to its alias of all computed fields
|
|
|
|
-- in the selection set.
|
|
|
|
computedFields :: Map.HashMap ComputedFieldName FieldName
|
2021-09-24 01:56:37 +03:00
|
|
|
computedFields =
|
|
|
|
Map.fromList $
|
|
|
|
[ (fieldName, alias)
|
|
|
|
| -- Note that we do not currently care about input arguments to a computed
|
|
|
|
-- field because only computed fields which do not accept input arguments
|
|
|
|
-- are currently allowed.
|
|
|
|
(alias, fieldName) <- getFields (_AFComputedField . _2) fields
|
|
|
|
]
|
|
|
|
|
2021-12-07 16:12:02 +03:00
|
|
|
-- Annotate a 'DBJoinField' with its field name and an alias so that it may
|
|
|
|
-- be used to construct a remote join.
|
|
|
|
annotateDBJoinField ::
|
|
|
|
FieldName -> DBJoinField src -> (DBJoinField src, JoinColumnAlias)
|
|
|
|
annotateDBJoinField fieldName = \case
|
|
|
|
jc@(JoinColumn column _) ->
|
|
|
|
let alias = getJoinColumnAlias fieldName column columnFields allAliases
|
|
|
|
in (jc, alias)
|
|
|
|
jcf@(JoinComputedField ScalarComputedField {..}) ->
|
|
|
|
let alias = getJoinColumnAlias fieldName _scfName computedFields allAliases
|
|
|
|
in (jcf, alias)
|
|
|
|
where
|
|
|
|
allAliases = map fst fields
|
|
|
|
|
|
|
|
-- goes through all the remote relationships in the selection set and emits
|
|
|
|
-- 1. a map of join field names to their aliases in the lhs response
|
|
|
|
-- 2. a list of extra fields that need to be included in the lhs query
|
|
|
|
-- that are required for the join
|
|
|
|
(joinColumnAliases, phantomFields) =
|
|
|
|
let lhsJoinFields =
|
|
|
|
Map.unions $ map (_rrsLHSJoinFields . snd) $ getFields _AFRemote fields
|
|
|
|
annotatedJoinColumns = Map.mapWithKey annotateDBJoinField $ lhsJoinFields
|
|
|
|
phantomFields_ =
|
|
|
|
toList annotatedJoinColumns & mapMaybe \(joinField, alias) ->
|
|
|
|
case alias of
|
|
|
|
JCSelected _ -> Nothing
|
|
|
|
JCPhantom a -> case joinField of
|
|
|
|
JoinColumn column columnType ->
|
|
|
|
let annotatedColumn =
|
|
|
|
AFColumn $ AnnColumnField column columnType False Nothing Nothing
|
|
|
|
in Just (a, annotatedColumn)
|
|
|
|
JoinComputedField computedFieldInfo ->
|
|
|
|
Just (a, mkScalarComputedFieldSelect computedFieldInfo)
|
|
|
|
in (fmap snd annotatedJoinColumns, phantomFields_)
|
2021-09-24 01:56:37 +03:00
|
|
|
|
|
|
|
mkScalarComputedFieldSelect ::
|
|
|
|
ScalarComputedField b ->
|
2021-12-07 16:12:02 +03:00
|
|
|
AnnFieldG b Void (UnpreparedValue b)
|
2021-09-24 01:56:37 +03:00
|
|
|
mkScalarComputedFieldSelect ScalarComputedField {..} =
|
|
|
|
let functionArgs =
|
|
|
|
flip FunctionArgsExp mempty $
|
|
|
|
functionArgsWithTableRowAndSession UVSession _scfTableArgument _scfSessionArgument
|
|
|
|
fieldSelect =
|
|
|
|
flip CFSScalar Nothing $
|
|
|
|
ComputedFieldScalarSelect _scfFunction functionArgs _scfType Nothing
|
|
|
|
in AFComputedField _scfXField _scfName fieldSelect
|
|
|
|
|
2022-03-03 06:43:27 +03:00
|
|
|
-- | Get the fields targeted by some 'Traversal' for an arbitrary list of
|
|
|
|
-- tuples, discarding any elements whose fields cannot be focused upon.
|
|
|
|
getFields :: Traversal' super sub -> [(any, super)] -> [(any, sub)]
|
|
|
|
getFields focus = mapMaybe (traverse $ preview focus)
|
|
|
|
|
2021-12-16 02:51:52 +03:00
|
|
|
-- | Annotate an element a remote source join from '_rssJoinMapping' so that
|
|
|
|
-- a remote join can be constructed.
|
|
|
|
transformAnnRelation ::
|
|
|
|
(a -> Collector b) ->
|
|
|
|
AnnRelationSelectG src a ->
|
|
|
|
Collector (AnnRelationSelectG src b)
|
|
|
|
transformAnnRelation transform relation@(AnnRelationSelectG _ _ select) = do
|
|
|
|
transformedSelect <- transform select
|
|
|
|
pure $ relation {aarAnnSelect = transformedSelect}
|
|
|
|
|
|
|
|
transformActionFields ::
|
2022-03-03 06:43:27 +03:00
|
|
|
ActionFieldsG (RemoteRelationshipField UnpreparedValue) ->
|
|
|
|
Collector (ActionFieldsG Void)
|
2021-12-16 02:51:52 +03:00
|
|
|
transformActionFields fields = do
|
|
|
|
-- Produces a list of transformed fields that may or may not have an
|
|
|
|
-- associated remote join.
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
annotatedFields <- for fields \(fieldName, field') -> withField Nothing (getFieldNameTxt fieldName) do
|
2022-03-03 06:43:27 +03:00
|
|
|
(fieldName,) <$> case field' of
|
|
|
|
-- ActionFields which do not need to be transformed.
|
|
|
|
ACFScalar c -> pure (ACFScalar c, Nothing)
|
|
|
|
ACFExpression t -> pure (ACFExpression t, Nothing)
|
|
|
|
-- Remote ActionFields, whose elements require annotation so that they can be
|
|
|
|
-- used to construct a remote join.
|
|
|
|
ACFRemote ActionRemoteRelationshipSelect {..} ->
|
|
|
|
pure
|
|
|
|
( -- We generate this so that the response has a key with the relationship,
|
|
|
|
-- without which preserving the order of fields in the final response
|
|
|
|
-- would require a lot of bookkeeping.
|
|
|
|
remoteActionPlaceholder,
|
|
|
|
Just $ createRemoteJoin joinColumnAliases _arrsRelationship
|
|
|
|
)
|
|
|
|
ACFNestedObject fn fs ->
|
|
|
|
(,Nothing) . ACFNestedObject fn <$> transformActionFields fs
|
|
|
|
|
|
|
|
let transformedFields = (fmap . fmap) fst annotatedFields
|
|
|
|
remoteJoins =
|
|
|
|
annotatedFields & mapMaybe \(fieldName, (_, mRemoteJoin)) ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
(QualifiedFieldName Nothing (getFieldNameTxt fieldName),) <$> mRemoteJoin
|
2022-03-03 06:43:27 +03:00
|
|
|
|
|
|
|
case NEMap.fromList remoteJoins of
|
|
|
|
Nothing -> pure transformedFields
|
|
|
|
Just neRemoteJoins -> do
|
|
|
|
collect neRemoteJoins
|
|
|
|
pure $ transformedFields <> phantomFields
|
|
|
|
where
|
|
|
|
-- Placeholder text to annotate a remote relationship field.
|
|
|
|
remoteActionPlaceholder :: ActionFieldG Void
|
|
|
|
remoteActionPlaceholder = ACFExpression "remote relationship placeholder"
|
|
|
|
|
|
|
|
-- This is a map of column name to its alias of all columns in the
|
|
|
|
-- selection set.
|
|
|
|
scalarFields :: HashMap G.Name FieldName
|
|
|
|
scalarFields =
|
|
|
|
Map.fromList $
|
|
|
|
[ (name, alias)
|
|
|
|
| (alias, name) <- getFields _ACFScalar fields
|
|
|
|
]
|
|
|
|
|
|
|
|
-- Annotate a join field with its field name and an alias so that it may
|
|
|
|
-- be used to construct a remote join.
|
|
|
|
annotateJoinField ::
|
|
|
|
FieldName -> G.Name -> (G.Name, JoinColumnAlias)
|
|
|
|
annotateJoinField fieldName field =
|
|
|
|
let alias = getJoinColumnAlias fieldName field scalarFields allAliases
|
|
|
|
in (field, alias)
|
|
|
|
where
|
|
|
|
allAliases = map fst fields
|
|
|
|
|
|
|
|
-- goes through all the remote relationships in the selection set and emits
|
|
|
|
-- 1. a map of join field names to their aliases in the lhs response
|
|
|
|
-- 2. a list of extra fields that need to be included in the lhs query
|
|
|
|
-- that are required for the join
|
|
|
|
(joinColumnAliases, phantomFields :: ([(FieldName, ActionFieldG Void)])) =
|
|
|
|
let lhsJoinFields =
|
|
|
|
Map.unions $ map (_arrsLHSJoinFields . snd) $ getFields _ACFRemote fields
|
|
|
|
annotatedJoinColumns = Map.mapWithKey annotateJoinField $ lhsJoinFields
|
|
|
|
phantomFields_ :: ([(FieldName, ActionFieldG Void)]) =
|
|
|
|
toList annotatedJoinColumns & mapMaybe \(joinField, alias) ->
|
|
|
|
case alias of
|
|
|
|
JCSelected _ -> Nothing
|
|
|
|
JCPhantom a ->
|
|
|
|
let annotatedColumn =
|
|
|
|
ACFScalar joinField
|
|
|
|
in Just (a, annotatedColumn)
|
|
|
|
in (fmap snd annotatedJoinColumns, phantomFields_)
|
2021-12-16 02:51:52 +03:00
|
|
|
|
2021-12-07 16:12:02 +03:00
|
|
|
getJoinColumnAlias ::
|
|
|
|
(Eq field, Hashable field) =>
|
|
|
|
FieldName ->
|
|
|
|
field ->
|
|
|
|
HashMap field FieldName ->
|
|
|
|
[FieldName] ->
|
|
|
|
JoinColumnAlias
|
|
|
|
getJoinColumnAlias fieldName field selectedFields allAliases =
|
|
|
|
case Map.lookup field selectedFields of
|
|
|
|
Nothing -> JCPhantom uniqueAlias
|
|
|
|
Just fieldAlias -> JCSelected fieldAlias
|
|
|
|
where
|
|
|
|
-- This generates an alias for a phantom field that does not conflict with
|
2022-03-01 19:03:23 +03:00
|
|
|
-- any of the existing aliases in the selection set
|
2021-12-07 16:12:02 +03:00
|
|
|
--
|
|
|
|
-- If we generate a unique name for each field name which is longer than
|
|
|
|
-- the longest alias in the selection set, the generated name would be
|
|
|
|
-- unique
|
|
|
|
uniqueAlias :: FieldName
|
|
|
|
uniqueAlias =
|
|
|
|
let suffix =
|
|
|
|
"_join_column"
|
|
|
|
<>
|
|
|
|
-- 12 is the length of "_join_column"
|
|
|
|
T.replicate ((longestAliasLength - (T.length (coerce fieldName) + 12)) + 1) "_"
|
|
|
|
in fieldName <> FieldName suffix
|
|
|
|
where
|
|
|
|
longestAliasLength = maximum $ map (T.length . coerce) allAliases
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
getRemoteJoinsSourceRelation ::
|
|
|
|
Backend b =>
|
2021-12-07 16:12:02 +03:00
|
|
|
SourceRelationshipSelection b (RemoteRelationshipField UnpreparedValue) UnpreparedValue ->
|
|
|
|
(SourceRelationshipSelection b Void UnpreparedValue, Maybe RemoteJoins)
|
2021-09-22 13:43:05 +03:00
|
|
|
getRemoteJoinsSourceRelation = runCollector . transformSourceRelation
|
|
|
|
where
|
|
|
|
transformSourceRelation = \case
|
|
|
|
SourceRelationshipObject objectSelect ->
|
|
|
|
SourceRelationshipObject <$> transformObjectSelect objectSelect
|
|
|
|
SourceRelationshipArray simpleSelect ->
|
|
|
|
SourceRelationshipArray <$> transformSelect simpleSelect
|
|
|
|
SourceRelationshipArrayAggregate aggregateSelect ->
|
|
|
|
SourceRelationshipArrayAggregate <$> transformAggregateSelect aggregateSelect
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
|
|
|
|
transformGraphQLSelectionSet ::
|
|
|
|
SelectionSet (RemoteRelationshipField UnpreparedValue) var ->
|
|
|
|
Collector (SelectionSet Void var)
|
|
|
|
transformGraphQLSelectionSet = \case
|
|
|
|
SelectionSetNone -> pure SelectionSetNone
|
|
|
|
SelectionSetObject s -> SelectionSetObject <$> transformObjectSelectionSet Nothing s
|
|
|
|
SelectionSetUnion s -> SelectionSetUnion <$> transformAbstractTypeSelectionSet s
|
|
|
|
SelectionSetInterface s -> SelectionSetInterface <$> transformAbstractTypeSelectionSet s
|
|
|
|
where
|
|
|
|
transformAbstractTypeSelectionSet DeduplicatedSelectionSet {..} = do
|
|
|
|
transformedMemberSelectionSets <-
|
|
|
|
_atssMemberSelectionSets & Map.traverseWithKey \typeName objectSelectionSet ->
|
|
|
|
transformObjectSelectionSet (Just typeName) objectSelectionSet
|
|
|
|
pure
|
|
|
|
DeduplicatedSelectionSet
|
|
|
|
{ _atssMemberSelectionSets = transformedMemberSelectionSets,
|
|
|
|
..
|
|
|
|
}
|
|
|
|
|
|
|
|
transformObjectSelectionSet ::
|
|
|
|
-- | The type name on which this selection set is defined; this is only
|
|
|
|
-- expected to be provided for unions and interfaces, not for regular objects,
|
|
|
|
-- as this is used to determine whether a selection set is potentially
|
|
|
|
-- "ambiguous" or not, and regular objects cannot. This will be used as the
|
|
|
|
-- type name in the 'QualifiedFieldName' key of the join tree if this
|
|
|
|
-- selection set or its subselections contain remote joins.
|
|
|
|
Maybe G.Name ->
|
|
|
|
ObjectSelectionSet (RemoteRelationshipField UnpreparedValue) var ->
|
|
|
|
Collector (ObjectSelectionSet Void var)
|
|
|
|
transformObjectSelectionSet typename selectionSet = do
|
|
|
|
-- we need to keep track of whether any subfield contained a remote join
|
|
|
|
(annotatedFields, subfieldsContainRemoteJoins) <-
|
|
|
|
listens isJust $
|
|
|
|
flip OMap.traverseWithKey selectionSet \alias field ->
|
|
|
|
withField (G.unName <$> typename) (G.unName alias) do
|
|
|
|
case field of
|
|
|
|
FieldGraphQL f -> (,Nothing) <$> transformGraphQLField f
|
|
|
|
FieldRemote SchemaRemoteRelationshipSelect {..} -> do
|
|
|
|
pure
|
|
|
|
( mkPlaceholderField alias,
|
|
|
|
Just $ createRemoteJoin joinColumnAliases _srrsRelationship
|
|
|
|
)
|
|
|
|
let internalTypeAlias = $$(G.litName "__hasura_internal_typename")
|
|
|
|
remoteJoins = OMap.mapMaybe snd annotatedFields
|
|
|
|
additionalFields =
|
|
|
|
if
|
|
|
|
| isJust typename && (not (null remoteJoins) || subfieldsContainRemoteJoins) ->
|
|
|
|
-- We are in a situation in which the type name matters, and we know
|
|
|
|
-- that there is at least one remote join in this part of tree, meaning
|
|
|
|
-- we might need to branch on the typename when traversing the join
|
|
|
|
-- tree: we insert a custom field that will return the type name.
|
|
|
|
OMap.singleton internalTypeAlias $
|
|
|
|
mkGraphQLField
|
|
|
|
(Just internalTypeAlias)
|
|
|
|
$$(G.litName "__typename")
|
|
|
|
mempty
|
|
|
|
mempty
|
|
|
|
SelectionSetNone
|
|
|
|
| otherwise ->
|
|
|
|
-- Either the typename doesn't matter, or this tree doesn't have remote
|
|
|
|
-- joins; this selection set isn't "ambiguous".
|
|
|
|
mempty
|
|
|
|
transformedFields = fmap fst annotatedFields <> additionalFields
|
|
|
|
case NEMap.fromList $ OMap.toList remoteJoins of
|
|
|
|
Nothing -> pure $ fmap FieldGraphQL transformedFields
|
|
|
|
Just neRemoteJoins -> do
|
|
|
|
collect $ NEMap.mapKeys (\fieldGName -> QualifiedFieldName (G.unName <$> typename) (G.unName fieldGName)) neRemoteJoins
|
|
|
|
pure $
|
|
|
|
fmap
|
|
|
|
FieldGraphQL
|
|
|
|
(transformedFields <> OMap.fromList [(_fAlias fld, fld) | fld <- toList phantomFields])
|
|
|
|
where
|
|
|
|
nameToField = FieldName . G.unName
|
|
|
|
allAliases = map (nameToField . fst) $ OMap.toList selectionSet
|
|
|
|
|
|
|
|
mkPlaceholderField alias =
|
|
|
|
mkGraphQLField (Just alias) $$(G.litName "__typename") mempty mempty SelectionSetNone
|
|
|
|
|
|
|
|
-- A map of graphql scalar fields (without any arguments) to their aliases
|
|
|
|
-- in the selection set. We do not yet support lhs join fields which take
|
|
|
|
-- arguments. To be consistent with that, we ignore fields with arguments
|
|
|
|
noArgsGraphQLFields =
|
|
|
|
Map.fromList $
|
|
|
|
flip mapMaybe (OMap.toList selectionSet) \(alias, field) -> case field of
|
|
|
|
FieldGraphQL f ->
|
|
|
|
if null (_fArguments f)
|
|
|
|
then Just (_fName f, FieldName $ G.unName alias)
|
|
|
|
else Nothing
|
|
|
|
FieldRemote _ -> Nothing
|
|
|
|
|
|
|
|
annotateLHSJoinField fieldName lhsJoinField =
|
|
|
|
let columnAlias =
|
|
|
|
getJoinColumnAlias fieldName lhsJoinField noArgsGraphQLFields allAliases
|
|
|
|
in ( mkGraphQLField
|
|
|
|
(Just $ G.unsafeMkName $ getFieldNameTxt $ getAliasFieldName columnAlias)
|
|
|
|
lhsJoinField
|
|
|
|
mempty
|
|
|
|
mempty
|
|
|
|
SelectionSetNone,
|
|
|
|
columnAlias
|
|
|
|
)
|
|
|
|
|
|
|
|
(joinColumnAliases, phantomFields) =
|
|
|
|
let lhsJoinFields =
|
|
|
|
Map.unions $ map _srrsLHSJoinFields $ mapMaybe (^? _FieldRemote) $ toList selectionSet
|
|
|
|
annotatedJoinColumns = Map.mapWithKey annotateLHSJoinField lhsJoinFields
|
|
|
|
in (fmap snd annotatedJoinColumns, fmap fst annotatedJoinColumns)
|
|
|
|
|
|
|
|
transformGraphQLField ::
|
|
|
|
GraphQLField (RemoteRelationshipField UnpreparedValue) var ->
|
|
|
|
Collector (GraphQLField Void var)
|
|
|
|
transformGraphQLField GraphQLField {..} = do
|
|
|
|
transformedSelectionSet <- transformGraphQLSelectionSet _fSelectionSet
|
|
|
|
pure $ GraphQLField {_fSelectionSet = transformedSelectionSet, ..}
|
|
|
|
|
|
|
|
getRemoteJoinsGraphQLSelectionSet ::
|
|
|
|
SelectionSet (RemoteRelationshipField UnpreparedValue) var ->
|
|
|
|
(SelectionSet Void var, Maybe RemoteJoins)
|
|
|
|
getRemoteJoinsGraphQLSelectionSet =
|
|
|
|
runCollector . transformGraphQLSelectionSet
|
|
|
|
|
|
|
|
getRemoteJoinsGraphQLField ::
|
|
|
|
GraphQLField (RemoteRelationshipField UnpreparedValue) var ->
|
|
|
|
(GraphQLField Void var, Maybe RemoteJoins)
|
|
|
|
getRemoteJoinsGraphQLField =
|
|
|
|
runCollector . transformGraphQLField
|