hasura/graphql-engine
1
0
Fork 0
mirror of https://github.com/hasura/graphql-engine.git synced 2024-12-17 12:31:52 +03:00
Code Issues Projects Releases Wiki Activity
66ac7ea1aa
graphql-engine/Makefile

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

75 lines
2.1 KiB
Makefile
Raw Normal View History

server, CI: use ormolu as a formatter for Haskell sources ### Description - sets up a Makefile target for running ormolu to format and check source code - updates CI to run ormolu instead of stylish-haskell (and to check instead of format actively) Compare #1679. Here's the plan for merging this: 1. merge this PR; at this point, all PRs will fail CI unless they have the `ignore-server-format-checks` label set 2. merge follow-up PR #2404 that does nothing but actually reformats the codebase 3. tag the merge commit as `post-ormolu` (also on `graphql-engine`, for the benefits of community contributors) 4. provide the following script to any devs in order to update their branches: ``` $ git checkout my-feature-branch $ git merge post-ormolu^ $ make format $ git commit -a -m "reformat with ormolu" $ git merge -s ours post-ormolu ``` (I'll put this in the commit message) https://github.com/hasura/graphql-engine-mono/pull/2020 Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com> Co-authored-by: Swann Moreau <62569634+evertedsphere@users.noreply.github.com> GitOrigin-RevId: 130f480a6d79967c8d045b7f3a6dec30b10472a7
2021-09-24 00:22:27 +03:00
# skip contrib with its generated .hs file because it doesn't
# come with a cabal file, which can trigger a bug in ormolu
Add Makefile targets to run `hlint` on all and changed files. * `make lint-hs` will lint all files. * `make lint-hs-changed` will lint all modified files on this branch. * `make lint` will delegate to `make lint-hs`. * `make lint-changed` will delegate to `make lint-hs-changed`. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4720 GitOrigin-RevId: d872f5b672b1d06100cd9fdaa5e60dc8bb5cae86
2022-06-14 18:20:12 +03:00
HS_FILES = $(shell git ls-files '*.hs' '*.hs-boot' | grep -v '^contrib/')
CHANGED_HS_FILES = $(shell git diff --diff-filter=d --name-only `git merge-base HEAD origin/main` \
| grep '.*\(hs\|hs-boot\)$$' | grep -v '^contrib/')
HLINT = hlint
server, CI: use ormolu as a formatter for Haskell sources ### Description - sets up a Makefile target for running ormolu to format and check source code - updates CI to run ormolu instead of stylish-haskell (and to check instead of format actively) Compare #1679. Here's the plan for merging this: 1. merge this PR; at this point, all PRs will fail CI unless they have the `ignore-server-format-checks` label set 2. merge follow-up PR #2404 that does nothing but actually reformats the codebase 3. tag the merge commit as `post-ormolu` (also on `graphql-engine`, for the benefits of community contributors) 4. provide the following script to any devs in order to update their branches: ``` $ git checkout my-feature-branch $ git merge post-ormolu^ $ make format $ git commit -a -m "reformat with ormolu" $ git merge -s ours post-ormolu ``` (I'll put this in the commit message) https://github.com/hasura/graphql-engine-mono/pull/2020 Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com> Co-authored-by: Swann Moreau <62569634+evertedsphere@users.noreply.github.com> GitOrigin-RevId: 130f480a6d79967c8d045b7f3a6dec30b10472a7
2021-09-24 00:22:27 +03:00
ORMOLU_CHECK_VERSION = 0.3.0.0
ORMOLU_ARGS = --cabal-default-extensions
ORMOLU = ormolu
ORMOLU_VERSION = $(shell $(ORMOLU) --version | awk 'NR==1 { print $$2 }')
# default target
.PHONY: help
## help: prints help message
help:
@echo "Usage:"
@sed -n 's/^##//p' ${MAKEFILE_LIST} | column -t -s ':' | sed -e 's/^/ /'
.PHONY: check-ormolu-version
check-ormolu-version:
@if ! [ "$(ORMOLU_VERSION)" = "$(ORMOLU_CHECK_VERSION)" ]; then \
echo "WARNING: ormolu version mismatch, expected $(ORMOLU_CHECK_VERSION)"; \
fi
.PHONY: format-hs
## format-hs: auto-format Haskell source code using ormolu
format-hs: check-ormolu-version
@echo running ormolu --mode inplace
Add Makefile targets to run `hlint` on all and changed files. * `make lint-hs` will lint all files. * `make lint-hs-changed` will lint all modified files on this branch. * `make lint` will delegate to `make lint-hs`. * `make lint-changed` will delegate to `make lint-hs-changed`. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4720 GitOrigin-RevId: d872f5b672b1d06100cd9fdaa5e60dc8bb5cae86
2022-06-14 18:20:12 +03:00
@$(ORMOLU) $(ORMOLU_ARGS) --mode inplace $(HS_FILES)
server, CI: use ormolu as a formatter for Haskell sources ### Description - sets up a Makefile target for running ormolu to format and check source code - updates CI to run ormolu instead of stylish-haskell (and to check instead of format actively) Compare #1679. Here's the plan for merging this: 1. merge this PR; at this point, all PRs will fail CI unless they have the `ignore-server-format-checks` label set 2. merge follow-up PR #2404 that does nothing but actually reformats the codebase 3. tag the merge commit as `post-ormolu` (also on `graphql-engine`, for the benefits of community contributors) 4. provide the following script to any devs in order to update their branches: ``` $ git checkout my-feature-branch $ git merge post-ormolu^ $ make format $ git commit -a -m "reformat with ormolu" $ git merge -s ours post-ormolu ``` (I'll put this in the commit message) https://github.com/hasura/graphql-engine-mono/pull/2020 Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com> Co-authored-by: Swann Moreau <62569634+evertedsphere@users.noreply.github.com> GitOrigin-RevId: 130f480a6d79967c8d045b7f3a6dec30b10472a7
2021-09-24 00:22:27 +03:00
.PHONY: format-hs-changed
## format-hs-changed: auto-format Haskell source code using ormolu (changed files only)
format-hs-changed: check-ormolu-version
@echo running ormolu --mode inplace
Add Makefile targets to run `hlint` on all and changed files. * `make lint-hs` will lint all files. * `make lint-hs-changed` will lint all modified files on this branch. * `make lint` will delegate to `make lint-hs`. * `make lint-changed` will delegate to `make lint-hs-changed`. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4720 GitOrigin-RevId: d872f5b672b1d06100cd9fdaa5e60dc8bb5cae86
2022-06-14 18:20:12 +03:00
@if [ -n "$(CHANGED_HS_FILES)" ]; then \
$(ORMOLU) $(ORMOLU_ARGS) --mode inplace $(CHANGED_HS_FILES); \
server, CI: use ormolu as a formatter for Haskell sources ### Description - sets up a Makefile target for running ormolu to format and check source code - updates CI to run ormolu instead of stylish-haskell (and to check instead of format actively) Compare #1679. Here's the plan for merging this: 1. merge this PR; at this point, all PRs will fail CI unless they have the `ignore-server-format-checks` label set 2. merge follow-up PR #2404 that does nothing but actually reformats the codebase 3. tag the merge commit as `post-ormolu` (also on `graphql-engine`, for the benefits of community contributors) 4. provide the following script to any devs in order to update their branches: ``` $ git checkout my-feature-branch $ git merge post-ormolu^ $ make format $ git commit -a -m "reformat with ormolu" $ git merge -s ours post-ormolu ``` (I'll put this in the commit message) https://github.com/hasura/graphql-engine-mono/pull/2020 Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com> Co-authored-by: Swann Moreau <62569634+evertedsphere@users.noreply.github.com> GitOrigin-RevId: 130f480a6d79967c8d045b7f3a6dec30b10472a7
2021-09-24 00:22:27 +03:00
fi
.PHONY: check-format-hs
## check-format-hs: check Haskell source code formatting using ormolu
check-format-hs: check-ormolu-version
@echo running ormolu --mode check
Add Makefile targets to run `hlint` on all and changed files. * `make lint-hs` will lint all files. * `make lint-hs-changed` will lint all modified files on this branch. * `make lint` will delegate to `make lint-hs`. * `make lint-changed` will delegate to `make lint-hs-changed`. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4720 GitOrigin-RevId: d872f5b672b1d06100cd9fdaa5e60dc8bb5cae86
2022-06-14 18:20:12 +03:00
@$(ORMOLU) $(ORMOLU_ARGS) --mode check $(HS_FILES)
server, CI: use ormolu as a formatter for Haskell sources ### Description - sets up a Makefile target for running ormolu to format and check source code - updates CI to run ormolu instead of stylish-haskell (and to check instead of format actively) Compare #1679. Here's the plan for merging this: 1. merge this PR; at this point, all PRs will fail CI unless they have the `ignore-server-format-checks` label set 2. merge follow-up PR #2404 that does nothing but actually reformats the codebase 3. tag the merge commit as `post-ormolu` (also on `graphql-engine`, for the benefits of community contributors) 4. provide the following script to any devs in order to update their branches: ``` $ git checkout my-feature-branch $ git merge post-ormolu^ $ make format $ git commit -a -m "reformat with ormolu" $ git merge -s ours post-ormolu ``` (I'll put this in the commit message) https://github.com/hasura/graphql-engine-mono/pull/2020 Co-authored-by: Philip Lykke Carlsen <358550+plcplc@users.noreply.github.com> Co-authored-by: Swann Moreau <62569634+evertedsphere@users.noreply.github.com> GitOrigin-RevId: 130f480a6d79967c8d045b7f3a6dec30b10472a7
2021-09-24 00:22:27 +03:00
.PHONY: format
format: format-hs
.PHONY: format-changed
format-changed: format-hs-changed
.PHONY: check-format
check-format: check-format-hs
Add Makefile targets to run `hlint` on all and changed files. * `make lint-hs` will lint all files. * `make lint-hs-changed` will lint all modified files on this branch. * `make lint` will delegate to `make lint-hs`. * `make lint-changed` will delegate to `make lint-hs-changed`. PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4720 GitOrigin-RevId: d872f5b672b1d06100cd9fdaa5e60dc8bb5cae86
2022-06-14 18:20:12 +03:00
.PHONY: lint-hs
## lint-hs: lint Haskell code using `hlint`
lint-hs:
@echo running hlint
@$(HLINT) $(HS_FILES)
.PHONY: lint-hs-changed
## lint-hs-changed: lint Haskell code using `hlint` (changed files only)
lint-hs-changed:
@echo running hlint
@if [ -n "$(CHANGED_HS_FILES)" ]; then \
$(HLINT) $(CHANGED_HS_FILES); \
fi
.PHONY: lint
lint: lint-hs
.PHONY: lint-changed
lint-changed: lint-hs-changed
Reference in New Issue Copy Permalink