2021-11-04 19:08:33 +03:00
|
|
|
module Hasura.GraphQL.Execute.Backend
|
|
|
|
( BackendExecute (..),
|
|
|
|
DBStepInfo (..),
|
|
|
|
ExecutionPlan,
|
|
|
|
ExecutionStep (..),
|
|
|
|
ExplainPlan (..),
|
|
|
|
MonadQueryTags (..),
|
|
|
|
convertRemoteSourceRelationship,
|
|
|
|
)
|
|
|
|
where
|
2021-02-12 06:04:09 +03:00
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
import Control.Monad.Trans.Control (MonadBaseControl)
|
|
|
|
import Data.Aeson qualified as J
|
|
|
|
import Data.Aeson.Casing qualified as J
|
|
|
|
import Data.Aeson.Ordered qualified as JO
|
2022-07-19 04:51:42 +03:00
|
|
|
import Data.Environment as Env
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.Kind (Type)
|
|
|
|
import Data.Tagged
|
|
|
|
import Data.Text.Extended
|
|
|
|
import Data.Text.NonEmpty (mkNonEmptyTextUnsafe)
|
Import `pg-client-hs` as `PG`
Result of executing the following commands:
```shell
# replace "as Q" imports with "as PG" (in retrospect this didn't need a regex)
git grep -lE 'as Q($|[^a-zA-Z])' -- '*.hs' | xargs sed -i -E 's/as Q($|[^a-zA-Z])/as PG\1/'
# replace " Q." with " PG."
git grep -lE ' Q\.' -- '*.hs' | xargs sed -i 's/ Q\./ PG./g'
# replace "(Q." with "(PG."
git grep -lE '\(Q\.' -- '*.hs' | xargs sed -i 's/(Q\./(PG./g'
# ditto, but for [, |, { and !
git grep -lE '\[Q\.' -- '*.hs' | xargs sed -i 's/\[Q\./\[PG./g'
git grep -l '|Q\.' -- '*.hs' | xargs sed -i 's/|Q\./|PG./g'
git grep -l '{Q\.' -- '*.hs' | xargs sed -i 's/{Q\./{PG./g'
git grep -l '!Q\.' -- '*.hs' | xargs sed -i 's/!Q\./!PG./g'
```
(Doing the `grep -l` before the `sed`, instead of `sed` on the entire codebase, reduces the number of `mtime` updates, and so reduces how many times a file gets recompiled while checking intermediate results.)
Finally, I manually removed a broken and unused `Arbitrary` instance in `Hasura.RQL.Network`. (It used an `import Test.QuickCheck.Arbitrary as Q` statement, which was erroneously caught by the first find-replace command.)
After this PR, `Q` is no longer used as an import qualifier. That was not the goal of this PR, but perhaps it's a useful fact for future efforts.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5933
GitOrigin-RevId: 8c84c59d57789111d40f5d3322c5a885dcfbf40e
2022-09-20 22:54:43 +03:00
|
|
|
import Database.PG.Query qualified as PG
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Base.Error
|
|
|
|
import Hasura.EncJSON
|
|
|
|
import Hasura.GraphQL.Execute.Action.Types (ActionExecutionPlan)
|
|
|
|
import Hasura.GraphQL.Execute.RemoteJoin.Types
|
2022-03-21 13:39:49 +03:00
|
|
|
import Hasura.GraphQL.Execute.Subscription.Plan
|
2021-10-29 17:42:07 +03:00
|
|
|
import Hasura.GraphQL.Namespace (RootFieldAlias, RootFieldMap)
|
2022-07-14 20:57:28 +03:00
|
|
|
import Hasura.GraphQL.Schema.Options qualified as Options
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.GraphQL.Transport.HTTP.Protocol qualified as GH
|
|
|
|
import Hasura.Metadata.Class
|
|
|
|
import Hasura.Prelude
|
|
|
|
import Hasura.QueryTags
|
|
|
|
import Hasura.RQL.DDL.Schema.Cache (CacheRWT)
|
|
|
|
import Hasura.RQL.IR
|
|
|
|
import Hasura.RQL.Types.Action
|
|
|
|
import Hasura.RQL.Types.Backend
|
|
|
|
import Hasura.RQL.Types.Column (ColumnType, fromCol)
|
|
|
|
import Hasura.RQL.Types.Common
|
|
|
|
import Hasura.RQL.Types.QueryTags (QueryTagsConfig)
|
2021-10-29 17:42:07 +03:00
|
|
|
import Hasura.RQL.Types.ResultCustomization
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.Types.Run (RunT (..))
|
|
|
|
import Hasura.RQL.Types.SchemaCache.Build (MetadataT (..))
|
scaffolding for remote-schemas module
The main aim of the PR is:
1. To set up a module structure for 'remote-schemas' package.
2. Move parts by the remote schema codebase into the new module structure to validate it.
## Notes to the reviewer
Why a PR with large-ish diff?
1. We've been making progress on the MM project but we don't yet know long it is going to take us to get to the first milestone. To understand this better, we need to figure out the unknowns as soon as possible. Hence I've taken a stab at the first two items in the [end-state](https://gist.github.com/0x777/ca2bdc4284d21c3eec153b51dea255c9) document to figure out the unknowns. Unsurprisingly, there are a bunch of issues that we haven't discussed earlier. These are documented in the 'open questions' section.
1. The diff is large but that is only code moved around and I've added a section that documents how things are moved. In addition, there are fair number of PR comments to help with the review process.
## Changes in the PR
### Module structure
Sets up the module structure as follows:
```
Hasura/
RemoteSchema/
Metadata/
Types.hs
SchemaCache/
Types.hs
Permission.hs
RemoteRelationship.hs
Build.hs
MetadataAPI/
Types.hs
Execute.hs
```
### 1. Types representing metadata are moved
Types that capture metadata information (currently scattered across several RQL modules) are moved into `Hasura.RemoteSchema.Metadata.Types`.
- This new module only depends on very 'core' modules such as
`Hasura.Session` for the notion of roles and `Hasura.Incremental` for `Cacheable` typeclass.
- The requirement on database modules is avoided by generalizing the remote schemas metadata to accept an arbitrary 'r' for a remote relationship
definition.
### 2. SchemaCache related types and build logic have been moved
Types that represent remote schemas information in SchemaCache are moved into `Hasura.RemoteSchema.SchemaCache.Types`.
Similar to `H.RS.Metadata.Types`, this module depends on 'core' modules except for `Hasura.GraphQL.Parser.Variable`. It has something to do with remote relationships but I haven't spent time looking into it. The validation of 'remote relationships to remote schema' is also something that needs to be looked at.
Rips out the logic that builds remote schema's SchemaCache information from the monolithic `buildSchemaCacheRule` and moves it into `Hasura.RemoteSchema.SchemaCache.Build`. Further, the `.SchemaCache.Permission` and `.SchemaCache.RemoteRelationship` have been created from existing modules that capture schema cache building logic for those two components.
This was a fair amount of work. On main, currently remote schema's SchemaCache information is built in two phases - in the first phase, 'permissions' and 'remote relationships' are ignored and in the second phase they are filled in.
While remote relationships can only be resolved after partially resolving sources and other remote schemas, the same isn't true for permissions. Further, most of the work that is done to resolve remote relationships can be moved to the first phase so that the second phase can be a very simple traversal.
This is the approach that was taken - resolve permissions and as much as remote relationships information in the first phase.
### 3. Metadata APIs related types and build logic have been moved
The types that represent remote schema related metadata APIs and the execution logic have been moved to `Hasura.RemoteSchema.MetadataAPI.Types` and `.Execute` modules respectively.
## Open questions:
1. `Hasura.RemoteSchema.Metadata.Types` is so called because I was hoping that all of the metadata related APIs of remote schema can be brought in at `Hasura.RemoteSchema.Metadata.API`. However, as metadata APIs depended on functions from `SchemaCache` module (see [1](https://github.com/hasura/graphql-engine-mono/blob/ceba6d62264603ee5d279814677b29bcc43ecaea/server/src-lib/Hasura/RQL/DDL/RemoteSchema.hs#L55) and [2](https://github.com/hasura/graphql-engine-mono/blob/ceba6d62264603ee5d279814677b29bcc43ecaea/server/src-lib/Hasura/RQL/DDL/RemoteSchema.hs#L91), it made more sense to create a separate top-level module for `MetadataAPI`s.
Maybe we can just have `Hasura.RemoteSchema.Metadata` and get rid of the extra nesting or have `Hasura.RemoteSchema.Metadata.{Core,Permission,RemoteRelationship}` if we want to break them down further.
1. `buildRemoteSchemas` in `H.RS.SchemaCache.Build` has the following type:
```haskell
buildRemoteSchemas ::
( ArrowChoice arr,
Inc.ArrowDistribute arr,
ArrowWriter (Seq CollectedInfo) arr,
Inc.ArrowCache m arr,
MonadIO m,
HasHttpManagerM m,
Inc.Cacheable remoteRelationshipDefinition,
ToJSON remoteRelationshipDefinition,
MonadError QErr m
) =>
Env.Environment ->
( (Inc.Dependency (HashMap RemoteSchemaName Inc.InvalidationKey), OrderedRoles),
[RemoteSchemaMetadataG remoteRelationshipDefinition]
)
`arr` HashMap RemoteSchemaName (PartiallyResolvedRemoteSchemaCtxG remoteRelationshipDefinition, MetadataObject)
```
Note the dependence on `CollectedInfo` which is defined as
```haskell
data CollectedInfo
= CIInconsistency InconsistentMetadata
| CIDependency
MetadataObject
-- ^ for error reporting on missing dependencies
SchemaObjId
SchemaDependency
deriving (Eq)
```
this pretty much means that remote schemas is dependent on types from databases, actions, ....
How do we fix this? Maybe introduce a typeclass such as `ArrowCollectRemoteSchemaDependencies` which is defined in `Hasura.RemoteSchema` and then implemented in graphql-engine?
1. The dependency on `buildSchemaCacheFor` in `.MetadataAPI.Execute` which has the following signature:
```haskell
buildSchemaCacheFor ::
(QErrM m, CacheRWM m, MetadataM m) =>
MetadataObjId ->
MetadataModifier ->
```
This can be easily resolved if we restrict what the metadata APIs are allowed to do. Currently, they operate in an unfettered access to modify SchemaCache (the `CacheRWM` constraint):
```haskell
runAddRemoteSchema ::
( QErrM m,
CacheRWM m,
MonadIO m,
HasHttpManagerM m,
MetadataM m,
Tracing.MonadTrace m
) =>
Env.Environment ->
AddRemoteSchemaQuery ->
m EncJSON
```
This should instead be changed to restrict remote schema APIs to only modify remote schema metadata (but has access to the remote schemas part of the schema cache), this dependency is completely removed.
```haskell
runAddRemoteSchema ::
( QErrM m,
MonadIO m,
HasHttpManagerM m,
MonadReader RemoteSchemasSchemaCache m,
MonadState RemoteSchemaMetadata m,
Tracing.MonadTrace m
) =>
Env.Environment ->
AddRemoteSchemaQuery ->
m RemoteSchemeMetadataObjId
```
The idea is that the core graphql-engine would call these functions and then call
`buildSchemaCacheFor`.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6291
GitOrigin-RevId: 51357148c6404afe70219afa71bd1d59bdf4ffc6
2022-10-21 06:13:07 +03:00
|
|
|
import Hasura.RemoteSchema.SchemaCache
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.SQL.AnyBackend qualified as AB
|
|
|
|
import Hasura.SQL.Backend
|
|
|
|
import Hasura.Session
|
|
|
|
import Hasura.Tracing (TraceT)
|
|
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
|
|
|
import Network.HTTP.Types qualified as HTTP
|
2021-02-12 06:04:09 +03:00
|
|
|
|
|
|
|
-- | This typeclass enacapsulates how a given backend translates a root field into an execution
|
|
|
|
-- plan. For now, each root field maps to one execution step, but in the future, when we have
|
|
|
|
-- a client-side dataloader, each root field might translate into a multi-step plan.
|
2021-09-24 01:56:37 +03:00
|
|
|
class
|
|
|
|
( Backend b,
|
|
|
|
ToTxt (MultiplexedQuery b),
|
|
|
|
Monad (ExecutionMonad b)
|
|
|
|
) =>
|
|
|
|
BackendExecute (b :: BackendType)
|
|
|
|
where
|
2021-02-12 06:04:09 +03:00
|
|
|
-- generated query information
|
2021-09-24 01:56:37 +03:00
|
|
|
type PreparedQuery b :: Type
|
2021-02-20 16:45:49 +03:00
|
|
|
type MultiplexedQuery b :: Type
|
2021-09-24 01:56:37 +03:00
|
|
|
type ExecutionMonad b :: Type -> Type
|
2021-02-12 06:04:09 +03:00
|
|
|
|
|
|
|
-- execution plan generation
|
2021-09-24 01:56:37 +03:00
|
|
|
mkDBQueryPlan ::
|
|
|
|
forall m.
|
|
|
|
( MonadError QErr m,
|
|
|
|
MonadQueryTags m,
|
|
|
|
MonadReader QueryTagsComment m
|
|
|
|
) =>
|
|
|
|
UserInfo ->
|
2022-07-19 04:51:42 +03:00
|
|
|
Env.Environment ->
|
2021-09-24 01:56:37 +03:00
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
2021-12-07 16:12:02 +03:00
|
|
|
QueryDB b Void (UnpreparedValue b) ->
|
2021-09-24 01:56:37 +03:00
|
|
|
m (DBStepInfo b)
|
|
|
|
mkDBMutationPlan ::
|
|
|
|
forall m.
|
|
|
|
( MonadError QErr m,
|
|
|
|
MonadQueryTags m,
|
|
|
|
MonadReader QueryTagsComment m
|
|
|
|
) =>
|
|
|
|
UserInfo ->
|
2023-01-17 03:33:56 +03:00
|
|
|
Env.Environment ->
|
2022-07-14 20:57:28 +03:00
|
|
|
Options.StringifyNumbers ->
|
2021-09-24 01:56:37 +03:00
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
2021-12-07 16:12:02 +03:00
|
|
|
MutationDB b Void (UnpreparedValue b) ->
|
2021-09-24 01:56:37 +03:00
|
|
|
m (DBStepInfo b)
|
2022-04-07 17:41:43 +03:00
|
|
|
mkLiveQuerySubscriptionPlan ::
|
2021-09-24 01:56:37 +03:00
|
|
|
forall m.
|
|
|
|
( MonadError QErr m,
|
|
|
|
MonadIO m,
|
2021-10-22 17:49:15 +03:00
|
|
|
MonadBaseControl IO m,
|
2021-09-24 01:56:37 +03:00
|
|
|
MonadReader QueryTagsComment m
|
|
|
|
) =>
|
|
|
|
UserInfo ->
|
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
2021-10-29 17:42:07 +03:00
|
|
|
Maybe G.Name ->
|
2021-12-07 16:12:02 +03:00
|
|
|
RootFieldMap (QueryDB b Void (UnpreparedValue b)) ->
|
2022-03-21 13:39:49 +03:00
|
|
|
m (SubscriptionQueryPlan b (MultiplexedQuery b))
|
2022-04-07 17:41:43 +03:00
|
|
|
mkDBStreamingSubscriptionPlan ::
|
|
|
|
forall m.
|
|
|
|
( MonadError QErr m,
|
|
|
|
MonadIO m,
|
|
|
|
MonadBaseControl IO m,
|
|
|
|
MonadReader QueryTagsComment m
|
|
|
|
) =>
|
|
|
|
UserInfo ->
|
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
|
|
|
(RootFieldAlias, (QueryDB b Void (UnpreparedValue b))) ->
|
|
|
|
m (SubscriptionQueryPlan b (MultiplexedQuery b))
|
2021-09-24 01:56:37 +03:00
|
|
|
mkDBQueryExplain ::
|
|
|
|
forall m.
|
|
|
|
( MonadError QErr m
|
|
|
|
) =>
|
2021-10-29 17:42:07 +03:00
|
|
|
RootFieldAlias ->
|
2021-09-24 01:56:37 +03:00
|
|
|
UserInfo ->
|
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
2021-12-07 16:12:02 +03:00
|
|
|
QueryDB b Void (UnpreparedValue b) ->
|
2021-09-24 01:56:37 +03:00
|
|
|
m (AB.AnyBackend DBStepInfo)
|
2022-03-21 13:39:49 +03:00
|
|
|
mkSubscriptionExplain ::
|
2021-09-24 01:56:37 +03:00
|
|
|
( MonadError QErr m,
|
|
|
|
MonadIO m,
|
|
|
|
MonadBaseControl IO m
|
|
|
|
) =>
|
2022-03-21 13:39:49 +03:00
|
|
|
SubscriptionQueryPlan b (MultiplexedQuery b) ->
|
|
|
|
m SubscriptionQueryPlanExplanation
|
2021-09-24 01:56:37 +03:00
|
|
|
|
|
|
|
mkDBRemoteRelationshipPlan ::
|
|
|
|
forall m.
|
|
|
|
( MonadError QErr m,
|
|
|
|
MonadQueryTags m
|
|
|
|
) =>
|
|
|
|
UserInfo ->
|
|
|
|
SourceName ->
|
|
|
|
SourceConfig b ->
|
|
|
|
-- | List of json objects, each of which becomes a row of the table.
|
|
|
|
NonEmpty J.Object ->
|
|
|
|
-- | The above objects have this schema.
|
|
|
|
HashMap FieldName (Column b, ScalarType b) ->
|
|
|
|
-- | This is a field name from the lhs that *has* to be selected in the
|
2021-11-24 19:21:59 +03:00
|
|
|
-- response along with the relationship. It is populated in
|
|
|
|
-- `Hasura.GraphQL.Execute.RemoteJoin.Join.processRemoteJoins_` and
|
|
|
|
-- the function `convertRemoteSourceRelationship` below assumes it
|
|
|
|
-- to be returned as either a number or a string with a number in it
|
2021-09-24 01:56:37 +03:00
|
|
|
FieldName ->
|
2021-12-07 16:12:02 +03:00
|
|
|
(FieldName, SourceRelationshipSelection b Void UnpreparedValue) ->
|
2022-12-19 17:03:13 +03:00
|
|
|
Options.StringifyNumbers ->
|
2021-09-24 01:56:37 +03:00
|
|
|
m (DBStepInfo b)
|
2021-09-22 13:43:05 +03:00
|
|
|
|
|
|
|
-- | This is a helper function to convert a remote source's relationship to a
|
|
|
|
-- normal relationship to a temporary table. This function can be used to
|
|
|
|
-- implement executeRemoteRelationship function in databases which support
|
|
|
|
-- constructing a temporary table for a list of json objects.
|
2021-09-24 01:56:37 +03:00
|
|
|
convertRemoteSourceRelationship ::
|
|
|
|
forall b.
|
|
|
|
(Backend b) =>
|
|
|
|
-- | Join columns for the relationship
|
|
|
|
HashMap (Column b) (Column b) ->
|
|
|
|
-- | The LHS of the join, this is the expression which selects from json
|
2021-09-22 13:43:05 +03:00
|
|
|
-- objects
|
2021-09-24 01:56:37 +03:00
|
|
|
SelectFromG b (UnpreparedValue b) ->
|
|
|
|
-- | This is the __argument__ id column, that needs to be added to the response
|
2021-09-22 13:43:05 +03:00
|
|
|
-- This is used by by the remote joins processing logic to convert the
|
|
|
|
-- response from upstream to join indices
|
2021-09-24 01:56:37 +03:00
|
|
|
Column b ->
|
|
|
|
-- | This is the type of the __argument__ id column
|
|
|
|
ColumnType b ->
|
|
|
|
-- | The relationship column and its name (how it should be selected in the
|
2021-09-22 13:43:05 +03:00
|
|
|
-- response)
|
2021-12-07 16:12:02 +03:00
|
|
|
(FieldName, SourceRelationshipSelection b Void UnpreparedValue) ->
|
2022-12-19 17:03:13 +03:00
|
|
|
Options.StringifyNumbers ->
|
2021-12-07 16:12:02 +03:00
|
|
|
QueryDB b Void (UnpreparedValue b)
|
2021-09-24 01:56:37 +03:00
|
|
|
convertRemoteSourceRelationship
|
|
|
|
columnMapping
|
|
|
|
selectFrom
|
|
|
|
argumentIdColumn
|
|
|
|
argumentIdColumnType
|
2022-12-19 17:03:13 +03:00
|
|
|
(relationshipName, relationship)
|
|
|
|
stringifyNumbers =
|
2021-09-24 01:56:37 +03:00
|
|
|
QDBMultipleRows simpleSelect
|
|
|
|
where
|
|
|
|
-- TODO: FieldName should have also been a wrapper around NonEmptyText
|
|
|
|
relName = RelName $ mkNonEmptyTextUnsafe $ getFieldNameTxt relationshipName
|
|
|
|
|
|
|
|
relationshipField = case relationship of
|
|
|
|
SourceRelationshipObject s ->
|
|
|
|
AFObjectRelation $ AnnRelationSelectG relName columnMapping s
|
|
|
|
SourceRelationshipArray s ->
|
|
|
|
AFArrayRelation $ ASSimple $ AnnRelationSelectG relName columnMapping s
|
|
|
|
SourceRelationshipArrayAggregate s ->
|
|
|
|
AFArrayRelation $ ASAggregate $ AnnRelationSelectG relName columnMapping s
|
|
|
|
|
|
|
|
argumentIdField =
|
|
|
|
( fromCol @b argumentIdColumn,
|
|
|
|
AFColumn $
|
|
|
|
AnnColumnField
|
|
|
|
{ _acfColumn = argumentIdColumn,
|
|
|
|
_acfType = argumentIdColumnType,
|
|
|
|
_acfAsText = False,
|
2022-05-03 11:58:56 +03:00
|
|
|
_acfArguments = Nothing,
|
2021-09-24 01:56:37 +03:00
|
|
|
_acfCaseBoolExpression = Nothing
|
|
|
|
}
|
|
|
|
)
|
|
|
|
|
|
|
|
simpleSelect =
|
|
|
|
AnnSelectG
|
|
|
|
{ _asnFields = [argumentIdField, (relationshipName, relationshipField)],
|
|
|
|
_asnFrom = selectFrom,
|
|
|
|
_asnPerm = TablePerm annBoolExpTrue Nothing,
|
|
|
|
_asnArgs = noSelectArgs,
|
2022-12-19 17:03:13 +03:00
|
|
|
_asnStrfyNum = stringifyNumbers,
|
2022-07-19 09:55:42 +03:00
|
|
|
_asnNamingConvention = Nothing
|
2021-09-24 01:56:37 +03:00
|
|
|
}
|
2021-09-22 13:43:05 +03:00
|
|
|
|
2021-04-01 23:40:31 +03:00
|
|
|
data DBStepInfo b = DBStepInfo
|
2021-09-24 01:56:37 +03:00
|
|
|
{ dbsiSourceName :: SourceName,
|
|
|
|
dbsiSourceConfig :: SourceConfig b,
|
|
|
|
dbsiPreparedQuery :: Maybe (PreparedQuery b),
|
|
|
|
dbsiAction :: ExecutionMonad b EncJSON
|
2021-04-01 23:40:31 +03:00
|
|
|
}
|
2021-02-12 06:04:09 +03:00
|
|
|
|
2021-04-13 14:10:08 +03:00
|
|
|
-- | The result of an explain query: for a given root field (denoted by its name): the generated SQL
|
|
|
|
-- query, and the detailed explanation obtained from the database (if any). We mostly use this type
|
|
|
|
-- as an intermediary step, and immediately tranform any value we obtain into an equivalent JSON
|
|
|
|
-- representation.
|
2021-09-24 01:56:37 +03:00
|
|
|
data ExplainPlan = ExplainPlan
|
2021-10-29 17:42:07 +03:00
|
|
|
{ _fpField :: !RootFieldAlias,
|
2021-09-24 01:56:37 +03:00
|
|
|
_fpSql :: !(Maybe Text),
|
|
|
|
_fpPlan :: !(Maybe [Text])
|
|
|
|
}
|
|
|
|
deriving (Show, Eq, Generic)
|
2021-04-13 14:10:08 +03:00
|
|
|
|
|
|
|
instance J.ToJSON ExplainPlan where
|
|
|
|
toJSON = J.genericToJSON $ J.aesonPrefix J.camelCase
|
|
|
|
|
2021-02-12 06:04:09 +03:00
|
|
|
-- | One execution step to processing a GraphQL query (e.g. one root field).
|
2021-02-20 16:45:49 +03:00
|
|
|
data ExecutionStep where
|
2021-06-11 06:26:50 +03:00
|
|
|
-- | A query to execute against the database
|
2021-09-24 01:56:37 +03:00
|
|
|
ExecStepDB ::
|
|
|
|
HTTP.ResponseHeaders ->
|
|
|
|
AB.AnyBackend DBStepInfo ->
|
|
|
|
Maybe RemoteJoins ->
|
|
|
|
ExecutionStep
|
2021-06-11 06:26:50 +03:00
|
|
|
-- | Execute an action
|
2021-09-24 01:56:37 +03:00
|
|
|
ExecStepAction ::
|
|
|
|
ActionExecutionPlan ->
|
|
|
|
ActionsInfo ->
|
|
|
|
Maybe RemoteJoins ->
|
|
|
|
ExecutionStep
|
2021-06-11 06:26:50 +03:00
|
|
|
-- | A graphql query to execute against a remote schema
|
2021-09-24 01:56:37 +03:00
|
|
|
ExecStepRemote ::
|
|
|
|
!RemoteSchemaInfo ->
|
2021-10-29 17:42:07 +03:00
|
|
|
!ResultCustomizer ->
|
2021-09-24 01:56:37 +03:00
|
|
|
!GH.GQLReqOutgoing ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
Maybe RemoteJoins ->
|
2021-09-24 01:56:37 +03:00
|
|
|
ExecutionStep
|
2021-06-11 06:26:50 +03:00
|
|
|
-- | Output a plain JSON object
|
2021-09-24 01:56:37 +03:00
|
|
|
ExecStepRaw ::
|
|
|
|
JO.Value ->
|
|
|
|
ExecutionStep
|
2022-07-25 18:53:25 +03:00
|
|
|
ExecStepMulti ::
|
|
|
|
[ExecutionStep] ->
|
|
|
|
ExecutionStep
|
2021-03-13 17:40:50 +03:00
|
|
|
|
2021-02-12 06:04:09 +03:00
|
|
|
-- | The series of steps that need to be executed for a given query. For now, those steps are all
|
|
|
|
-- independent. In the future, when we implement a client-side dataloader and generalized joins,
|
|
|
|
-- this will need to be changed into an annotated tree.
|
2021-10-29 17:42:07 +03:00
|
|
|
type ExecutionPlan = RootFieldMap ExecutionStep
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
class (Monad m) => MonadQueryTags m where
|
|
|
|
-- | Creates Query Tags. These are appended to the Generated SQL.
|
|
|
|
-- Helps users to use native database monitoring tools to get some 'application-context'.
|
2021-09-24 01:56:37 +03:00
|
|
|
createQueryTags ::
|
|
|
|
QueryTagsAttributes -> Maybe QueryTagsConfig -> Tagged m QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (ReaderT r m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (ReaderT r m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (ExceptT e m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (ExceptT e m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (TraceT m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (TraceT m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (MetadataStorageT m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (MetadataStorageT m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
Import `pg-client-hs` as `PG`
Result of executing the following commands:
```shell
# replace "as Q" imports with "as PG" (in retrospect this didn't need a regex)
git grep -lE 'as Q($|[^a-zA-Z])' -- '*.hs' | xargs sed -i -E 's/as Q($|[^a-zA-Z])/as PG\1/'
# replace " Q." with " PG."
git grep -lE ' Q\.' -- '*.hs' | xargs sed -i 's/ Q\./ PG./g'
# replace "(Q." with "(PG."
git grep -lE '\(Q\.' -- '*.hs' | xargs sed -i 's/(Q\./(PG./g'
# ditto, but for [, |, { and !
git grep -lE '\[Q\.' -- '*.hs' | xargs sed -i 's/\[Q\./\[PG./g'
git grep -l '|Q\.' -- '*.hs' | xargs sed -i 's/|Q\./|PG./g'
git grep -l '{Q\.' -- '*.hs' | xargs sed -i 's/{Q\./{PG./g'
git grep -l '!Q\.' -- '*.hs' | xargs sed -i 's/!Q\./!PG./g'
```
(Doing the `grep -l` before the `sed`, instead of `sed` on the entire codebase, reduces the number of `mtime` updates, and so reduces how many times a file gets recompiled while checking intermediate results.)
Finally, I manually removed a broken and unused `Arbitrary` instance in `Hasura.RQL.Network`. (It used an `import Test.QuickCheck.Arbitrary as Q` statement, which was erroneously caught by the first find-replace command.)
After this PR, `Q` is no longer used as an import qualifier. That was not the goal of this PR, but perhaps it's a useful fact for future efforts.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5933
GitOrigin-RevId: 8c84c59d57789111d40f5d3322c5a885dcfbf40e
2022-09-20 22:54:43 +03:00
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (PG.TxET QErr m) where
|
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (PG.TxET QErr m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (MetadataT m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (MetadataT m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (CacheRWT m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (CacheRWT m) QueryTagsComment
|
2021-07-29 11:29:12 +03:00
|
|
|
|
|
|
|
instance (MonadQueryTags m) => MonadQueryTags (RunT m) where
|
2021-09-23 15:37:56 +03:00
|
|
|
createQueryTags qtSourceConfig attr = retag (createQueryTags @m qtSourceConfig attr) :: Tagged (RunT m) QueryTagsComment
|