2018-09-18 09:21:57 +03:00
|
|
|
import pytest
|
2020-04-24 12:10:53 +03:00
|
|
|
from validate import check_query_f, check_query, get_conf_f
|
[Preview] Inherited roles for postgres read queries
fixes #3868
docker image - `hasura/graphql-engine:inherited-roles-preview-48b73a2de`
Note:
To be able to use the inherited roles feature, the graphql-engine should be started with the env variable `HASURA_GRAPHQL_EXPERIMENTAL_FEATURES` set to `inherited_roles`.
Introduction
------------
This PR implements the idea of multiple roles as presented in this [paper](https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/FGALanguageICDE07.pdf). The multiple roles feature in this PR can be used via inherited roles. An inherited role is a role which can be created by combining multiple singular roles. For example, if there are two roles `author` and `editor` configured in the graphql-engine, then we can create a inherited role with the name of `combined_author_editor` role which will combine the select permissions of the `author` and `editor` roles and then make GraphQL queries using the `combined_author_editor`.
How are select permissions of different roles are combined?
------------------------------------------------------------
A select permission includes 5 things:
1. Columns accessible to the role
2. Row selection filter
3. Limit
4. Allow aggregation
5. Scalar computed fields accessible to the role
Suppose there are two roles, `role1` gives access to the `address` column with row filter `P1` and `role2` gives access to both the `address` and the `phone` column with row filter `P2` and we create a new role `combined_roles` which combines `role1` and `role2`.
Let's say the following GraphQL query is queried with the `combined_roles` role.
```graphql
query {
employees {
address
phone
}
}
```
This will translate to the following SQL query:
```sql
select
(case when (P1 or P2) then address else null end) as address,
(case when P2 then phone else null end) as phone
from employee
where (P1 or P2)
```
The other parameters of the select permission will be combined in the following manner:
1. Limit - Minimum of the limits will be the limit of the inherited role
2. Allow aggregations - If any of the role allows aggregation, then the inherited role will allow aggregation
3. Scalar computed fields - same as table column fields, as in the above example
APIs for inherited roles:
----------------------
1. `add_inherited_role`
`add_inherited_role` is the [metadata API](https://hasura.io/docs/1.0/graphql/core/api-reference/index.html#schema-metadata-api) to create a new inherited role. It accepts two arguments
`role_name`: the name of the inherited role to be added (String)
`role_set`: list of roles that need to be combined (Array of Strings)
Example:
```json
{
"type": "add_inherited_role",
"args": {
"role_name":"combined_user",
"role_set":[
"user",
"user1"
]
}
}
```
After adding the inherited role, the inherited role can be used like single roles like earlier
Note:
An inherited role can only be created with non-inherited/singular roles.
2. `drop_inherited_role`
The `drop_inherited_role` API accepts the name of the inherited role and drops it from the metadata. It accepts a single argument:
`role_name`: name of the inherited role to be dropped
Example:
```json
{
"type": "drop_inherited_role",
"args": {
"role_name":"combined_user"
}
}
```
Metadata
---------
The derived roles metadata will be included under the `experimental_features` key while exporting the metadata.
```json
{
"experimental_features": {
"derived_roles": [
{
"role_name": "manager_is_employee_too",
"role_set": [
"employee",
"manager"
]
}
]
}
}
```
Scope
------
Only postgres queries and subscriptions are supported in this PR.
Important points:
-----------------
1. All columns exposed to an inherited role will be marked as `nullable`, this is done so that cell value nullification can be done.
TODOs
-------
- [ ] Tests
- [ ] Test a GraphQL query running with a inherited role without enabling inherited roles in experimental features
- [] Tests for aggregate queries, limit, computed fields, functions, subscriptions (?)
- [ ] Introspection test with a inherited role (nullability changes in a inherited role)
- [ ] Docs
- [ ] Changelog
Co-authored-by: Vamshi Surabhi <6562944+0x777@users.noreply.github.com>
GitOrigin-RevId: 3b8ee1e11f5ceca80fe294f8c074d42fbccfec63
2021-03-08 14:14:13 +03:00
|
|
|
from conftest import use_inherited_roles_fixtures
|
2020-04-24 12:10:53 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
# Marking all tests in this module that server upgrade tests can be run
|
|
|
|
|
# Few of them cannot be run, which will be marked skip_server_upgrade_test
|
|
|
|
|
pytestmark = pytest.mark.allow_server_upgrade_test
|
|
|
|
|
|
|
|
|
|
usefixtures = pytest.mark.usefixtures
|
|
|
|
|
|
|
|
|
|
use_mutation_fixtures = usefixtures(
|
|
|
|
|
'per_class_db_schema_for_mutation_tests',
|
|
|
|
|
'per_method_db_data_for_mutation_tests'
|
|
|
|
|
)
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2019-05-10 09:05:11 +03:00
|
|
|
@pytest.mark.parametrize("transport", ['http', 'websocket'])
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
2020-04-15 19:13:53 +03:00
|
|
|
class TestGraphQLInsertWithTransport:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2019-04-08 10:22:38 +03:00
|
|
|
def test_inserts_author_article(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_article.yaml", transport)
|
2018-10-28 21:27:49 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/basic"
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphQLInsert:
|
|
|
|
|
|
|
|
|
|
def test_inserts_various_postgres_types(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_various_postgres_types.yaml")
|
|
|
|
|
|
2020-04-21 16:56:15 +03:00
|
|
|
def test_insert_integer_overflow(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_integer_overflow.yaml")
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@pytest.mark.xfail(reason="Refer https://github.com/hasura/graphql-engine/issues/348")
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_into_array_col_with_array_input(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_into_array_col_with_array_input.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_using_variable(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_jsonb_variable.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_using_array_variable(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_jsonb_variable_array.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_person(self, hge_ctx):
|
2018-12-04 17:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_jsonb.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_person_array(self, hge_ctx):
|
2018-12-04 17:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_jsonb_array.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_null_col_value(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/order_col_shipped_null.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
Rewrite GraphQL schema generation and query parsing (close #2801) (#4111)
Aka “the PDV refactor.” History is preserved on the branch 2801-graphql-schema-parser-refactor.
* [skip ci] remove stale benchmark commit from commit_diff
* [skip ci] Check for root field name conflicts between remotes
* [skip ci] Additionally check for conflicts between remotes and DB
* [skip ci] Check for conflicts in schema when tracking a table
* [skip ci] Fix equality checking in GraphQL AST
* server: fix mishandling of GeoJSON inputs in subscriptions (fix #3239) (#4551)
* Add support for multiple top-level fields in a subscription to improve testability of subscriptions
* Add an internal flag to enable multiple subscriptions
* Add missing call to withConstructorFn in live queries (fix #3239)
Co-authored-by: Alexis King <lexi.lambda@gmail.com>
* Scheduled triggers (close #1914) (#3553)
server: add scheduled triggers
Co-authored-by: Alexis King <lexi.lambda@gmail.com>
Co-authored-by: Marion Schleifer <marion@hasura.io>
Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
* dev.sh: bump version due to addition of croniter python dependency
* server: fix an introspection query caching issue (fix #4547) (#4661)
Introspection queries accept variables, but we need to make sure to
also touch the variables that we ignore, so that an introspection
query is marked not reusable if we are not able to build a correct
query plan for it.
A better solution here would be to deal with such unused variables
correctly, so that more introspection queries become reusable.
An even better solution would be to type-safely track *how* to reuse
which variables, rather than to split the reusage marking from the
planning.
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* flush log buffer on exception in mkWaiApp ( fix #4772 ) (#4801)
* flush log buffer on exception in mkWaiApp
* add comment to explain the introduced change
* add changelog
* allow logging details of a live query polling thread (#4959)
* changes for poller-log
add various multiplexed query info in poller-log
* minor cleanup, also fixes a bug which will return duplicate data
* Live query poller stats can now be logged
This also removes in-memory stats that are collected about batched
query execution as the log lines when piped into an monitoring tool
will give us better insights.
* allow poller-log to be configurable
* log minimal information in the livequery-poller-log
Other information can be retrieved from /dev/subscriptions/extended
* fix few review comments
* avoid marshalling and unmarshalling from ByteString to EncJSON
* separate out SubscriberId and SubscriberMetadata
Co-authored-by: Anon Ray <rayanon004@gmail.com>
* Don't compile in developer APIs by default
* Tighten up handling of admin secret, more docs
Store the admin secret only as a hash to prevent leaking the secret
inadvertently, and to prevent timing attacks on the secret.
NOTE: best practice for stored user passwords is a function with a
tunable cost like bcrypt, but our threat model is quite different (even
if we thought we could reasonably protect the secret from an attacker
who could read arbitrary regions of memory), and bcrypt is far too slow
(by design) to perform on each request. We'd have to rely on our
(technically savvy) users to choose high entropy passwords in any case.
Referencing #4736
* server/docs: add instructions to fix loss of float precision in PostgreSQL <= 11 (#5187)
This adds a server flag, --pg-connection-options, that can be used to set a PostgreSQL connection parameter, extra_float_digits, that needs to be used to avoid loss of data on older versions of PostgreSQL, which have odd default behavior when returning float values. (fixes #5092)
* [skip ci] Add new commits from master to the commit diff
* [skip ci] serve default directives (skip & include) over introspection
* [skip ci] Update non-Haskell assets with the version on master
* server: refactor GQL execution check and config API (#5094)
Co-authored-by: Vamshi Surabhi <vamshi@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] fix js issues in tests by pinning dependencies version
* [skip ci] bump graphql version
* [skip ci] Add note about memory usage
* generalize query execution logic on Postgres (#5110)
* generalize PGExecCtx to support specialized functions for various operations
* fix tests compilation
* allow customising PGExecCtx when starting the web server
* server: changes catalog initialization and logging for pro customization (#5139)
* new typeclass to abstract the logic of QueryLog-ing
* abstract the logic of logging websocket-server logs
introduce a MonadWSLog typeclass
* move catalog initialization to init step
expose a helper function to migrate catalog
create schema cache in initialiseCtx
* expose various modules and functions for pro
* [skip ci] cosmetic change
* [skip ci] fix test calling a mutation that does not exist
* [skip ci] minor text change
* [skip ci] refactored input values
* [skip ci] remove VString Origin
* server: fix updating of headers behaviour in the update cron trigger API and create future events immediately (#5151)
* server: fix bug to update headers in an existing cron trigger and create future events
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* Lower stack chunk size in RTS to reduce thread STACK memory (closes #5190)
This reduces memory consumption for new idle subscriptions significantly
(see linked ticket).
The hypothesis is: we fork a lot of threads per websocket, and some of
these use slightly more than the initial 1K stack size, so the first
overflow balloons to 32K, when significantly less is required.
However: running with `+RTS -K1K -xc` did not seem to show evidence of
any overflows! So it's a mystery why this improves things.
GHC should probably also be doubling the stack buffer at each overflow
or doing something even smarter; the knobs we have aren't so helpful.
* [skip ci] fix todo and schema generation for aggregate fields
* 5087 libpq pool leak (#5089)
Shrink libpq buffers to 1MB before returning connection to pool. Closes #5087
See: https://github.com/hasura/pg-client-hs/pull/19
Also related: #3388 #4077
* bump pg-client-hs version (fixes a build issue on some environments) (#5267)
* do not use prepared statements for mutations
* server: unlock scheduled events on graceful shutdown (#4928)
* Fix buggy parsing of new --conn-lifetime flag in 2b0e3774
* [skip ci] remove cherry-picked commit from commit_diff.txt
* server: include additional fields in scheduled trigger webhook payload (#5262)
* include scheduled triggers metadata in the webhook body
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* server: call the webhook asynchronously in event triggers (#5352)
* server: call the webhook asynchronosly in event triggers
* Expose all modules in Cabal file (#5371)
* [skip ci] update commit_diff.txt
* [skip ci] fix cast exp parser & few TODOs
* [skip ci] fix remote fields arguments
* [skip ci] fix few more TODO, no-op refactor, move resolve/action.hs to execute/action.hs
* Pass environment variables around as a data structure, via @sordina (#5374)
* Pass environment variables around as a data structure, via @sordina
* Resolving build error
* Adding Environment passing note to changelog
* Removing references to ILTPollerLog as this seems to have been reintroduced from a bad merge
* removing commented-out imports
* Language pragmas already set by project
* Linking async thread
* Apply suggestions from code review
Use `runQueryTx` instead of `runLazyTx` for queries.
* remove the non-user facing entry in the changelog
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] fix: restrict remote relationship field generation for hasura queries
* [skip ci] no-op refactor; move insert execution code from schema parser module
* server: call the webhook asynchronously in event triggers (#5352)
* server: call the webhook asynchronosly in event triggers
* Expose all modules in Cabal file (#5371)
* [skip ci] update commit_diff.txt
* Pass environment variables around as a data structure, via @sordina (#5374)
* Pass environment variables around as a data structure, via @sordina
* Resolving build error
* Adding Environment passing note to changelog
* Removing references to ILTPollerLog as this seems to have been reintroduced from a bad merge
* removing commented-out imports
* Language pragmas already set by project
* Linking async thread
* Apply suggestions from code review
Use `runQueryTx` instead of `runLazyTx` for queries.
* remove the non-user facing entry in the changelog
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] implement header checking
Probably closes #14 and #3659.
* server: refactor 'pollQuery' to have a hook to process 'PollDetails' (#5391)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* update pg-client (#5421)
* [skip ci] update commit_diff
* Fix latency buckets for telemetry data
These must have gotten messed up during a refactor. As a consequence
almost all samples received so far fall into the single erroneous 0 to
1K seconds (originally supposed to be 1ms?) bucket.
I also re-thought what the numbers should be, but these are still
arbitrary and might want adjusting in the future.
* [skip ci] include the latest commit compared against master in commit_diff
* [skip ci] include new commits from master in commit_diff
* [skip ci] improve description generation
* [skip ci] sort all introspect arrays
* [skip ci] allow parsers to specify error codes
* [skip ci] fix integer and float parsing error code
* [skip ci] scalar from json errors are now parse errors
* [skip ci] fixed negative integer error message and code
* [skip ci] Re-fix nullability in relationships
* [skip ci] no-op refactor and removed couple of FIXMEs
* [skip ci] uncomment code in 'deleteMetadataObject'
* [skip ci] Fix re-fix of nullability for relationships
* [skip ci] fix default arguments error code
* [skip ci] updated test error message
!!! WARNING !!!
Since all fields accept `null`, they all are technically optional in
the new schema. Meaning there's no such thing as a missing mandatory
field anymore: a field that doesn't have a default value, and which
therefore isn't labelled as "optional" in the schema, will be assumed
to be null if it's missing, meaning it isn't possible anymore to have
an error for a missing mandatory field. The only possible error is now
when a optional positional argument is omitted but is not the last
positional argument.
* [skip ci] cleanup of int scalar parser
* [skip ci] retro-compatibility of offset as string
* [skip ci] Remove commit from commit_diff.txt
Although strictly speaking we don't know if this will work correctly in PDV
if we would implement query plan caching, the fact is that in the theoretical
case that we would have the same issue in PDV, it would probably apply not just
to introspection, and the fix would be written completely differently. So this
old commit is of no value to us other than the heads-up "make sure query plan
caching works correctly even in the presence of unused variables", which is
already part of the test suite.
* Add MonadTrace and MonadExecuteQuery abstractions (#5383)
* [skip ci] Fix accumulation of input object types
Just like object types, interface types, and union types, we have to avoid
circularities when collecting input types from the GraphQL AST.
Additionally, this fixes equality checks for input object types (whose fields
are unordered, and hence should be compared as sets) and enum types (ditto).
* [skip ci] fix fragment error path
* [skip ci] fix node error code
* [skip ci] fix paths in insert queries
* [skip ci] fix path in objects
* [skip ci] manually alter node id path for consistency
* [skip ci] more node error fixups
* [skip ci] one last relay error message fix
* [skip ci] update commit_diff
* Propagate the trace context to event triggers (#5409)
* Propagate the trace context to event triggers
* Handle missing trace and span IDs
* Store trace context as one LOCAL
* Add migrations
* Documentation
* changelog
* Fix warnings
* Respond to code review suggestions
* Respond to code review
* Undo changelog
* Update CHANGELOG.md
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* server: log request/response sizes for event triggers (#5463)
* server: log request/response sizes for event triggers
event triggers (and scheduled triggers) now have request/response size
in their logs.
* add changelog entry
* Tracing: Simplify HTTP traced request (#5451)
Remove the Inversion of Control (SuspendRequest) and simplify
the tracing of HTTP Requests.
Co-authored-by: Phil Freeman <phil@hasura.io>
* Attach request ID as tracing metadata (#5456)
* Propagate the trace context to event triggers
* Handle missing trace and span IDs
* Store trace context as one LOCAL
* Add migrations
* Documentation
* Include the request ID as trace metadata
* changelog
* Fix warnings
* Respond to code review suggestions
* Respond to code review
* Undo changelog
* Update CHANGELOG.md
* Typo
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* server: add logging for action handlers (#5471)
* server: add logging for action handlers
* add changelog entry
* change action-handler log type from internal to non-internal
* fix action-handler-log name
* server: pass http and websocket request to logging context (#5470)
* pass request body to logging context in all cases
* add message size logging on the websocket API
this is required by graphql-engine-pro/#416
* message size logging on websocket API
As we need to log all messages recieved/sent by the websocket server,
it makes sense to log them as part of the websocket server event logs.
Previously message recieved were logged inside the onMessage handler,
and messages sent were logged only for "data" messages (as a server event log)
* fix review comments
Co-authored-by: Phil Freeman <phil@hasura.io>
* server: stop eventing subsystem threads when shutting down (#5479)
* server: stop eventing subsystem threads when shutting down
* Apply suggestions from code review
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
* [skip ci] update commit_diff with new commits added in master
* Bugfix to support 0-size HASURA_GRAPHQL_QUERY_PLAN_CACHE_SIZE
Also some minor refactoring of bounded cache module:
- the maxBound check in `trim` was confusing and unnecessary
- consequently trim was unnecessary for lookupPure
Also add some basic tests
* Support only the bounded cache, with default HASURA_GRAPHQL_QUERY_PLAN_CACHE_SIZE of 4000. Closes #5363
* [skip ci] remove merge commit from commit_diff
* server: Fix compiler warning caused by GHC upgrade (#5489)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] update all non server code from master
* [skip ci] aligned object field error message with master
* [skip ci] fix remaining undefined?
* [skip ci] remove unused import
* [skip ci] revert to previous error message, fix tests
* Move nullableType/nonNullableType to Schema.hs
These are functions on Types, not on Parsers.
* [skip ci] fix setup to fix backend only test
the order in which permission checks are performed on the branch is
slightly different than on master, resulting in a slightly different
error if there are no other mutations the user has access to. By
adding update permissions, we go back to the expected case.
* [skip ci] fix insert geojson tests to reflect new paths
* [skip ci] fix enum test for better error message
* [skip ci] fix header test for better error message
* [skip ci] fix fragment cycle test for better error message
* [skip ci] fix error message for type mismatch
* [skip ci] fix variable path in test
* [skip ci] adjust tests after bug fix
* [skip ci] more tests fixing
* Add hdb_catalog.current_setting abstraction for reading Hasura settings
As the comment in the function’s definition explains, this is needed to
work around an awkward Postgres behavior.
* [skip ci] Update CONTRIBUTING.md to mention Node setup for Python tests
* [skip ci] Add missing Python tests env var to CONTRIBUTING.md
* [skip ci] fix order of result when subscription is run with multiple nodes
* [skip ci] no-op refactor: fix a warning in Internal/Parser.hs
* [skip ci] throw error when a subscription contains remote joins
* [skip ci] Enable easier profiling by hiding AssertNF behind a flag
In order to compile a profiling build, run:
$ cabal new-build -f profiling --enable-profiling
* [skip ci] Fix two warnings
We used to lookup the objects that implement a given interface by filtering all
objects in the schema document. However, one of the tests expects us to
generate a warning if the provided `implements` field of an introspection query
specifies an object not implementing some interface. So we use that field
instead.
* [skip ci] Fix warnings by commenting out query plan caching
* [skip ci] improve masking/commenting query caching related code & few warning fixes
* [skip ci] Fixed compiler warnings in graphql-parser-hs
* Sync non-Haskell assets with master
* [skip ci] add a test inserting invalid GraphQL but valid JSON value in a jsonb column
* [skip ci] Avoid converting to/from Map
* [skip ci] Apply some hlint suggestions
* [skip ci] remove redundant constraints from buildLiveQueryPlan and explainGQLQuery
* [skip ci] add NOTEs about missing Tracing constraints in PDV from master
* Remove -fdefer-typed-holes, fix warnings
* Update cabal.project.freeze
* Limit GHC’s heap size to 8GB in CI to avoid the OOM killer
* Commit package-lock.json for Python tests’ remote schema server
* restrict env variables start with HASURA_GRAPHQL_ for headers configuration in actions, event triggers & remote schemas (#5519)
* restrict env variables start with HASURA_GRAPHQL_ for headers definition in actions & event triggers
* update CHANGELOG.md
* Apply suggestions from code review
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* add test for table_by_pk node when roles doesn't have permission to PK
* [skip ci] fix introspection query if any enum column present in primary key (fix #5200) (#5522)
* [skip ci] test case fix for a6450e126bc2d98bcfd3791501986e4627ce6c6f
* [skip ci] add tests to agg queries when role doesn't have access to any cols
* fix backend test
* Simplify subscription execution
* [skip ci] add test to check if required headers are present while querying
* Suppose, table B is related to table A and to query B certain headers are
necessary, then the test checks that we are throwing error when the header
is not set when B is queried through A
* fix mutations not checking for view mutability
* [skip ci] add variable type checking and corresponding tests
* [skip ci] add test to check if update headers are present while doing an upsert
* [skip ci] add positive counterparts to some of the negative permission tests
* fix args missing their description in introspect
* [skip ci] Remove unused function; insert missing markNotReusable call
* [skip ci] Add a Note about InputValue
* [skip ci] Delete LegacySchema/ 🎉
* [skip ci] Delete GraphQL/{Resolve,Validate}/ 🎉
* [skip ci] Delete top-level Resolve/Validate modules; tidy .cabal file
* [skip ci] Delete LegacySchema top-level module
Somehow I missed this one.
* fix input value to json
* [skip ci] elaborate on JSON objects in GraphQL
* [skip ci] add missing file
* [skip ci] add a test with subscription containing remote joins
* add a test with remote joins in mutation output
* [skip ci] Add some comments to Schema/Mutation.hs
* [skip ci] Remove no longer needed code from RemoteServer.hs
* [skip ci] Use a helper function to generate conflict clause parsers
* [skip ci] fix type checker error in fields with default value
* capitalize the header keys in select_articles_without_required_headers
* Somehow, this was the reason the tests were failing. I have no idea, why!
* [skip ci] Add a long Note about optional fields and nullability
* Improve comments a bit; simplify Schema/Common.hs a bit
* [skip ci] full implementation of 5.8.5 type checking.
* [skip ci] fix validation test teardown
* [skip ci] fix schema stitching test
* fix remote schema ignoring enum nullability
* [skip ci] fix fieldOptional to not discard nullability
* revert nullability of use_spheroid
* fix comment
* add required remote fields with arguments for tests
* [skip ci] add missing docstrings
* [skip ci] fixed description of remote fields
* [skip ci] change docstring for consistency
* fix several schema inconsistencies
* revert behaviour change in function arguments parsing
* fix remaining nullability issues in new schema
* minor no-op refactor; use isListType from graphql-parser-hs
* use nullability of remote schema node, while creating a Remote reln
* fix 'ID' input coercing & action 'ID' type relationship mapping
* include ASTs in MonadExecuteQuery
* needed for PRO code-base
* Delete code for "interfaces implementing ifaces" (draft GraphQL spec)
Previously I started writing some code that adds support for a future GraphQL
feature where interfaces may themselves be sub-types of other interfaces.
However, this code was incomplete, and partially incorrect. So this commit
deletes support for that entirely.
* Ignore a remote schema test during the upgrade/downgrade test
The PDV refactor does a better job at exposing a minimal set of types through
introspection. In particular, not every type that is present in a remote schema
is re-exposed by Hasura. The test
test_schema_stitching.py::TestRemoteSchemaBasic::test_introspection assumed that
all types were re-exposed, which is not required for GraphQL compatibility, in
order to test some aspect of our support for remote schemas.
So while this particular test has been updated on PDV, the PDV branch now does
not pass the old test, which we argue to be incorrect. Hence this test is
disabled while we await a release, after which we can re-enable it.
This also re-enables a test that was previously disabled for similar, though
unrelated, reasons.
* add haddock documentation to the action's field parsers
* Deslecting some tests in server-upgrade
Some tests with current build are failing on server upgrade
which it should not. The response is more accurate than
what it was.
Also the upgrade tests were not throwing errors when the test is
expected to return an error, but succeeds. The test framework is
patched to catch this case.
* [skip ci] Add a long Note about interfaces and object types
* send the response headers back to client after running a query
* Deselect a few more tests during upgrade/downgrade test
* Update commit_diff.txt
* change log kind from db_migrate to catalog_migrate (#5531)
* Show method and complete URI in traced HTTP calls (#5525)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* restrict env variables start with HASURA_GRAPHQL_ for headers configuration in actions, event triggers & remote schemas (#5519)
* restrict env variables start with HASURA_GRAPHQL_ for headers definition in actions & event triggers
* update CHANGELOG.md
* Apply suggestions from code review
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* fix introspection query if any enum column present in primary key (fix #5200) (#5522)
* Fix telemetry reporting of transport (websocket was reported as http)
* add log kinds in cli-migrations image (#5529)
* add log kinds in cli-migrations image
* give hint to resolve timeout error
* minor changes and CHANGELOG
* server: set hasura.tracecontext in RQL mutations [#5542] (#5555)
* server: set hasura.tracecontext in RQL mutations [#5542]
* Update test suite
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* Add bulldozer auto-merge and -update configuration
We still need to add the github app (as of time of opening this PR)
Afterwards devs should be able to allow bulldozer to automatically
"update" the branch, merging in parent when it changes, as well as
automatically merge when all checks pass.
This is opt-in by adding the `auto-update-auto-merge` label to the PR.
* Remove 'bulldozer' config, try 'kodiak' for auto-merge
see: https://github.com/chdsbd/kodiak
The main issue that bit us was not being able to auto update forked
branches, also:
https://github.com/palantir/bulldozer/issues/66
https://github.com/palantir/bulldozer/issues/145
* Cherry-picked all commits
* [skip ci] Slightly improve formatting
* Revert "fix introspection query if any enum column present in primary key (fix #5200) (#5522)"
This reverts commit 0f9a5afa59a88f6824f4d63d58db246a5ba3fb03.
This undoes a cherry-pick of 34288e1eb5f2c5dad9e6d1e05453dd52397dc970 that was
already done previously in a6450e126bc2d98bcfd3791501986e4627ce6c6f, and
subsequently fixed for PDV in 70e89dc250f8ddc6e2b7930bbe2b3eeaa6dbe1db
* Do a small bit of tidying in Hasura.GraphQL.Parser.Collect
* Fix cherry-picking work
Some previous cherry-picks ended up modifying code that is commented out
* [skip ci] clarified comment regarding insert representation
* [skip ci] removed obsolete todos
* cosmetic change
* fix action error message
* [skip ci] remove obsolete comment
* [skip ci] synchronize stylish haskell extensions list
* use previously defined scalar names in parsers rather than ad-hoc literals
* Apply most syntax hlint hints.
* Clarify comment on update mutation.
* [skip ci] Clarify what fields should be specified for objects
* Update "_inc" description.
* Use record types rather than tuples fo IntrospectionResult and ParsedIntrospection
* Get rid of checkFieldNamesUnique (use Data.List.Extended.duplicates)
* Throw more errors when collecting query root names
* [skip ci] clean column parser comment
* Remove dead code inserted in ab65b39
* avoid converting to non-empty list where not needed
* add note and TODO about the disabled checks in PDV
* minor refactor in remoteField' function
* Unify two getObject methods
* Nitpicks in Remote.hs
* Update CHANGELOG.md
* Revert "Unify two getObject methods"
This reverts commit bd6bb40355b3d189a46c0312eb52225e18be57b3.
We do need two different getObject functions as the corresponding error message is different
* Fix error message in Remote.hs
* Update CHANGELOG.md
Co-authored-by: Auke Booij <auke@tulcod.com>
* Apply suggested Changelog fix.
Co-authored-by: Auke Booij <auke@tulcod.com>
* Fix typo in Changelog.
* [skip ci] Update changelog.
* reuse type names to avoid duplication
* Fix Hashable instance for Definition
The presence of `Maybe Unique`, and an optional description, as part of
`Definition`s, means that `Definition`s that are considered `Eq`ual may get
different hashes. This can happen, for instance, when one object is memoized
but another is not.
* [skip ci] Update commit_diff.txt
* Bump parser version.
* Bump freeze file after changes in parser.
* [skip ci] Incorporate commits from master
* Fix developer flag in server/cabal.project.freeze
Co-authored-by: Auke Booij <auke@tulcod.com>
* Deselect a changed ENUM test for upgrade/downgrade CI
* Deselect test here as well
* [skip ci] remove dead code
* Disable more tests for upgrade/downgrade
* Fix which test gets deselected
* Revert "Add hdb_catalog.current_setting abstraction for reading Hasura settings"
This reverts commit 66e85ab9fbd56cca2c28a80201f6604fbe811b85.
* Remove circular reference in cabal.project.freeze
Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
Co-authored-by: Auke Booij <auke@hasura.io>
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
Co-authored-by: Marion Schleifer <marion@hasura.io>
Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
Co-authored-by: Brandon Simmons <brandon.m.simmons@gmail.com>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Co-authored-by: Anon Ray <rayanon004@gmail.com>
Co-authored-by: rakeshkky <12475069+rakeshkky@users.noreply.github.com>
Co-authored-by: Anon Ray <ecthiender@users.noreply.github.com>
Co-authored-by: Vamshi Surabhi <vamshi@hasura.io>
Co-authored-by: Antoine Leblanc <antoine@hasura.io>
Co-authored-by: Brandon Simmons <brandon@hasura.io>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Lyndon Maydwell <lyndon@sordina.net>
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Naveen Naidu <naveennaidu479@gmail.com>
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
Co-authored-by: Nizar Malangadan <nizar-m@users.noreply.github.com>
Co-authored-by: Antoine Leblanc <crucuny@gmail.com>
Co-authored-by: Auke Booij <auke@tulcod.com>
2020-08-21 20:27:01 +03:00
|
|
|
def test_insert_valid_variable_but_invalid_graphql_value(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_valid_variable_but_invalid_graphql_value.yaml")
|
|
|
|
|
|
|
|
|
|
def test_can_insert_in_insertable_view(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/can_insert_in_insertable_view.yaml")
|
|
|
|
|
|
|
|
|
|
def test_cannot_insert_in_non_insertable_view(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/cannot_insert_in_non_insertable_view.yaml")
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/basic"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlInsertOnConflict:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_on_conflict_update(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_update.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_on_conflict_ignore(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_ignore_constraint.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_on_conflict_update_empty_cols(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_empty_update_columns.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_err_missing_article_constraint(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_error_missing_article_constraint.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_err_unexpected_action(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_unexpected_on_conflict_action.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_err_unexpected_constraint(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_unexpected_on_conflict_constraint_error.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_order_on_conflict_where(self, hge_ctx):
|
2019-10-09 13:09:20 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/order_on_conflict_where.yaml')
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/onconflict"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlInsertPermission:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_role_on_conflict_update(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_user_role.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_role_on_conflict_constraint_on_error(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_on_conflict_constraint_on_user_role_error.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_role_on_conflict_ignore(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_on_conflict_ignore_user_role.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_err_missing_article_constraint(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_article_on_conflict_error_missing_article_constraint.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_err_unexpected_action(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_article_error_unexpected_on_conflict_action.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_err_unexpected_constraint(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_article_unexpected_on_conflict_constraint_error.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_role_has_no_permissions_err(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/address_permission_error.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_user_role_insert_check_perm_success(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_user_role_insert_check_perm_success.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_role_insert_check_is_registered_fail(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_user_role_insert_check_is_registered_fail.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_role_insert_check_user_id_fail(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_user_role_insert_check_user_id_fail.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_student_role_insert_check_bio_success(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_student_role_insert_check_bio_success.yaml")
|
2018-09-18 14:45:35 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_student_role_insert_check_bio_fail(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_student_role_insert_check_bio_fail.yaml")
|
2018-09-18 14:45:35 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_company_user_role_insert(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/company_user_role.yaml")
|
2018-09-20 18:24:20 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_company_user_role_insert_on_conflict(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/company_user_role_on_conflict.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_user_role_insert(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_user.yaml")
|
2018-10-26 17:58:20 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_infant_role_insert(self, hge_ctx):
|
2018-11-02 18:08:38 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_infant.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_infant_role_insert_fail(self, hge_ctx):
|
2018-11-02 18:08:38 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_infant_fail.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_5_modifies_resident_6_upsert(self, hge_ctx):
|
2018-12-15 19:10:29 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_5_modifies_resident_6_upsert.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_on_conflict_where(self, hge_ctx):
|
2019-10-09 13:09:20 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_on_conflict_where.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_blog_on_conflict_update_preset(self, hge_ctx):
|
2019-02-23 13:36:42 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/blog_on_conflict_update_preset.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_arr_sess_var_insert_article_as_editor_allowed_user_id(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_article_arr_sess_var_editor_allowed_user_id.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_arr_sess_var_insert_article_as_editor_err_not_allowed_user_id(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_article_arr_sess_var_editors_err_not_allowed_user_id.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_seller_insert_computer_json_has_keys_all(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/seller_insert_computer_has_keys_all_pass.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_seller_insert_computer_json_has_keys_all_err(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/seller_insert_computer_has_keys_all_fail.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_developer_insert_computer_json_has_keys_any(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/developer_insert_has_keys_any_pass.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_developer_insert_computer_json_has_keys_any_err(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/developer_insert_has_keys_any_fail.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_insert_account_success(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_insert_account_success.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_insert_account_fail(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_insert_account_fail.yaml")
|
|
|
|
|
|
2020-04-24 12:10:53 +03:00
|
|
|
def test_backend_user_insert_fail(self, hge_ctx):
|
|
|
|
|
check_query_admin_secret(hge_ctx, self.dir() + "/backend_user_insert_fail.yaml")
|
|
|
|
|
|
|
|
|
|
def test_backend_user_insert_pass(self, hge_ctx):
|
|
|
|
|
check_query_admin_secret(hge_ctx, self.dir() + "/backend_user_insert_pass.yaml")
|
|
|
|
|
|
|
|
|
|
def test_backend_user_insert_invalid_bool(self, hge_ctx):
|
|
|
|
|
check_query_admin_secret(hge_ctx, self.dir() + "/backend_user_insert_invalid_bool.yaml")
|
|
|
|
|
|
|
|
|
|
def test_user_with_no_backend_privilege(self, hge_ctx):
|
|
|
|
|
check_query_admin_secret(hge_ctx, self.dir() + "/user_with_no_backend_privilege.yaml")
|
|
|
|
|
|
|
|
|
|
def test_backend_user_no_admin_secret_fail(self, hge_ctx):
|
|
|
|
|
if hge_ctx.hge_key and (hge_ctx.hge_jwt_key or hge_ctx.hge_webhook):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/backend_user_no_admin_secret_fail.yaml")
|
|
|
|
|
else:
|
|
|
|
|
pytest.skip("authorization not configured, skipping the test")
|
|
|
|
|
|
Rewrite GraphQL schema generation and query parsing (close #2801) (#4111)
Aka “the PDV refactor.” History is preserved on the branch 2801-graphql-schema-parser-refactor.
* [skip ci] remove stale benchmark commit from commit_diff
* [skip ci] Check for root field name conflicts between remotes
* [skip ci] Additionally check for conflicts between remotes and DB
* [skip ci] Check for conflicts in schema when tracking a table
* [skip ci] Fix equality checking in GraphQL AST
* server: fix mishandling of GeoJSON inputs in subscriptions (fix #3239) (#4551)
* Add support for multiple top-level fields in a subscription to improve testability of subscriptions
* Add an internal flag to enable multiple subscriptions
* Add missing call to withConstructorFn in live queries (fix #3239)
Co-authored-by: Alexis King <lexi.lambda@gmail.com>
* Scheduled triggers (close #1914) (#3553)
server: add scheduled triggers
Co-authored-by: Alexis King <lexi.lambda@gmail.com>
Co-authored-by: Marion Schleifer <marion@hasura.io>
Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
* dev.sh: bump version due to addition of croniter python dependency
* server: fix an introspection query caching issue (fix #4547) (#4661)
Introspection queries accept variables, but we need to make sure to
also touch the variables that we ignore, so that an introspection
query is marked not reusable if we are not able to build a correct
query plan for it.
A better solution here would be to deal with such unused variables
correctly, so that more introspection queries become reusable.
An even better solution would be to type-safely track *how* to reuse
which variables, rather than to split the reusage marking from the
planning.
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* flush log buffer on exception in mkWaiApp ( fix #4772 ) (#4801)
* flush log buffer on exception in mkWaiApp
* add comment to explain the introduced change
* add changelog
* allow logging details of a live query polling thread (#4959)
* changes for poller-log
add various multiplexed query info in poller-log
* minor cleanup, also fixes a bug which will return duplicate data
* Live query poller stats can now be logged
This also removes in-memory stats that are collected about batched
query execution as the log lines when piped into an monitoring tool
will give us better insights.
* allow poller-log to be configurable
* log minimal information in the livequery-poller-log
Other information can be retrieved from /dev/subscriptions/extended
* fix few review comments
* avoid marshalling and unmarshalling from ByteString to EncJSON
* separate out SubscriberId and SubscriberMetadata
Co-authored-by: Anon Ray <rayanon004@gmail.com>
* Don't compile in developer APIs by default
* Tighten up handling of admin secret, more docs
Store the admin secret only as a hash to prevent leaking the secret
inadvertently, and to prevent timing attacks on the secret.
NOTE: best practice for stored user passwords is a function with a
tunable cost like bcrypt, but our threat model is quite different (even
if we thought we could reasonably protect the secret from an attacker
who could read arbitrary regions of memory), and bcrypt is far too slow
(by design) to perform on each request. We'd have to rely on our
(technically savvy) users to choose high entropy passwords in any case.
Referencing #4736
* server/docs: add instructions to fix loss of float precision in PostgreSQL <= 11 (#5187)
This adds a server flag, --pg-connection-options, that can be used to set a PostgreSQL connection parameter, extra_float_digits, that needs to be used to avoid loss of data on older versions of PostgreSQL, which have odd default behavior when returning float values. (fixes #5092)
* [skip ci] Add new commits from master to the commit diff
* [skip ci] serve default directives (skip & include) over introspection
* [skip ci] Update non-Haskell assets with the version on master
* server: refactor GQL execution check and config API (#5094)
Co-authored-by: Vamshi Surabhi <vamshi@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] fix js issues in tests by pinning dependencies version
* [skip ci] bump graphql version
* [skip ci] Add note about memory usage
* generalize query execution logic on Postgres (#5110)
* generalize PGExecCtx to support specialized functions for various operations
* fix tests compilation
* allow customising PGExecCtx when starting the web server
* server: changes catalog initialization and logging for pro customization (#5139)
* new typeclass to abstract the logic of QueryLog-ing
* abstract the logic of logging websocket-server logs
introduce a MonadWSLog typeclass
* move catalog initialization to init step
expose a helper function to migrate catalog
create schema cache in initialiseCtx
* expose various modules and functions for pro
* [skip ci] cosmetic change
* [skip ci] fix test calling a mutation that does not exist
* [skip ci] minor text change
* [skip ci] refactored input values
* [skip ci] remove VString Origin
* server: fix updating of headers behaviour in the update cron trigger API and create future events immediately (#5151)
* server: fix bug to update headers in an existing cron trigger and create future events
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* Lower stack chunk size in RTS to reduce thread STACK memory (closes #5190)
This reduces memory consumption for new idle subscriptions significantly
(see linked ticket).
The hypothesis is: we fork a lot of threads per websocket, and some of
these use slightly more than the initial 1K stack size, so the first
overflow balloons to 32K, when significantly less is required.
However: running with `+RTS -K1K -xc` did not seem to show evidence of
any overflows! So it's a mystery why this improves things.
GHC should probably also be doubling the stack buffer at each overflow
or doing something even smarter; the knobs we have aren't so helpful.
* [skip ci] fix todo and schema generation for aggregate fields
* 5087 libpq pool leak (#5089)
Shrink libpq buffers to 1MB before returning connection to pool. Closes #5087
See: https://github.com/hasura/pg-client-hs/pull/19
Also related: #3388 #4077
* bump pg-client-hs version (fixes a build issue on some environments) (#5267)
* do not use prepared statements for mutations
* server: unlock scheduled events on graceful shutdown (#4928)
* Fix buggy parsing of new --conn-lifetime flag in 2b0e3774
* [skip ci] remove cherry-picked commit from commit_diff.txt
* server: include additional fields in scheduled trigger webhook payload (#5262)
* include scheduled triggers metadata in the webhook body
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* server: call the webhook asynchronously in event triggers (#5352)
* server: call the webhook asynchronosly in event triggers
* Expose all modules in Cabal file (#5371)
* [skip ci] update commit_diff.txt
* [skip ci] fix cast exp parser & few TODOs
* [skip ci] fix remote fields arguments
* [skip ci] fix few more TODO, no-op refactor, move resolve/action.hs to execute/action.hs
* Pass environment variables around as a data structure, via @sordina (#5374)
* Pass environment variables around as a data structure, via @sordina
* Resolving build error
* Adding Environment passing note to changelog
* Removing references to ILTPollerLog as this seems to have been reintroduced from a bad merge
* removing commented-out imports
* Language pragmas already set by project
* Linking async thread
* Apply suggestions from code review
Use `runQueryTx` instead of `runLazyTx` for queries.
* remove the non-user facing entry in the changelog
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] fix: restrict remote relationship field generation for hasura queries
* [skip ci] no-op refactor; move insert execution code from schema parser module
* server: call the webhook asynchronously in event triggers (#5352)
* server: call the webhook asynchronosly in event triggers
* Expose all modules in Cabal file (#5371)
* [skip ci] update commit_diff.txt
* Pass environment variables around as a data structure, via @sordina (#5374)
* Pass environment variables around as a data structure, via @sordina
* Resolving build error
* Adding Environment passing note to changelog
* Removing references to ILTPollerLog as this seems to have been reintroduced from a bad merge
* removing commented-out imports
* Language pragmas already set by project
* Linking async thread
* Apply suggestions from code review
Use `runQueryTx` instead of `runLazyTx` for queries.
* remove the non-user facing entry in the changelog
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] implement header checking
Probably closes #14 and #3659.
* server: refactor 'pollQuery' to have a hook to process 'PollDetails' (#5391)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* update pg-client (#5421)
* [skip ci] update commit_diff
* Fix latency buckets for telemetry data
These must have gotten messed up during a refactor. As a consequence
almost all samples received so far fall into the single erroneous 0 to
1K seconds (originally supposed to be 1ms?) bucket.
I also re-thought what the numbers should be, but these are still
arbitrary and might want adjusting in the future.
* [skip ci] include the latest commit compared against master in commit_diff
* [skip ci] include new commits from master in commit_diff
* [skip ci] improve description generation
* [skip ci] sort all introspect arrays
* [skip ci] allow parsers to specify error codes
* [skip ci] fix integer and float parsing error code
* [skip ci] scalar from json errors are now parse errors
* [skip ci] fixed negative integer error message and code
* [skip ci] Re-fix nullability in relationships
* [skip ci] no-op refactor and removed couple of FIXMEs
* [skip ci] uncomment code in 'deleteMetadataObject'
* [skip ci] Fix re-fix of nullability for relationships
* [skip ci] fix default arguments error code
* [skip ci] updated test error message
!!! WARNING !!!
Since all fields accept `null`, they all are technically optional in
the new schema. Meaning there's no such thing as a missing mandatory
field anymore: a field that doesn't have a default value, and which
therefore isn't labelled as "optional" in the schema, will be assumed
to be null if it's missing, meaning it isn't possible anymore to have
an error for a missing mandatory field. The only possible error is now
when a optional positional argument is omitted but is not the last
positional argument.
* [skip ci] cleanup of int scalar parser
* [skip ci] retro-compatibility of offset as string
* [skip ci] Remove commit from commit_diff.txt
Although strictly speaking we don't know if this will work correctly in PDV
if we would implement query plan caching, the fact is that in the theoretical
case that we would have the same issue in PDV, it would probably apply not just
to introspection, and the fix would be written completely differently. So this
old commit is of no value to us other than the heads-up "make sure query plan
caching works correctly even in the presence of unused variables", which is
already part of the test suite.
* Add MonadTrace and MonadExecuteQuery abstractions (#5383)
* [skip ci] Fix accumulation of input object types
Just like object types, interface types, and union types, we have to avoid
circularities when collecting input types from the GraphQL AST.
Additionally, this fixes equality checks for input object types (whose fields
are unordered, and hence should be compared as sets) and enum types (ditto).
* [skip ci] fix fragment error path
* [skip ci] fix node error code
* [skip ci] fix paths in insert queries
* [skip ci] fix path in objects
* [skip ci] manually alter node id path for consistency
* [skip ci] more node error fixups
* [skip ci] one last relay error message fix
* [skip ci] update commit_diff
* Propagate the trace context to event triggers (#5409)
* Propagate the trace context to event triggers
* Handle missing trace and span IDs
* Store trace context as one LOCAL
* Add migrations
* Documentation
* changelog
* Fix warnings
* Respond to code review suggestions
* Respond to code review
* Undo changelog
* Update CHANGELOG.md
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* server: log request/response sizes for event triggers (#5463)
* server: log request/response sizes for event triggers
event triggers (and scheduled triggers) now have request/response size
in their logs.
* add changelog entry
* Tracing: Simplify HTTP traced request (#5451)
Remove the Inversion of Control (SuspendRequest) and simplify
the tracing of HTTP Requests.
Co-authored-by: Phil Freeman <phil@hasura.io>
* Attach request ID as tracing metadata (#5456)
* Propagate the trace context to event triggers
* Handle missing trace and span IDs
* Store trace context as one LOCAL
* Add migrations
* Documentation
* Include the request ID as trace metadata
* changelog
* Fix warnings
* Respond to code review suggestions
* Respond to code review
* Undo changelog
* Update CHANGELOG.md
* Typo
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* server: add logging for action handlers (#5471)
* server: add logging for action handlers
* add changelog entry
* change action-handler log type from internal to non-internal
* fix action-handler-log name
* server: pass http and websocket request to logging context (#5470)
* pass request body to logging context in all cases
* add message size logging on the websocket API
this is required by graphql-engine-pro/#416
* message size logging on websocket API
As we need to log all messages recieved/sent by the websocket server,
it makes sense to log them as part of the websocket server event logs.
Previously message recieved were logged inside the onMessage handler,
and messages sent were logged only for "data" messages (as a server event log)
* fix review comments
Co-authored-by: Phil Freeman <phil@hasura.io>
* server: stop eventing subsystem threads when shutting down (#5479)
* server: stop eventing subsystem threads when shutting down
* Apply suggestions from code review
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
* [skip ci] update commit_diff with new commits added in master
* Bugfix to support 0-size HASURA_GRAPHQL_QUERY_PLAN_CACHE_SIZE
Also some minor refactoring of bounded cache module:
- the maxBound check in `trim` was confusing and unnecessary
- consequently trim was unnecessary for lookupPure
Also add some basic tests
* Support only the bounded cache, with default HASURA_GRAPHQL_QUERY_PLAN_CACHE_SIZE of 4000. Closes #5363
* [skip ci] remove merge commit from commit_diff
* server: Fix compiler warning caused by GHC upgrade (#5489)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* [skip ci] update all non server code from master
* [skip ci] aligned object field error message with master
* [skip ci] fix remaining undefined?
* [skip ci] remove unused import
* [skip ci] revert to previous error message, fix tests
* Move nullableType/nonNullableType to Schema.hs
These are functions on Types, not on Parsers.
* [skip ci] fix setup to fix backend only test
the order in which permission checks are performed on the branch is
slightly different than on master, resulting in a slightly different
error if there are no other mutations the user has access to. By
adding update permissions, we go back to the expected case.
* [skip ci] fix insert geojson tests to reflect new paths
* [skip ci] fix enum test for better error message
* [skip ci] fix header test for better error message
* [skip ci] fix fragment cycle test for better error message
* [skip ci] fix error message for type mismatch
* [skip ci] fix variable path in test
* [skip ci] adjust tests after bug fix
* [skip ci] more tests fixing
* Add hdb_catalog.current_setting abstraction for reading Hasura settings
As the comment in the function’s definition explains, this is needed to
work around an awkward Postgres behavior.
* [skip ci] Update CONTRIBUTING.md to mention Node setup for Python tests
* [skip ci] Add missing Python tests env var to CONTRIBUTING.md
* [skip ci] fix order of result when subscription is run with multiple nodes
* [skip ci] no-op refactor: fix a warning in Internal/Parser.hs
* [skip ci] throw error when a subscription contains remote joins
* [skip ci] Enable easier profiling by hiding AssertNF behind a flag
In order to compile a profiling build, run:
$ cabal new-build -f profiling --enable-profiling
* [skip ci] Fix two warnings
We used to lookup the objects that implement a given interface by filtering all
objects in the schema document. However, one of the tests expects us to
generate a warning if the provided `implements` field of an introspection query
specifies an object not implementing some interface. So we use that field
instead.
* [skip ci] Fix warnings by commenting out query plan caching
* [skip ci] improve masking/commenting query caching related code & few warning fixes
* [skip ci] Fixed compiler warnings in graphql-parser-hs
* Sync non-Haskell assets with master
* [skip ci] add a test inserting invalid GraphQL but valid JSON value in a jsonb column
* [skip ci] Avoid converting to/from Map
* [skip ci] Apply some hlint suggestions
* [skip ci] remove redundant constraints from buildLiveQueryPlan and explainGQLQuery
* [skip ci] add NOTEs about missing Tracing constraints in PDV from master
* Remove -fdefer-typed-holes, fix warnings
* Update cabal.project.freeze
* Limit GHC’s heap size to 8GB in CI to avoid the OOM killer
* Commit package-lock.json for Python tests’ remote schema server
* restrict env variables start with HASURA_GRAPHQL_ for headers configuration in actions, event triggers & remote schemas (#5519)
* restrict env variables start with HASURA_GRAPHQL_ for headers definition in actions & event triggers
* update CHANGELOG.md
* Apply suggestions from code review
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* add test for table_by_pk node when roles doesn't have permission to PK
* [skip ci] fix introspection query if any enum column present in primary key (fix #5200) (#5522)
* [skip ci] test case fix for a6450e126bc2d98bcfd3791501986e4627ce6c6f
* [skip ci] add tests to agg queries when role doesn't have access to any cols
* fix backend test
* Simplify subscription execution
* [skip ci] add test to check if required headers are present while querying
* Suppose, table B is related to table A and to query B certain headers are
necessary, then the test checks that we are throwing error when the header
is not set when B is queried through A
* fix mutations not checking for view mutability
* [skip ci] add variable type checking and corresponding tests
* [skip ci] add test to check if update headers are present while doing an upsert
* [skip ci] add positive counterparts to some of the negative permission tests
* fix args missing their description in introspect
* [skip ci] Remove unused function; insert missing markNotReusable call
* [skip ci] Add a Note about InputValue
* [skip ci] Delete LegacySchema/ 🎉
* [skip ci] Delete GraphQL/{Resolve,Validate}/ 🎉
* [skip ci] Delete top-level Resolve/Validate modules; tidy .cabal file
* [skip ci] Delete LegacySchema top-level module
Somehow I missed this one.
* fix input value to json
* [skip ci] elaborate on JSON objects in GraphQL
* [skip ci] add missing file
* [skip ci] add a test with subscription containing remote joins
* add a test with remote joins in mutation output
* [skip ci] Add some comments to Schema/Mutation.hs
* [skip ci] Remove no longer needed code from RemoteServer.hs
* [skip ci] Use a helper function to generate conflict clause parsers
* [skip ci] fix type checker error in fields with default value
* capitalize the header keys in select_articles_without_required_headers
* Somehow, this was the reason the tests were failing. I have no idea, why!
* [skip ci] Add a long Note about optional fields and nullability
* Improve comments a bit; simplify Schema/Common.hs a bit
* [skip ci] full implementation of 5.8.5 type checking.
* [skip ci] fix validation test teardown
* [skip ci] fix schema stitching test
* fix remote schema ignoring enum nullability
* [skip ci] fix fieldOptional to not discard nullability
* revert nullability of use_spheroid
* fix comment
* add required remote fields with arguments for tests
* [skip ci] add missing docstrings
* [skip ci] fixed description of remote fields
* [skip ci] change docstring for consistency
* fix several schema inconsistencies
* revert behaviour change in function arguments parsing
* fix remaining nullability issues in new schema
* minor no-op refactor; use isListType from graphql-parser-hs
* use nullability of remote schema node, while creating a Remote reln
* fix 'ID' input coercing & action 'ID' type relationship mapping
* include ASTs in MonadExecuteQuery
* needed for PRO code-base
* Delete code for "interfaces implementing ifaces" (draft GraphQL spec)
Previously I started writing some code that adds support for a future GraphQL
feature where interfaces may themselves be sub-types of other interfaces.
However, this code was incomplete, and partially incorrect. So this commit
deletes support for that entirely.
* Ignore a remote schema test during the upgrade/downgrade test
The PDV refactor does a better job at exposing a minimal set of types through
introspection. In particular, not every type that is present in a remote schema
is re-exposed by Hasura. The test
test_schema_stitching.py::TestRemoteSchemaBasic::test_introspection assumed that
all types were re-exposed, which is not required for GraphQL compatibility, in
order to test some aspect of our support for remote schemas.
So while this particular test has been updated on PDV, the PDV branch now does
not pass the old test, which we argue to be incorrect. Hence this test is
disabled while we await a release, after which we can re-enable it.
This also re-enables a test that was previously disabled for similar, though
unrelated, reasons.
* add haddock documentation to the action's field parsers
* Deslecting some tests in server-upgrade
Some tests with current build are failing on server upgrade
which it should not. The response is more accurate than
what it was.
Also the upgrade tests were not throwing errors when the test is
expected to return an error, but succeeds. The test framework is
patched to catch this case.
* [skip ci] Add a long Note about interfaces and object types
* send the response headers back to client after running a query
* Deselect a few more tests during upgrade/downgrade test
* Update commit_diff.txt
* change log kind from db_migrate to catalog_migrate (#5531)
* Show method and complete URI in traced HTTP calls (#5525)
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* restrict env variables start with HASURA_GRAPHQL_ for headers configuration in actions, event triggers & remote schemas (#5519)
* restrict env variables start with HASURA_GRAPHQL_ for headers definition in actions & event triggers
* update CHANGELOG.md
* Apply suggestions from code review
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
* fix introspection query if any enum column present in primary key (fix #5200) (#5522)
* Fix telemetry reporting of transport (websocket was reported as http)
* add log kinds in cli-migrations image (#5529)
* add log kinds in cli-migrations image
* give hint to resolve timeout error
* minor changes and CHANGELOG
* server: set hasura.tracecontext in RQL mutations [#5542] (#5555)
* server: set hasura.tracecontext in RQL mutations [#5542]
* Update test suite
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
* Add bulldozer auto-merge and -update configuration
We still need to add the github app (as of time of opening this PR)
Afterwards devs should be able to allow bulldozer to automatically
"update" the branch, merging in parent when it changes, as well as
automatically merge when all checks pass.
This is opt-in by adding the `auto-update-auto-merge` label to the PR.
* Remove 'bulldozer' config, try 'kodiak' for auto-merge
see: https://github.com/chdsbd/kodiak
The main issue that bit us was not being able to auto update forked
branches, also:
https://github.com/palantir/bulldozer/issues/66
https://github.com/palantir/bulldozer/issues/145
* Cherry-picked all commits
* [skip ci] Slightly improve formatting
* Revert "fix introspection query if any enum column present in primary key (fix #5200) (#5522)"
This reverts commit 0f9a5afa59a88f6824f4d63d58db246a5ba3fb03.
This undoes a cherry-pick of 34288e1eb5f2c5dad9e6d1e05453dd52397dc970 that was
already done previously in a6450e126bc2d98bcfd3791501986e4627ce6c6f, and
subsequently fixed for PDV in 70e89dc250f8ddc6e2b7930bbe2b3eeaa6dbe1db
* Do a small bit of tidying in Hasura.GraphQL.Parser.Collect
* Fix cherry-picking work
Some previous cherry-picks ended up modifying code that is commented out
* [skip ci] clarified comment regarding insert representation
* [skip ci] removed obsolete todos
* cosmetic change
* fix action error message
* [skip ci] remove obsolete comment
* [skip ci] synchronize stylish haskell extensions list
* use previously defined scalar names in parsers rather than ad-hoc literals
* Apply most syntax hlint hints.
* Clarify comment on update mutation.
* [skip ci] Clarify what fields should be specified for objects
* Update "_inc" description.
* Use record types rather than tuples fo IntrospectionResult and ParsedIntrospection
* Get rid of checkFieldNamesUnique (use Data.List.Extended.duplicates)
* Throw more errors when collecting query root names
* [skip ci] clean column parser comment
* Remove dead code inserted in ab65b39
* avoid converting to non-empty list where not needed
* add note and TODO about the disabled checks in PDV
* minor refactor in remoteField' function
* Unify two getObject methods
* Nitpicks in Remote.hs
* Update CHANGELOG.md
* Revert "Unify two getObject methods"
This reverts commit bd6bb40355b3d189a46c0312eb52225e18be57b3.
We do need two different getObject functions as the corresponding error message is different
* Fix error message in Remote.hs
* Update CHANGELOG.md
Co-authored-by: Auke Booij <auke@tulcod.com>
* Apply suggested Changelog fix.
Co-authored-by: Auke Booij <auke@tulcod.com>
* Fix typo in Changelog.
* [skip ci] Update changelog.
* reuse type names to avoid duplication
* Fix Hashable instance for Definition
The presence of `Maybe Unique`, and an optional description, as part of
`Definition`s, means that `Definition`s that are considered `Eq`ual may get
different hashes. This can happen, for instance, when one object is memoized
but another is not.
* [skip ci] Update commit_diff.txt
* Bump parser version.
* Bump freeze file after changes in parser.
* [skip ci] Incorporate commits from master
* Fix developer flag in server/cabal.project.freeze
Co-authored-by: Auke Booij <auke@tulcod.com>
* Deselect a changed ENUM test for upgrade/downgrade CI
* Deselect test here as well
* [skip ci] remove dead code
* Disable more tests for upgrade/downgrade
* Fix which test gets deselected
* Revert "Add hdb_catalog.current_setting abstraction for reading Hasura settings"
This reverts commit 66e85ab9fbd56cca2c28a80201f6604fbe811b85.
* Remove circular reference in cabal.project.freeze
Co-authored-by: Karthikeyan Chinnakonda <karthikeyan@hasura.io>
Co-authored-by: Auke Booij <auke@hasura.io>
Co-authored-by: Tirumarai Selvan <tiru@hasura.io>
Co-authored-by: Marion Schleifer <marion@hasura.io>
Co-authored-by: Aleksandra Sikora <ola.zxcvbnm@gmail.com>
Co-authored-by: Brandon Simmons <brandon.m.simmons@gmail.com>
Co-authored-by: Vamshi Surabhi <0x777@users.noreply.github.com>
Co-authored-by: Anon Ray <rayanon004@gmail.com>
Co-authored-by: rakeshkky <12475069+rakeshkky@users.noreply.github.com>
Co-authored-by: Anon Ray <ecthiender@users.noreply.github.com>
Co-authored-by: Vamshi Surabhi <vamshi@hasura.io>
Co-authored-by: Antoine Leblanc <antoine@hasura.io>
Co-authored-by: Brandon Simmons <brandon@hasura.io>
Co-authored-by: Phil Freeman <phil@hasura.io>
Co-authored-by: Lyndon Maydwell <lyndon@sordina.net>
Co-authored-by: Phil Freeman <paf31@cantab.net>
Co-authored-by: Naveen Naidu <naveennaidu479@gmail.com>
Co-authored-by: Karthikeyan Chinnakonda <chkarthikeyan95@gmail.com>
Co-authored-by: Nizar Malangadan <nizar-m@users.noreply.github.com>
Co-authored-by: Antoine Leblanc <crucuny@gmail.com>
Co-authored-by: Auke Booij <auke@tulcod.com>
2020-08-21 20:27:01 +03:00
|
|
|
def test_check_set_headers_while_doing_upsert(self,hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/leads_upsert_check_with_headers.yaml")
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/permissions"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-24 12:10:53 +03:00
|
|
|
def check_query_admin_secret(hge_ctx, f, transport='http'):
|
|
|
|
|
conf = get_conf_f(f)
|
|
|
|
|
admin_secret = hge_ctx.hge_key
|
|
|
|
|
if admin_secret:
|
|
|
|
|
conf['headers']['x-hasura-admin-secret'] = admin_secret
|
|
|
|
|
check_query(hge_ctx, conf, transport, False)
|
|
|
|
|
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@usefixtures('per_class_tests_db_state')
|
|
|
|
|
class TestGraphqlInsertConstraints:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_address_not_null_constraint_err(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/address_not_null_constraint_error.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_unique_constraint_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_unique_constraint_error.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/constraints"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-02 08:27:43 +03:00
|
|
|
@usefixtures('per_class_tests_db_state')
|
|
|
|
|
class TestGraphqlInsertNullPrefixedColumnOnConflict:
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_address_not_null_constraint_err(self, hge_ctx):
|
2020-04-02 08:27:43 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/null_prefixed_column_ok.yaml")
|
|
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/nullprefixcolumn"
|
|
|
|
|
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlInsertGeoJson:
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_point_landmark(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_landmark.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_3d_point_drone_loc(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_drone_3d_location.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_landmark_single_position_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_landmark_single_position_err.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_line_string_road(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_road.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_road_single_point_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_road_single_point_err.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_multi_point_service_locations(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_service_locations.yaml")
|
2020-04-15 19:13:53 +03:00
|
|
|
|
|
|
|
|
def test_insert_multi_line_string_route(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_route.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_polygon(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_area.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_linear_ring_less_than_4_points_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_area_less_than_4_points_err.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_linear_ring_last_point_not_equal_to_first_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_linear_ring_last_point_not_equal_to_first_err.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_multi_polygon_compounds(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_compounds.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_geometry_collection(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_geometry_collection.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_unexpected_geometry_type_err(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_geometry_unexpected_type_err.yaml")
|
2018-10-24 11:21:37 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/geojson"
|
2018-10-24 11:21:37 +03:00
|
|
|
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
# Skipping server upgrade tests for a few tests below
|
|
|
|
|
# Those tests capture bugs in the previous release
|
|
|
|
|
class TestGraphqlNestedInserts:
|
2021-03-03 16:02:00 +03:00
|
|
|
def test_author_with_detail(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_detail.yaml")
|
|
|
|
|
|
|
|
|
|
def test_author_with_detail_fk(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_detail_fk.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_with_articles(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_articles.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_with_articles_empty(self, hge_ctx):
|
2019-01-11 10:22:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_articles_empty.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_with_articles_null(self, hge_ctx):
|
2019-01-11 10:22:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_articles_null.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_with_articles_author_id_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_articles_author_id_fail.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_articles_with_author(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/articles_with_author.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_articles_with_author_author_id_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/articles_with_author_author_id_fail.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_upsert_articles_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_upsert_articles_fail.yaml")
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_articles_author_upsert_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/articles_author_upsert_fail.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_articles_with_author_returning(self, hge_ctx):
|
2019-03-07 13:24:07 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/articles_with_author_returning.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_one(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_one.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_with_articles_one(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_with_articles_one.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_upsert_one_update(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_upsert_one_update.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_upsert_one_no_update(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_upsert_one_no_update.yaml")
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/nested"
|
2018-10-05 18:13:51 +03:00
|
|
|
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlInsertViews:
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_view_author_simple(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_view_author_simple.yaml")
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_insert_view_author_complex_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/insert_view_author_complex_fail.yaml")
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_nested_insert_article_author_simple_view(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/nested_insert_article_author_simple_view.yaml")
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_nested_insert_article_author_complex_view_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/nested_insert_article_author_complex_view_fail.yaml")
|
2018-10-16 13:25:41 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/insert/views"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlUpdateBasic:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_set_author_name(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_set_name.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_empty_set_author(self, hge_ctx):
|
2019-01-28 10:24:24 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_empty_set.yaml")
|
|
|
|
|
hge_ctx.may_skip_test_teardown = True
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_set_person_details(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_set_details.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_person_id_inc(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_inc.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_no_operator_err(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_error_no_operator.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_column_in_multiple_operators(self, hge_ctx):
|
2019-12-03 23:00:37 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_column_multiple_operators.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_by_pk(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_by_pk.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_by_pk_null(self, hge_ctx):
|
2020-02-13 20:38:23 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_by_pk_null.yaml")
|
|
|
|
|
|
2020-04-17 12:32:09 +03:00
|
|
|
def test_numerics_inc(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/numerics_inc.yaml")
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/update/basic"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlUpdateJsonB:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_append_object(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_append_object.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_append_array(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_append_array.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_prepend_array(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_prepend_array.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_delete_at_path(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_delete_at_path.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_delete_array_element(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_delete_array_element.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_jsonb_delete_key(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/person_delete_key.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/update/jsonb"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlUpdatePermissions:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_update_author(self, hge_ctx):
|
2020-03-11 12:15:02 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_update_author.yaml")
|
2020-03-10 15:45:47 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_can_update_unpublished_article(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_can_update_unpublished_article.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_cannot_update_published_version_col(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_cannot_update_published_article_version.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_cannot_update_another_users_article(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_cannot_update_another_users_article.yaml")
|
2020-03-10 15:45:47 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_cannot_publish(self, hge_ctx):
|
2020-02-13 10:38:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_cannot_publish.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_cannot_update_id_col(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_cannot_update_id_col_article.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_update_resident_preset(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/user_update_resident_preset.yaml')
|
2019-02-11 15:45:30 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_update_resident_preset_session_var(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/user_update_resident_preset_session_var.yaml')
|
2019-02-11 15:45:30 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_account_update_success(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/user_account_update_success.yaml')
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_account_update_no_rows(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/user_account_update_no_rows.yaml')
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/update/permissions"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
|
|
|
|
|
2019-05-10 09:05:11 +03:00
|
|
|
@pytest.mark.parametrize("transport", ['http', 'websocket'])
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlDeleteBasic:
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2019-04-08 10:22:38 +03:00
|
|
|
def test_article_delete(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/article.yaml", transport)
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2019-04-08 10:22:38 +03:00
|
|
|
def test_article_delete_returning(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_returning.yaml", transport)
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2019-04-08 10:22:38 +03:00
|
|
|
def test_article_delete_returning_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_returning_author.yaml", transport)
|
2019-03-22 10:08:42 +03:00
|
|
|
|
2019-12-11 02:20:55 +03:00
|
|
|
def test_author_returning_empty_articles(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_returning_empty_articles.yaml", transport)
|
|
|
|
|
|
2020-02-13 20:38:23 +03:00
|
|
|
def test_article_by_pk(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_by_pk.yaml", transport)
|
|
|
|
|
|
|
|
|
|
def test_article_by_pk_null(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/article_by_pk_null.yaml", transport)
|
|
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/delete/basic"
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2019-05-10 09:05:11 +03:00
|
|
|
@pytest.mark.parametrize("transport", ['http', 'websocket'])
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlDeleteConstraints:
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2019-04-08 10:22:38 +03:00
|
|
|
def test_author_delete_foreign_key_violation(self, hge_ctx, transport):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_foreign_key_violation.yaml")
|
2018-09-18 09:21:57 +03:00
|
|
|
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/delete/constraints"
|
2018-09-18 09:21:57 +03:00
|
|
|
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlDeletePermissions:
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_can_delete_his_articles(self, hge_ctx):
|
2018-10-30 12:21:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_can_delete_his_articles.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_author_cannot_delete_other_users_articles(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/author_cannot_delete_other_users_articles.yaml")
|
2018-10-04 15:44:15 +03:00
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_resident_delete_without_select_perm_fail(self, hge_ctx):
|
2018-10-28 21:27:49 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/resident_delete_without_select_perm_fail.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_agent_delete_perm_arr_sess_var(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/agent_delete_perm_arr_sess_var.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_agent_delete_perm_arr_sess_var_fail(self, hge_ctx):
|
2019-07-10 13:19:58 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/agent_delete_perm_arr_sess_var_fail.yaml")
|
|
|
|
|
|
2020-12-02 17:12:06 +03:00
|
|
|
def test_user_delete_author(self, hge_ctx):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_delete_author.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_delete_account_success(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_delete_account_success.yaml")
|
|
|
|
|
|
2020-04-15 19:13:53 +03:00
|
|
|
def test_user_delete_account_no_rows(self, hge_ctx):
|
2019-09-05 10:34:53 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + "/user_delete_account_no_rows.yaml")
|
2018-10-28 21:27:49 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/delete/permissions"
|
2019-07-22 15:47:13 +03:00
|
|
|
|
2019-09-19 07:47:36 +03:00
|
|
|
@pytest.mark.parametrize("transport", ['http', 'websocket'])
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlMutationCustomSchema:
|
2019-09-19 07:47:36 +03:00
|
|
|
|
|
|
|
|
def test_insert_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_author.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_insert_article_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_article_author.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_update_article(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/update_article.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_delete_article(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/delete_article.yaml', transport)
|
|
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/custom_schema"
|
|
|
|
|
|
2020-10-29 15:48:45 +03:00
|
|
|
@pytest.mark.parametrize("transport", ['http', 'websocket'])
|
|
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphqlMutationCustomGraphQLTableName:
|
|
|
|
|
|
|
|
|
|
def test_insert_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_author_details.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_insert_article_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_article_author.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_update_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/update_author_details.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_delete_author(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/delete_author_details.yaml', transport)
|
|
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return "queries/graphql_mutation/custom_schema/custom_table_name"
|
|
|
|
|
|
2019-07-22 15:47:13 +03:00
|
|
|
@pytest.mark.parametrize('transport', ['http', 'websocket'])
|
2020-02-13 12:14:02 +03:00
|
|
|
@use_mutation_fixtures
|
|
|
|
|
class TestGraphQLMutateEnums:
|
2019-07-22 15:47:13 +03:00
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return 'queries/graphql_mutation/enums'
|
|
|
|
|
|
|
|
|
|
def test_insert_enum_field(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_enum_field.yaml', transport)
|
|
|
|
|
|
2020-02-13 12:14:02 +03:00
|
|
|
def test_insert_nullable_enum_field(self, hge_ctx, transport):
|
2019-10-11 05:22:16 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_nullable_enum_field.yaml', transport)
|
|
|
|
|
|
2019-07-22 15:47:13 +03:00
|
|
|
def test_insert_enum_field_bad_value(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/insert_enum_field_bad_value.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_update_enum_field(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/update_enum_field.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_update_where_enum_field(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/update_where_enum_field.yaml', transport)
|
|
|
|
|
|
|
|
|
|
def test_delete_where_enum_field(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/delete_where_enum_field.yaml', transport)
|
2020-11-18 21:04:57 +03:00
|
|
|
|
2021-01-29 08:48:17 +03:00
|
|
|
use_function_permission_fixtures = usefixtures(
|
|
|
|
|
'per_class_db_schema_for_mutation_tests',
|
|
|
|
|
'per_method_db_data_for_mutation_tests',
|
|
|
|
|
'functions_permissions_fixtures'
|
|
|
|
|
)
|
2020-11-18 21:04:57 +03:00
|
|
|
# Tracking VOLATILE SQL functions as mutations, or queries (#1514)
|
|
|
|
|
@pytest.mark.parametrize('transport', ['http', 'websocket'])
|
2021-01-29 08:48:17 +03:00
|
|
|
@use_function_permission_fixtures
|
2020-11-18 21:04:57 +03:00
|
|
|
class TestGraphQLMutationFunctions:
|
|
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return 'queries/graphql_mutation/functions'
|
|
|
|
|
|
|
|
|
|
# basic test that functions are added in the right places in the schema:
|
|
|
|
|
def test_smoke(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/smoke.yaml', transport)
|
|
|
|
|
|
|
|
|
|
# separate file since we this only works over http transport:
|
|
|
|
|
def test_smoke_errs(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/smoke_errs.yaml', 'http')
|
|
|
|
|
|
|
|
|
|
# Test tracking a VOLATILE function as top-level field of mutation root
|
|
|
|
|
# field, also smoke testing basic permissions on the table return type.
|
|
|
|
|
def test_functions_as_mutations(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/function_as_mutations.yaml', transport)
|
|
|
|
|
|
2021-01-29 08:48:17 +03:00
|
|
|
# When graphql-engine is started with `--infer-function-permissions=false` then
|
|
|
|
|
# a function is only accessible to a role when the permission is granted through
|
|
|
|
|
# the `pg_create_function_permission` definition
|
|
|
|
|
def test_function_as_mutation_without_function_permission(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/function_without_function_permission.yaml')
|
|
|
|
|
|
2020-11-18 21:04:57 +03:00
|
|
|
# Ensure select permissions on the corresponding SETOF table apply to
|
|
|
|
|
# the return set of the mutation field backed by the tracked function.
|
|
|
|
|
def test_functions_as_mutations_permissions(self, hge_ctx, transport):
|
2021-01-29 08:48:17 +03:00
|
|
|
st_code, resp = hge_ctx.v1metadataq_f(self.dir() + '/create_function_permission_add_to_score.yaml')
|
|
|
|
|
assert st_code == 200, resp
|
2020-11-18 21:04:57 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/function_as_mutations_permissions.yaml', transport)
|
2021-01-29 08:48:17 +03:00
|
|
|
st_code, resp = hge_ctx.v1metadataq_f(self.dir() + '/drop_function_permission_add_to_score.yaml')
|
|
|
|
|
assert st_code == 200, resp
|
2021-02-03 17:06:30 +03:00
|
|
|
|
|
|
|
|
def test_single_row_function_as_mutation(self, hge_ctx, transport):
|
2021-02-18 11:26:04 +03:00
|
|
|
st_code, resp = hge_ctx.v1metadataq_f(self.dir() + '/create_function_permission_add_to_score_by_user_id.yaml')
|
|
|
|
|
assert st_code == 200, resp
|
2021-02-03 17:06:30 +03:00
|
|
|
check_query_f(hge_ctx, self.dir() + '/single_row_function_as_mutation.yaml', transport)
|
2021-02-18 11:26:04 +03:00
|
|
|
st_code, resp = hge_ctx.v1metadataq_f(self.dir() + '/drop_function_permission_add_to_score_by_user_id.yaml')
|
|
|
|
|
assert st_code == 200, resp
|
[Preview] Inherited roles for postgres read queries
fixes #3868
docker image - `hasura/graphql-engine:inherited-roles-preview-48b73a2de`
Note:
To be able to use the inherited roles feature, the graphql-engine should be started with the env variable `HASURA_GRAPHQL_EXPERIMENTAL_FEATURES` set to `inherited_roles`.
Introduction
------------
This PR implements the idea of multiple roles as presented in this [paper](https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/FGALanguageICDE07.pdf). The multiple roles feature in this PR can be used via inherited roles. An inherited role is a role which can be created by combining multiple singular roles. For example, if there are two roles `author` and `editor` configured in the graphql-engine, then we can create a inherited role with the name of `combined_author_editor` role which will combine the select permissions of the `author` and `editor` roles and then make GraphQL queries using the `combined_author_editor`.
How are select permissions of different roles are combined?
------------------------------------------------------------
A select permission includes 5 things:
1. Columns accessible to the role
2. Row selection filter
3. Limit
4. Allow aggregation
5. Scalar computed fields accessible to the role
Suppose there are two roles, `role1` gives access to the `address` column with row filter `P1` and `role2` gives access to both the `address` and the `phone` column with row filter `P2` and we create a new role `combined_roles` which combines `role1` and `role2`.
Let's say the following GraphQL query is queried with the `combined_roles` role.
```graphql
query {
employees {
address
phone
}
}
```
This will translate to the following SQL query:
```sql
select
(case when (P1 or P2) then address else null end) as address,
(case when P2 then phone else null end) as phone
from employee
where (P1 or P2)
```
The other parameters of the select permission will be combined in the following manner:
1. Limit - Minimum of the limits will be the limit of the inherited role
2. Allow aggregations - If any of the role allows aggregation, then the inherited role will allow aggregation
3. Scalar computed fields - same as table column fields, as in the above example
APIs for inherited roles:
----------------------
1. `add_inherited_role`
`add_inherited_role` is the [metadata API](https://hasura.io/docs/1.0/graphql/core/api-reference/index.html#schema-metadata-api) to create a new inherited role. It accepts two arguments
`role_name`: the name of the inherited role to be added (String)
`role_set`: list of roles that need to be combined (Array of Strings)
Example:
```json
{
"type": "add_inherited_role",
"args": {
"role_name":"combined_user",
"role_set":[
"user",
"user1"
]
}
}
```
After adding the inherited role, the inherited role can be used like single roles like earlier
Note:
An inherited role can only be created with non-inherited/singular roles.
2. `drop_inherited_role`
The `drop_inherited_role` API accepts the name of the inherited role and drops it from the metadata. It accepts a single argument:
`role_name`: name of the inherited role to be dropped
Example:
```json
{
"type": "drop_inherited_role",
"args": {
"role_name":"combined_user"
}
}
```
Metadata
---------
The derived roles metadata will be included under the `experimental_features` key while exporting the metadata.
```json
{
"experimental_features": {
"derived_roles": [
{
"role_name": "manager_is_employee_too",
"role_set": [
"employee",
"manager"
]
}
]
}
}
```
Scope
------
Only postgres queries and subscriptions are supported in this PR.
Important points:
-----------------
1. All columns exposed to an inherited role will be marked as `nullable`, this is done so that cell value nullification can be done.
TODOs
-------
- [ ] Tests
- [ ] Test a GraphQL query running with a inherited role without enabling inherited roles in experimental features
- [] Tests for aggregate queries, limit, computed fields, functions, subscriptions (?)
- [ ] Introspection test with a inherited role (nullability changes in a inherited role)
- [ ] Docs
- [ ] Changelog
Co-authored-by: Vamshi Surabhi <6562944+0x777@users.noreply.github.com>
GitOrigin-RevId: 3b8ee1e11f5ceca80fe294f8c074d42fbccfec63
2021-03-08 14:14:13 +03:00
|
|
|
|
|
|
|
|
@pytest.mark.parametrize('transport', ['http', 'websocket'])
|
|
|
|
|
@use_inherited_roles_fixtures
|
|
|
|
|
class TestGraphQLInheritedRoles:
|
|
|
|
|
|
|
|
|
|
@classmethod
|
|
|
|
|
def dir(cls):
|
|
|
|
|
return 'queries/graphql_mutation/insert/permissions/inherited_roles'
|
|
|
|
|
|
|
|
|
|
# This test exists here as a sanity check to check if mutations aren't exposed
|
|
|
|
|
# to an inherited role. When mutations are supported for everything, this test
|
|
|
|
|
# should be removed/modified.
|
|
|
|
|
def test_mutations_not_exposed_for_inherited_roles(self, hge_ctx, transport):
|
|
|
|
|
check_query_f(hge_ctx, self.dir() + '/mutation_not_exposed_to_inherited_roles.yaml')
|
