2022-03-16 03:39:21 +03:00
|
|
|
{-# LANGUAGE QuasiQuotes #-}
|
2022-06-08 18:31:28 +03:00
|
|
|
{-# LANGUAGE ViewPatterns #-}
|
2022-03-16 03:39:21 +03:00
|
|
|
|
2021-05-24 23:12:53 +03:00
|
|
|
module Hasura.GraphQL.Schema.RemoteTest (spec) where
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
import Control.Lens (Prism', prism', to, (^..), _Right)
|
|
|
|
import Data.Aeson qualified as J
|
2022-06-08 18:31:28 +03:00
|
|
|
import Data.Aeson.Key qualified as K
|
|
|
|
import Data.Aeson.KeyMap qualified as KM
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.ByteString.Lazy qualified as LBS
|
2021-11-30 17:46:41 +03:00
|
|
|
import Data.HashMap.Strict.Extended qualified as M
|
2021-09-24 01:56:37 +03:00
|
|
|
import Data.Text qualified as T
|
|
|
|
import Data.Text.Extended
|
|
|
|
import Data.Text.RawString
|
|
|
|
import Hasura.Base.Error
|
|
|
|
import Hasura.GraphQL.Execute.Inline
|
|
|
|
import Hasura.GraphQL.Execute.Remote (resolveRemoteVariable, runVariableCache)
|
|
|
|
import Hasura.GraphQL.Execute.Resolve
|
2021-11-30 03:37:14 +03:00
|
|
|
import Hasura.GraphQL.Namespace
|
2022-06-23 12:14:24 +03:00
|
|
|
import Hasura.GraphQL.Parser.Name qualified as GName
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
import Hasura.GraphQL.Parser.Names
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.GraphQL.Parser.TestUtils
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
import Hasura.GraphQL.Parser.Variable
|
2022-03-14 19:21:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Common
|
2022-07-12 17:00:15 +03:00
|
|
|
import Hasura.GraphQL.Schema.NamingCase
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Parser qualified as P
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.GraphQL.Schema.Remote
|
2022-07-12 17:00:15 +03:00
|
|
|
import Hasura.GraphQL.Schema.Typename (MkTypename)
|
2022-06-23 12:14:24 +03:00
|
|
|
import Hasura.Name qualified as Name
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Prelude
|
2022-02-25 23:37:32 +03:00
|
|
|
import Hasura.RQL.IR.RemoteSchema
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
import Hasura.RQL.IR.Root
|
2022-05-31 01:07:02 +03:00
|
|
|
import Hasura.RQL.IR.Value
|
2022-05-21 12:04:53 +03:00
|
|
|
import Hasura.RQL.Types.Common
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.RQL.Types.RemoteSchema
|
|
|
|
import Hasura.RQL.Types.SchemaCache
|
2022-03-14 19:21:26 +03:00
|
|
|
import Hasura.RQL.Types.SourceCustomization
|
2021-09-24 01:56:37 +03:00
|
|
|
import Hasura.Session
|
|
|
|
import Language.GraphQL.Draft.Parser qualified as G
|
|
|
|
import Language.GraphQL.Draft.Syntax qualified as G
|
2022-06-23 12:14:24 +03:00
|
|
|
import Language.GraphQL.Draft.Syntax.QQ qualified as G
|
2021-09-24 01:56:37 +03:00
|
|
|
import Network.URI qualified as N
|
|
|
|
import Test.Hspec
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
-- test tools
|
|
|
|
|
|
|
|
runError :: Monad m => ExceptT QErr m a -> m a
|
|
|
|
runError = runExceptT >=> (`onLeft` (error . T.unpack . qeError))
|
|
|
|
|
|
|
|
mkTestRemoteSchema :: Text -> RemoteSchemaIntrospection
|
2021-09-24 01:56:37 +03:00
|
|
|
mkTestRemoteSchema schema = RemoteSchemaIntrospection $
|
2021-11-30 17:46:41 +03:00
|
|
|
M.fromListOn getTypeName $
|
|
|
|
runIdentity $
|
|
|
|
runError $ do
|
|
|
|
G.SchemaDocument types <- G.parseSchemaDocument schema `onLeft` throw500
|
|
|
|
pure $ flip mapMaybe types \case
|
|
|
|
G.TypeSystemDefinitionSchema _ -> Nothing
|
|
|
|
G.TypeSystemDefinitionType td -> Just $ case fmap toRemoteInputValue td of
|
|
|
|
G.TypeDefinitionScalar std -> G.TypeDefinitionScalar std
|
|
|
|
G.TypeDefinitionObject otd -> G.TypeDefinitionObject otd
|
|
|
|
G.TypeDefinitionUnion utd -> G.TypeDefinitionUnion utd
|
|
|
|
G.TypeDefinitionEnum etd -> G.TypeDefinitionEnum etd
|
|
|
|
G.TypeDefinitionInputObject itd -> G.TypeDefinitionInputObject itd
|
|
|
|
G.TypeDefinitionInterface itd ->
|
|
|
|
G.TypeDefinitionInterface $
|
|
|
|
G.InterfaceTypeDefinition
|
|
|
|
{ G._itdDescription = G._itdDescription itd,
|
|
|
|
G._itdName = G._itdName itd,
|
|
|
|
G._itdDirectives = G._itdDirectives itd,
|
|
|
|
G._itdFieldsDefinition = G._itdFieldsDefinition itd,
|
|
|
|
G._itdPossibleTypes = []
|
|
|
|
}
|
2021-05-24 23:12:53 +03:00
|
|
|
where
|
2021-09-24 01:56:37 +03:00
|
|
|
toRemoteInputValue ivd =
|
|
|
|
RemoteSchemaInputValueDefinition
|
|
|
|
{ _rsitdDefinition = ivd,
|
|
|
|
_rsitdPresetArgument =
|
|
|
|
choice $
|
|
|
|
G._ivdDirectives ivd <&> \dir -> do
|
2022-06-23 12:14:24 +03:00
|
|
|
guard $ G._dName dir == Name._preset
|
|
|
|
value <- M.lookup Name._value $ G._dArguments dir
|
2021-09-24 01:56:37 +03:00
|
|
|
Just $ case value of
|
|
|
|
G.VString "x-hasura-test" ->
|
|
|
|
G.VVariable $
|
2022-06-23 12:14:24 +03:00
|
|
|
SessionPresetVariable (mkSessionVariable "x-hasura-test") GName._String SessionArgumentPresetScalar
|
2021-09-24 01:56:37 +03:00
|
|
|
_ -> absurd <$> value
|
|
|
|
}
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
mkTestExecutableDocument :: Text -> ([G.VariableDefinition], G.SelectionSet G.NoFragments G.Name)
|
2021-09-24 01:56:37 +03:00
|
|
|
mkTestExecutableDocument t = runIdentity $
|
|
|
|
runError $ do
|
|
|
|
G.ExecutableDocument execDoc <- G.parseExecutableDoc t `onLeft` throw500
|
|
|
|
case execDoc of
|
|
|
|
[G.ExecutableDefinitionOperation op] -> case op of
|
|
|
|
G.OperationDefinitionUnTyped selSet -> ([],) <$> inlineSelectionSet [] selSet
|
|
|
|
G.OperationDefinitionTyped opDef -> do
|
|
|
|
unless (G._todType opDef == G.OperationTypeQuery) $
|
|
|
|
throw500 "only queries for now"
|
|
|
|
resSelSet <- inlineSelectionSet [] $ G._todSelectionSet opDef
|
|
|
|
pure (G._todVariableDefinitions opDef, resSelSet)
|
|
|
|
_ -> throw500 "must have only one query in the document"
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
mkTestVariableValues :: LBS.ByteString -> M.HashMap G.Name J.Value
|
2021-09-24 01:56:37 +03:00
|
|
|
mkTestVariableValues vars = runIdentity $
|
|
|
|
runError $ do
|
|
|
|
value <- J.eitherDecode vars `onLeft` (throw500 . T.pack)
|
|
|
|
case value of
|
|
|
|
J.Object vs ->
|
2022-06-08 18:31:28 +03:00
|
|
|
M.fromList <$> for (KM.toList vs) \(K.toText -> name, val) -> do
|
2021-09-24 01:56:37 +03:00
|
|
|
gname <- G.mkName name `onNothing` throw500 ("wrong Name: " <>> name)
|
|
|
|
pure (gname, val)
|
|
|
|
_ -> throw500 "variables must be an object"
|
|
|
|
|
|
|
|
buildQueryParsers ::
|
|
|
|
RemoteSchemaIntrospection ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
IO (P.FieldParser TestMonad (GraphQLField (RemoteRelationshipField UnpreparedValue) RemoteSchemaVariable))
|
2021-05-24 23:12:53 +03:00
|
|
|
buildQueryParsers introspection = do
|
2022-06-23 12:14:24 +03:00
|
|
|
let introResult = IntrospectionResult introspection GName._Query Nothing Nothing
|
2022-05-21 12:04:53 +03:00
|
|
|
remoteSchemaInfo = RemoteSchemaInfo (ValidatedRemoteSchemaDef (EnvRecord "" N.nullURI) [] False 60 Nothing) identityCustomizer
|
2022-03-14 19:21:26 +03:00
|
|
|
remoteSchemaRels = mempty
|
|
|
|
-- Since remote schemas can theoretically join against tables, we need to
|
|
|
|
-- have access to all relevant sources-specific information to build their
|
|
|
|
-- schema. Here, since there are no relationships to a source in this
|
|
|
|
-- test, we are free to give 'undefined' for such fields, as they won't be
|
|
|
|
-- evaluated.
|
Remove circular dependency in schema building code
### Description
The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop.
As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context.
This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4557
GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
2022-05-27 20:21:22 +03:00
|
|
|
schemaInfo =
|
2022-03-14 19:21:26 +03:00
|
|
|
( adminRoleName :: RoleName,
|
|
|
|
mempty :: CustomizeRemoteFieldName,
|
|
|
|
mempty :: MkTypename,
|
2022-05-26 14:54:30 +03:00
|
|
|
mempty :: MkRootFieldName,
|
Remove circular dependency in schema building code
### Description
The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop.
As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context.
This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4557
GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
2022-05-27 20:21:22 +03:00
|
|
|
HasuraCase :: NamingCase,
|
|
|
|
undefined :: SchemaOptions,
|
|
|
|
SchemaContext
|
Clean Relay's code, break schema cycles, introduce Node ID V2
## Motivation
This PR rewrites most of Relay to achieve the following:
- ~~fix a bug in which the same node id could refer to two different tables in the schema~~
- remove one of the few remaining uses of the source cache in the schema building code
In doing so, it also:
- simplifies the `BackendSchema` class by removing `node` from it,
- makes it much easier for other backends to support Relay,
- documents, re-organizes, and clarifies the code.
## Description
This PR introduces a new `NodeId` version ~~, and adapts the Postgres code to always generate this V2 version~~. This new id contains the source name, in addition to the table name, in order to disambiguate similar table names across different sources (which is now possible with source customization). In doing so, it now explicitly handles that case for V1 node ids, and returns an explicit error message instead of running the risk of _silently returning the wrong information_.
Furthermore, it adapts `nodeField` to support multiple backends; most of the code was trivial to generalize, and as a result it lowers the cost of entry for other backends, that now only need to support `AFNodeId` in their translation layer.
Finally, it removes one more cycle in the schema building code, by using the same trick we used for remote relationships instead of using the memoization trick of #4576.
## Remaining work
- ~~[ ]write a Changelog entry~~
- ~~[x] adapt all tests that were asserting on an old node id~~
## Future work
This PR was adapted from its original form to avoid a breaking change: while it introduces a Node ID V2, we keep generating V1 IDs and the parser rejects V2 IDs. It will be easy to make the switch at a later data in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4593
GitOrigin-RevId: 88e5cb91e8b0646900547fa8c7c0e1463de267a1
2022-06-07 16:35:26 +03:00
|
|
|
HasuraSchema
|
Remove circular dependency in schema building code
### Description
The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop.
As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context.
This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4557
GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
2022-05-27 20:21:22 +03:00
|
|
|
ignoreRemoteRelationship
|
2022-03-14 19:21:26 +03:00
|
|
|
)
|
|
|
|
RemoteSchemaParser query _ _ <-
|
2021-09-24 01:56:37 +03:00
|
|
|
runError $
|
Remove circular dependency in schema building code
### Description
The main goal of this PR is, as stated, to remove the circular dependency in the schema building code. This cycle arises from the existence of remote relationships: when we build the schema for a source A, a remote relationship might force us to jump to the schema of a source B, or some remote schema. As a result, we end up having to do a dispatch from a "leaf" of the schema, similar to the one done at the root. In turn, this forces us to carry along in the schema a lot of information required for that dispatch, AND it forces us to import the instances in scope, creating an import loop.
As discussed in #4489, this PR implements the "dependency injection" solution: we pass to the schema a function to call to do the dispatch, and to get a generated field for a remote relationship. That way, this function can be chosen at the root level, and the leaves need not be aware of the overall context.
This PR grew a bit bigger than that, however; in an attempt to try and remove the `SourceCache` from the schema altogether, it changed a lot of functions across the schema building code, to thread along the `SourceInfo b` of the source being built. This avoids having to do cache lookups within a given source. A few cases remain, such as relay, that we might try to tackle in a subsequent PR.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4557
GitOrigin-RevId: 9388e48372877520a72a9fd1677005df9f7b2d72
2022-05-27 20:21:22 +03:00
|
|
|
flip runReaderT schemaInfo $
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
P.runSchemaT $
|
2022-03-14 19:21:26 +03:00
|
|
|
buildRemoteParser introResult remoteSchemaRels remoteSchemaInfo
|
2021-09-24 01:56:37 +03:00
|
|
|
pure $
|
2021-11-30 03:37:14 +03:00
|
|
|
head query <&> \case
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
NotNamespaced remoteFld -> _rfField remoteFld
|
2021-11-30 03:37:14 +03:00
|
|
|
Namespaced _ ->
|
|
|
|
-- Shouldn't happen if we're using identityCustomizer
|
|
|
|
-- TODO: add some tests for remote schema customization
|
|
|
|
error "buildQueryParsers: unexpected Namespaced field"
|
2021-09-24 01:56:37 +03:00
|
|
|
|
|
|
|
runQueryParser ::
|
|
|
|
P.FieldParser TestMonad any ->
|
|
|
|
([G.VariableDefinition], G.SelectionSet G.NoFragments G.Name) ->
|
|
|
|
M.HashMap G.Name J.Value ->
|
|
|
|
any
|
2021-08-05 00:23:33 +03:00
|
|
|
runQueryParser parser (varDefs, selSet) vars = runIdentity . runError $ do
|
2021-05-24 23:12:53 +03:00
|
|
|
(_, resolvedSelSet) <- resolveVariables varDefs vars [] selSet
|
|
|
|
field <- case resolvedSelSet of
|
|
|
|
[G.SelectionField f] -> pure f
|
2021-09-24 01:56:37 +03:00
|
|
|
_ -> error "expecting only one field in the query"
|
2021-05-24 23:12:53 +03:00
|
|
|
runTest (P.fParser parser field) `onLeft` throw500
|
|
|
|
|
2021-09-24 01:56:37 +03:00
|
|
|
run ::
|
|
|
|
-- | schema
|
|
|
|
Text ->
|
|
|
|
-- | query
|
|
|
|
Text ->
|
|
|
|
-- | variables
|
|
|
|
LBS.ByteString ->
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
IO (GraphQLField (RemoteRelationshipField UnpreparedValue) RemoteSchemaVariable)
|
2021-08-05 00:23:33 +03:00
|
|
|
run schema query variables = do
|
|
|
|
parser <- buildQueryParsers $ mkTestRemoteSchema schema
|
2021-09-24 01:56:37 +03:00
|
|
|
pure $
|
|
|
|
runQueryParser
|
|
|
|
parser
|
|
|
|
(mkTestExecutableDocument query)
|
|
|
|
(mkTestVariableValues variables)
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
-- actual test
|
|
|
|
|
|
|
|
spec :: Spec
|
|
|
|
spec = do
|
|
|
|
testNoVarExpansionIfNoPreset
|
|
|
|
testNoVarExpansionIfNoPresetUnlessTopLevelOptionalField
|
|
|
|
testPartialVarExpansionIfPreset
|
2021-08-05 00:23:33 +03:00
|
|
|
testVariableSubstitutionCollision
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
testNoVarExpansionIfNoPreset :: Spec
|
|
|
|
testNoVarExpansionIfNoPreset = it "variables aren't expanded if there's no preset" $ do
|
2021-09-24 01:56:37 +03:00
|
|
|
field <-
|
|
|
|
run
|
|
|
|
-- schema
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
scalar Int
|
|
|
|
|
|
|
|
input A {
|
|
|
|
b: B
|
|
|
|
}
|
|
|
|
|
|
|
|
input B {
|
|
|
|
c: C
|
|
|
|
}
|
|
|
|
|
|
|
|
input C {
|
|
|
|
i: Int
|
|
|
|
}
|
|
|
|
|
|
|
|
type Query {
|
|
|
|
test(a: A!): Int
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- query
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
query($a: A!) {
|
|
|
|
test(a: $a)
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- variables
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
{
|
|
|
|
"a": {
|
|
|
|
"b": {
|
|
|
|
"c": {
|
|
|
|
"i": 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|]
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
let arg = head $ M.toList $ _fArguments field
|
2021-09-24 01:56:37 +03:00
|
|
|
arg
|
2022-06-23 12:14:24 +03:00
|
|
|
`shouldBe` ( _a,
|
2021-09-24 01:56:37 +03:00
|
|
|
-- the parser did not create a new JSON variable, and forwarded the query variable unmodified
|
|
|
|
G.VVariable $
|
|
|
|
QueryVariable $
|
|
|
|
Variable
|
2022-06-23 12:14:24 +03:00
|
|
|
(VIRequired _a)
|
|
|
|
(G.TypeNamed (G.Nullability False) _A)
|
2022-06-08 18:31:28 +03:00
|
|
|
(JSONValue $ J.Object $ KM.fromList [("b", J.Object $ KM.fromList [("c", J.Object $ KM.fromList [("i", J.Number 0)])])])
|
2021-09-24 01:56:37 +03:00
|
|
|
)
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
testNoVarExpansionIfNoPresetUnlessTopLevelOptionalField :: Spec
|
|
|
|
testNoVarExpansionIfNoPresetUnlessTopLevelOptionalField = it "unless fieldOptional peels the variable first" $ do
|
2021-09-24 01:56:37 +03:00
|
|
|
field <-
|
|
|
|
run
|
|
|
|
-- schema
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
scalar Int
|
|
|
|
|
|
|
|
input A {
|
|
|
|
b: B
|
|
|
|
}
|
|
|
|
|
|
|
|
input B {
|
|
|
|
c: C
|
|
|
|
}
|
|
|
|
|
|
|
|
input C {
|
|
|
|
i: Int
|
|
|
|
}
|
|
|
|
|
|
|
|
type Query {
|
|
|
|
test(a: A): Int
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- query
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
query($a: A) {
|
|
|
|
test(a: $a)
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- variables
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
{
|
|
|
|
"a": {
|
|
|
|
"b": {
|
|
|
|
"c": {
|
|
|
|
"i": 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|]
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
let arg = head $ M.toList $ _fArguments field
|
2021-09-24 01:56:37 +03:00
|
|
|
arg
|
2022-06-23 12:14:24 +03:00
|
|
|
`shouldBe` ( _a,
|
2021-09-24 01:56:37 +03:00
|
|
|
-- fieldOptional has peeled the variable; all we see is a JSON blob, and in doubt
|
|
|
|
-- we repackage it as a newly minted JSON variable
|
|
|
|
G.VVariable $
|
|
|
|
RemoteJSONValue
|
2022-06-23 12:14:24 +03:00
|
|
|
(G.TypeNamed (G.Nullability True) _A)
|
2022-06-08 18:31:28 +03:00
|
|
|
(J.Object $ KM.fromList [("b", J.Object $ KM.fromList [("c", J.Object $ KM.fromList [("i", J.Number 0)])])])
|
2021-09-24 01:56:37 +03:00
|
|
|
)
|
2021-05-24 23:12:53 +03:00
|
|
|
|
|
|
|
testPartialVarExpansionIfPreset :: Spec
|
|
|
|
testPartialVarExpansionIfPreset = it "presets cause partial var expansion" $ do
|
2021-09-24 01:56:37 +03:00
|
|
|
field <-
|
|
|
|
run
|
|
|
|
-- schema
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
scalar Int
|
|
|
|
|
|
|
|
input A {
|
|
|
|
x: Int @preset(value: 0)
|
|
|
|
b: B
|
|
|
|
}
|
|
|
|
|
|
|
|
input B {
|
|
|
|
c: C
|
|
|
|
}
|
|
|
|
|
|
|
|
input C {
|
|
|
|
i: Int
|
|
|
|
}
|
|
|
|
|
|
|
|
type Query {
|
|
|
|
test(a: A!): Int
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- query
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
query($a: A!) {
|
|
|
|
test(a: $a)
|
|
|
|
}
|
|
|
|
|]
|
2021-09-24 01:56:37 +03:00
|
|
|
-- variables
|
|
|
|
[raw|
|
2021-05-24 23:12:53 +03:00
|
|
|
{
|
|
|
|
"a": {
|
|
|
|
"b": {
|
|
|
|
"c": {
|
|
|
|
"i": 0
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|]
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
let arg = head $ M.toList $ _fArguments field
|
2021-09-24 01:56:37 +03:00
|
|
|
arg
|
2022-06-23 12:14:24 +03:00
|
|
|
`shouldBe` ( _a,
|
2021-09-24 01:56:37 +03:00
|
|
|
-- the preset has caused partial variable expansion, only up to where it's needed
|
|
|
|
G.VObject $
|
|
|
|
M.fromList
|
2022-06-23 12:14:24 +03:00
|
|
|
[ ( _x,
|
2021-09-24 01:56:37 +03:00
|
|
|
G.VInt 0
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( _b,
|
2021-09-24 01:56:37 +03:00
|
|
|
G.VVariable $
|
|
|
|
RemoteJSONValue
|
2022-06-23 12:14:24 +03:00
|
|
|
(G.TypeNamed (G.Nullability True) _B)
|
2022-06-08 18:31:28 +03:00
|
|
|
(J.Object $ KM.fromList [("c", J.Object $ KM.fromList [("i", J.Number 0)])])
|
2021-09-24 01:56:37 +03:00
|
|
|
)
|
|
|
|
]
|
|
|
|
)
|
2021-08-05 00:23:33 +03:00
|
|
|
|
|
|
|
-- | Regression test for https://github.com/hasura/graphql-engine/issues/7170
|
|
|
|
testVariableSubstitutionCollision :: Spec
|
|
|
|
testVariableSubstitutionCollision = it "ensures that remote variables are de-duplicated by type and value, not just by value" $ do
|
|
|
|
field <- run schema query variables
|
2021-09-24 01:56:37 +03:00
|
|
|
let dummyUserInfo =
|
|
|
|
UserInfo
|
|
|
|
adminRoleName
|
|
|
|
(mempty @SessionVariables)
|
|
|
|
BOFADisallowed
|
2021-08-05 00:23:33 +03:00
|
|
|
eField <-
|
|
|
|
runExceptT
|
2021-09-24 01:56:37 +03:00
|
|
|
. runVariableCache
|
|
|
|
. traverse (resolveRemoteVariable dummyUserInfo)
|
|
|
|
$ field
|
|
|
|
let variableNames =
|
Enable remote joins from remote schemas in the execution engine.
### Description
This PR adds the ability to perform remote joins from remote schemas in the engine. To do so, we alter the definition of an `ExecutionStep` targeting a remote schema: the `ExecStepRemote` constructor now expects a `Maybe RemoteJoins`. This new argument is used when processing the execution step, in the transport layer (either `Transport.HTTP` or `Transport.WebSocket`).
For this `Maybe RemoteJoins` to be extracted from a parsed query, this PR also extends the `Execute.RemoteJoin.Collect` module, to implement "collection" from a selection set. Not only do those new functions extract the remote joins, but they also apply all necessary transformations to the selection sets (such as inserting the necessary "phantom" fields used as join keys).
Finally in `Execute.RemoteJoin.Join`, we make two changes. First, we now always look for nested remote joins, regardless of whether the join we just performed went to a source or a remote schema; and second we adapt our join tree logic according to the special cases that were added to deal with remote server edge cases.
Additionally, this PR refactors / cleans / documents `Execute.RemoteJoin.RemoteServer`. This is not required as part of this change and could be moved to a separate PR if needed (a similar cleanup of `Join` is done independently in #3894). It also introduces a draft of a new documentation page for this project, that will be refined in the release PR that ships the feature (either #3069 or a copy of it).
While this PR extends the engine, it doesn't plug such relationships in the schema, meaning that, as of this PR, the new code paths in `Join` are technically unreachable. Adding the corresponding schema code and, ultimately, enabling the metadata API will be done in subsequent PRs.
### Keeping track of concrete type names
The main change this PR makes to the existing `Join` code is to handle a new reserved field we sometimes use when targeting remote servers: the `__hasura_internal_typename` field. In short, a GraphQL selection set can sometimes "branch" based on the concrete "runtime type" of the object on which the selection happens:
```graphql
query {
author(id: 53478) {
... on Writer {
name
articles {
title
}
}
... on Artist {
name
articles {
title
}
}
}
}
```
If both of those `articles` are remote joins, we need to be able, when we get the answer, to differentiate between the two different cases. We do this by asking for `__typename`, to be able to decide if we're in the `Writer` or the `Artist` branch of the query.
To avoid further processing / customization of results, we only insert this `__hasura_internal_typename: __typename` field in the query in the case of unions of interfaces AND if we have the guarantee that we will processing the request as part of the remote joins "folding": that is, if there's any remote join in this branch in the tree. Otherwise, we don't insert the field, and we leave that part of the response untouched.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3810
GitOrigin-RevId: 89aaf16274d68e26ad3730b80c2d2fdc2896b96c
2022-03-09 06:17:28 +03:00
|
|
|
eField ^.. _Right . to _fArguments . traverse . _VVariable . to vInfo . to getName . to G.unName
|
2021-08-05 00:23:33 +03:00
|
|
|
variableNames `shouldBe` ["hasura_json_var_1", "hasura_json_var_2"]
|
|
|
|
where
|
|
|
|
-- A schema whose values are representable as collections of JSON values.
|
|
|
|
schema :: Text
|
2021-09-24 01:56:37 +03:00
|
|
|
schema =
|
|
|
|
[raw|
|
2021-08-05 00:23:33 +03:00
|
|
|
scalar Int
|
|
|
|
scalar String
|
|
|
|
|
|
|
|
type Query {
|
|
|
|
test(a: [Int], b: [String]): Int
|
|
|
|
}
|
|
|
|
|]
|
|
|
|
-- A query against values from 'schema' using JSON variable substitution.
|
|
|
|
query :: Text
|
2021-09-24 01:56:37 +03:00
|
|
|
query =
|
|
|
|
[raw|
|
2021-08-05 00:23:33 +03:00
|
|
|
query($a: [Int], $b: [String]) {
|
|
|
|
test(a: $a, b: $b)
|
|
|
|
}
|
|
|
|
|]
|
|
|
|
-- Two identical JSON variables to substitute; 'schema' and 'query' declare
|
|
|
|
-- that these variables should have different types despite both being
|
|
|
|
-- empty collections.
|
|
|
|
variables :: LBS.ByteString
|
2021-09-24 01:56:37 +03:00
|
|
|
variables =
|
|
|
|
[raw|
|
2021-08-05 00:23:33 +03:00
|
|
|
{
|
|
|
|
"a": [],
|
|
|
|
"b": []
|
|
|
|
}
|
|
|
|
|]
|
|
|
|
|
|
|
|
-- | Convenience function to focus on a 'G.VVariable' when pulling test values
|
|
|
|
-- out in 'testVariableSubstitutionCollision'.
|
|
|
|
_VVariable :: Prism' (G.Value var) var
|
|
|
|
_VVariable = prism' upcast downcast
|
|
|
|
where
|
|
|
|
upcast = G.VVariable
|
|
|
|
downcast = \case
|
|
|
|
G.VVariable var -> Just var
|
2021-09-24 01:56:37 +03:00
|
|
|
_ -> Nothing
|
2022-06-23 12:14:24 +03:00
|
|
|
|
|
|
|
_A :: G.Name
|
|
|
|
_A = [G.name|A|]
|
|
|
|
|
|
|
|
_B :: G.Name
|
|
|
|
_B = [G.name|B|]
|
|
|
|
|
|
|
|
_a :: G.Name
|
|
|
|
_a = [G.name|a|]
|
|
|
|
|
|
|
|
_b :: G.Name
|
|
|
|
_b = [G.name|b|]
|
|
|
|
|
|
|
|
_x :: G.Name
|
|
|
|
_x = [G.name|x|]
|