2021-09-22 18:34:53 +03:00
|
|
|
{-# LANGUAGE ApplicativeDo #-}
|
2022-04-22 22:53:12 +03:00
|
|
|
{-# LANGUAGE TemplateHaskellQuotes #-}
|
2021-07-15 15:44:26 +03:00
|
|
|
{-# OPTIONS_GHC -fno-warn-orphans #-}
|
|
|
|
|
2021-11-04 19:08:33 +03:00
|
|
|
module Hasura.Backends.MySQL.Instances.Schema () where
|
2021-07-15 15:44:26 +03:00
|
|
|
|
2021-08-04 14:42:24 +03:00
|
|
|
import Data.ByteString (ByteString)
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Data.HashMap.Strict qualified as HM
|
|
|
|
import Data.List.NonEmpty qualified as NE
|
2021-08-04 14:42:24 +03:00
|
|
|
import Data.Text.Encoding (encodeUtf8)
|
2021-07-15 15:44:26 +03:00
|
|
|
import Data.Text.Extended
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Database.MySQL.Base.Types qualified as MySQL
|
|
|
|
import Hasura.Backends.MySQL.Types qualified as MySQL
|
2021-07-15 15:44:26 +03:00
|
|
|
import Hasura.Base.Error
|
An `ErrorMessage` type, to encapsulate.
This introduces an `ErrorMessage` newtype which wraps `Text` in a manner which is designed to be easy to construct, and difficult to deconstruct.
It provides functionality similar to `Data.Text.Extended`, but designed _only_ for error messages. Error messages are constructed through `fromString`, concatenation, or the `toErrorValue` function, which is designed to be overridden for all meaningful domain types that might show up in an error message. Notably, there are not and should never be instances of `ToErrorValue` for `String`, `Text`, `Int`, etc. This is so that we correctly represent the value in a way that is specific to its type. For example, all `Name` values (from the _graphql-parser-hs_ library) are single-quoted now; no exceptions.
I have mostly had to add `instance ToErrorValue` for various backend types (and also add newtypes where necessary). Some of these are not strictly necessary for this changeset, as I had bigger aspirations when I started. These aspirations have been tempered by trying and failing twice.
As such, in this changeset, I have started by introducing this type to the `parseError` and `parseErrorWith` functions. In the future, I would like to extend this to the `QErr` record and the various `throwError` functions, but this is a much larger task and should probably be done in stages.
For now, `toErrorMessage` and `fromErrorMessage` are provided for conversion to and from `Text`, but the intent is to stop exporting these once all error messages are converted to the new type.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/5018
GitOrigin-RevId: 84b37e238992e4312255a87ca44f41af65e2d89a
2022-07-18 23:26:01 +03:00
|
|
|
import Hasura.Base.ErrorMessage (toErrorMessage)
|
2021-07-15 15:44:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Backend
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Hasura.GraphQL.Schema.Build qualified as GSB
|
Role-invariant schema constructors
We build the GraphQL schema by combining building blocks such as `tableSelectionSet` and `columnParser`. These building blocks individually build `{InputFields,Field,}Parser` objects. Those object specify the valid GraphQL schema.
Since the GraphQL schema is role-dependent, at some point we need to know what fragment of the GraphQL schema a specific role is allowed to access, and this is stored in `{Sel,Upd,Ins,Del}PermInfo` objects.
We have passed around these permission objects as function arguments to the schema building blocks since we first started dealing with permissions during the PDV refactor - see hasura/graphql-engine@5168b99e463199b1934d8645bd6cd37eddb64ae1 in hasura/graphql-engine#4111. This means that, for instance, `tableSelectionSet` has as its type:
```haskell
tableSelectionSet ::
forall b r m n.
MonadBuildSchema b r m n =>
SourceName ->
TableInfo b ->
SelPermInfo b ->
m (Parser 'Output n (AnnotatedFields b))
```
There are three reasons to change this.
1. We often pass a `Maybe (xPermInfo b)` instead of a proper `xPermInfo b`, and it's not clear what the intended semantics of this is. Some potential improvements on the data types involved are discussed in issue hasura/graphql-engine-mono#3125.
2. In most cases we also already pass a `TableInfo b`, and together with the `MonadRole` that is usually also in scope, this means that we could look up the required permissions regardless: so passing the permissions explicitly undermines the "single source of truth" principle. Breaking this principle also makes the code more difficult to read.
3. We are working towards role-based parsers (see hasura/graphql-engine-mono#2711), where the `{InputFields,Field,}Parser` objects are constructed in a role-invariant way, so that we have a single object that can be used for all roles. In particular, this means that the schema building blocks _need_ to be constructed in a role-invariant way. While this PR doesn't accomplish that, it does reduce the amount of role-specific arguments being passed, thus fixing hasura/graphql-engine-mono#3068.
Concretely, this PR simply drops the `xPermInfo b` argument from almost all schema building blocks. Instead these objects are looked up from the `TableInfo b` as-needed. The resulting code is considerably simpler and shorter.
One way to interpret this change is as follows. Before this PR, we figured out permissions at the top-level in `Hasura.GraphQL.Schema`, passing down the obtained `xPermInfo` objects as required. After this PR, we have a bottom-up approach where the schema building blocks themselves decide whether they want to be included for a particular role.
So this moves some permission logic out of `Hasura.GraphQL.Schema`, which is very complex.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/3608
GitOrigin-RevId: 51a744f34ec7d57bc8077667ae7f9cb9c4f6c962
2022-02-17 11:16:20 +03:00
|
|
|
import Hasura.GraphQL.Schema.Common
|
2022-07-12 17:00:15 +03:00
|
|
|
import Hasura.GraphQL.Schema.NamingCase
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Parser
|
|
|
|
( InputFieldsParser,
|
|
|
|
Kind (..),
|
|
|
|
MonadParse,
|
|
|
|
Parser,
|
|
|
|
)
|
|
|
|
import Hasura.GraphQL.Schema.Parser qualified as P
|
2021-07-15 15:44:26 +03:00
|
|
|
import Hasura.GraphQL.Schema.Select
|
2022-06-23 12:14:24 +03:00
|
|
|
import Hasura.Name qualified as Name
|
2021-07-15 15:44:26 +03:00
|
|
|
import Hasura.Prelude
|
|
|
|
import Hasura.RQL.IR
|
server: remove remnants of query plan caching (fix #1795)
Query plan caching was introduced by - I believe - hasura/graphql-engine#1934 in order to reduce the query response latency. During the development of PDV in hasura/graphql-engine#4111, it was found out that the new architecture (for which query plan caching wasn't implemented) performed comparably to the pre-PDV architecture with caching. Hence, it was decided to leave query plan caching until some day in the future when it was deemed necessary.
Well, we're in the future now, and there still isn't a convincing argument for query plan caching. So the time has come to remove some references to query plan caching from the codebase. For the most part, any code being removed would probably not be very well suited to the post-PDV architecture of query execution, so arguably not much is lost.
Apart from simplifying the code, this PR will contribute towards making the GraphQL schema generation more modular, testable, and easier to profile. I'd like to eventually work towards a situation in which it's easy to generate a GraphQL schema parser *in isolation*, without being connected to a database, and then parse a GraphQL query *in isolation*, without even listening any HTTP port. It is important that both of these operations can be examined in detail, and in isolation, since they are two major performance bottlenecks, as well as phases where many important upcoming features hook into.
Implementation
The following have been removed:
- The entirety of `server/src-lib/Hasura/GraphQL/Execute/Plan.hs`
- The core phases of query parsing and execution no longer have any references to query plan caching. Note that this is not to be confused with query *response* caching, which is not affected by this PR. This includes removal of the types:
- - `Opaque`, which is replaced by a tuple. Note that the old implementation was broken and did not adequately hide the constructors.
- - `QueryReusability` (and the `markNotReusable` method). Notably, the implementation of the `ParseT` monad now consists of two, rather than three, monad transformers.
- Cache-related tests (in `server/src-test/Hasura/CacheBoundedSpec.hs`) have been removed .
- References to query plan caching in the documentation.
- The `planCacheOptions` in the `TenantConfig` type class was removed. However, during parsing, unrecognized fields in the YAML config get ignored, so this does not cause a breaking change. (Confirmed manually, as well as in consultation with @sordina.)
- The metrics no longer send cache hit/miss messages.
There are a few places in which one can still find references to query plan caching:
- We still accept the `--query-plan-cache-size` command-line option for backwards compatibility. The `HASURA_QUERY_PLAN_CACHE_SIZE` environment variable is not read.
https://github.com/hasura/graphql-engine-mono/pull/1815
GitOrigin-RevId: 17d92b254ec093c62a7dfeec478658ede0813eb7
2021-07-27 14:51:52 +03:00
|
|
|
import Hasura.RQL.IR.Select qualified as IR
|
2022-04-27 16:57:28 +03:00
|
|
|
import Hasura.RQL.Types.Backend as RQL
|
|
|
|
import Hasura.RQL.Types.Column as RQL
|
|
|
|
import Hasura.RQL.Types.SchemaCache as RQL
|
|
|
|
import Hasura.SQL.Backend
|
2022-06-10 06:59:00 +03:00
|
|
|
import Language.GraphQL.Draft.Syntax qualified as GQL
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
instance BackendSchema 'MySQL where
|
2022-06-07 08:32:08 +03:00
|
|
|
buildTableQueryAndSubscriptionFields = GSB.buildTableQueryAndSubscriptionFields
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
buildTableRelayQueryFields _ _ _ _ _ = pure []
|
2022-04-22 22:53:12 +03:00
|
|
|
buildTableStreamingSubscriptionFields = GSB.buildTableStreamingSubscriptionFields
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
buildTableInsertMutationFields _ _ _ _ _ = pure []
|
2023-01-10 04:54:40 +03:00
|
|
|
buildTableUpdateMutationFields _ _ _ = pure []
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
buildTableDeleteMutationFields _ _ _ _ _ = pure []
|
|
|
|
buildFunctionQueryFields _ _ _ _ = pure []
|
|
|
|
buildFunctionRelayQueryFields _ _ _ _ _ = pure []
|
|
|
|
buildFunctionMutationFields _ _ _ _ = pure []
|
2021-07-15 15:44:26 +03:00
|
|
|
relayExtension = Nothing
|
|
|
|
nodesAggExtension = Just ()
|
2022-04-22 22:53:12 +03:00
|
|
|
streamSubscriptionExtension = Nothing
|
2021-07-15 15:44:26 +03:00
|
|
|
columnParser = columnParser'
|
2022-09-14 00:21:07 +03:00
|
|
|
enumParser = enumParser'
|
|
|
|
possiblyNullable = possiblyNullable'
|
2022-08-11 14:57:06 +03:00
|
|
|
scalarSelectionArgumentsParser _ = pure Nothing
|
2022-06-10 06:59:00 +03:00
|
|
|
orderByOperators _sourceInfo = orderByOperators'
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
comparisonExps = comparisonExps'
|
2022-01-28 15:21:17 +03:00
|
|
|
countTypeInput = mysqlCountTypeInput
|
2021-08-04 14:42:24 +03:00
|
|
|
aggregateOrderByCountType = error "aggregateOrderByCountType: MySQL backend does not support this operation yet."
|
|
|
|
computedField = error "computedField: MySQL backend does not support this operation yet."
|
2021-07-15 15:44:26 +03:00
|
|
|
|
2022-06-30 18:22:19 +03:00
|
|
|
instance BackendTableSelectSchema 'MySQL where
|
|
|
|
tableArguments = mysqlTableArgs
|
|
|
|
selectTable = defaultSelectTable
|
|
|
|
selectTableAggregate = defaultSelectTableAggregate
|
|
|
|
tableSelectionSet = defaultTableSelectionSet
|
|
|
|
|
2021-07-15 15:44:26 +03:00
|
|
|
mysqlTableArgs ::
|
|
|
|
forall r m n.
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
TableInfo 'MySQL ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (InputFieldsParser n (IR.SelectArgsG 'MySQL (UnpreparedValue 'MySQL)))
|
server: reduce schema contexts to the bare minimum
### Description
This monster of a PR took way too long. As the title suggests, it reduces the schema context carried in the readers to the very strict minimum. In practice, that means that to build a source, we only require:
- the global `SchemaContext`
- the global `SchemaOptions` (soon to be renamed `SchemaSourceOptions`)
- that source's `SourceInfo`
Furthermore, _we no longer carry "default" customization options throughout the schema_. All customization information is extracted from the `SourceInfo`, when required. This prevents an entire category of bugs we had previously encountered, such as parts of the code using uninitialized / unupdated customization info.
In turn, this meant that we could remove the explicit threading of the `SourceInfo` throughout the schema, since it is now always available through the reader context.
Finally, this meant making a few adjustments to relay and actions as well, such as the introduction of a new separate "context" for actions, and a change to how we create some of the action-specific postgres scalar parsers.
I'll highlight with review comments the areas of interest.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/6709
GitOrigin-RevId: ea80fddcb24e2513779dd04b0b700a55f0028dd1
2022-11-17 13:34:05 +03:00
|
|
|
mysqlTableArgs tableInfo = do
|
|
|
|
whereParser <- tableWhereArg tableInfo
|
|
|
|
orderByParser <- tableOrderByArg tableInfo
|
2021-07-15 15:44:26 +03:00
|
|
|
pure do
|
|
|
|
whereArg <- whereParser
|
|
|
|
orderByArg <- orderByParser
|
|
|
|
limitArg <- tableLimitArg
|
|
|
|
offsetArg <- tableOffsetArg
|
|
|
|
pure $
|
|
|
|
IR.SelectArgs
|
|
|
|
{ IR._saWhere = whereArg,
|
|
|
|
IR._saOrderBy = orderByArg,
|
|
|
|
IR._saLimit = limitArg,
|
|
|
|
IR._saOffset = offsetArg,
|
|
|
|
IR._saDistinct = Nothing
|
|
|
|
}
|
|
|
|
|
2021-08-04 14:42:24 +03:00
|
|
|
bsParser :: MonadParse m => Parser 'Both m ByteString
|
|
|
|
bsParser = encodeUtf8 <$> P.string
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
columnParser' ::
|
2022-09-06 19:48:04 +03:00
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnType 'MySQL ->
|
2022-06-10 06:59:00 +03:00
|
|
|
GQL.Nullability ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (Parser 'Both n (ValueWithOrigin (ColumnValue 'MySQL)))
|
2022-10-03 23:09:42 +03:00
|
|
|
columnParser' columnType nullability = case columnType of
|
|
|
|
ColumnScalar scalarType ->
|
|
|
|
P.memoizeOn 'columnParser' (scalarType, nullability) $
|
|
|
|
peelWithOrigin . fmap (ColumnValue columnType) . possiblyNullable' scalarType nullability
|
|
|
|
<$> case scalarType of
|
|
|
|
MySQL.Decimal -> pure $ MySQL.DecimalValue <$> P.float
|
|
|
|
MySQL.Tiny -> pure $ MySQL.TinyValue <$> P.int
|
|
|
|
MySQL.Short -> pure $ MySQL.SmallValue <$> P.int
|
|
|
|
MySQL.Long -> pure $ MySQL.IntValue <$> P.int
|
|
|
|
MySQL.Float -> pure $ MySQL.FloatValue <$> P.float
|
|
|
|
MySQL.Double -> pure $ MySQL.DoubleValue <$> P.float
|
|
|
|
MySQL.Null -> pure $ MySQL.NullValue <$ P.string
|
|
|
|
MySQL.LongLong -> pure $ MySQL.BigValue <$> P.int
|
|
|
|
MySQL.Int24 -> pure $ MySQL.MediumValue <$> P.int
|
|
|
|
MySQL.Date -> pure $ MySQL.DateValue <$> P.string
|
|
|
|
MySQL.Year -> pure $ MySQL.YearValue <$> P.string
|
|
|
|
MySQL.Bit -> pure $ MySQL.BitValue <$> P.boolean
|
|
|
|
MySQL.String -> pure $ MySQL.VarcharValue <$> P.string
|
|
|
|
MySQL.VarChar -> pure $ MySQL.VarcharValue <$> P.string
|
|
|
|
MySQL.DateTime -> pure $ MySQL.DatetimeValue <$> P.string
|
|
|
|
MySQL.Blob -> pure $ MySQL.BlobValue <$> bsParser
|
|
|
|
MySQL.Timestamp -> pure $ MySQL.TimestampValue <$> P.string
|
|
|
|
_ -> do
|
|
|
|
name <- MySQL.mkMySQLScalarTypeName scalarType
|
|
|
|
let schemaType = P.TNamed P.NonNullable $ P.Definition name Nothing Nothing [] P.TIScalar
|
|
|
|
pure $
|
|
|
|
P.Parser
|
|
|
|
{ pType = schemaType,
|
|
|
|
pParser =
|
|
|
|
P.valueToJSON (P.toGraphQLType schemaType)
|
|
|
|
>=> either (P.parseErrorWith P.ParseFailed . toErrorMessage . qeError) pure . (MySQL.parseScalarValue scalarType)
|
|
|
|
}
|
|
|
|
ColumnEnumReference (EnumReference tableName enumValues customTableName) ->
|
|
|
|
case nonEmpty (HM.toList enumValues) of
|
|
|
|
Just enumValuesList ->
|
|
|
|
peelWithOrigin . fmap (ColumnValue columnType)
|
|
|
|
<$> enumParser' tableName enumValuesList customTableName nullability
|
|
|
|
Nothing -> throw400 ValidationFailed "empty enum values"
|
2022-09-14 00:21:07 +03:00
|
|
|
|
|
|
|
enumParser' ::
|
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
|
|
|
TableName 'MySQL ->
|
|
|
|
NonEmpty (EnumValue, EnumValueInfo) ->
|
|
|
|
Maybe GQL.Name ->
|
|
|
|
GQL.Nullability ->
|
|
|
|
SchemaT r m (Parser 'Both n (ScalarValue 'MySQL))
|
|
|
|
enumParser' tableName enumValues customTableName nullability = do
|
|
|
|
enumName <- mkEnumTypeName @'MySQL tableName customTableName
|
|
|
|
pure $ possiblyNullable' MySQL.VarChar nullability $ P.enum enumName Nothing (mkEnumValue <$> enumValues)
|
2021-07-15 15:44:26 +03:00
|
|
|
where
|
|
|
|
mkEnumValue :: (EnumValue, EnumValueInfo) -> (P.Definition P.EnumValueInfo, RQL.ScalarValue 'MySQL)
|
|
|
|
mkEnumValue (RQL.EnumValue value, EnumValueInfo description) =
|
2022-07-25 18:53:25 +03:00
|
|
|
( P.Definition value (GQL.Description <$> description) Nothing [] P.EnumValueInfo,
|
2022-06-10 06:59:00 +03:00
|
|
|
MySQL.VarcharValue $ GQL.unName value
|
2021-07-15 15:44:26 +03:00
|
|
|
)
|
|
|
|
|
2022-09-14 00:21:07 +03:00
|
|
|
possiblyNullable' ::
|
|
|
|
(MonadParse m) =>
|
|
|
|
ScalarType 'MySQL ->
|
|
|
|
GQL.Nullability ->
|
|
|
|
Parser 'Both m (ScalarValue 'MySQL) ->
|
|
|
|
Parser 'Both m (ScalarValue 'MySQL)
|
|
|
|
possiblyNullable' _scalarType (GQL.Nullability isNullable)
|
|
|
|
| isNullable = fmap (fromMaybe MySQL.NullValue) . P.nullable
|
|
|
|
| otherwise = id
|
|
|
|
|
server: Metadata origin for definitions (type parameter version v2)
The code that builds the GraphQL schema, and `buildGQLContext` in particular, is partial: not every value of `(ServerConfigCtx, GraphQLQueryType, SourceCache, HashMap RemoteSchemaName (RemoteSchemaCtx, MetadataObject), ActionCache, AnnotatedCustomTypes)` results in a valid GraphQL schema. When it fails, we want to be able to return better error messages than we currently do.
The key thing that is missing is a way to trace back GraphQL type information to their origin from the Hasura metadata. Currently, we have a number of correctness checks of our GraphQL schema. But these correctness checks only have access to pure GraphQL type information, and hence can only report errors in terms of that. Possibly the worst is the "conflicting definitions" error, which, in practice, can only be debugged by Hasura engineers. This is terrible DX for customers.
This PR allows us to print better error messages, by adding a field to the `Definition` type that traces the GraphQL type to its origin in the metadata. So the idea is simple: just add `MetadataObjId`, or `Maybe` that, or some other sum type of that, to `Definition`.
However, we want to avoid having to import a `Hasura.RQL` module from `Hasura.GraphQL.Parser`. So we instead define this additional field of `Definition` through a new type parameter, which is threaded through in `Hasura.GraphQL.Parser`. We then define type synonyms in `Hasura.GraphQL.Schema.Parser` that fill in this type parameter, so that it is not visible for the majority of the codebase.
The idea of associating metadata information to `Definition`s really comes to fruition when combined with hasura/graphql-engine-mono#4517. Their combination would allow us to use the API of fatal errors (just like the current `MonadError QErr`) to report _inconsistencies_ in the metadata. Such inconsistencies are then _automatically_ ignored. So no ad-hoc decisions need to be made on how to cut out inconsistent metadata from the GraphQL schema. This will allow us to report much better errors, as well as improve the likelihood of a successful HGE startup.
PR-URL: https://github.com/hasura/graphql-engine-mono/pull/4770
Co-authored-by: Samir Talwar <47582+SamirTalwar@users.noreply.github.com>
GitOrigin-RevId: 728402b0cae83ae8e83463a826ceeb609001acae
2022-06-28 18:52:26 +03:00
|
|
|
orderByOperators' :: NamingCase -> (GQL.Name, NonEmpty (P.Definition P.EnumValueInfo, (BasicOrderType 'MySQL, NullsOrderType 'MySQL)))
|
2022-05-26 14:54:30 +03:00
|
|
|
orderByOperators' _tCase =
|
2022-06-23 12:14:24 +03:00
|
|
|
(Name._order_by,) $
|
2022-06-10 06:59:00 +03:00
|
|
|
-- NOTE: NamingCase is not being used here as we don't support naming conventions for this DB
|
|
|
|
NE.fromList
|
2022-06-23 12:14:24 +03:00
|
|
|
[ ( define Name._asc "in ascending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Asc, MySQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._asc_nulls_first "in ascending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Asc, MySQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._asc_nulls_last "in ascending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Asc, MySQL.NullsLast)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc "in descending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Desc, MySQL.NullsLast)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc_nulls_first "in descending order, nulls first",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Desc, MySQL.NullsFirst)
|
|
|
|
),
|
2022-06-23 12:14:24 +03:00
|
|
|
( define Name._desc_nulls_last "in descending order, nulls last",
|
2022-06-10 06:59:00 +03:00
|
|
|
(MySQL.Desc, MySQL.NullsLast)
|
|
|
|
)
|
|
|
|
]
|
2021-07-15 15:44:26 +03:00
|
|
|
where
|
2022-07-25 18:53:25 +03:00
|
|
|
define name desc = P.Definition name (Just desc) Nothing [] P.EnumValueInfo
|
2021-07-15 15:44:26 +03:00
|
|
|
|
|
|
|
-- | TODO: Make this as thorough as the one for MSSQL/PostgreSQL
|
|
|
|
comparisonExps' ::
|
2021-10-29 17:42:07 +03:00
|
|
|
forall m n r.
|
2022-09-06 19:48:04 +03:00
|
|
|
MonadBuildSchema 'MySQL r m n =>
|
2021-07-15 15:44:26 +03:00
|
|
|
ColumnType 'MySQL ->
|
2022-09-06 19:48:04 +03:00
|
|
|
SchemaT r m (Parser 'Input n [ComparisonExp 'MySQL])
|
2021-07-15 15:44:26 +03:00
|
|
|
comparisonExps' = P.memoize 'comparisonExps $ \columnType -> do
|
|
|
|
-- see Note [Columns in comparison expression are never nullable]
|
2022-06-10 06:59:00 +03:00
|
|
|
typedParser <- columnParser columnType (GQL.Nullability False)
|
2022-06-23 12:14:24 +03:00
|
|
|
let name = P.getName typedParser <> Name.__MySQL_comparison_exp
|
2021-07-15 15:44:26 +03:00
|
|
|
desc =
|
2022-06-10 06:59:00 +03:00
|
|
|
GQL.Description $
|
2021-07-15 15:44:26 +03:00
|
|
|
"Boolean expression to compare columns of type "
|
|
|
|
<> P.getName typedParser
|
|
|
|
<<> ". All fields are combined with logical 'AND'."
|
|
|
|
pure $
|
|
|
|
P.object name (Just desc) $
|
|
|
|
catMaybes
|
|
|
|
<$> sequenceA
|
2022-06-23 12:14:24 +03:00
|
|
|
[ P.fieldOptional Name.__is_null Nothing (bool ANISNOTNULL ANISNULL <$> P.boolean),
|
|
|
|
P.fieldOptional Name.__eq Nothing (AEQ True . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional Name.__neq Nothing (ANE True . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional Name.__gt Nothing (AGT . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional Name.__lt Nothing (ALT . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional Name.__gte Nothing (AGTE . mkParameter <$> typedParser),
|
|
|
|
P.fieldOptional Name.__lte Nothing (ALTE . mkParameter <$> typedParser)
|
2021-07-15 15:44:26 +03:00
|
|
|
]
|
|
|
|
|
2022-01-28 15:21:17 +03:00
|
|
|
mysqlCountTypeInput ::
|
|
|
|
MonadParse n =>
|
|
|
|
Maybe (Parser 'Both n (Column 'MySQL)) ->
|
|
|
|
InputFieldsParser n (IR.CountDistinct -> CountType 'MySQL)
|
|
|
|
mysqlCountTypeInput = \case
|
|
|
|
Just columnEnum -> do
|
2022-06-23 12:14:24 +03:00
|
|
|
columns <- P.fieldOptional Name._columns Nothing $ P.list columnEnum
|
2022-01-28 15:21:17 +03:00
|
|
|
pure $ flip mkCountType columns
|
|
|
|
Nothing -> pure $ flip mkCountType Nothing
|
|
|
|
where
|
|
|
|
mkCountType :: IR.CountDistinct -> Maybe [Column 'MySQL] -> CountType 'MySQL
|
|
|
|
mkCountType _ Nothing = MySQL.StarCountable
|
|
|
|
mkCountType IR.SelectCountDistinct (Just cols) =
|
|
|
|
maybe MySQL.StarCountable MySQL.DistinctCountable $ nonEmpty cols
|
|
|
|
mkCountType IR.SelectCountNonDistinct (Just cols) =
|
|
|
|
maybe MySQL.StarCountable MySQL.NonNullFieldCountable $ nonEmpty cols
|